pfSense

Skip IPsec ping host CARP check when there are no IPSec ping hosts. Also, add a safety belt so cat can't get stuck waiting on input. Fixes #8172

(cherry picked from commit 45d078c5964b94dd2aa7f1a609fcb47e89eaac49)

Fix auth_check.inc to perform a commit to avoid PHP session gc from reaping the session. Fixes occasional timeouts when sitting on pages that only fetch AJAX for prolonged periods. Fixes #8116

(cherry picked from commit 2138aad96c7046bff8000cb1febd85f16b9292bb)

Backported for bug #8159 so sort by index before deleting to delete the correct one

Revert "Fixed #8159 added a sort by index after a delete call has been made to make sure it lines up correctly."

This reverts commit 1e659e027c5cd9f42a20286f84f0e2967bb01c3c.

Fixed #8159 added a sort by index after a delete call has been made to make sure it lines up correctly.

When retrieving a the modulus for a certificate, private key, or signing request, write the certificate data out to a temp file instead of echoing it through a pipe. Fixes #8153

(cherry picked from commit 6e316e955350ad69d4f86cb332a1a48bfa028e2e)

Fixed #8143 Remove any html special characters for request variable

Prevent Clickjacking in CSRF error page

(cherry picked from commit 6026c9dabdd66a154c8a9a5170947ea098959835)

Fixed it so it will validate that it is an image uploaded and not something else

Fix saving the CRL choice for OpenVPN clients. Fixes #8088

(cherry picked from commit 5bd94e5f2e3a4b694e3cfa91d16dab76078c118b)
(cherry picked from commit 2055285920b2714b7115911e0a0ea723256e5b2f)

Use a strict check of array_search() result

Remove empty items from output

Detect when system is running a newer version than the one available on remote repository

Always do rquery when pkg search is not used

Fix #7946: Display installed packages missing on remote repo to let user to delete it

Fixed #8035

Several corrections to service sorting to produce output consistent with user expectations. Fixes #8069

(cherry picked from commit 258fc75b0995a53997927edc5186b1fe8a5b409e)
(cherry picked from commit 8d9037dda9ab473af6df0c9e2f7e6ccb9b177f2a)

Reindex the user and group arrays after deleting items, to avoid operating on incorrect array entries. Fixes #7733

(cherry picked from commit 92c27793b4c7f87e89aec3faec5582c17502d6d5)
(cherry picked from commit 106de6365c7407f2325d5b3e07625620c10436d0)

It's time for 2.3.5-RELEASE

Do not print JS when there are input errors on diag_dns.php; fix json_encode syntax. Ticket #7999

(cherry picked from commit f32e9531ae21852ef0b21709b8278d1091d55d56)

Only show copynotice when version changes

Add support for copyright notice

Fix #7984: Make sure sshlockout_pf stops when syslogd stops

Do not allow direct download of .inc files (unparsed PHP source). Fixes #8005

(cherry picked from commit b1fccd42547201f4dbfe941bcc59c8eac3456364)
(cherry picked from commit 71c70114aa10e594253b9bf85df155774199e2bc)
(cherry picked from commit 82405c15fabd5759f05ecdfab92942c63a07ae16)

Abort when binary is not found

Do not execute pfSense-upgrade on install media

Encode hostname parameter contents in javascript for diag_dns.php. Fixes #7999

(cherry picked from commit 43746e1b4ef6fec0e9c915495aa3926a6b97e7a3)

Welcome 2.3.5-RC

fixed indentation:

fixed weird merge issue

Fixed #7714 Edited it to show correct timezone

(cherry picked from commit fe814d92aae5c53305d484480fa403299a39541a)

Fix #7976: Do not add button value to gettext

Fix #7968

Show Network Device ID in console banner

Do not show Serial when it's empty

Stop using hostuuid as serial

Helped make the ajax more robust to check for non json return types

Revert "Added JSON checks for widgets to prevent parsing errors."

This reverts commit e63aee854214c93fd0cba71f7023c194942c1ca9.

Added JSON checks for widgets to prevent parsing errors.

(cherry picked from commit 63f686bde3e95eed8d2223d00e5f6403a5ef2d4c)

add cache busting to css using last modified timestamp

Use pkg-static binary to prevent errors when moving to new major FreeBSD version

Use hostapd / wpa_supplicant from ports when available

xmlrpc, webgui, prevent that a xmlrpc.lock is placed that is never unlocked, thus hanging php and the webgui after a few more sync request are trying to acquire the lock and all are waiting..

(cherry picked from commit 8239af2dc167fd865818a29b4e01d7e464d564d3)

Remove no-op code

See https://redmine.pfsense.org/issues/7889 for related discussion

(cherry picked from commit 401e2ac783756e22ab738d28c0f170455f00e2ff)

Remove no-op code

See https://redmine.pfsense.org/issues/7889 for related discussion

(cherry picked from commit cbbb8fdb62fc75bfac28b26a867ceceee982b5aa)

Fixed #7896
2.3 is slightly different than 2.4 with different variables so this
fix is different than the 2.4 version.

roll back for 2_3 for picture widget

Fixed #7896
Handled the case where there is no picture and made it simpler to load
a picture.

(cherry picked from commit dc91c9490a61c374b4358a3a328019f3e0e150ab)

Fixed #7714
Added JS code to formate the date/time for UCT

(cherry picked from commit 893b609111be502233a7a4ad6804fff1e4779a03)

Fixed #7921

(cherry picked from commit 5fce3e8e905c3a2029475293cf760ee2c2a51074)

Update pfsense small logo

If ECL picks up a config on the first boot post-install, trigger a package sync and don't run the wizard.

(cherry picked from commit 695f7d5c054b7df724ea4fd6883a29a2da60cca5)
(cherry picked from commit 661c5b7f6a80e9a2819393164c3557f74bf9a023)

Fix PPP log reference in status.php

(cherry picked from commit 35e5c404ef0d03d40eeac7f5a33f43da0d3ac6fc)
(cherry picked from commit 69ed1107fac3c256695d9c1ba4fb684a328a6faa)

Detect XG-1537

Don't call widget callback function if no data is returned

Move this file_exists test inside the dpinger status check loop and also suppress PHP errors from stream_socket_client()
Both are done to avoid a race where the status file can be missing and the status check fails, resulting in an alert/crash report.

(cherry picked from commit 59104a6ff6c862482eddb9696fd8d22dec89052e)...

gateway monitoring, give apinger some time to properly 'initialize' before using its results

(cherry picked from commit 29fa6f0f46ba039a67a93c00a08bcaecc3935b78)

Restore bad login message

remove old logo from default page

make css compatible with newer nvd3 version

update top nav bar logo

remove image from rss widget

update favicon

Fixed #7811

Fixed #7804
Replace Math.trunc with Math.floor to make IE happy

Captive portal: fix idle times in details popup

Explicitly cast $idle_time to integer.

(cherry picked from commit 07df3494bd9a508e568b4ae999369ec8b2d14ec2)

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

(cherry picked from commit 6d028dc26c129ce1b0b25551142819772664f1e5)
(cherry picked from commit c7fd6ec9b196b0d7c37d14dad13f745dab82420d)

fixed #7795
By changing var name to no longer conflict with ipsec widget

(cherry picked from commit 3ed475b11dfcb2999a71195987495ccf05808127)
(cherry picked from commit bc2772c18ef2aa9a32b941fcf79c0c160fad7666)

If the user chose to have DDNS Hostnames forced, respect that in the backend code for static map IPv6 hosts. Fixes #7324

(cherry picked from commit bad77fc0aca53e560710eaa75b3de198d7edb8f3)
(cherry picked from commit 50608d158646e32a612f845bcd0dfa91ce37d713)

Eliminate unused functions from functions.inc.php

Backport 2.4 getstats format for ease of maintenance

Fix system information widget display order

Avoid JS error by always rendering mobile ipsec DIV, even if empty

Fixed JSON format in IPSec widet per Kill Bill (Thanks!)

Interfaces menu "(Assign)" -> "Assigments"
Add support for menu divider bars

Revise CPU load display to eliminate sleep in AJAX call

No longer experimental so comment removed

Speedup package related calls to get_pkg_info() since now we have a script that update metadata periodically

shaper, hfsc cannot use priority, as such don't show the field in the webgui.
Also for the other shapers 0 is a valid priority
While fairq causes a error loading rules with a priority above 7 so prevent that.

(cherry picked from commit 417991954c631fcc33ed3dc38a99ae3efecfea6e)

Some systems - only one that I am aware of, complain that unbound is starting before dchp6 has completed leading to problems, this occurs only on boot.

Further examination did indeed show that the problem is caused by unbound starting before the dhcp6c - RTSOLD - rc.newwanipv6 have completed, making sure that these have all run before unbound is allowed to start corrects the problem....

DOn't automatically update CIDR masks if the selector is disabled

Do not use reference to avoid losing data

Ignore upgrade_167_to_168() when upgrade_166_to_167() runs, they are both the same

Always run additional_config_upgrade() and do it after config is written

Each item in additional_config_upgrade() must write config after changing it

Detect old workarounds in config upgrade and deal with them

Bring upgrade_166_to_167() to 2.3 world

Move workaround used to enable pkg metadata update cronjob to a generic mechanism

Check if specific config upgrade code already ran and skip it

Add a function to be called every time convert_config() runs

Hide dashboard update period control. No longer needed with central refresh system

Convert firewall logs widget to centralized refresh system

Revert config version to 15.8 and remove upgrade script

Add thermal_sensors.inc file to obsoleted files list

COnvert thermal sensor widget to central refresh system

COnvert dyndns widget to central refresh system

Added refresh icon to version display

Add refresh icon to system info widget version display

Refresh cache every 2h when using GUI

Make sure pfSense-upgrade return code is obtained instead of tail's one

Add a workaround to register rc.update_pkg_metadata cronjob on 2.3 since config version cannot be bumped