pfSense

Code spacing

and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.

Code style Firewall NAT

Ticket #4445 do not write config and remove its cache when applying settings its just behaviour from dinosaur era and should have been cleanded long time ago.

Fix lineup of copyright lines

and module names and other bits of formatting and typos in header
comment sections.

Welcome 2015

outbound NAT can apply to any type of interface, make WAN-type specific reference generic

modify copyright statement to reflect reality

Make sure button 'move to the end' highlight last line

Add (self) for an outbound NAT source as well

Unset these globals after use

Include static routes in automatic NAT rules display

If I have an internal gateway to other private subnets behind LAN, and add a static route to those private subnets through the internal gateway, then pfSense very nicely generates NAT rules on WAN-style interfaces to NAT those internal subnets on the way out of WAN. That is very good and convenient. This outbound NAT is actually correctly in the ruleset....

removed duplicate type=text/javascript
added type for <script>

replaced uppercase html tags with lowercase
js files saved as UTF-8 / LF
language="JavaScript" deprecated, replaced with type="text/javascript"

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Show aliases popup on Outbound NAT list

Fix typos

Make it more visible when an item is disabled

We do not need 2 variables to do the same thing, simplify it a bit

Improve text on outbound NAT page to reflect last changes, it should fix #2416

Fix a wrong } left on my last commit

Try to detect already automatically created outbound NAT rules and avoid duplicating them. Also automatically create rules when switching from hybrid to manual. Ticket #2416

Use the same code to automatically create outbound NAT rules when mode change to manual, ticket #2416

Move automatic rules to a separate table, ticket #2416

Show advanced outbound rules and inform user what are being used and what are being ignored. It should fix #2416

Add hybrid and disabled outbound NAT, fixes #2416:

- Add 2 new outbound NAT modes, hybrid and disabled, manual and advanced
keep working the same way
- Hybrid mode applies manual rules first, automatic after
- Disabled do no create any outbound NAT rules...

Fix indent, whitespaces and a close a couple of unbalanced tags

outboundnat, disable checkbox

touch up text, s/nat/NAT/

Tidy up "firewall_nat_out.php" XHTML

Close BR, INPUT and IMG tags and ALT to IMG tags
Update HTML Boolean operators
Move NOWRAP to class statement
Move CENTER tag to ALIGN statement in TD tag
Add missing closing SPAN tag
Add missing closing P tag

Rearrange this manual outbound NAT rule generation loop -- fixes unnecessary duplication of Localhost and VPN rules.

Add the user/time tracking to Port forwards and outbound NAT also.

Insert new NAT rules on the top of the list when top plus icon is used. Fixes #1118

Do not skip displaying outbound NAT rules with no interface or an invalid interface; it interferes with editing/deleting the skipped rule itself or rules after it.

Revert "Use get_Cofnigured_interface_with_descr() here since that's the purpose"

This reverts commit 0c8e9f0c26b29f57faa2ccef9a559774103fee79.

Use get_Cofnigured_interface_with_descr() here since that's the purpose

Fix outbound NAT rules when interface is deleted:

- When delete interface, do not touch outbound NAT rules
- Skip outbound NAT rules when interface doesn't exist
- Bump latest_config to 9.2
- Since rules with no interface were considered as wan, convert old...

add " address" behind the interface nat name

show difference between outbound NAT and outbound NONAT.

Refine saving/applying on more pages - don't show apply or take an action unless the user is allowed to do that.

Protect against a potential infinite loop here.

Add per-rule delete ("X") button to Outbound NAT rules

http://redmine.pfsense.org/issues/1062

fix firewall_nat_out to not auto-generate outbound NAT rules with one too many IPs

Clarify notes so people don't think they need to disable pf to disable NAT.

Merge remote branch 'upstream/master'

Conflicts:
conf.default/config.xml
etc/inc/filter.inc
etc/inc/globals.inc
etc/inc/pfsense-utils.inc
etc/inc/upgrade_config.inc
usr/local/www/interfaces.php

Bug#1528. Automatically create outbound NAT rules on WAN for localhost when switching to manual.

Fix automatic and manual outbound NAT for PPTP. Fixes #954

Merge remote branch 'upstream/master'

Fix typo

Clarify text on outbound NAT page.

Merge remote branch 'upstream/master'

Also fix easyrule and auto->manual nat switch code. Ticket #1243

Unbreak static routes
Add initial NPt Network Prefix Translation pages

If an outbound nat rule has a protocol specified, show it in the summary view.

Allow entering an arbitrary subnet for outbound NAT translations.

Fix variable names. Ticket #954

Merge remote branch 'mainline/master'

Conflicts:
usr/local/www/diag_smart.php
usr/local/www/firewall_rules_edit.php
usr/local/www/interfaces.php
usr/local/www/load_balancer_pool_edit.php
usr/local/www/pkg_mgr_settings.php

gettext() fixes on firewall_nat_out.php

Modify various (s)printf format strings to allow translations to change the order of the inserted strings.

don't static port 5060 by default, it breaks things much more often than it helps.

Merge remote branch 'mainline/master' into 2_firewall

Conflicts:
usr/local/www/diag_nanobsd.php
usr/local/www/diag_packet_capture.php
usr/local/www/firewall_shaper.php

Fix interface name display for various cases on NAT rule listings.

Checked gettext() implementation on firewall_nat_out.php

Checked gettext() implementation on firewall_nat_out.php

Merge remote branch 'mainline/master' into 2_firewall

Conflicts:
usr/local/www/firewall_nat_out.php
usr/local/www/firewall_rules.php
usr/local/www/firewall_rules_edit.php

Cleanup HTMl formatting a bit more, stick mode on its on TR

Cleanup HTMl formatting a bit more, stick mode on its on TR

Cleanup HTML formatting

Fixing gettext() calls on firewall_nat_out.php

Implement gettext() calls on firewall_nat_out.php

Revert "Implemment gettext()"

This reverts commit 1baff2e5d32ebb5a71b07f38d9f97e3c4788e3be.

Lot of syntax errors

Conflicts:

usr/local/www/firewall_nat_edit.php

Revert "Implemment gettext() calls"

This reverts commit 7502ef0a698a49d9652cd3616447eb717cba707d.
A lot of mistakes

Conflicts:

usr/local/www/firewall_nat.php

Revert "Implemment gettext() calls"

This reverts commit 49031495b501e4477941fa6248fe94cc698f9dcd.
A lot of mistakes

Conflicts:

usr/local/www/firewall_nat.php

Implemment gettext() calls

Implemment gettext() calls

Implemment gettext()

properly create auto AON rules for PPTP, PPPoE, L2TP and OpenVPN

Create rules for openvpn/l2tp/pppoe/pptp when switching to manual outbound nat so the user can do less work.

don't generate automatic outbound rules again if there are already rules defined

more fixes to auto generated outbound NAT rules to match what is actually created by default in auto NAT mode

fix up auto-generated outbound NAT rules.

Don't wipe out user's configured NAT rules when switching back to automatic.

Add the no nat for tftp-proxy entry. Ticket #140

Correctly unset rules when switching disabling AON.

Revert "Correctly unset rules when switching disabling AON."

This reverts commit 989e5d62da2f7f6dad2bb55d20d2558cfb3fa34a.

Correctly unset rules when switching disabling AON.

Ticket #140 Fix Outbound edit page to really show errors. Propperly generate rules when switching from/to AON.

Resolves #179. Propperly check if this is an array or not. This is required since php 5.+.

Require filter.inc and shaper.inc

Add pfSense_BUILDER_BINARIES: and pfSense_MODULE:. Adjust Copyright to include 2009 on files that I have asserted (C) on

• Reorganize the 'apply' button infrustructure in the GUI.
  - Present three new functions is/mark/clear_subsystem_dirty('name_of_subsystem'). This makes easier to create such things without needing to introduce new globals.
  - Convert all pages to the new infrustructure...

• Create two new functions lock($subsystem)/unlock() to have more reliable locking using semaphores.
  This function can sleep till the resource is free and can help find not well behaving code.
• Remove most of the config_lock/config_unlock logics on the whole scripts/pages it is an abuse of this....

• Hide interfaces internals to other code and use the propper interfaces.
  Basically use get_interface*() functions instead of accessing fields like 'ipaddr'/'descr' etc...
• Make get_interfaces_with_gateway less heavyweight by getting information from the configuration stored in config.xml...

Massive javascript cleanup, all .js files now live in $g['www_path']/javascript
Purged unused JS

Do not automatically create a record for WAN.

Do not harc code white

Rewrite the pfsense privilege system with the following goals in mind ...

1) Redefine page privileges to not use static urls
2) Accurate generation of privilege definitions from source
3) Merging the user and group privileges into a single set
4) Allow any privilege to be added to users or groups w/ inheritance...

When switching to AON rules do not create nat rules for interfaces that have gateway.
This fixes some broken generated rules.

NOTE: That some more work is needed to make it comply to interfaces that are set as dhcp or to produce nat rules for interfaces other then WAN.

• Merge multiple PPPoE/PPTP interfaces from RELENG_1_MULTI_ANYTHING
• Much improved rule generation speed
• Many bug fixing in general of the interface handling

NOTE: this is the other half of changes

Continue interface improvements

touch up text

Ticket #1569

Switch over to array style page titles. Obtained-from: m0n0wall