Ticket #4418 make sure the dns_split is separated with spaces rather than space or comma to comply with strongswan requirements.
Ticket #4418 Make the DNS names attr 28675 space separated as identified by Jeffrey Dvornek
remove old, unused code
When RADIUS auth is selected, radius protocol and server ip/host are mandatory. Fixes #4384
Initialize var and move unset outside the loop
Merge pull request #1495 from k-paulius/fix-dhcp6c-4436
isset is a better check here
Merge pull request #1494 from k-paulius/ntp-rrd-fix
Merge pull request #1479 from surrural/master
Merge pull request #1492 from PiBa-NL/carp-statusicon
Merge pull request #1498 from phil-davis/patch-3
Merge pull request #1513 from znerol/bug/master/unbound-host-alias-ptr-followup
Fix PTR records for aliases in host overrides
Ticket #4445 do not write config and remove its cache when applying settings its just behaviour from dinosaur era and should have been cleanded long time ago.
Add support for DNSimple (dnsimple.com)
Update dyndns.class
Merge pull request #1511 from phil-davis/patch-4
Merge pull request #1497 from phil-davis/patch-2
Merge pull request #1477 from razzfazz/fix_net_ipv6_compress_all_zeroes_master
Preserve "add routers" value across loop for each interface
Forum: https://forum.pfsense.org/index.php?topic=89302.0
If the user put "none" in the 'gateway' field for the DHCP settings of an interface, that would set $add_routers to false at line 742. Coming around the loop again for a subsequent interface, and going through the else line 744, nothing would set $add_routers back to true (actually back to the value originally calculated at line 461)....
Merge pull request #1496 from stilez/patch-2
Merge pull request #1476 from razzfazz/fix_dns6ip_assignment_for_track6_master
Merge pull request #1478 from razzfazz/fix_dhcpv6_avail_range_dump_master
Merge pull request #1509 from znerol/bug/master/unbound-host-alias-ptr
Merge pull request #1510 from phil-davis/patch-6
Fix display style typo
I could not see any difference in rendering of the page after fixing this, but it looks it it should be fixed.
OpenVPN server improve handling of authmode
Currently if the user is clicking around while they are setting up an OpenVPN server, they can do stuff like this:a) Select Server Mode - Remote Access (SSL/TLS + User Auth)b) Select something in Backend for authentication...
vpn_openvpn_server.php white space
Do not add PTR records for aliases in host overrides
Merge pull request #1505 from phil-davis/patch-7
Merge pull request #1504 from phil-davis/patch-6
Merge pull request #1506 from k-paulius/fix-links
Merge pull request #1507 from phil-davis/patch-8
Merge pull request #1508 from johnbyronent/master
Success typo
might as well fix it while I notice it
Fix broken links to dhcp6c.conf man page.
manpath FreeBSD+Ports no longer exits and needs to be replaced with FreeBSD+10.1-RELEASE+and+Ports
Mention interface name on DHCP edit GUI
IMHO it can be confusing on the DHCP edit page for static mapped entries to know which interface the entry is being edited/added for. Specially if the user comes from the Status DHCP Leases page, the lease they are editing/adding could be for 1 of many LAN-style interfaces....
Status_dhcp_leases fix edit button for static entries with no IP address
The edit button for static entries always has an index id=0 and thus pressing the edit button goes to (mostly) edit the wrong entry.It was easier and made the code cleaner to get rid of the looping through the staticmap array every time trying to matach IP, MAC address... That data ('if' and 'staticmap_array_index') is easily gathered further up, the first time the staticmap array for each DHCP interface is traversed. I think this should also be more efficient when there are many static mapping entries....
Clean up some old, possibly stale, files when restarting php-fpm
add a couple unnecessary bsdinstaller files to obsoletedfiles
remove unused dfuife files.
Handle reverse lookup domain overrides
that match exactly a whole block of private address space.e.g. if the user has checked "Do not forward private reverse lookups" and also adds adds a domain override that matches a whole block of private address space, such as:...
diag_arp allow underscore in resolved host names
is_hostname() and is_domain() allow underscore in the names. So it is possible to have underscore in host names, for example in DHCP server static mapped entries I have some things like:10.42.3.4 client-pc-01_LAN...
Don't hard code harden-referral-path. It defaults to no, so no behavior change, and that setting is unlikely to ever become a default. This allows users to configure an override to enable this option if desired. part of Ticket #4399
Add GUI control for MOBIKE. Hide it when IKEv1 selected. Enable toggling of NAT-T field display so it's on for IKEv1, off for IKEv2. Do same for reauth while here. Ticket #3979
Wait a bit after sending a TERM to syslogd as in some instances it can take too long to stop, and it fails to restart because it's still running at that point. Add a KILL in case it's still running after that. Ticket #4393
Three minor improvements to IP functions
1) Most is_ip***() functions can return 4 or 6 to indicate type of IP, for benefit of calling code (both evaluate to boolean TRUE for backwards compatibility). But is_ipddr() doesn't. Fix is_ipaddr() so it follows same result schema. This saves calling code having to retest same data to determine type....
Do not request prefix delegation if no tracking interfaces are setup touse it. Ticket #4436
Fixing issues with NTP RRD graph state changes
- only call enable_rrd_graphing() after $config['ntpd']['statsgraph'] is set - fix if condition; empty and isset are each other's opposites
carp, don't show status icon from previous carp ip in case the ip is not present on the interface (test with ifconfig em0 1.2.3.4 delete)
Unobsolete libpcre.so.1
Merge pull request #1484 from phil-davis/more-text-typos
Merge pull request #1485 from BBcan177/patch-1
Surrond the some mobile clients attributes with " ( quote ) to help the strongswan parser identify properly the values. Ticket #4418
force minimum 100000 byte log file size. Some have been confused thinking this is KB, in some cases causing problems. This should help, and there shouldn't be a need for logs smaller than that.
Update fbegin.inc - Missing '/' in path
Found this issue in conjunction with user Digdug3
Set srctrack separate from this test or the value won't save unless the sticky box status also changed.
Unobsolete crypto tools and athstats, ticket #4239
get rid of wizards/initial/ images that were never used
DHCPv6 client rules MUST come before bogons. Add a comment that hopefullysticks out so this stops getting broken. Ticket #3395
Ticket #4390 Return only the subnet bits not the full network in cidr format.
Remove dead code and unset vars so next time the code works properly avoiding cache issues.
Fixes #4389 The VIP interfaces cannot be assigned since they are just an identification of the VIP for tracking. Consider that when configuring gif/gre. Also on bridges you cannot set a vip interface as its member.
Random text typos
and I "corrected" function names that had "_choosen_" in them.That is not technically an error - function names do not have to beEnglish words. But it does look nicer to read.
Merge pull request #1480 from phil-davis/patch-1
Merge pull request #1482 from phil-davis/CP-text-typos
Merge pull request #1483 from phil-davis/formfld-unknown
Remove unset variable, spotted by phil-davis
rrset-cache-size should == 2 * msg-cache-size. Ticket #4367
Fix typo in class in bridge edit
Fixing this makes nice little pencil icons appear in front of the textentry fields.
Check if Unbound is enabled and using the same port before allowing dnsmasq to be enabled. part of Ticket #4332
that I noticed.
Fixes #4370 Use the curlies to not confuse php
Actually fix even the openvpn auth user script with proper checks. I thought this was fixes already!
Fixes #4329, Fix even tls.auth script by using proper isset() test as the fixes for other authentication scripts.
Fixes #4397 Make mtu configuration before the ip address assignment. This fixes the issues of link routes having the wrong mtu configured on them.
Check if notification is disabled
in send_smtp_message()Other packages like arpwatch sm.php and cron job output as reported in forum https://forum.pfsense.org/index.php?topic=88347.0 call send_smtp_message() directly, currently bypassing notification disabled checks. I think those packages [are intended to | should be] respecting the notifications disabled setting. People in the forum certainly expect them to respect this setting....
touch up Unbound text
Update Unbound defaults
also add v6 IPs to hosts in the same manner v4 IPs are added. Ticket #4395
Use appropriate interface field description when working with floating rules, it was confusing and potentially incorrect for floating rule purposes.
Merge pull request #1469 from makkbe/master
make computation of start of DHCPv6 range consistent with actual check
When computing the start IP for the 'available range' field,services_dhcpv6.php attempts to increment a colon-formatted v6 address.Since this always fails, so the value that's printed is not actually...
fix Net_IPv6::compress() to properly handle all-zeros address
The existing implementation of Net_IPv6::compress produces an emptystring when compressing the all-zeros ("::") address; fix this bychecking for empty return values and replacing them with "::".
add dhcp6.name-servers option with DHCPD-PD regardless of PD length
The existing code only includes a v6 name server IP in theautomatically generated dhcpdv6 configuration for tracking interfaces ifthere are additional prefixes that can be delegated on to the next...
fix up text
remove CGN from "Block private networks" as it was in 2.0x and earlierreleases since it specifically notes RFC 1918 and CGN is more bogon.Ticket #4379
Fixes #4381 this was a leftover of the change of zoneids to start from 2.
Merge pull request #1458 from xbipin/patch-4
Merge pull request #1472 from bassebaba/master
Merge pull request #1455 from xbipin/patch-2
Use web-gui setting for pap or chap instead of having it hard-coded to chap.
remove empty values
upgrade config
upgrade config code so old entries not lost during upgrade
Merge pull request #1466 from tuyan/master
Merge pull request #1470 from phil-davis/patch-1