pfSense

Removed debug statement

Changed it to just use the variable name

Fixed #8633 PHP7 issue use of undefined constant, Should work as it did before.

routing, add option 'automatic' for gateway selection, and allow manual ordering of gateways

routeing, gateways show proper IPv4 IPv6 default, also for dynamic gateways

routing, fix setting the default-route when the configured default gateway is a dynamic pppoe gateway. it doesnt have a gateway-status when it hasn't connected yet.

Fix IPsec VTI gateway generation to match interface changes. Fixes #8544

Please welcome routed IPsec using if_ipsec VTI interfaces. Implements #8544

To use, create a P1/P2 and set P2 to VTI using local/remote network as tunnel endpoint addresses, then assign the interface (enable, but IP type = none), and use like any other interface for routing.

Suppress route command errors and related debug output. Fixes #8497

PHP7 - Resolve foreach() warning

Use array tests and operations that are more friedly to PHP 7.2 in gwlb.

Check for valid array before call foreach()

Gateways, allow for configuring a gatewaygroup as the default gateway.
-Avoid changing routes by just visiting a webgui page.
-Avoid change some unneeded events when nothing changed.

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Fix dyndns update with gateway group

Update the Copyright notice for pfSense.

Don't create vestigial gateways, alt. approach

Move this file_exists test inside the dpinger status check loop and also suppress PHP errors from stream_socket_client()
Both are done to avoid a race where the status file can be missing and the status check fails, resulting in an alert/crash report.

Merge pull request #3763 from PiBa-NL/20170624-apinger-initialize

Do not run the dpinger when the IPv6 address has the tentative flag even after the timeout.

Issue #7659 foreach warning on adding gateway

Signed-off-by: Phil Davis <phil@jankaritech.com>

gateway monitoring, give apinger some time to properly 'initialize' before using its results

Merge pull request #3700 from phil-davis/ifgwadd

Simplify indexing of gateways array

Remove obsolete isAjax array key handling

Validate gateway and interface together

Refactor gateway save

Refactor gateway parameter validation

Refactor get_configured_interface_with_descr remove unused parameter

Fix incorrect sorting for various dropdown lists.

Wait while interface is in 'tentative' state before try to bind dpinger to its address

Correctly report unmonitored gateway status

If an alternate monitor IP has been entered and saved, then the user
checks "Disable Gateway Monitoring" and saves, the alternate monitor IP
is retained in the config - that is handy for when unchecking "Disable...

Add a function to format and return plain text output showing the gateway status, for use by a shell script and status.php. Ticket #7046

Add a gateway state plugin hook.

Pull Request #3093

Feature #3151 Disable gateway monitoring actions

without disabling gateway monitoring.

This allows the user to continue to monitor the gateway with dpinger, so
they can see how it is performing, but for the system not to take any
real action if the latency/loss exceeds the given limits....

Add missing L2TP from this gateway handling case. Fixes #6980

Fix #6828

Until 2.3.x pfSense carried a patch that changed the behavior of 'route
change' command, making it add the route when it fails to change.
On 2.4 this patch was removed and will not be added back. This change
adjust PHP code to deal with route add / change and make it work...

Make unlink_if_exists return true/false

This allows the caller to do a single "atomic" call to unlink_if_exists.
If it returns true, then they know that the file existed and that it has
been unlinked successfully.
This should help avoid race conditions where multiple code paths try...

Improve gwlb.inc notification mechanisms

1) Unlink earlier to reduce the chances of any concurrency issues;
2) Translate and improve output of available notification;
3) While I'm here, fix whitespace and improve PHP syntax.

Move copyright from ESF to Netgate

dpinger: fixed check for pidfile length #6505

Move to Apache License 2.0

Review license / copyright on all files (final round)

Review license / copyright on all files (1st round)

Merge pull request #2847 from jazzl0ver/patch-1

Shorten gwifip if whole socket path exceeds 100 chars

dpinger stopps with an error when the socketname exceeds over
(around) 100 characters. The dpinger will not start and not deliver
monitoring results to the WebUI.

These long socket names can get created when using link-local addresses...

Use a different delimiter for dpinger socket names

Currently underscores are used to seperate gwifip, monitorip, etc, but
underscors are also used in vlan subinterfaces like em0_vlan10 and
therefore can't be used because the interface scope is appended to IPv6...

Fix scope for IPv6 link local gateway IPs. Ticket #6353

Handle link local IPv6 gateways and default gateway switching correctly. Ticket #6258

Put gateway name and group around the correct way

Redmine #6134
Forum: https://forum.pfsense.org/index.php?topic=109781.0
Originally broken by commit: https://github.com/pfsense/pfsense/commit/d18f3f6e09b86359395cd78db2e19f721818b992

notify by email and in syslog when a channel goes up or down

Fix display of gateway IP address and gateway/group descriptions in firewall_rules_edit.php.

Adjust default parameters to match changes in dpinger

Fix a typo.

Merge pull request #2660 from phil-davis/gtetc1

Internationalize etc inc a-i files

Fix interface write_config message for dhclient_update_gateway_groups_defaultroute

Typo in var name.

Fix style issues.

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Return blank rather than 0ms/0% for unmonitored gateways latency and loss. Show on dashboard widget when a gateway is unmonitored. Ticket #2226

Fix #5830

Add a new advanced option on gateways to allow user define data
payload. Default is 0

Add standard deviation to gateway status and widget

Update license on files from /etc/inc

Adjust dpinger default values to match recent changes in dpinger project

Remove workaround to get dpinger running when interface is in tentative state

Make sure source and target addresses have scope id when they are link-local. It should fix #5695

Add a seatbelt to prevent 2 dpinger instances for same GW

Collect dpinger processes that failed to start and try again after 1 second, this should be enough to fix #5711

No need to return 0 here

Change start_dpinger() to return dpinger return code

Do not overwrite $params

Merge pull request #2332 from dennypage/master

Follow dpinger and change default loss_interval to 4* send_interval

Disable unused stdout reporting thread

update comment for dpinger

Return complete path for dpinger PID filename, it should fix #5686

Be less specific with dpinger PID filename regex, old version was not matching IPv6 addresses, with or without %ifname in case of ll

Rework dpinger related code to new version

- s/-U/-u/
- Add i GW_NAME to get this info on logs and make life easier
Since i parameter will be send to alert_cmd, remove it from command
Add source and target IP addresses on pid/socket filename since status...

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Use default values for latencylow and losslow when they are not defined by user. Reported by grandrivers at https://forum.pfsense.org/index.php?topic=103818.msg579069#msg579069

Convert latency to ms before use it to compare with value defined in gateway conf

gwlb array key typo loss_interval

Ticket #5624: Welcome dpinger!

Move main pfSense content to src/