pfSense

Add user option to sort interface names RELENG_2_3

Signed-off-by: Phil Davis <phil@jankaritech.com>

User Manager - Status Icon - Sort Order

Make status column sort order work correctly with the icons.

(2.4, 2.3)

(cherry picked from commit 0fdbaca8f16d0424cb2565ff4341e7620a7bdd2d)

User Manager - Status Icon

Use icon for status rather than textual asterisk to indicate disabled account.

(2.4, 2.3)

(cherry picked from commit edd88334dbe95af4600ae493fa86d45244cbaecb)

Breadcrumb links

(cherry picked from commit edcd75357f0e93b124159314d3306197d5312e6c)

Required fields for System pages

(cherry picked from commit 153c3aa61fe65c51d584a57c032a4805048e3062)

clarified input format hint for expiration date
(cherry picked from commit 98b87cfafe8a890787ca5d22a1089678b9b250ac)

Move copyright from ESF to Netgate

Code style and comments

No functional change - just making style consistent

(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)

Merge pull request #3073 from phil-davis/certs

Backport Add missing recommended key lengths/digest to Cert system

Original pull request to master was #2944

Backport Remove input_errors2Ajax calls

Original commit to master was

https://github.com/pfsense/pfsense/commit/86d431a89d920f64dda5e7e1821f720daf6e067b

Review license / copyright on all files (final round)

webgui tables, doubleclick event to perform 'edit' action, part 2

(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)

Feature #6388 custom GUI preference settings per user

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

(cherry picked from commit 53c38ff16c1eb8743e69d506f69167c88cf34910)

Validate submitted groups when editing a user. Ticket #6475

Changed element type from date to text. Date inputs are not yet handled consistently accross different browsers :(

(cherry picked from commit d78dbc34299652c637c77684b7848191c510f9f0)

Miscellanous Textual Corrections - Add missing dots to phrases

(cherry picked from commit e4c7d45fc7a294817325354e13f4d5bc4987739e)

Fix typo

System / User Manager - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

System / User Manager / Users / Edit

Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).

Error: Stray end tag td.

Fixed #5911

Restore infoblock functionality for now

Replace alert with callout. Removed mention about greyed out icon - that is no longer applicable.

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Merge pull request #2637 from k-paulius/patch-6

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Indicate in the breadcrumb if we are editing list item.

Synchronize page title with tab title

Convert section titles to title case

Fix description disappering when editing admin user

Internationalize system user and group code

UI Consistency

1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g....

Fixed #5566

Allow thee use of multiple infoblock on a page

Change the automatic information block to look for <div class="infoblock" instrad of <div id="infoblock"
Just makes more sense to use a class for this

Adjust more calls to print_info_box with unquoted strings

HTML Compliance - System / User Manager / Users

A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.

Remove $closehead variable

Remove unused variable $closehead

system_usermanager remove unused code

1) Line 448 "Remove this certificate association? (Certificate will not be deleted)" there was the text "Delete" being displayed and not looking good, in addition to the trash bin icon. Just the trash bin icon seems to be all that is needed....

Code style system_*

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Standardize breadcrumbs for User Manager tabs

I think this is the way it should be to make it like everywhere else.
Even when in the "Groups" pages, it is still reached by "System" "User
Manager".

Fixed #5389

Merge pull request #2134 from ExolonDX/branch_04

Type up SCRIPT tags

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

fix moveOption function

Ticket #5471 another convert batch to font-awesome icons

Fixed #5416

undo earlier commit

Merge pull request #2047 from heper/patch-2

Fixed #5405

fix submit & move back to seperate ACT==delprivid

the code for delprivid was inside ACT==save / when hitting 'save' the post-data for delprivid was already gone

Completes #5400, #3999, #5405
Mote: New ticket will be opened to provide IP address sorting

partial fix Bug #5389

Fixed #5388

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Copyright updates Batch 2 of 3

Delete confirmation vi fa-trash automated via pfSense.js

Moved action-buttons in-line styling to pfSense.css

replace and find for icon-embed-btn

Buttons updated

convert system_usermanager to font-awesome

Ticket #5204 a clean up pass of the jquery sections

Work around a chicken-and-egg problem in user syncing. See #5152
See also: 5372d26d9d25d751d16865ed9d46869d3b0ec5e1

Fixed 5139
Resolver GET/POST error

Fixed 5118
Input was set 'disabled' but should have bee 'readonly'

Fixed #5105
Page updated as suggested via comments

Fixed #5096
Layout changed as requested

Fixed 5095

Merge pull request #1853 from PiBa-NL/bootstrap_fix1

Fixed #5028
Restored correct delcert action

Fixed #5055
"All" no longer appears in group lists

Fixed #5028
By restoring "Delete" button and fixing table elements

Corrected cert table functionality by adding missing PHP

bootstrap, use require_once for classes/Form.class.php

Fixed bug #5028
The page was junk as originally converted. It has been re-written to work as required. Links to certificates have yet to be implemented, but that will be added once testing is complete on this version.

Merge branch 'master' into bootstrap

Move main pfSense content to src/