pfSense

Convert easyrule.php to use a confirmation landing page so that the parameters can be submitted via POST. Also, remove the JavaScript confirmation box since it is now redundant. Fixes #7228
The confirmation page displays the submitted parameters for an extra user sanity check. Also fixed a bunch of page formatting issues that were not apparent because users rarely if ever saw output from the page.

interfaces_ppps_edit remove embedded HTML from setHelp string

There was only one of these remaining to do.

Merge pull request #3501 from phil-davis/patch-1

Merge pull request #3503 from phil-davis/patch-3

Merge pull request #3502 from phil-davis/patch-2

Encode the contents of pkg_filter before output. Fixes #7227

Fix #7226 Package installation message is incomplete

This makes it remember pkgname after the install finishes and the form is re-submitted.

pkg_mgr_install remove embedded HTML from result strings

Encode 'from' and 'to' before output on pkg_mgr_install.php. Fixes #7225

Merge pull request #3494 from lukehamburg/copy-duid-patch-2

interfaces_ppps_edit fixes that will work on 2.3.3 also

1) Make "The MTU is too big" message actually come out. The code around line 300 was rubbish (maybe from before bootstrap?).
2) Show friendly description rather than 'wan' 'lan' opt1' in interface link list....

Merge pull request #3484 from phil-davis/sethelp-empty

Merge pull request #3500 from phil-davis/patch-5

Merge pull request #3499 from phil-davis/sethelp-review4

Merge pull request #3497 from phil-davis/patch-3

Merge pull request #3496 from phil-davis/patch-2

Merge pull request #3495 from phil-davis/fbegin-fend

Merge pull request #3487 from phil-davis/patch-1

Merge pull request #3473 from jxmx/7206_route53

license.php getext formats and breadcrumbs

1) I added a breadcrumb because the "?" "help on this page" icon does not display nicely without the breadcrumbs section.
2) Make various gettext() a bit nicer.

setHelp and getttext for i*.php files

interfaces_bridge_edit setHelp and input_errors formatting

This had enough things to be worth its own pull request.
1) Get embedded HTML out of setHelp etc strings.
2) Fix some array parameters to setHelp (these were causing warnings).
3) Make various input error messages display the friendly interface name, rather thn "wan", "lan", "opt1".

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

fbegin.inc and fend.inc are no longer used

add Copy DUID convenience button
- adds `Copy DUID` convenience button/js
- no page refresh or AJAX

Merge pull request #3490 from phil-davis/sethelp-review3

Do not attempt to translate '-DIVIDER-'

'-DIVIDER-' is a keyword here. If someone does translate this, then the divider is going to go missing when in their language.

user/local/www inc file gettext improvements

Internationalization graph.php

1) A few extra strings to be translated.
2) The scale_type code values 'up' and 'follow' need to be kept as those strings in the JS scale_type variable. The text to be translated needs to be in a different variable that can be in translated form for display. Otherwise things go wrong when in a different language....

Merge pull request #3465 from phil-davis/system-widget-filter

Merge pull request #3480 from PiBa-NL/certmgr_20170206

Merge pull request #3485 from phil-davis/form-var-names

Merge pull request #3482 from phil-davis/patch-4

Merge pull request #3478 from phil-davis/sethelp-review2

Merge pull request #3477 from phil-davis/patch-2

Merge pull request #3476 from phil-davis/sethelp-review1

Use unique var names in Input.class.php

Do not pass empty string to gettext

Remove unused restore_ver from diag_backup

I cannot see where this is used any more. The functionality seems to now be done in diag_confbak

Escape '%' in help text

certificatemanager, don't show information from previous certificate if no cert or csr is present in the cert

setHelp and gettext changes for firewall* pages

Firewall Rules Edit translate Source and Destination

These bits were not translating.
Line 1406 could possibly be like:
```
$group = new Form_Group($name . ' ' . gettext('Port Range'));
```
But then that assumes that in every target language the translation of "Source" or "Destination" can be put in front of the translation of "Port Range"....

Remove HTML from strings in diags files

Merge pull request #3469 from phil-davis/fw-nat-out-edit-other-subnet

Merge pull request #3472 from phil-davis/patch-2

Merge pull request #3474 from lukehamburg/lukehamburg-patch-1

Merge pull request #3471 from phil-davis/patch-1

Add a '.' to the help text for consistency

Fixed embedded '%' that was breaking setText.

Update help message for Zone ID for new region requirement

system_advanced_admin remove href from setHelp strings

I think that giving long strings that contain various HTML tags in-line through for translation is going to be error-prone. Actually we do not want the translators to accidentally also translate href like system_usermanager or accidentally miss out some quotes or brackets. It seems safer to substitute these in using %s formatting....

system_advanced_admin remove setHelp array

Fix firewall_nat_out_edit dependency on English

System Information widget filter gettext()

Several more fixes for setHelp to assist with translation

Fix #7202
Fix several sprintf errors by escaping '%'s and removing '[ ]' which had been use to pass arguments to setHelp as an array.

Remove \n from gettext strings

Merge pull request #3463 from jskyboo/master

Remove unneeded sprint and gettext in setHelp

Provide info on services_checkip.php about what the server must return, and provide two examples of server-side code to return the client address. Fixes #6374

Remove unneeded sprintf from setHelp calls

COnvert the setHelp method(s) to accept conventioanl printf style argument lists. e.g.: setHelp("%d interfaces have been detected", $numIfs);

System Information Widget Filter

Add to NTP GPS processing of PGRMF sentence

Merge pull request #3462 from phil-davis/percent-s-www

Code with multiple %s in usr/local/www

Merge pull request #3461 from phil-davis/patch-3

Merge pull request #3458 from phil-davis/ifname-nopkg

diag_reseststate sourcetablehelp escape of double-quotes not needed

The backslash escaping of the double-quotes here displays the backslashes literal on the GUI. Escaping is not needed in this single-quoted string.

Redmine #7173 Do not allow pkg_ for If, IfGroup, Alias

Fix #7183 Do not allow Interface Groups with the same name

I should stop trying bad stuff, there seem to be so many holes to find in the validation :)

Fixed #7180

Merge pull request #3451 from phil-davis/required-fields-vpn

Fix #7173 Interface Group Name cannot contain dash

Required fields for VPN pages

Merge pull request #3449 from phil-davis/required-fields-system

Required fields for System pages

Fixed #7171
Moved setHelpText() to helpers file

Merge pull request #3448 from phil-davis/required-fields-services

Required fields in Services pages

Fixed #7154
Remove duplication in javascript

Merge pull request #3446 from jskyboo/master

Fix indentation

Changed max repeat alert to use sprintf get text

Bug #7164 Limit NTP time source fields to the maximum number saved to configuration.

Typo in pppoe_subnet input error message

Merge pull request #3442 from phil-davis/monitor-reload

Merge pull request #3441 from phil-davis/required-fields7

Merge pull request #3440 from phil-davis/patch-2

Merge pull request #3439 from phil-davis/patch-1

Merge pull request #3433 from jskyboo/master

Fix cut-paste error in Breadcrumb Links

Standardize rules reloading message

Required fields for Captive Portal

Captive Portal auth method is required

When creating a new Captive Portal Zone the user can fail to select any of the Authorization Method radio buttons. No default radio button is selected - that is probably good, as the user has to think and click to decide which authorization method they will use....

CP HTTPS Forwards setHelp format

Add full stop and spacing between sentences.

Revert change to css

Changed default state of GPS init command auto correct tool.

Merge pull request #3424 from phil-davis/patch-8