pfSense

Add user option to sort interface names RELENG_2_3

Signed-off-by: Phil Davis <phil@jankaritech.com>

Update diag_gmirror.php

Fix typo

(cherry picked from commit 55588e0ce32865568522e0afd0b577fdfabd3b74)

Issue #7659 foreach warning on adding gateway RELENG_2_3

Signed-off-by: Phil Davis <phil@jankaritech.com>
(cherry picked from commit 5c88dacbc259c668899d8127e9ad1ec74d12e565)

Fix interface groups link

Add more checks to eliminate empty config tags in package settings. Fixes #7624

Add input validation for interface names on firewall_nat_edit.php and fix encoding of the interface name in dst_change. Fixes #7651

Fix handling of the 'type' parameter so it is validated and encoded on diag_table.php. Fixes #7652

Prevent the filename from being used to run XSS in the diag_edit.php file browser. Fixes #7650

Change paid support help link to new support URL

Restore the captive portal feature to view the captive portal page directly from the portal web server. Add this as an additional button so both methods are possible. Fixes #7646

Redact BGP MD5 password/key in status output. Fixes #7642

(cherry picked from commit aa18c5b9b62e110ebf88fbb24c39c2a13813bd89)

Various updates to PR

1) convert echo to print, and add infobox, as requested in PR comments
2) If no identifiable line number, say so
3) EVAL gives an error message format that wasn't picked up, it is now. Test case - enter as the code: eval("X");
4) Warn that EVAL gives a "spurious" "error at line 1" as well, the real error is in the (...). See above test case for this....

add comment
(cherry picked from commit d2d58d6ad1b32e0ccce094bfd247547f353e38ba)

typo
(cherry picked from commit 4711322b4a6ecedba6a4a11c1f7f04ef8427b46e)

If user-entered PHP errors out, display the error line in context to help the user

If the user enters PHP in the command-line page, and it errors out, it's usually a typo or something minor. But the user is left with an error that references a /tmp file which doesn't exist at the point they read the message, a line number that's incorrect, and their input which doesn't display line numbers anyhow....

Removed htmlspecialchars when loading leases from config
(cherry picked from commit 2322e9f3cb6dea9203d63a17c6a27de3a2c6b8bc)

auth_check, faster authentication check while automatically refreshing diag_routes

(cherry picked from commit 60ba7c7642036deb1001f1862e5c19d465fbdf74)

auth_check lowers cpu usage for checking if the user has permission for the page requested when used in place of guiconfig, especially useful for frequent requests like those made by stats and traffic widgets

(cherry picked from commit c07071cbcadd1c9de9951d9ba497b73752ee52cc)

Add missing break for cloudflare case
(cherry picked from commit d900381c9384676462c91c0b2e7e59ec42723237)

Integrate various cloudflare changes
(cherry picked from commit 5ce6ce4b1ad850e70d5a2fe218317b1a1b545907)

Diag DNS disable Add Alias button when host field is changed

(cherry picked from commit 45eafdbd7b958bd4f9459d90a6a63ff8202eec3b)

virtualips, ability to sort the table

(cherry picked from commit 77c53e65fb7d4f40baec5c01a796a637c9cc5034)

Make consistent rule information section

(cherry picked from commit f0dc8b688c2b7d973bc18769579ee8cc6d3d2dad)

Add download button/function directly on status.php to ease confusion.

(cherry picked from commit f7a72733f8c482e230e0042a6c65f4935a2b723a)

pkg_edit, fix empty config tag check

(cherry picked from commit 6bf2a65086f7664c870a9565b70c39655c2a3dcf)

Diag DNS fix update alias button text after add alias

1) Lookup a name with Diag DNS
2) Press "Add Alias"
The alias is added, but the button still says "Add Alias".

Actually the alias exists by now. The button should say "Update Alias".

Fix: once we have emitted the alias create/update success message, we can set $alias_exists true so that the rest of the code is based on the (possibly new) state.(cherry picked from commit 474b275684950ab8215b449987d4cbece005f9ed)

Diag DNS do not show Add Alias if no priv to add alais

(cherry picked from commit 7fcccc8f09afd7f4a524ff598b43e15d678905eb)

Diag DNS do not create an empty alias if name does not resolve

(cherry picked from commit f445385114c43cb46b8188a7cea425648f7647f2)

Add NGID to status.php

(cherry picked from commit fcc24426ab16b02ffc77bc7c9ee040d76dd987a2)

Backport syslogd service definition/control to RELENG_2_3. Ticket #4382

Revert "Updated d3.js and d3pie.js to latest versions"

This reverts commit 47d4784602466d723a84bb1af6d313c4ba5a0115.

Updated d3.js and d3pie.js to latest versions
Fixed #7546

(cherry picked from commit 47d4784602466d723a84bb1af6d313c4ba5a0115)

get_pkg_info improve installed_pkgs_only case

(cherry picked from commit dd6ecfa27246935ca03747162b802fcd4ba36100)

Add "netstat -nWx" to status.php output

(cherry picked from commit 6252b47062a3bf2be19a43be480fd0acd56b75d0)

Only cache CP RADIUS Auth credentials when reauthentication is enabled. Fixes #7528

(cherry picked from commit d4e42c54a2b7d9c955b11ad3034a186a73159f1a)

Typos in pkg management code comments

(cherry picked from commit 146dbf0139d1f3049131bdf7a7d96675e4ff00a4)

Let he user know if all selected interfaces are down

in the interface statistics widget.
At the moment, if all the selected interfaces are down, the widget will just display no columns. That will make users wonder what happened.
(cherry picked from commit b22fceb2d7973b8c80a55b4ec492819ddd5ae9f9)

Fix interface down in interface statistics widget

If an interface is down, the widget would write the interface description in a column heading but then omit the stats items. So later columns (to the right) would have the headings and stats items out of line....

Redmine #7318 None button for widget filters

(cherry picked from commit fba53b438540eb544c43adf4598e07320a910347)

Handle widgets having no items selected for display

(cherry picked from commit 405dfaad144de90a6e401354b80b82baf5ae3d59)

Remove bonus end td tag in interface statistics widget
(cherry picked from commit 9795332b0e101b4c500c3c75a8ea02325364fc17)

Make sure that array exists before using foreach() (Bug #7399)
(cherry picked from commit ce348731b63ea6980dc4f652e76d7c8c7432544c)

Spelling

space/tab

Add Netgate ID display to system info widget

Read default language from globals.inc instead of hardcoding (it was already defined there)

Set default anguage in General Setup to en_US

Since https://github.com/pfsense/pfsense/commit/fdcde31b4a910c4e058513c1e3f68a62e722da6b added German to the top of the get_locale_list() array, if you start with a default system and go to System->General Setup (make some changes to other fields if you like) and press Save, you end up in German because that is what gets selected in the dropdown when the config does not yet have a language in it....

Checks for DHCP Relay being enabled/disabled should be skipped when editting an additional pool

Encode hostname and other output for DHCP lease status. Fixes #7497

(cherry picked from commit a260eda55905607e9adfd5d7c3fd779b115459d5)

Always add the CN as the first SAN when creating a certificate in the GUI or an automatic GUI self-signed certificate. Per RFC 2818, relying on the CN to determine the hostname is deprecated, SANs are required. Chrome 58 started enforcing this requirement. Fixes #7496

Add expiration field to NDP listing

(cherry picked from commit fec2c3b73f05683b674d3b5351529268eadc8dd9)

Fix #7493 only check interface IP if static

(cherry picked from commit 8c6190e82f83a7907ec2757e72d9a8eac496dd61)

Avoid invalid arg error when saving WoL widget

when there are no WoL entries
(cherry picked from commit 66a5b767b1b533f6ce508a125404a2d8e3353c41)

Update services_dyndns_edit.php
(cherry picked from commit df4c21fc24cc6ff38988ca866928f2f73b97b744)

trafficgraphs, divide bandwidth by time when statistics where gathered to smooth out bumps in the graphs

(cherry picked from commit eddb01316c7ad06c1798e629b6158db505a86118)

ipsec overview, check label exists for interface including disabled ones, tell what was configured if not found.

(cherry picked from commit ac24ac6bbb5b94e1eb8420404a9b7bd9daf998b7)

ipsec webgui, move building the $iflabels array outside if the loop

(cherry picked from commit 11b9896609c2998106d5503fe2581bb3304b4a5f)

notify test buttons for smtp/growl should use new unsaved settings just made

(cherry picked from commit 64f8ec62ddd57241e4a8a755cade7ca8cd9196a6)

Do input validation on the actual array passed in

I was tearing my hair out for a while. If do_input_validation() is passed some array of keys/values that has been assembled elsewhere (not $_POST, $_GET or $_REQUEST superglobals) then it does not work. The code here, for at least the last 7 years, has actually been checking the array keys in the "hard-coded" superglobals. That is a bit surprising, since the array to be checked is passed in as $postdata parameter....

Escape IPv6 when passed to ndp delete command

(cherry picked from commit 1d92faa34f7c9aaa97b1983f273d2d73285befb5)

Add ability to delete NDP entry

(cherry picked from commit 13105d9c79fe3ac8be2b01c152fb9fb6a95147b4)

Remember original alias name on edit input errors

(cherry picked from commit 1271754326fe648093204296652398b1edd24912)

Refactor update_alias_names_upon_change

(cherry picked from commit 24807bfeaec218948937a1fdc2b4e863319e41a0)

Revise dev_mode change handler

(cherry picked from commit 8a0af41adc9c29ccf7b8dabb3b7658abf46054a6)

Fixed #7451
Revised onchage handlers to obviate need for second click in Chrome on MacOS

(cherry picked from commit dd3c646fa5744a550f91524035a92f509d6162cf)

Revert "Restore CSRF customizations"

This reverts commit 1d7a414705794f2527dc1b7b3bb5419db1024bb6.

Revert "CSRF: Close session before exit"

This reverts commit d2495e5893baa63b2973b66f7c1b9787fada2e30.

CSRF: Close session before exit

On CSRF, call phpsession_end() before exit to avoid syslog warning
about open session

Submitted by: PiBa-NL

Restore CSRF customizations

Update CSRF to latest version from github

Fix UTF8 in base64 decode

(cherry picked from commit 557e082696823ea5fa09a36d98f01775bf1e0c77)

Adds ability to ignore DHCP offers from multiple servers
- Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
- related dhclient source:
https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945

changed files:...

Typo fix

Disallow IPv6 for RADIUS server.

See https://redmine.pfsense.org/issues/4154. No need for users to waste their time with debugging packets black hole.

Merge pull request #3613 from doktornotor/patch-15

Fixed #7445
Now properly handles service names that contain hyphens

(cherry picked from commit 21a8edd7836baf1e4ee2f347fdc1bafb4d96c9d9)

Merge pull request #3687 from doktornotor/patch-1

(cherry picked from commit 7c820a5d1ddb0ecf66ccaf1c4c82cc6361e15a6b)

Merge pull request #3580 from doktornotor/patch-9

load package add-on tabs into config to avoid parsing all installed package xml's, fix tabgroup filter

(cherry picked from commit bc0661b7b32a99016b9e71b0ece969f6584034c2)

Redmine #7435 Fix edit problems due to POST id code

Add underscores to is_port* function names

(cherry picked from commit 593e9fe32d2959cd823fe5da55714ccfb9a0e958)

Provide functions for checking port range alias combinations

Show the button to reset CARP demotion status even when the value is negative, and change the reset code to accommodate. Also fixup text in that dialog. Fixes #7424

Fix display of BIOS only on Sytem Info widget

Show BIOS information in the system info widget, if it exists in kenv.

System Info Widget enable All button when disable firmware check is set

If system firmware disablecheck is set, then the click event for the filter "All" button is also not included in the JS, so the "All" button is not effective.

The setTimeout for systemStatusGetUpdateStatus() can be moved up just below where it is declared and inside the existing "if" that conditionally includes that function - no need for it to be inside events.push...

Fix #7317 Widget Filter All button gateways widget RELENG_2_3

Reduce numeric precision in gateways widget to single decimal place (Feature #6841)

Further internationalization

Add missing internationalization

Revise gateway widget config form

Allow hiding of gateways in Gateways Widget

Sometimes there are gateways that I do not care about, so it is handy to
be able to save some space on the dashboard by hiding them.
This uses similar code structure taken from service_status widget. I
made the Save and Clear buttons and all that stuff use the same styles...

Visually separate the package manager legend area (Bug #7203)

Fix #7317 Widget Filter All button

(cherry picked from commit 7067e174c27a1fe9b23d13806f1e52ce9bc2aaee)

Fix #7364 Console assigned VLAN disappears after reboot

(cherry picked from commit 75a1149e0104561446e6f90f98d98c6c13c52996)

Fix #7306 Correctly filter log widget entries by interface description
(cherry picked from commit 27bc5848cfea95f97f70a4fe0c30da6319794a9a)

Remove whirlpool from the list of CA/Cert digest algorithms as it does not work properly. OpenSSL claims it's not valid ("unknown signature algorithm"). Fixes #7370
While I'm here, stop needlessly repeating the algo list, it's a global in certs.inc, so use that single copy of the list.

Fix display of openssl errors when working with CA or certificate entries. Found this while looking into ticket #7370

Set new blog URL (https://www.netgate.com/blog/) as default for RSS widget

(cherry picked from commit 294f14f7897f973f1fa2a1506cfdd9117b5daf65)

Redmine #7301 Put dot after the word break

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 81b1b44ad7e4d7abc635b08533359b9df45b54b2)