pfSense

Redmine #7301 Provide word-break opportunity for dynamic DNS host names

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 138e79d42cb1771e3b8fcc727270187f5c7ee7db)

Add reasons to write_config() calls
(cherry picked from commit 919a43a7caa551cb14e72a5cd82ec1629b3a9aa5)

Remove useless add_base_packages_menu_items() function

Not really sure what was the idea 7+ years ago, but the code just doesn't make sense now.
(cherry picked from commit 94503103d8ce4e34de79f221f4fdd24f07dccb93)

Deduplicate code

Allow CloudFlare DDNS entries to use "" or "." for the hostname portion of the domain in the GUI to update the domain's @ record. Then in the backend code, remove that from the FQDN since CloudFlare doesn't like that to be sent explicitly. Fixes #7357

Fix is confirmed to work by two forum users: https://forum.pfsense.org/index.php?topic=122099.msg699763#msg699763

Do not enforce a max limit on state timeout when editing a firewall rule. Fixes #7356

Adjust fix for ticket #7294 for 2.3.x, it used a setHelp change that was only valid on 2.4.

Fix 7294 keep full rule description

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 680e15baef76a9c598d52d3f2b9ab498077336a8)

Show PPPoE/PPTP/L2TP uptime on the Interfaces widget (Feature #6032)
(cherry picked from commit dc0f5e46a03e0ea797fb74df03e09c58f44a5c1a)

User Manager - Status Icon - Sort Order

Make status column sort order work correctly with the icons.

(2.4, 2.3)

(cherry picked from commit 0fdbaca8f16d0424cb2565ff4341e7620a7bdd2d)

Use the same cache filename pattern for RFC2136 IPv6 items as used by dyndns

Use | to separate dyndns IPv4 fields on cache file as done by rfc2136 items and for all IPv6 items

Fix #7300 provide default value for ipprotocol for old rules

Fixes #7296
HTML tags not allowed in selector option values

(cherry picked from commit 57f4327a60c0cabf43161a6cfde98479b42a7092)

Check that DHCP registration isn't enabled for DNS forwarder/resolver when disabling DHCP server
(cherry picked from commit e83c9b733c86f39a14a874b115f2b8e0adc952e7)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit c6d03f09e035806dca8ac3314b41a3eaf523ab3f)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit 13fca9bcb3fdecfb6f9707e621b49f89569abfd7)

User Manager - Status Icon

Use icon for status rather than textual asterisk to indicate disabled account.

(2.4, 2.3)

(cherry picked from commit edd88334dbe95af4600ae493fa86d45244cbaecb)

Merge pull request #3528 from phil-davis/system-information-widget-filter-2_3

Merge pull request #3527 from phil-davis/breadcrumbs-2_3

fix colspan background on dark theme

Add "required field" highlighting

Only save valid widget locations in config

Some widgets create extra panels, e.g. the widgets that now have the filter functionality. Those panels are processed in the ".each" at line 424. They do not have an id in the form "widget-*" and when the old code tries to find the "*" part it gets "undefined". This results in the layout being saved like:...

Allow 5 dashboard columns to work

Selecting 1,2,3,4 or 6 dashboards columns results in an exact integer result here and all is good. But 5 columns results in "2.4" and "col-sm-2.4" is not a thing in bootstrap.
We need just the best int we can choose here, which is one that is just the int part of the division. That ensures that the 5 columns extend over less than the standard bootstrap total of 12 "units" wide....

Fix saving Hybrid RSA + Xauth. Fixes #7258

Revert "Add privs to control display of notices"

Fix #7051

This reverts commit 04665e78537906f7375668ca665cba17f95a4864.

IPv4 Tunnel Network is required for OpenVPN server

(cherry picked from commit e4488e51cf424907e06ef7cc73370aa0657e5e25)

System Information widget filter gettext()

(cherry picked from commit f5d762f90924510c097a9065dff135dab01f46f0)

System Information Widget Filter

(cherry picked from commit 718b3b0b1b75de09a87866cb37b5a0752643283a)

Fix cut-paste error in Breadcrumb Links
(cherry picked from commit 0e5ee5ae260c42a05b79edf74fb491fca52bacb4)

Breadcrumb links

(cherry picked from commit edcd75357f0e93b124159314d3306197d5312e6c)

Breadcrumb links support

(cherry picked from commit c50f228a1583fe694993778e8576322877a15bba)

Add foot.inc back to status.php

4th attempt!
- Reworked based on recent comments from @rbgarga

(cherry picked from commit c516cb287a78f7b05459e7fcba410f443d8eb8af)

3rd try!
- incorporate suggestions from @rbgarga with slight modification

(cherry picked from commit 6c2f093000b05285546e81dd1a578fc9b573b72b)

2nd try. . .

/etc/inc/util.inc:
- arp_get_mac_by_ip() updated to support IPv6
- attempt at code streamline

/usr/local/www/services_dhcp_edit.php:
- streamline code, now just a simple call to arp_get_mac_by_ip()

(cherry picked from commit dd83f869b79a858bd74c7a8bb4adcd49217445b0)

enhancements to services_dhcp_edit.php
- added ndp call to get MAC addr if remote client is connected via IPv6
- automatically hide `Copy MAC` button if arp/ndp returns null
- switch to exec() instead of backticks for calls to arp
- uses builtin is_ipaddr() function from util.inc...

Sync up status.php with master, but keep the 2.3/10.3-specific parts. Fixes #7246

Fix for bug 6966 https://redmine.pfsense.org/issues/6966

Change-Id: I9471c2bbd8941e70965a86d369c8de87be9a4417
(cherry picked from commit 109a304e154a179bd340b06880ce95baec4dab03)

Revert "Fixed #6753"
User feedback suggests the sorted menu was better, despite the lack of consistency elsewhere.
This reverts commit 96ff627ff95e0fcadf8c15dbd6fe681309cb0fd8.

Mark missing parameter as required. It got lost during backport from master as spotted by @phil-davis

Required fields - Alias Type

should be a required field. And this 1-char change can also be backported to RELENG_2_3. I noticed this while looking at GUI pages in 2.3.3
(cherry picked from commit 8ea10c11441b5aed0b10eb14038aa8f8adbfb3de)

Fix #7157

trafficgraph: Don't update the on screen visual graph while invisible,
which avoids creating a large queue of pending timer objects waiting
for the next requestAnimationFrame to happen.

Submitted by: PiBa-NL at https://github.com/pfsense/pfsense/pull/3450

Ticket #7157: Backport upstream fix from https://github.com/novus/nvd3/commit/305cbad96e94f61a3c0bae02d16c28e09249fbc0

Example of setting required items

(cherry picked from commit 32a85c63c9411463c98a0605772b3e2c01702971)

Revise setHelpText to accommodate required fields

Provide Javascript set_Required function

Provide CSS for required fields

Add "Required field" capability to Groups.class.php

status_upnp remove nested getext()

I don't think this does anything useful.
(cherry picked from commit 3224663a3759935b47406c789b9f5cea3eb88136)

Part fix #7233 keep correct staticmap_array_index

The index needs to be incremented even for entries that were skipped for display because they (for whatever reason) have no MAC or CID set. So use the key directly from the array.
(cherry picked from commit 9aa3c5e84984958caa19ac76ecba849b94a8b360)

Part Fix #7233 Allow deletion of empty static map entries
(cherry picked from commit 2ea70e1a474fd871a007c76841f2a33f34082c58)

diag_backup do not use button text for comparisons

(cherry picked from commit 9a7e1c9580c5779c86bc97d6d82c43401c7a4b12)

Rather than setting the value directly, minimize exposure to eval() in update_config_field() from wizard.php by constructing a variable reference, then set the value using the reference rather than passing user input through eval(). Fixes #7230

Convert easyrule.php to use a confirmation landing page so that the parameters can be submitted via POST. Also, remove the JavaScript confirmation box since it is now redundant. Fixes #7228
The confirmation page displays the submitted parameters for an extra user sanity check. Also fixed a bunch of page formatting issues that were not apparent because users rarely if ever saw output from the page.

interfaces_ppps_edit fixes that will work on 2.3.3 also

1) Make "The MTU is too big" message actually come out. The code around line 300 was rubbish (maybe from before bootstrap?).
2) Show friendly description rather than 'wan' 'lan' opt1' in interface link list....

Fix #7226 Package installation message is incomplete

This makes it remember pkgname after the install finishes and the form is re-submitted.
(cherry picked from commit d12bc864ceb5d656fc094bde7cf5ec96e24bdde9)

pkg_mgr_install remove embedded HTML from result strings
(cherry picked from commit 682008ff758b942d85ed007b485e0b2fa8e3a11c)

Encode the contents of pkg_filter before output. Fixes #7227

Encode 'from' and 'to' before output on pkg_mgr_install.php. Fixes #7225

Revert "setHelp formatting for interfaces.php"

This reverts commit e6068596baf4307fe3eb9866072800e4c23b6840.

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

fbegin.inc and fend.inc are no longer used

(cherry picked from commit c09188a21938f7b1d19fd845fa7e5b0712dd4a83)

Internationalization graph.php

1) A few extra strings to be translated.
2) The scale_type code values 'up' and 'follow' need to be kept as those strings in the JS scale_type variable. The text to be translated needs to be in a different variable that can be in translated form for display. Otherwise things go wrong when in a different language....

Update help message for Zone ID for new region requirement

(cherry picked from commit 49f90f17bfaf2422d56160ad06ef5e2513beb1ba)

certificatemanager, don't show information from previous certificate if no cert or csr is present in the cert

(cherry picked from commit 1048585a08ac824057eea35c57fe359b9e6a48fe)

Use unique var names in Input.class.php

(cherry picked from commit a66177645191359e5ce854d733e9be40ada3535b)

Add to NTP GPS processing of PGRMF sentence

(cherry picked from commit 6924a2bf34a70cd33284a28ca3575f33f9834375)

Provide info on services_checkip.php about what the server must return, and provide two examples of server-side code to return the client address. Fixes #6374

diag_reseststate sourcetablehelp escape of double-quotes not needed

The backslash escaping of the double-quotes here displays the backslashes literal on the GUI. Escaping is not needed in this single-quoted string.
(cherry picked from commit 4ede308c615508a7b70074f56a3ca77cae7b68f1)

Redmine #7173 Do not allow pkg_ for If, IfGroup, Alias

(cherry picked from commit c9d93b62b0cc559d1ed4326212b6385cae2eb398)

Fix #7183 Do not allow Interface Groups with the same name

I should stop trying bad stuff, there seem to be so many holes to find in the validation :)
(cherry picked from commit 89ac71d38a4c49e1537e4afe2b34b2457d9817a7)

vpn_openvpn_server: fix missing parameter

Fixed #7180

Required fields for VPN pages

(cherry picked from commit 1bbdab13e436f5f2b9e381886be4d9c2d1a4e44f)

Fix #7173 Interface Group Name cannot contain dash

Required fields for System pages

(cherry picked from commit 153c3aa61fe65c51d584a57c032a4805048e3062)

More required fields for NAT pages

(cherry picked from commit 877be5e6205ada2608b364f57150010ba473e66d)

Required fields in NAT pages

(cherry picked from commit f2e58c16307795f572ff443e999c54eb6a9839e7)

Required fields in diagnostics

(cherry picked from commit 3e2028f4dca359e715058d2c35ae0df5b939657e)

More required fields for Interface pages

(cherry picked from commit fb572e810abe247c273c27ffafb129430b13be1f)

Use gettext on Username and Password

(cherry picked from commit e52b5a409faa41222a4ff0c917355eb66d0ff19a)

Required fields in Interfaces pages

(cherry picked from commit 1095b20410963e748fe13268e6fa8f35ccce2319)

Required fields in Status pages

(cherry picked from commit f311d3ba11572364488ee25ca9df08a33e42a089)

Remaining required fields for Diag pages

(cherry picked from commit fe54f09154f4116ceea6897bff54a624f1eb63bc)

Required fields for firewall*.php

(cherry picked from commit 8a1b5c561f93611b711eb4e7b58ccb4990577d8e)

Required fields for Captive Portal

(cherry picked from commit c06865be6de6b164d06ee9bb1768dfe6829d783c)

Required fields in Services pages

(cherry picked from commit 24b82516e0baac87316245427e870a36fbcda4ac)

Fix indentation

(cherry picked from commit c18d0d12b3e683f07b4bac933240332cd4d95829)

Changed max repeat alert to use sprintf get text

(cherry picked from commit 950342400bdc75b35c01442c400bd53a18015818)

Bug #7164 Limit NTP time source fields to the maximum number saved to configuration.

(cherry picked from commit 5a1d67b17d485697e19ef49d66e8e5f91e7e884d)

Typo in pppoe_subnet input error message
(cherry picked from commit 01799e5bd5f363e21c744752760ab0cc591713da)

Captive Portal auth method is required

When creating a new Captive Portal Zone the user can fail to select any of the Authorization Method radio buttons. No default radio button is selected - that is probably good, as the user has to think and click to decide which authorization method they will use....

CP HTTPS Forwards setHelp format

Add full stop and spacing between sentences.
(cherry picked from commit 0046a7da59fb3015512ce181cba6b37516c0b76f)

Changed default state of GPS init command auto correct tool.

(cherry picked from commit 2559f37539cf37221f8fddd7c0b7928e8e3969a8)

Feature #7159 Add GPS initialization command auto correct tool
Corrects malformed NMEA sentences by calculating and appending the checksum and adding missing special characters "$" and "*"

(cherry picked from commit 8c23d92a159c1282e7d185665977f0c45d45f845)

Require at least one tag value in a QinQ entry
(cherry picked from commit 4085eb055850e07540145c87fd6d3b5912a865dd)

Use is_intrange() to validate QinQ tag range

Note: is_intrange() only tells us that the range is good and might be delimited by a "-" or a ":", so if we want to take apart the 2 parts of the range (like is done here) we have to also test the string to decide which separator to use....

QinQ Tag Value Validation

Tags must be in the range 1 to 4094
Flag the various input errors and only report them once each.
(cherry picked from commit e0b7a2e76bddd121bc7f92a6ecb20266c8485ed1)

QinQ Edit fix row add delete

1) Make the row delete button actually work
2) Do not allow ranges that go backwards like 25-20 or just "-" or 1-sided ranges "-42" "42-"
3) Remember the POSTed stuff to redisplay to the user if there were input errors
4) Ranges or numbers entered could overlap - just save a list of the unique members. e.g. If the user enters 5-15 and 10-20...