pfSense

Apply #601 fix to firewall_nat.php

(cherry picked from commit 4b0815f38a8a0f98519ca0c2bff7c81b6464e579)

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

Do not show certificates in drop-down list that are already contained in this CRL.

Add missing \) and fix syntax

Extra "S" fixed - thanks @rbgarga
(cherry picked from commit d20b69c529654f2b5d4adf9ab2bba5116f980c64)

Add OpenVPN key lengths to Wizard - missed in original PRs

Original PRs and rationale:

• https://github.com/pfsense/pfsense/pull/2944 ("Add missing recommended key lengths/digest to Cert system")
• https://github.com/pfsense/pfsense/pull/2942 ("Add missing recommended key lengths to OpenVPN options")...

Sanitize 'zone' parameter on CP pages

Show a little more key info in main info table

• Key crypto info shown
• TAP/TUN appended to description (important descriptive distinction)
  (cherry picked from commit b1919bc7d635c875c9187df7ac4885cde7acf621)

Merge pull request #3137 from NOYB/Secure_SMTP_Connection_Modes_-_Mutually_Exclusive

Correct indentation.

Fixed #6786 by making table sortable

(cherry picked from commit e846d7f882d57331d7ead5fcf593e7e4daf7e247)

Simplify icmp conversion

pprior code "converts" every icmp type - of which only 3 actually get changed (rest keep same value anyhow!). If also uses a SWITCH {} construct rather than lookup + foreach, which is longer and less efficient.
(cherry picked from commit 0ce1667bc6fe80ef8e6b4d0d6d38d9859d5f4d94)

Improve handling of source-hash key

- Store the source-hash key in its own config field.
- Validate the provided source-hash key. Check that hex string input is
of the form "0x" followed by 32 hexadecimal digits. Any other string
not starting with "0x" is hashed using md5 and stored as "0x" followed...

Add field to specify source-hash key

The source-hash pool option uses a hash of the source address to
determine the translation address. This hashing algorithm is also fed a
key, which unless specified defaults to a random value. This random
value is then generated each time pf is reloaded....

Merged #2975

Fixed #6788 by clearing only the first label in the cloned row

(cherry picked from commit d38d215d1d9429d3a1a15708f92b14cf3a15b247)

Secure SMTP Connection Modes - Mutually Exclusive

Secure SMTP Connection modes are mutually exclusive. Select only one.

Code style changes

(cherry picked from commit b2836666a8e7fc021ea750fafc8fc6e8097d52ff)

Allow packages to request syslogd log socket to be created inside chroot by specifying it in /package/logging/logsocket element. Implements #4898.

Example:
<package>
<logging>
<logsocket>/var/appname/var/run/log</logsocket>
</logging>...

dnsresolver, make interface boxes resizable, to allow for easier picking/checking of multiple selected interfaces

(cherry picked from commit 57625777c88603f1d2ca55cc981c5ec538c3770f)

Fix diag_dns regressions

After testing diag_dns behaviour some regressions have been noticed.

1) Looking up ipv6.google.com (it only has AAAA records) doesn't work
- gethostbyname() only supports v4, ipv6.google.com only has v6
- this bug was recently and inadvertently introduced...

Remove empty concatenation.

(cherry picked from commit a25c797a44e5cd2480947eb5ae427dcb8e0c031c)

Check IP Services - Info Box

Change warning box with dismissal to collapsible info box.

(cherry picked from commit 6f3ac947b2a83f18ade12ad9876fb8d75a9ff3a2)

Fix up/catch up remote syslog areas. Fixes #6780

Remove some more dangling PPTP bits.

Fix description of the VPN remote log setting

Move copyright from ESF to Netgate

Revert "Remove unused file browser.php"

This reverts commit 48ffade7502839380cc6046187e0c1447723d67a.

Move copyright from ESF to Netgate

Remove unused file browser.php

css: Fix jQuery UI widgets' font

Use the main font with jQuery UI widgets (e.g. autocomplete forms)

(cherry picked from commit e540a9d774f5dfcdd18bf51529932f79f78374a0)

[theme] Compact-RED: improve hovered table rows visibility
(cherry picked from commit e5bc38d21b6ac6c419758ecab7b31f7c06a5c53d)

[theme] Compact-RED: compact panel titles

(cherry picked from commit 953a88a4482e72764ba6ab7ed9f0ce2b21748506)

[theme] Compact-RED: make drop-down menus not too "compact"

and improve hovered element visibility

(cherry picked from commit b8916dccad084ffaa4b402c535f4047fb7a51f3c)

[theme] Compact-RED: get rid of anti-aliased fonts

(cherry picked from commit 9e1208e5833a81c05f86db31078b0fe6901b70ac)

Obscured password field in system_authservers.php bind section
Fixed #6759

(cherry picked from commit 1c1f08f92e8841f7282280caeed7613edd810453)

Merge pull request #3071 from phil-davis/Check_IP_Services

Call services_dhcpd_configure with the right parameter

Previously code segment for v4 would call both v4 and v6. Fixed to call v4 and v6 where appropriate.

(cherry picked from commit 6756052b595b470ce064a44095ec12ce5abe789c)

Uniformize memory limits and remove old code (revised)

1) Allow setting a memory_limit up to 768M (Suhosin)
2) Remove old workarounds. Memory limits on config.inc will be new defaults

(cherry picked from commit 7edcc54b2e9d1de51d5e6d0aedade89bc2cf0699)

Fix diag_dns ipaddr set to use in IP WHOIS and IP Info

- Do not call resolve_host_addresses() when hostname cannot be resolved
by gethostbyname(). The old check was considering gethostbyname would
return NULL in this case but it returns a string with the hostname...

Removed unused variable $hostname

Input boxes with setPattern validation should not contain escape characters as they are already properly considered 'lists of characters' even when not escaped.

(cherry picked from commit 8ea3fd0569ac2b1681de5ba3fbc2a2cc20981ad6)

Outbound nat overview, show alias popup and edit options on source and destination, for both the address and port.

(cherry picked from commit d98e54b215a7798aa0cd9d8432340d6e6df762f5)

-resolved syntax error
(cherry picked from commit 0a6ab475d80b580b09fefaf3ca346b08ec6a23c9)

change traffic graphs to use d3.js

add visibility js

Clean up the text on diag_sockets.php. Fixes #6708

Clarify language on diag_tables.php. Fixes #6713

Use -l with traceroute6 to show both IP Addresses and Hostnames when resolving hops. Add note about max ttl/hop limit in source comment. Fixes #6715

Add output encoding to diag_dns.php for results returned from DNS. Fixes #6737

Fixed #6711

(cherry picked from commit ca3dc6c9ac6b6045430779f407a31ed620f5a32d)

Fixed #6732

(cherry picked from commit e73770057872aa1f78dfff885f89916e446e2e4c)

Fix syntax error on openvpn.widget.php

(cherry picked from commit 516e609ccb7a39fb27f52a69f11eee68f86974df)

Text typos in openvpn.widget.php
(cherry picked from commit 8da4847472e03195aeb73a1acedbc27f8af520d1)

Revise widget refresh timing

(cherry picked from commit 134ee13df54280441c25b047b406628eeebbb8db)

Added control to set dashboard widget refresh period
Start each widget refresh system after a short random delay to prevent all widgets hitting the server at the exactsame time
Fix issues wherein two widgets were resetting the refresh timer from the AJAX call, not the call-back function, thereby risking stepping on themselves...

Completed #6723\
by making the OpenVPN widget update dynamically

(cherry picked from commit f30e6bd49c773de28b5ec143add30fc900e7874d)

Add an option to push "block-outside-dns" to clients of an RA OpenVPN. Fixes #6719

diag-edit.php: Perform "Goto line #" action on pressing enter key within the line number element

(cherry picked from commit 86e94becbec130f9eeca5bc94b497ec1167a640a)

Fix messup caused by 9d3e872

(cherry picked from commit d5b993fc310147d68bc3c3654a512b0ac981ecd2)

Tidy up filenames

Make sure the filenames represent the actual file

(cherry picked from commit 6173d1f5a5ed50b8c8a8523b1eb6824f7c9c1ae6)

Code style and comments

No functional change - just making style consistent

(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)

Improved solution to #6716

(cherry picked from commit 0ed3b15981b4451efb11839d6ee7b9acf1ed1d84)

Fixed #6716

(cherry picked from commit 4d4782fcd7213b5f279cb372853f5fedb07f6178)

Fixed #6700

(cherry picked from commit 40eca7e3a8abdff768e29e310ba945e74fdcfe17)

Fixed #6710

(cherry picked from commit 13b92290e0fa367a76016a15ccf5e76ff77b0706)

Fixed #6709

(cherry picked from commit 3726918df1dc4744bb7ea694ec5c8f40de59d856)

Fixed #6703

(cherry picked from commit e5343844c6de78feafae9e601b25bdf31f114a50)

Fixed #6706

(cherry picked from commit b86938e7e19a09a5b1f3f54825193b57f7c73131)

Fixed #6705

(cherry picked from commit d526fc2d2acc87af2ca829dfe01f0037e3368051)

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

Fixed #6704

(cherry picked from commit fd778d8bef8ea3b0e5dcc8007de242b6e2ac6d5a)

Be sure that user_settings for widgets is an array

(cherry picked from commit 5aad73235c1965e9f4c000244ca657ac9d1e4f68)

Fixed to properly save configs in PPPs interfaces

(cherry picked from commit 545a7850ea37cd8c379cc75428353ad0089f2bd3)

Be more verbose and let user know results of SMTP settings test

Fix wording of the "Reject leases from" option for a DHCP interface.

pfSense.css: Fix sortable tables' font

Experiment using the OS' native font stack

Following the steps of bfbfa4dd254c110db4122925d0a3716a34d4c664,
experiment using the OS' native font stack.

Obtained from the Bootstrap project (twbs/bootstrap#19098,
twbs/bootstrap@0a31dacf3e0c43a73b2e61e266155b9dcce35339)

Allow URLs for TFTP Server (Bug #6634)

The setPattern() thing ain't usable for this and just causes regressions.
(cherry picked from commit c411661a8e8f9f9eb014a24954b9be2fcaaece18)

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.
(cherry picked from commit 8ff248d6a3f31dba42c4c64b5290928030faad4a)

Typo fix
(cherry picked from commit 4b79a9d443c4e16d6ffa304775aec79938d2988c)

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.
(cherry picked from commit 483816313924f87707bca0aa983c73064bd52371)

services_dhcp: Ignore BOOTP queries

BOOTP leases do not have a maximum lease time by default, this could
potentially lead to a DHCP address pool exhaustion.

This commit adds an option to ignore BOOTP queries.

Redmine #4351

(cherry picked from commit 6d53301b1f612ff3e0490abbb46b53c50193b80b)

Add a field to CA/Cert pages for OU, which is required by some external CAs and users. Fixes #6672

Display local DHCP lease times in 24-hour clock

It seems odd to me that when the times are displayed in UTC they have
24-hour clock, but when displayed in local time they are formatted with
12-our clock and AM/PM.
24-hour format takes less screen space, and I would have thought that...

Save widget settings per user

For users that have "custom settings" enabled, save the "tool" settings
of their widgets on a per-user basis.
User that do not have "custom settings" enabled will continue to use and
save widget settings to/from the system-wide settings....

Some tweaks to improve alignment in table with checkbox

1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly

2) UPnP checkbox looks better with description instead of help

This commit fixes the two issues...

Remove defunct link to the devwiki site. Everything is on doc.pfsense.org now.

Fix typo, LT2P->L2TP

Fixed #6669
Read widget config before adding a new one. (Was starting a new array)

(cherry picked from commit 236e6a54e9a93284ca170b68aa1188dfaa195c3d)

replace attribute 'name' to 'id' in openvpn status

(cherry picked from commit 5a5a11cd489bbf15e868c1607c74824c128d693f)

Merge pull request #3073 from phil-davis/certs

Merge pull request #3070 from phil-davis/input_errors2Ajax

Merge pull request #3063 from phil-davis/dhcpinitbeforera3055_23

experiment with tighter styling

Fixes #6601 clean up installed packages html

clean up Installed Packages widget by removing category

Fix redmine #6640 DHCPv6 server time format

The original code here ended up always applying the time zone offset once, and if you had set dhcpv6leaseinlocaltime then it got applied twice, so Sydney at UTC+10:00 would show UTC+20:00 and presumably somewhere at UTC-04:00 would show UTC-08:00...

Section title was wrong, discovered by mfine

Backport Add missing recommended key lengths/digest to Cert system

Original pull request to master was #2944