pfSense

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Use the translated destination for kill_states if one exists. Ticket #6531

Correct/clarify column header. Ticket #6530

Fix style

pfSense_get_pf_states always returns source as src and dest as dst, this flipping based on direction is wrong. Ticket #6530

Fix style

Comment typo

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Merge pull request #3019 from NOYB/RFC2136_Client_Edit_Priv_Def

Merge pull request #3017 from phil-davis/patch-2

Restored countdown functionality and menu refresh on successful update/remove/install
Added comments to clarify operation of the page

Move /etc/ascii-art to /usr/local/share/pfSense

Remove copy of serviceproviders.xml, it will be provided by port net/mobile-broadband-provider-info

Move iso_3166-1_list_en.xml to /usr/local/share/pfSense

Remove DejaVuSansMono-Roman.ttf, rrdtool is not plotting graphs anymore

Move athctrl.sh to /usr/local/sbin

Shouldn't the priv match here be set to "services_rfc2136_edit.php*"?

Load actual value of webguihostnamemenu

This is a string from a list of valid values (empty, "hostonly", "fqdn"). So it is not correct to just gather a true/false value here.

Clarify ports alias hint. Ticket #6523

% and / are also allowed in values

Merge pull request #3011 from NewEraCracker/redmine-6394

Merge pull request #3005 from phil-davis/patch-4

Merge pull request #3004 from hailthemelody/master

Merge pull request #3002 from NewEraCracker/patch-invalid-foreach

Merge pull request #2989 from phil-davis/patch-2

Merge pull request #2988 from stilez/patch-28

Merge pull request #2987 from stilez/patch-27

Merge pull request #2986 from NewEraCracker/patch-ntp-gps

Merge pull request #2982 from stilez/patch-26

Merge pull request #2942 from stilez/patch-22

Merge pull request #2935 from cfazendin/hostname_menu

Merge pull request #2906 from Chrisc-c-c/Fix-QinQ-Interfaces

Allow IGMP Proxy logging verbosity to be selected via system log settings (PR 2901)

Merge pull request #2891 from gottaloveit/dns-overrides-privs

Fixed #6504 by making table sortable

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

fix rowhelper select_source empty combo

while using $config['installedpackage']{['...'] as source

update d3.js

update nvd3 files

Fixed #6514 by requiring string starts with letter ot underscore

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

Create openssl.cnf symlink during boot

Fix typo

Fix redundant phrasing.

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

Remove tab_array from interfaces_groups_edit.php to be consistent with other *_edit files

Correct value for 9600. Ticket #6416

Fix NTP PPS. It had 'None' option available on 2.2.x.

Fix "Unable to remove NTP GPS from configuration"

https://forum.pfsense.org/index.php?topic=112771.msg627573

Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue

This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked)....

added missing div.content wrapper when reloading filters

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

Merge pull request #2999 from phil-davis/patch-6

Validate submitted groups when editing a user. Ticket #6475

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Merge pull request #2998 from phil-davis/patch-5

Fix #6460 Interface mismatch apply changes button

Rework pkg_mgr_install.php:

- Stop using id parameter for additional packages, keep using it only
for firmware upgrades
- Created to control variables $completed and $confirmed to check all
the stages and make it easy to understand what is happening
- Stop using $pkgid and use $pkgname instead...

Fix variable name s/POST/_POST/ and also parameter name s/complete/completed/

Fix indent

Improve readability

Improve readability

Simplify mode parameter validation

Remove redundant check since pkgcancel is never set

Validate mode parameter and use sanitized variable on other places

Fix #6468 Do not allow edit of day and times

in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields....

Fix #6463 Dest net alias matching on page load

Do not set destination field to use customarray
Note: dstbeginport_cust does not exist on this page, so I got removed it here also to avoid future confusion.

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

Fix save and reset buttons on status_lb_pool.php. Ticket #6254

Fix #6440 RADIUS issued IPs

This is a checkbox - the state in the config is stored as set or not set.
This should fix the reported issue. I don;t have a system right now to test, but the bug seems obvious.

Allow - and _ in sysctl values. Ticket #6438

Don't override type so changing it is possible. Ticket #6439

Allow - in TFTP Server field. Ticket #6433

Merge pull request #2990 from phil-davis/colmn

Mask a few more sensitive bits of data in the status.php config.

Comment typos

I can't resist fixing them when I see them.

Link to correct schedule from firewall_rules.php. Ticket #6428

Move our copy of dhclient-script to /usr/local/sbin/pfSense-dhclient-script and change interfaces.inc accordingly

Move openssl.cnf to better place and copy it over to /etc/ssl during boot

function name hms -> dhms

to match edit to util.inc

Add "delete entry" for ARP table

Useful function in some circumstances - seems no reason not to have it.

Uses IP rather than hostname since not all ARP entries have hostnames.

Probably should also have "delete all" but not done that.

Merge pull request #2983 from NOYB/Firewall_/_Aliases_/_Edit_-_New_URL_Table_Alias_Type

Fixed #6401

Handle mode correctly with Auto IKE. Ticket #6360

Firewall / Rules / Edit - URL (IP) Alias

Make alias type URL (IP) available for selection in firewall rules.

Firewall / Aliases / Edit - New URL Table Alias Type

Need to pass alias type to process_alias_urltable() function when creating a new url table alias because it is not yet set/available from config. So the alias_get_type() function can't be successfully used yet.

Changed element type from date to text. Date inputs are not yet handled consistently accross different browsers :(

Merge pull request #2978 from NOYB/Miscellaneous_Textual_Correction_-_System_/_Advanced_/_Networking

Fix #6381 ipv6nat_ipaddr
(cherry picked from commit f489cfdbd4705578ee290b9df5bafe86efddbca8)

redundant check - is_numericint() tests for >= 0

fix logic and replace hard coded value by global

backups should be a numeric int.
text hint for number of backups can now refer to the global value for this platform (and explains how to get that default, by leaving blank)

Give settings section a more helpful/standard title to match other GUI settings tabs

Miscellaneous Textual Correction - System / Advanced / Networking

Use apostrophe instead of quote.

Fix quoting in diag_routes.php, see ticket #6371

Better fix for escaping in ticket #6371

Revert "Status / Services - Status Indicator"

This reverts commit e7161dc3b62b306b57c8d094f93c2ec08c9e0af2.

Merge pull request #2970 from NOYB/Status_/_Interfaces_-_DNS_Servers

Merge pull request #2972 from NOYB/Status_/_Services_-_Status_Indicator

Merge pull request #2969 from marianamorim/add_function_gettext