pfSense

Fix range and prefix delegation range help text to match From/To in correct order

Revert change that avoided loading hte sorting lib if not required. The issue turned out to be a browser quirk

Merge pull request #2666 from NewEraCracker/status_ipsec_leases-remove-debug

Merge pull request #2667 from phil-davis/patch-1

Merge pull request #2669 from NOYB/Diagnostics_/_Tables_-_Large_Tables_Perf_Band-Aid

Merge pull request #2665 from NewEraCracker/simplify-code

Merge pull request #2664 from NOYB/Diagnostics_/_Tables_-_InfoBox_-_#_Records

Merge pull request #2663 from NewEraCracker/vpn_ipsec_keys_edit-cleanup

Correct if statement

• close p tags * wrap first sentence in p tag for proper styling * indicate section in the link * correct punctuation

Close p tags, wrap first sentence in p tag for proper styling.

Fix word case

Remove unused variable.

Merge pull request #2668 from phil-davis/gtetc2

Simplify logic

Internationalize etc inc i through s

pkg-utils update_status text typo

Simplify logic

Quote the 1st parameter (constant name) when calling define()

Remove debug code added at c00152f371d7ac403cce090c8188857171b727fb

Minor tweaks to simplify code

Calling print(sprintf(...)) can be simplified to printf(...).

Diagnostics / Tables - InfoBox - # Records

Include number of records in table info box.

Clean up vpn_ipsec_keys_edit.php

This commit removes all unneeded tags.

Merge pull request #2661 from phil-davis/patch-1

use get_interface_ip functions rather than find_ since the former handles VIPs, gateway groups, etc. correctly. Ticket #4858

Add IP to dyndns error log, remove often wrong explanation.

Replace deprecated link_carp function, fix sprintf. Ticket #4858

Partial update of license.php. Ticket #5903

Need $config here. No need to check count() as it'll always evaluate to true where is_array does. Ticket #4312

Fix hardcoded pfSense on login page

I guess this hard-coded mention of pfSense should use the value from $g ?

Diagnostics / Tables - Large Tables Perf Band-Aid

Here's my band-aid proposal for large tables performance issue.
I would prefer for large tables be un-formated and usable than formated and unusable.

Workaround to prevent the sortable library from being loaded on very large tables.

Change ISO image filename to remove "LiveCD" from its name, and clean up associated references to LiveCD. Ticket #5895

Set bridgeif for new bridge creation.

Fixed #5904

Add m0n0wall entry back and also use product_name on pfSense line

Merge pull request #2591 from k-paulius/patch-license

Simplify logic increasing value direct in hexa, PHP is smart to do it right. Spotteb by @loos-br

Merge pull request #2660 from phil-davis/gtetc1

Internationalize etc inc a-i files

Fix printf(printf())

This looked odd having nested calls to printf()
Should it actually log_error()?

Merge pull request #2658 from NOYB/Available_Widgets_Icon_Missing

Merge pull request #2657 from NewEraCracker/status_logs_vpn-buffer-space-removal

Merge pull request #2654 from NOYB/Status_/_System_Logs_-_Associated_Panels_-_Remove_Icon_Text_Buffer_Space

Merge pull request #2653 from k-paulius/patch-12

Slightly reduce logo size. Looks a bit nicer and prevents navbar from wrapping into a second row when notification icon is displayed.

May as well fix this while here.

Replace style cursor:pointer with bootstrap class icon-pointer.

Fix #4675

Following bugs and improvements on DHCPv6 DDNS area, obtained from
PR #1638 from @Robert-Nelson:

- Use correct domain (ddnsdomain) instead of (domain)
- The option "deny client-updates" wasn't being set so forward entries
weren't being added. Allow user to chose between allow, deny or ignore...

Implement get_v6_ptr_zones()

This function takes an IPv6 subnet and return an array containing all
DNS PTR zones

Fix for but #5901

Move the widgets save out of index.php jquery and into head.inc php along with it's counterpart the available widgets icon.

status_logs_vpn.php - Remove icon text buffer space

Fix another occurrence similar to PR #2654

Sync RCC detection with RELENG_2_2

Status / System Logs - Associated Panels - Remove Icon Text Buffer Space

The space that was being inserted as a buffer between button icon and text is no longer necessary. Recently addressed in css.

carp_status is now status_carp

Align notification and logout icons to the right, to make them stand out from the menu items.

Expand advanced where advanced options are configured. Ticket #5900

Exclude assigned bridge interfaces from selection as part of bridge config. Ticket #5900

Fix interfaces_bridge_edit.php fields. Ticket #5900

Separate bridge application of STP and advanced parameters into their own functions so they can be applied separately from creation of the entire bridge. Apply those after adding a bridge member. Ticket #4312

Correct default if_bridge settings.

Revert this because of issues in Ticket #5888, will fix #4312 differently. Revert "interface_bridge_add_member is inadequate for adding a bridge member that may have not existed at the time of bridge interface's creation. interface_bridge_configure on the interface's bridge ensures all settings (private, etc.) are applied. Ticket #4312"...

Clean up logic here. It makes no sense to proceed if bridgeif isn't defined but platform_booting is true. In interfaces_bridge_configure before it gets to this point, it's setting bridgeif if it's not set, and doing so in a way that won't potentially create conflicting bridgeifs (which this removed code didn't).

Fix mistyped word

Use p instead of br for better styling support.

This wording is also shown during system upgrade, so update it to be more accurate.

No need for this message to be in bold.

Move action alert box to the top of the page, just like on all other pages.

Convert button name to upper case.

Review alert wording. End sentence with period

Remove breaks and use content class to provide proper styling.

Change wording from stating what is going to happen to asking user if they want it to happen.

Change wording from stating what is going to happen to asking user if they want it to happen.

Do not generate empty tags if there is no link.

Remove deprecated <bridge/> tag from default config

Remove variables deprecated some time ago.

Prevent "Ignore denied clients" and "Failover Peer IP" from being combined in the DHCP server settings for IPv4. The daemon fails to start when configured in this way, it apparently only allows "allow" or "deny" in failover mode. Fixes #5898

Fix link_interface_to_vips() to account for IP alias over CARP.

Simplify and correct the comments in get_carp_interface_status().

Simplify the code with the use the newly introduced function to list CARP addresses.

Fix the return value if no matching VIP was found.

Implement a switch that allows get_configured_vip_list() return only the selected type of VIP addresses: CARP, IP alias or all VIPs (default).

It seems that a few packages still rely on this.

Ticket #5885

Fix handling of promicuous checkbox on packet capture. Fixes #5896

Fix spacing issue with "Exclude ESP"

Merge pull request #2650 from NOYB/Firewall_/_Rules_-_Simplify_Order-Store_Loops

Merge branch 'patch-9' of https://github.com/k-paulius/pfsense

• 'patch-9' of https://github.com/k-paulius/pfsense:
  Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Restore infoblock div

Revise button icon spacing

• Converted alerts to callouts. * Split first message into paragraphs to make it more readable * Moved 2nd and 3rd messages above the applicable panels, instead of being below them; that's how it was in v2.x

Convert alert to callout

Replace alert with callout. Removed mention about greyed out icon - that is no longer applicable.

Add support for Bootstrap callouts

Use PHP CLI explicitly to run rc.conf_mount_r(w|o) from pfSense-upgrade, it fixes #5875

Call conf_mount_rw() before run pfSense-upgrade to avoid doing it twice

Merge pull request #2651 from NewEraCracker/pkg_edit-fix

Break long lines

Headers don't need HTML entities

This commits fixes form submission on Services/UPnP redirecting to an URL with & on it.

Firewall / Rules - Simplify Order-Store Loops

Replace indexing for loops with more easily readable key/value foreach loops.
Make the order-store rules selection logic consistent with the display rules selection logic.

Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Remove Help -> Search Portal menu entry, it fixes #5894

This seems to have negatively impacted LAGG/VLAN configs. Revert "Only set IFCAPS where they're not already set correctly. Ticket #5887"

This reverts commit 7f283fab1b18bb575537bb8498b16a6b1b6d0251.