pfSense

remove trash icon coloring

Fix links to logs in shortcuts

Address some security issues in diag_logs.php. While I'm here, fixup page names and shortcuts.

Change Form_TextArea to Form_Textarea
(autoload now makes the classes case sensitive)

Fixed #5505

Fixed #5521

IPSec statistis updated dynamically
Partial fix to #5520

Interface widget icon adjustments

Use some icons here that have a somewhat more relevant appearance (no exact matches, unfortunately)

Don't reuse $icon here - results should be two different icons. Fixes #5519

Move pkg data around early and fix #5493

Improve sh syntax

Completed #5407

Also get time zones three levels deep. Fixes #5517

Teach pfSense-upgrade to run gitsync after upgrade

Correct Form_TextArea -> Form_Textarea

List CSS file in alpha order

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Define user-agent on pfSense-upgrade

Use new host_uuid option name when changing User-Agent

Re-add host_uuid user-agent option lost during bootstrap import. While here, change its name to be more clear what it does

Tunable value can be zero, use isset() to validate it

Merge pull request #2103 from jlduran/escape-strongswan-radius-key

Merge pull request #2102 from doktornotor/patch-6

Merge pull request #2101 from doktornotor/patch-5

Merge pull request #2100 from doktornotor/patch-2

Move recently added config upgrade for IPsec enable to last config upgrade

Optimize upgrade_128_to_129()

Move recently added upgrade code to a new config version

When necessary, unset $config['ipsec']['enable'] in upgrade code.

Fix ipsec_enabled() to return true only when at least one of the phase 1 entries are enabled.

Remove the last usage cases of $config['ipsec']['enable'].

IPSEC is always on in 2.3, where necessary (IPSEC rules, IPSEC daemon), we check the existence of phase 1 entries.

Do not allow the same interface be part of two different bridges.

This is already forbidden in OS, so just add a warning to prevent this kind of misconfiguration.

Issue: #4595

Preserve bridge name while editing bridge settings, otherwise a new bridge is created every time you edit a bridge.

Fix the interfaces widget to show the IP address of v6 only interfaces.

Unset "net.inet.ip.fastforwarding" when upgrading from older versions.

Issue: #5370

Convert all the occurrences of $config['ipsec']['enable'] in filter.inc, ipsec.inc and service-utils.inc

Fix ruleset when IPSEC is enabled but there are no Phase 1 entries.

Issue: #5487

Escape RADIUS secret in strongswan.conf

If a RADIUS secret is, for example, `#secret-key#`, EAP-RADIUS
authentication will fail, as the `#` can be interpreted by the
strongswan.conf parser as a comment.

To avoid this from happening, set the key within double quotes.

Stick xmlrpc.inc include back to avoid breaking packages

Removing this broke 29 packages which rely on it for configuration sync and include pkg-utils.inc instead of xmlrpc.inc.

Always honor the required tag in package XML fields

Dunno whose idea it was to restrict this to input. WTH really.

restart_service() - do not attempt to stop service that is not running

Attempting to stop service that's not running just produces useless log noise.

BTW - dunno what was the idea behind restart_service_if_running() but it appears to be completely unused both in pfSense and in packages, suspect mainly because it doesn't make any sense as implemented.

Tidy up "services_status.widget.php"

Update code style
Close TH tags properly

Remove "orphaned" closing SPAN tag

Remove "orphaned" closing SPAN tag

add ipfw-classifyd to obsoletedfiles list. Ticket #5508

Bind to IP aliases correctly in Unbound. Ticket #5464

add layer7 files to obsoletedfiles list. Ticket #5508

Remove layer7 components. Ticket #5508

Revise System->Routing menu entry and page titles

Removed no longer needed jQuery

remove old function call

clean up interface statistics widget

clean up installed packages widget

add common background color classes for dark theme

clean up gateways widget

Fix search box icon color

Always define $last_update_file to avoid calling file_put_contents with empty filename. Fixes #5502

NTP -> NTPD

Fixed duplicate NTP

remove inline styles

update dark theme

Merge pull request #2097 from phil-davis/timeupdateinterval

Remove unused time-update-interval

There is no longer any code for a UI field in 2.3 master.
In RELENG_2_2 system.php the code for the field display is commented
out.
The commented out code has been removed in the bootstrap conversion.
This removes the various bits of leftover processing and validation code...

Merge pull request #2096 from phil-davis/patch-1

Completes #5263

Better test for webguicss being not set

As discussed in https://github.com/pfsense/pfsense/pull/2094

Fixed #5497

Completed #5499

Merge pull request #2088 from phil-davis/bindlan

Fixes #5488

Remove /etc/inc/uuid.php and /etc/inc/dot.hushlogin, both unused files

Move timeout value to PHP definition for easier modification

If webguicss is not yet specified then default to pfSense

On systems where webguicss (the theme) was not yet set in the config, the selection here was defaulting to other than pfSense.
Now that pfSense-dark has come along, it happened to be first in the list. When I changed something else in General Setup today, my them went to pfSense-dark because I did not notice the (accidentally) selected value that was in the field....

Redmine #5492 case of acronyms in widget names

I am not sure how else to do this. If someone in future writes a widget about "Smart Carp" (an intelligent species of fish) then it will get turned into "SMART CARP". The other strings are not English words, or parts of English words, so not likely to be matched wrongly in future....

Fix widgetname variables

These were wrong. But actually I don't think any widgets use this mechanism of $config['widgets']['mywidget-config'] - they seem to do their own thing making names for the keys they use in $config['widgets'] to store their settings. So I didn't find anything actually broken because of this.

PEAR.inc is already required by radius.inc

Break long lines

Delete code that is commented out since 2005

Remove debug leftover

Fix #5329

Since PHP 5.6, fsockopen() is checking SSL certificates, xmlrpc_client
is used only for HA today so it's safe to disable this check.

Since fsockopen() doesn't provide a way to disable it, move code to use
stream_socket_client()

Remove unused function http_post()

correct igmpproxy command for new version.

Cosmetic fixes

Partial fix to #5495

Fixed #5489

Fixed #5490

-d4 doesn't exist in updated igmpproxy version, remove.

Work-around for #5488

Ticket #5470 fix dashboard breadcumbs

Fixed #5478 clean up title text

Make text areas fixed width font with a tabstop of 4

Merge pull request #2090 from brunostein/add_identification_form_section

add attribute 'id' for the Form_Section

Merge pull request #2089 from brunostein/fix_move_options

Fixed #5486

fix moveOption function

Use full 'Local Database' name to be sure it's authmode is local, fixes #4469

Remove comment

Add tr/td to empty tbodys for Microsoft IE

Duplicate slice before upgrade, fixes #5483

Revised order of input fields in edit form