pfSense

Fix diag_dns regressions

After testing diag_dns behaviour some regressions have been noticed.

1) Looking up ipv6.google.com (it only has AAAA records) doesn't work
- gethostbyname() only supports v4, ipv6.google.com only has v6
- this bug was recently and inadvertently introduced...

Remove empty concatenation.

(cherry picked from commit a25c797a44e5cd2480947eb5ae427dcb8e0c031c)

Check IP Services - Info Box

Change warning box with dismissal to collapsible info box.

(cherry picked from commit 6f3ac947b2a83f18ade12ad9876fb8d75a9ff3a2)

Fix up/catch up remote syslog areas. Fixes #6780

More pptp bits

Remove some more dangling PPTP bits.

Fix description of the VPN remote log setting

Move copyright from ESF to Netgate

Revert "Remove unused file browser.php"

This reverts commit 48ffade7502839380cc6046187e0c1447723d67a.

Move copyright from ESF to Netgate

Remove unused file browser.php

css: Fix jQuery UI widgets' font

Use the main font with jQuery UI widgets (e.g. autocomplete forms)

(cherry picked from commit e540a9d774f5dfcdd18bf51529932f79f78374a0)

[theme] Compact-RED: improve hovered table rows visibility
(cherry picked from commit e5bc38d21b6ac6c419758ecab7b31f7c06a5c53d)

[theme] Compact-RED: compact panel titles

(cherry picked from commit 953a88a4482e72764ba6ab7ed9f0ce2b21748506)

[theme] Compact-RED: make drop-down menus not too "compact"

and improve hovered element visibility

(cherry picked from commit b8916dccad084ffaa4b402c535f4047fb7a51f3c)

[theme] Compact-RED: get rid of anti-aliased fonts

(cherry picked from commit 9e1208e5833a81c05f86db31078b0fe6901b70ac)

Remove some obsolete code from globals.inc

Fix handling of backup config count. Fixes #6771

Obscured password field in system_authservers.php bind section
Fixed #6759

(cherry picked from commit 1c1f08f92e8841f7282280caeed7613edd810453)

Merge pull request #3071 from phil-davis/Check_IP_Services

Force changes in routing to be detected by the system

When dhcp6c without RA is enabled, dhcp6c isn't killed and respawned, this causes the system not being able to pick up the routing changes. In this case, running the configuration script which fires rc.newwanipv6 solves the problem....

DHCP6 Before RA. Additions and ammendments

Replaced posix_kill() in kill_dhcp6client_process() with mwexec("kill -9 $pid"), this is because the posix_kill call was not reliably killing the dhcp6c process, kill -9 works every time.

Changes to the rtsold script creation. The script lines starting dhcp6c should not have be written to the script when dhcpwithoutra is true....

Improve dhcpd and dhcpleases reload

1) Avoid running services_dhcpd_configure() more times than needed.
2) Always restart dhcpleases after it's killed during interface recycle.
3) It's not necessary to restart dhcpdv4 when doing changes in ipv6 config.

(cherry picked from commit 509e9357df4755a4fe5d1d9b20eda65bafb855e7)

Call services_dhcpd_configure with the right parameter

Previously code segment for v4 would call both v4 and v6. Fixed to call v4 and v6 where appropriate.

(cherry picked from commit 6756052b595b470ce064a44095ec12ce5abe789c)

Uniformize memory limits and remove old code (revised)

1) Allow setting a memory_limit up to 768M (Suhosin)
2) Remove old workarounds. Memory limits on config.inc will be new defaults

(cherry picked from commit 7edcc54b2e9d1de51d5e6d0aedade89bc2cf0699)

Ensure only one instance of services_dhcpd_configure runs concurrently

This way kill and respawn will behave as they should for the dhcpd processes

(cherry picked from commit c69ea0051c5549a9db0d092e85b92f78ffb4c978)

Fix diag_dns ipaddr set to use in IP WHOIS and IP Info

- Do not call resolve_host_addresses() when hostname cannot be resolved
by gethostbyname(). The old check was considering gethostbyname would
return NULL in this case but it returns a string with the hostname...

Removed unused variable $hostname

Input boxes with setPattern validation should not contain escape characters as they are already properly considered 'lists of characters' even when not escaped.

(cherry picked from commit 8ea3fd0569ac2b1681de5ba3fbc2a2cc20981ad6)

Outbound nat overview, show alias popup and edit options on source and destination, for both the address and port.

(cherry picked from commit d98e54b215a7798aa0cd9d8432340d6e6df762f5)

Merge pull request #3125 from NewEraCracker/patch-net_ipv6

-resolved syntax error
(cherry picked from commit 0a6ab475d80b580b09fefaf3ca346b08ec6a23c9)

Prevent accessing undefined offset in IPv6.inc

On perfectly good IPs (eg. 1:2::3:4) this code could cause the following notice:
Notice: Undefined offset: 2 in IPv6.inc on line 560

On bad IPs like 1::2::3 it would not result in any notice.

This commit fixes the above problem, while making sure that only valid sequences pass validation.

system_dhcpleases_configure() - Improve pidfile handling

1) Set the pidfile variable in the correct place.
pidfile variable is required in both 'if' and 'else' blocks.

2) Ensure pidfile is valid before sending term signal

(cherry picked from commit 4509abc380552554cbdf3f42c6783b47112f245a)

Apply the fix for ticket #6589 also into dhcpdv6 config

(cherry picked from commit 20350989db5d66ffb827beaed5ef5738cd62fc9d)

Indent dhcpd.conf option custom
(cherry picked from commit c507161d557817c1f6f0adbef9ffdbad82115ee8)

Fix #6720 DHCP options by pool

It is a little bit tricky having to generate the unique "option custom-if-n-m code ..." lines at first where n = pool index and m = item index in the items of the pool. Then make sure to reference that later, getting the same pool index into the array of pools. The $all_pools array as the "overall" or "base" pool first (at index 0), followed by the user-specified pools at index 1, 2, 3,... - which are actually at indexes 0, 1, 2,... in the ordinary array of pools in the config. So the -1 at line 910 has to happen....

Fix double domain-name-servers for pool

Add a pool and specify something in 1 or more of the DNS servers boxes for the pool.
The "option domain-name-servers 1.2.3.4" line appears twice in dhcpd.conf
The first bit of code to do it is at lines 787-799. I have deleted this 2nd time that it is done at lines 854-856....

Fix #6724 VLAN interface displayed wrong

in interface assignment script dialog.

The str_replace() calls were not smart enough to just get rid of bare "igb1" when "igb1_vlan123" and such like was also in the list.
(cherry picked from commit fd020a2d94077cc9c8ee6bac5b3da11e116c84a2)

change traffic graphs to use d3.js

add visibility js

Add a selection for OpenVPN to have no compression preference + comp-noadapt, which is necessary in some client edge cases. Fixes #6739

Clean up the text on diag_sockets.php. Fixes #6708

Clarify language on diag_tables.php. Fixes #6713

Use -l with traceroute6 to show both IP Addresses and Hostnames when resolving hops. Add note about max ttl/hop limit in source comment. Fixes #6715

Add output encoding to diag_dns.php for results returned from DNS. Fixes #6737

Fixed #6711

(cherry picked from commit ca3dc6c9ac6b6045430779f407a31ed620f5a32d)

Fixed #6732

(cherry picked from commit e73770057872aa1f78dfff885f89916e446e2e4c)

Fix syntax error on openvpn.widget.php

(cherry picked from commit 516e609ccb7a39fb27f52a69f11eee68f86974df)

Use "-C /dev/null" when starting dnsmasq to avoid it picking up an incorrect default config which would override our command line parameters. Fixes #6730

Text typos in openvpn.widget.php
(cherry picked from commit 8da4847472e03195aeb73a1acedbc27f8af520d1)

Revise widget refresh timing

(cherry picked from commit 134ee13df54280441c25b047b406628eeebbb8db)

Added control to set dashboard widget refresh period
Start each widget refresh system after a short random delay to prevent all widgets hitting the server at the exactsame time
Fix issues wherein two widgets were resetting the refresh timer from the AJAX call, not the call-back function, thereby risking stepping on themselves...

Completed #6723\
by making the OpenVPN widget update dynamically

(cherry picked from commit f30e6bd49c773de28b5ec143add30fc900e7874d)

Add an option to push "block-outside-dns" to clients of an RA OpenVPN. Fixes #6719

diag-edit.php: Perform "Goto line #" action on pressing enter key within the line number element

(cherry picked from commit 86e94becbec130f9eeca5bc94b497ec1167a640a)

Fix messup caused by 9d3e872

(cherry picked from commit d5b993fc310147d68bc3c3654a512b0ac981ecd2)

Tidy up filenames

Make sure the filenames represent the actual file

(cherry picked from commit 6173d1f5a5ed50b8c8a8523b1eb6824f7c9c1ae6)

Fix DDNS domain for static map DHCP entries

If you specify DDNS Domain in a DHCP static map entry, it does not make its way through to dhcpd.conf
This is because the var name $pdnscfg is wrong from an old copy-paste that first made this code.
(cherry picked from commit a5a55231770e548898b6b1c18146cc0c6631c5c6)

Code style and comments

No functional change - just making style consistent

(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)

Improved solution to #6716

(cherry picked from commit 0ed3b15981b4451efb11839d6ee7b9acf1ed1d84)

Fixed #6716

(cherry picked from commit 4d4782fcd7213b5f279cb372853f5fedb07f6178)

Fixed #6700

(cherry picked from commit 40eca7e3a8abdff768e29e310ba945e74fdcfe17)

Fixed #6710

(cherry picked from commit 13b92290e0fa367a76016a15ccf5e76ff77b0706)

Fixed #6709

(cherry picked from commit 3726918df1dc4744bb7ea694ec5c8f40de59d856)

Fixed #6703

(cherry picked from commit e5343844c6de78feafae9e601b25bdf31f114a50)

Fixed #6706

(cherry picked from commit b86938e7e19a09a5b1f3f54825193b57f7c73131)

Fixed #6705

(cherry picked from commit d526fc2d2acc87af2ca829dfe01f0037e3368051)

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

Fixed #6704

(cherry picked from commit fd778d8bef8ea3b0e5dcc8007de242b6e2ac6d5a)

Protect package_reinstall_all()

If one restores a config.xml without packages, there will be a warning about invalid argument supplied for foreach(). This commit fixes the problem.

(cherry picked from commit 5eda5816d8a7bd05730c70e44493815079925b48)

Be sure that user_settings for widgets is an array

(cherry picked from commit 5aad73235c1965e9f4c000244ca657ac9d1e4f68)

Fixed to properly save configs in PPPs interfaces

(cherry picked from commit 545a7850ea37cd8c379cc75428353ad0089f2bd3)

Merge pull request #3095 from NewEraCracker/redmine-6686

Be more verbose and let user know results of SMTP settings test

Pass along send_smtp_message() return, otherwise message will not be shown when testing SMTP settings

Ensure extensions.ini is readable by non root users

https://redmine.pfsense.org/issues/6686

Fix wording of the "Reject leases from" option for a DHCP interface.

Text typo

Noted by Daryl Morse in comment on Redmine bug 6637.
(cherry picked from commit bf6ae0ad277710ffa64ee0967c5d4f717c2bc54b)

Ignore linkup eventos for interfaces that are member of bridges and have no IP address configured

Verify if interface is active gw for gw group before update dynamic DNS

pfSense.css: Fix sortable tables' font

Experiment using the OS' native font stack

Following the steps of bfbfa4dd254c110db4122925d0a3716a34d4c664,
experiment using the OS' native font stack.

Obtained from the Bootstrap project (twbs/bootstrap#19098,
twbs/bootstrap@0a31dacf3e0c43a73b2e61e266155b9dcce35339)

Update pfSense.pot
(cherry picked from commit 51c5313df8b9a9470cad9031b3e93594a4728c9e)

Allow URLs for TFTP Server (Bug #6634)

The setPattern() thing ain't usable for this and just causes regressions.
(cherry picked from commit c411661a8e8f9f9eb014a24954b9be2fcaaece18)

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.
(cherry picked from commit 8ff248d6a3f31dba42c4c64b5290928030faad4a)

Typo fix
(cherry picked from commit 4b79a9d443c4e16d6ffa304775aec79938d2988c)

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.
(cherry picked from commit 483816313924f87707bca0aa983c73064bd52371)

Fix a redundant HTTP "User-Agent" string.

CURLOPT_USERAGENT expect the value to the user-agent string, not the entire key-value pair.
Before this fix, HTTP header "User-Agent: User-Agent: phpDynDNS/0.7" was sent for DDNS updates.
NGINX configuration at GratisDNS will not accept a user-agent formatted in the above way....

Merge pull request #3066 from phil-davis/notifychannelupdown

Merge pull request #3065 from phil-davis/radius-openvpn

services_dhcp: Ignore BOOTP queries

BOOTP leases do not have a maximum lease time by default, this could
potentially lead to a DHCP address pool exhaustion.

This commit adds an option to ignore BOOTP queries.

Redmine #4351

(cherry picked from commit 6d53301b1f612ff3e0490abbb46b53c50193b80b)

Add a field to CA/Cert pages for OU, which is required by some external CAs and users. Fixes #6672

Display local DHCP lease times in 24-hour clock

It seems odd to me that when the times are displayed in UTC they have
24-hour clock, but when displayed in local time they are formatted with
12-our clock and AM/PM.
24-hour format takes less screen space, and I would have thought that...

Update firewall rules separators when NAT associated rule is deleted.

Bug: https://redmine.pfsense.org/issues/6676
(cherry picked from commit 7475d7b337c0a08dc4d6636f33b0998067f26008)

Save widget settings per user

For users that have "custom settings" enabled, save the "tool" settings
of their widgets on a per-user basis.
User that do not have "custom settings" enabled will continue to use and
save widget settings to/from the system-wide settings....

Some tweaks to improve alignment in table with checkbox

1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly

2) UPnP checkbox looks better with description instead of help

This commit fixes the two issues...

Remove defunct link to the devwiki site. Everything is on doc.pfsense.org now.

Fix typo, LT2P->L2TP

Fixed #6669
Read widget config before adding a new one. (Was starting a new array)

(cherry picked from commit 236e6a54e9a93284ca170b68aa1188dfaa195c3d)