pfSense

standardize on https://www.pfsense.org

Improve checks for params 'id', 'dup' and other similar ones to make sure they are numeric integer, also, pass them through htmlspecialchars() before print

Gateway Monitor Advanced Settings

Recommended changes made to calculated value input behavior.
Restrict interval to integer of 1 or greater.

Gateway Monitor Advanced Settings

Exposes 3 additional apinger configuration options in the gateway monitor advanced section which can either be set manually, calculated based on interval, or use the hard coded defaults.
1) Avg Delay Samples
2) Avg Loss Samples...

Add an option to force a gateway to be down, it fixes #2847

Delete static route when monitor IP is removed, also save monitor IP even when it's disabled

Add an option to disable gateway items

Fix an issue that changes wrong gateway entry when items are hidden

Use a more accurate error message, fixes #3282

Remove call-time pass by reference for do_input_validation, helps ticket #2565

Fix #3127

By default htmlspecialchars does not consider single quotes, what can be
a problem when value attribute is set using it. Replace value attribute
set to use double quotes on places where it's obviously recieving a
result of htmlspecialchars() call.

Bring back static routes to fix issues reported on Ticext #3179

Use ipprotocol to check gateway protocol, this fix a issue that allow to set more than one default gateway when it's dynamic

Use Probe Interval on gateway advanced settings

Correct gateway down/probe interval text.

Fix up gateway advanced option note that was missed from 2.1 but on 2.0.x.

Replace all linklocal checks by is_linklocal()

Allow IPs inside virtual IP networks to be used as gateways. Fixed #2962

make fe80 gateway check case-insensitive

Tidy up "system_gateways_edit.php" XHTML

Add CDATA section to SCRIPT tags
Close INPUT and BR tags
Update HTML boolean operators

Fix indent, whitespaces and unbalanced <tr> and <td> tags

Make more strict checks during is_ip* functions. Helps http://forum.pfsense.org/index.php/topic,58399.0.html and http://forum.pfsense.org/index.php/topic,58273.0.html

Update usr/local/www/system_gateways_edit.php

Correct IP family mix-up.

Update PHP shorthand tag

Standardise all PHP start tags from "

Encode parameters before showing them to users.

Activate new shortcuts/status in the rest of the areas that are currently setup.

Validate advanced gateway monitoring settings

Use the default values from return_apinger_defaults.
Validate values - low less than high, probe interval less than "down" time, values are positive numeric.
Update descriptions on the UI to show the defaults used.

Now that we actually have a IP protocol tag in the config.xml we can make this check a lot simpler and do less guessing.
Redmine ticket #2503

Actually save the IPprotocol variable into the config, otherwise it stil won't work.
People will likely need to edit and save their gateways now if they have double entries.
e.g. both manual and automatically added entries, these will dissapear as soon as you save....

Finally give in and sprout a Internet Protocol drop down on the gateways edit screen.
With added validation and multiple detection parts to work when the value is not set yet.
Redmine ticket #2463

remove some log_error calls

bug fix for #2426

Input validaton on interface gateway creation box needs to reject duplicate names

report errors adding a gateway through ajax calls

Fix the link local check when trying to add a link local gateway
Ticket #2071

Fix for ticket 2071, this allows link local addresses for gateways.
Backend already added the interface scope for link local addresses, hurrah.

Clarify the potential pitfalls when setting the Frequency Probe and Down parameters.

Fix for redmine ticket #1993. Allow saving multiple dynamic entries.
Make sure that return_gateways_status() also returns all gateways that have monitoring disabled as up.

Add default values for latency, packet loss, down on GUI

Fix a typo in the subnet generation causing the code to fail

Add address family input validation on the Gateways edit page, also prevent adding gateways on interfaces that do not carry that address family.
Fix Ticket #1633

Simplify this code a bit, should be the same test in both locations since this should be either/or, and with the other code it can apparently fall into a trap where it shows neither.

Add an override for default interval to send icmp

Add a new option to allow disabling of gateway monitoring. This gateways will always be reported as up.

makes correct use of printf and gettext

removes variables names and replace it with '%s'

Fix field lengths for IPv6 addresses

Make it possible to set the default gateway bit for 1 ipv4 gateway and 1 ipv6 gateway

Make the subnet check failure better readable

Merge remote branch 'upstream/master'

Conflicts:
etc/inc/interfaces.inc
etc/inc/system.inc

fix text

Merge remote branch 'upstream/master'

Conflicts:
etc/inc/interfaces.inc
etc/inc/vslb.inc
usr/local/www/interfaces.php

When adding/editing a gateway, check IP alias subnets, too. Fixes #1015

Merge remote branch 'upstream/master'

Conflicts:
etc/inc/filter.inc
etc/inc/system.inc
usr/local/www/interfaces.php
usr/local/www/interfaces_gif_edit.php

Bring in XSS id fixes from m0n0wall

Verify that we validate against a ipv6 subnet properly. This should help for static route gateways

Allow for configuring a IPv6 address on the interfaces page.
Add code to verify a ipv6 address
Let is_ipaddr() return true on a v4 and v6 address.
Change system gateways edit to fetch the global ipv6 interface ipv6 addresses and subnets
The current ipv6 function might need folding into filter_var() when that catches some documented corner cases....

Simplify this code so it's obvious what we're really testing for.

Should be no functional change here.

Fix intended behaviour when the default gateway changes interface.

This breaks the code because the ASSUMPTION is to reload the gateway interface that was a defaultgw previously and not the interface that just became defaultgw. Mostly for dynamic connections like dhcp/ppp*

Pointy-hat: gnhb

Revert "Update code to actually accomplish the intended behavior of NOT reloading the interface"...

Update code to actually accomplish the intended behavior of NOT reloading the interface
if not necessary when a GW record is saved.

Do not allow a gateway to be renamed. Possibly a better solution is to rename the gateway in all pointed places!

Handle the cases to not save data on config better.

Make sure we do not overwrite the gateway stored in config with a dynamic gateway info. Correct POST var name(Found by ghnb). Also correctly reload only the defaultgw interface changed only if it is different than the present one.

Fix the problem of not saving data when most of the information is not being posted. Also do not disable any field anymore to allow people to choose static gateways for dynamic interfaces. Also do not save any information when the user Clicks save but has not posted any information not known already. Do not prevent to post a dynamic value for gateway on an interface that is configured with static ip.

We don't store monitor ip in the <interfaces> config any more.

Requested by cbuechler in ticket #919.

When a dynamic interface is up, we still need to report that it's "dynamic" to this GUI in system_gateways_edit.php.

If user edits a dynamic gateway that is up, the gateway IP address (reported by return_gateways_array) will end up
in the "Gateway" field, and then the gateway will get saved as a static gateway unless user manually changes field...

Revert previous change to enter a hidden value when interface is disabled. GHNB broke this on revision 58611e3a1da07a33c6cf65401ad3edf278190e75 and it does not make sense.

Remove forgotten code.

Initialize variable properly. Handle the case when the interfaces select box is disabled and it will not be posted(Reported-by: ghnb

Fixes #919 by properly saving <gateway> field as "dynamic"

`

Oops bring back this code too.

Actually this part should not have been committed at all.

Fix gettext! Needed here?!

Bring code up to speed with latest world.

Cleanup code.

Correct my email address, adjust copyright to 2010

fix gettext

Correctly check when to actually save dynamic gateways or not.

Ensure that monitor IP stays blank when editing a system dynamic gateway.

Default to "dynamic" for a dynamic gateway.

Add status links to gateway/route pages.

Move the settings of down/latency/loss to per gateway. This allows more fine grained control on gateways.

Adding missing gettext() calls

Merge remote branch 'mainline/master'

Conflicts:
usr/local/www/system_gateway_groups.php
usr/local/www/system_gateway_groups_edit.php
usr/local/www/system_gateways_edit.php

Save gateway data when weight changes on dynamic gateways.

Add gateways validation code before deleteing. This prevents footshooting especially with Gateway Groups.

Ticket #506. Correctly save dynamic gateways extra parameters.

Allow for each gateway a weight to be choosen if the gateway has to be used in Gateway groups. This will create that many entries in the route-to statement as the weight says.

Adding gettext() call

Adding gettext() calls

Fix gettext issues

Fix gettext issues

Reviewing gettext() implementation

Implement gettext()

Ticket #517. Fix saving of monitorip in dynamic interface cases.

Correctly configure the default route addition when interfaces are configured for pppoe/pptp. Handle in system routing configure dynamic interfaces. Also when chaning or configuring the defaultgw reconfigure the underlying interface, this helps when this interfaces are dynamics one.

Correct typo in function name

Mute route delete message, regenerate resolv.conf as this also corrects static routes to the DNS servers.

Ticket #303. Correctly retain the interface in case or validation errors.

Allow editing entries that are not system/dynamic ones even though their gateway is specified as dynamic.

Ticket #303. Fix gateway address checking.