Unbreak a number of explode() replacements which required preg_split()
The function split() is replaced by the function explode(). Starting with PHP 5.3 this is deprecated and with version 6 gone.Replacing it surpresses all the warnings
variable is not yet available so rebrands get a blank page on the last step in the setup wizard
When making a server certificate in the wizard, make sure we specify it must be a server certificate.
Fixes #1948. Do not specify an interface for the Voip rules that intend a source ip.
Revert "Another try at prventing panic on reconfig of ppp type wans. Ticket #1696"
This reverts commit afe88d69235f84530ed6386b22cfc9c488bf94c5.
Revert "Be correct on teh variable scope"
This reverts commit 106646b4204b2850ec7f41547079cf00cc374f6f.
Be correct on teh variable scope
Another try at prventing panic on reconfig of ppp type wans. Ticket #1696
If we are coming from a PPPoE/PPTP WAN type, grab the old physical interface first to avoid assigning a ppp interface to itself. Fixes pppoe->pppoe wizard run as well as changing pppoe->dhcp. Fixes #1696
Fixes #1696. Do not store temporary information under interfaces section during wizards since this might generate a message to netgraph that triggers a panic.
Make the checks during step4 and step5 actually work.
Correctly check the values for VoIP on multi_lan traffic shaper wizard. Reported-by: http://forum.pfsense.org/index.php/topic,32833.15.html. Ticket #1728
Declare the arrays as global since that is what they are. Correct the name of asterisk in the global defniition.
Correct battlenet data to not be overriden. Reported-by: http://forum.pfsense.org/index.php/topic,39176.0.html
Correct priority number to not have clashes with PRIQ which do not allow same priority numbers for two different queues.
Ticket #749. Make the rules of the traffic shaper wizard select the wan side of the interfaces to not make the intra-lan traffic classifible in this way.
makes correct use of printf and gettext
removes variables names and replace it with '%s'
Actually increase the default queue length for the new default queue
Respect the p2p catchall setting.
Re-enable downstream queues but with the difference that the default queue now tries to use all the link when possible and the bandwidth limit is specified on a subqueue instead of the interface.
Revert "Ticket #749. Do not create the queues at LAN side for traffic_shaper_wizard_dedicated. Since we cannot control bandwidth its useless to try to handle it(ALTQ was built with this concept in mind)."
This reverts commit cd3346e205ad0f818977b7ccd0bd7259ed2f2e4e.
Revert "Ticket #749. Do not create the queues at LAN side for traffic_shaper_wizard and traffic_shaper_wizard_multi_all. Since we cannot control bandwidth its useless to try to handle it(ALTQ was built with this concept in mind."
This reverts commit 4447358371f80814ea1c5e0f00c1a7301a2396f6.
Reconfigure wan/lan when finishing wizard, or the new IPs will not be applied.
Revert this change. reload_all() already sends a reload message. Unfortunately there is still something else lurking that causes a delay when loading the wizard step
Use send_event()
Use send_message and issue the reload all operation in the background
Skip step #9 for non pfSense branded installations
Reload the wizard and then redirect to a wizard completed step. Prompt the user to donate to the project.
Misc fixes to make the openvpn wizard stop re-creating a CA previously made via the wizard if you re-ran the wizard and chose a CA instead. Fixes #1512
Ensure the protocol on the firewall rule from the OpenVPN wizard ends up lower case, or it causes some GUI irregularities. Seen http://forum.pfsense.org/index.php/topic,33865.0.html and elsewhere.
Only make gateway changes if we have been given a new gateway IP.
Setup gateway monitoring since we just altered a gateway.
Fix gateway handling in setup wizard.
Remove direction from traffic shaper generated rules now that the match action is present to correctly put packets on proper queues. Before it was not possible since this would have also open firewall ports/holes.
The doubled "$rule = array();" lines are probably a copy/paste error. Probably meant to paste the line that sets the rule type to the match action like the rest of what was added in the affected commit.
Correctly verify the input on bandwith at voip step for traffic shaper wizards. Reported-by: http://forum.pfsense.org/index.php/topic,32833.0.html
Convert the shapers to the match action so the generated rules do not impact the filtering policy implemented.
Do proper input validation on traffic shaper wizards to not allow empty fiedls.
Properly check empty fields when specifying bandwidth values.
Fix OpenVPN wizard.
Add drop-down to select OpenVPN hardware crypto (finds usable devices from "openssl engine" list) for clients and servers.
Add a checkbox for duplicate-cn on OpenVPN servers.
Fix multi_all wizard to properly verify VoIP bandwidth specified.
Fix OpenVPN NetBIOS settings not propagating from the wizard to the server instance.
Ticket #749. Do not create the queues at LAN side for traffic_shaper_wizard_dedicated. Since we cannot control bandwidth its useless to try to handle it(ALTQ was built with this concept in mind).
Ticket #749. Do not create the queues at LAN side for traffic_shaper_wizard and traffic_shaper_wizard_multi_all. Since we cannot control bandwidth its useless to try to handle it(ALTQ was built with this concept in mind.
Use the provided settings even for HFSC scheduler instead of hardcoding 32Kbit/s speed on VoIP. Also cleanup some whitespace.
Use 1024 not 1000 in conversion.
Provide a default value to the function for converting kb/Mb to coeficient for math.
Remove dropdown to select interface. Should fix #1090
Use correct variable name so the message is actually displayed.
Ticket #1081. Fix header() function to do correct redirection. Also remove bogus step9 in the wizards.
Add exit; so the redirection actually works.
Remove old reference to function. Reported-by: http://forum.pfsense.org/index.php/topic,30508.0.html
Save the host name and domain to a temporary location until the setup wizard is finished to prevent triggering the DNS rebind message. Fixes #1022 Also use this information to implement the redirect for changed host for ticket #455
Change OpenVPN wizard to set input_errors when there is a fatal condition that will require preventing a config save.
Reject special characters in CA/Cert field names during OpenVPN wizard. Fixes #900
Traffic shaper wizards remove redirection before final step. This seems a forgotten item.
Rename 'name' to 'descr' for CA, Certificates, and CRLs, to gain CDATA protection and standardize field names. Ticket #320.
Fix the dedicated and multi_all wizards. They had typos in variable names and some remaining unused code which caused problems!
Disable the bandwidth speed selection field also to avoid errors/problems when the catch all is not activated.
Spelling of 'Access'.
Update wizard files for setup wizard to write proper config for current ppp architecture.
I also allowed selection of physical interface from the wizard screen. This is crucialbecause if the user has the WAN set to anything other than the same phyical interface used...
CA/CERT Move
Ticket #733. Provide a description that custom bandwidths cannot exceed 30% of entered bandwidths for interfaces/links.
Ticket #859. Remove strange character at the end of the xml. Also fix my name partially since our parser does not allow my special character there.
Enforce length of OpenVPN server descr in wizard.
Put some size tags on these fields.
Fix this test, allows proper selection of CA in OpenVPN wizard.
Add/Update copyrights where applicable. Mark copyright on XML as CDATA to aviod any issues that might happen.
These needs to be exit. Fix some whitespace too.
Resolves #713. Take in conisderation the suggestion of not setting m1 parameter to 0b.
Keep the list of different applications port numbers on a single file to easy its maintainance and sharing.
Whitespace changes.
Also do the wizard optimizations and user-friendliness to the traffic_shaper_wizard_multi_all.xml
Also do the wizard optimizations and user-friendliness to the traffic_shaper_wizard_dedicated.xml
Also do the wizard optimizations and user-friendliness to the traffic_shaper_wizard.xml
Resolves #732. Make the wizard behave better and actually work by correcting typos in code. Make it faster by not using HTTP redirection for showing errors. Try to make it more user friendly, though some more work is needed.
add TCP 1119 for battle.net
Validate time server. Should be the last thing that fixes #464
Do more strict validation on WAN setup fields. Ticket #464
Do some more strict validation on hostname, domain, and DNS servers. Ticket #464
Validate MTU in setup wizard. Ticket #464
Fix some errors in spelling, punctuation, grammar, etc.
Remove remote network from wizard, it is not used for a Remote Access VPN.
Fix more inconsistent capitalization.
Fix punctuation.
Fix some inconsistent capitalization on labels
fix "Invalid argument supplied for foreach"
Add dynamic IP option to OpenVPN wizard.
Perform IP/Host and Port number validation for Authentication servers in the OpenVPN Wizard.
Restrict country code entry in the OpenVPN wizard to two letters.
Fix default port choices for LDAP/RADIUS server in OpenVPN wizard.
Fix OpenVPN port default choice in Wizard. Also fix protocol specification. (Should be Uppercase)
Fix CA cert dupe detection when no certs yet exist.
Add titles to wizard steps, change some wording to be more consistent.
Perform more strict validation on CA and Cert names before proceeding in the wizard.