Check if variables are set before trying to pass them to function substr_count to avoid generating PHP alerts.
Ticket #4418 make sure the dns_split is separated with spaces rather than space or comma to comply with strongswan requirements.
When RADIUS auth is selected, radius protocol and server ip/host are mandatory. Fixes #4384
isset is a better check here
Merge pull request #1494 from k-paulius/ntp-rrd-fix
Merge pull request #1479 from surrural/master
Merge pull request #1492 from PiBa-NL/carp-statusicon
Ticket #4445 do not write config and remove its cache when applying settings its just behaviour from dinosaur era and should have been cleanded long time ago.
Add support for DNSimple (dnsimple.com)
Merge pull request #1497 from phil-davis/patch-2
Merge pull request #1478 from razzfazz/fix_dhcpv6_avail_range_dump_master
Fix display style typo
I could not see any difference in rendering of the page after fixing this, but it looks it it should be fixed.
OpenVPN server improve handling of authmode
Currently if the user is clicking around while they are setting up an OpenVPN server, they can do stuff like this:a) Select Server Mode - Remote Access (SSL/TLS + User Auth)b) Select something in Backend for authentication...
vpn_openvpn_server.php white space
Merge pull request #1505 from phil-davis/patch-7
Merge pull request #1504 from phil-davis/patch-6
Merge pull request #1506 from k-paulius/fix-links
Success typo
might as well fix it while I notice it
Fix broken links to dhcp6c.conf man page.
manpath FreeBSD+Ports no longer exits and needs to be replaced with FreeBSD+10.1-RELEASE+and+Ports
Mention interface name on DHCP edit GUI
IMHO it can be confusing on the DHCP edit page for static mapped entries to know which interface the entry is being edited/added for. Specially if the user comes from the Status DHCP Leases page, the lease they are editing/adding could be for 1 of many LAN-style interfaces....
Status_dhcp_leases fix edit button for static entries with no IP address
The edit button for static entries always has an index id=0 and thus pressing the edit button goes to (mostly) edit the wrong entry.It was easier and made the code cleaner to get rid of the looping through the staticmap array every time trying to matach IP, MAC address... That data ('if' and 'staticmap_array_index') is easily gathered further up, the first time the staticmap array for each DHCP interface is traversed. I think this should also be more efficient when there are many static mapping entries....
diag_arp allow underscore in resolved host names
is_hostname() and is_domain() allow underscore in the names. So it is possible to have underscore in host names, for example in DHCP server static mapped entries I have some things like:10.42.3.4 client-pc-01_LAN...
Add GUI control for MOBIKE. Hide it when IKEv1 selected. Enable toggling of NAT-T field display so it's on for IKEv1, off for IKEv2. Do same for reauth while here. Ticket #3979
Fixing issues with NTP RRD graph state changes
- only call enable_rrd_graphing() after $config['ntpd']['statsgraph'] is set - fix if condition; empty and isset are each other's opposites
carp, don't show status icon from previous carp ip in case the ip is not present on the interface (test with ifconfig em0 1.2.3.4 delete)
Merge pull request #1484 from phil-davis/more-text-typos
Merge pull request #1485 from BBcan177/patch-1
force minimum 100000 byte log file size. Some have been confused thinking this is KB, in some cases causing problems. This should help, and there shouldn't be a need for logs smaller than that.
Update fbegin.inc - Missing '/' in path
Found this issue in conjunction with user Digdug3
Set srctrack separate from this test or the value won't save unless the sticky box status also changed.
get rid of wizards/initial/ images that were never used
Remove dead code and unset vars so next time the code works properly avoiding cache issues.
Random text typos
and I "corrected" function names that had "_choosen_" in them.That is not technically an error - function names do not have to beEnglish words. But it does look nicer to read.
Merge pull request #1482 from phil-davis/CP-text-typos
Merge pull request #1483 from phil-davis/formfld-unknown
Fix typo in class in bridge edit
Fixing this makes nice little pencil icons appear in front of the textentry fields.
Check if Unbound is enabled and using the same port before allowing dnsmasq to be enabled. part of Ticket #4332
that I noticed.
touch up Unbound text
Use appropriate interface field description when working with floating rules, it was confusing and potentially incorrect for floating rule purposes.
Merge pull request #1469 from makkbe/master
make computation of start of DHCPv6 range consistent with actual check
When computing the start IP for the 'available range' field,services_dhcpv6.php attempts to increment a colon-formatted v6 address.Since this always fails, so the value that's printed is not actually...
fix up text
Merge pull request #1458 from xbipin/patch-4
Merge pull request #1455 from xbipin/patch-2
Merge pull request #1466 from tuyan/master
Merge remote-tracking branch 'upstream/master'
Fixed alignment issue.
Added DynDNS support for GleSYS API (www.glesys.com).
fix responder-only IPsec text
fix text
Fix aliases popup width when fields are hidden when page is loaded. It should fix #4238
Fixed not being able to save custom and custom-v6 dyndnsentries due to "host" being posted empty, and thus failingis_domain() check.
fix indent
Merge pull request #1457 from phil-davis/patch-2
Remove latin-1 encoding of RSS feed
Many thanks to Gertjan in forum https://forum.pfsense.org/index.php?topic=87504.msg484017#msg484017Specifically setting the output encoding to latin-1 was causing the "black diamonds" for special characters in the http://blog.pfsense.org RSS feed (e.g. the registered trademark sign after pfSense did not come out)....
Add input validation to prevent the use of AES > 128 where glxsb is enabled. Ticket #4361
Fixes #4360 allow marking a connection as responder only, the same behviour as mobile connections
Fixes #4359 Allow controlling uniqueids
Merge pull request #1453 from phil-davis/Upstream-SIP-server
Fixes #4353 Identify when strongswan.conf needs a reload and restart ipsec service.
Fixes #4333 Unset previous defined values before using the new ones
Fixes #4340 encode username same as with password to avoid issues with special chars.
Update pkg_edit.php
add schedule selection to pkg_edit.php
this allows schedule selection to pkg_edit.php, this can then beutilized by packages to set schedules in many other places. This is thefirst set of changes, will further modify other files to make full useof schedules.
Do not reuse reqid on copy of phase2 Fixes #4349
Unbound domain override IP:port validation
The domain override is IP:port is invalid if either the IP address OR port is invalid.Previously you could put an invalid IP with valid port, or valid IP with invalid port.
unnecessary but lets just add this for safety
multiple allow/deny entries for UPnP (rowhelper)
remove old permission box fields
fix input validation, = is OK here
Accept port range on Outbound NAT. Fixes #4300
Merge pull request #1440 from wagonza/patch-6
Merge pull request #1421 from phil-davis/patch-4
with this additional change we can allow infinite number of entriesrather than just 500 due to the for loop set to a max of 500 because therowhelper control doesnt post as an array but just adds a number at the...
Merge pull request #1445 from phil-davis/priv-typos
This patch will allow the web GUI for UPnP to enter more user specifiedentries rather than just 4, I replaced the 4 boxes with one rowhelpercontrol
Traffic Shaper Wizard Upstream SIP Server
Not being remembered and actioned.Bug #4314
Teach ufslabels.sh to deal with DESTDIR, useful on installation
Improve a bit sh syntax and fix it for multiple swap devices
Fix sed syntax, -i requires a space before the parameter. Also fix regex to find swap device
use example.com for examples
these descriptions were flipped. Ticket #4273
Make sure radvd is reconfigured when CARP is enabled/disabled. It should fix #4252
Add missing require for filter.inc since vpn_ipsec_configure() calls filter_configure(). It should fix #4236
Unimportant typos in user and group manager
that do not effect anything.
move jquery ui css to theme folders
Merge pull request #1441 from phil-davis/patch-1
Time to let these go
Ticket #3997 s/_vhid/_vip/g
Ticket #3997 Put a uniq identifier on the carp settings.
Ticket #3997, teach code to track carp through uniqids(). Missing carp GUI changes and upgrade code
Firewall Rules Apply be friendly to other languages
Forum: https://forum.pfsense.org/index.php?topic=86808.0Redmine: https://redmine.pfsense.org/issues/3886
print_info_box_np() when called with just the first $msg parameter has some rough tests to decide if the "Apply" button should be displayed. It checks if the translation of "apply", "save" or "create" appears in the $msg string (which is a translated string itself). If the $msg string did not translate, and thus remains in English, but gettext("apply") does translate then the e.g. Turkish word for "apply" is not going to appear in the English $msg string. So things go wrong....
Add support for 0x20 DNS random bit support. Fixes #4205
Add EAP-MSChapv2 implementation for Windows ipsec support as reported here https://forum.pfsense.org/index.php?topic=81657.15
Actually remove rekey/reauth from config to avoid strange issues. Ticket #4208
To avoid issues with clashing SAIDs go back to specifying the reqid in strongswan config.
To be able to manage this first upgrade the config to assign each phase2 an reqidSecond use that during config generation
Ticket #4208
Improving aesthetics.
Make title color more consistent with other pages.Improving aesthetics.
Where the P1 is disabled, show the P2s as disabled since they will be, same as in previous versions.
Fix IPsec widget for multiple P2, it fixes #4164