pfSense

Redmine #7301 Provide word-break opportunity for dynamic DNS host names

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 138e79d42cb1771e3b8fcc727270187f5c7ee7db)

Add reasons to write_config() calls
(cherry picked from commit 919a43a7caa551cb14e72a5cd82ec1629b3a9aa5)

Remove unused base_packages variable from globals
(cherry picked from commit 40f5b3e22effc3319afea306a7d691a5e6934c37)

Remove useless add_base_packages_menu_items() function

Not really sure what was the idea 7+ years ago, but the code just doesn't make sense now.
(cherry picked from commit 94503103d8ce4e34de79f221f4fdd24f07dccb93)

Deduplicate code

Allow CloudFlare DDNS entries to use "" or "." for the hostname portion of the domain in the GUI to update the domain's @ record. Then in the backend code, remove that from the FQDN since CloudFlare doesn't like that to be sent explicitly. Fixes #7357

Fix is confirmed to work by two forum users: https://forum.pfsense.org/index.php?topic=122099.msg699763#msg699763

Do not enforce a max limit on state timeout when editing a firewall rule. Fixes #7356

While I'm here, fix the case when the admin account has been removed.

When resetting admin account via /etc/rc.initial.password, Check if the admin account is expired and reset if needed. Fixes #7354

Adjust fix for ticket #7294 for 2.3.x, it used a setHelp change that was only valid on 2.4.

Fix 7294 keep full rule description

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 680e15baef76a9c598d52d3f2b9ab498077336a8)

Add a function to normalize CR and CRLF-style newlines to Unix LF

See Bug #5306.
(cherry picked from commit 117776e0c01e68a8b65584d86d7b8b56fe75c9d0)

Services - Status Icon - Sort Order

Make status column sort order work correctly with the icons.
Also refactor get_service_status_icon() output string construction to be cleaner and clearer.

(2.4, 2.3)

(cherry picked from commit 446505a9f9be7f43e4515658f1a5444bc3732a3f)

Show PPPoE/PPTP/L2TP uptime on the Interfaces widget (Feature #6032)
(cherry picked from commit dc0f5e46a03e0ea797fb74df03e09c58f44a5c1a)

User Manager - Status Icon - Sort Order

Make status column sort order work correctly with the icons.

(2.4, 2.3)

(cherry picked from commit 0fdbaca8f16d0424cb2565ff4341e7620a7bdd2d)

certificatemanager, link certificate to the proper CA after completing the CSR request

(cherry picked from commit 7fd7fbcff3304285f4407bec2ae62bab7195bcc4)

Fix the pkg_call() and set the timeout to a sane value (Bug #6594)
(cherry picked from commit 9c91c7bd747074b8cdaa90e8810f0c2df081f72d)

Use the same cache filename pattern for RFC2136 IPv6 items as used by dyndns

Use | to separate dyndns IPv4 fields on cache file as done by rfc2136 items and for all IPv6 items

Fix #7300 provide default value for ipprotocol for old rules

Fix #7299 and other stuff

As far as I can see, filter_generate_user_rule() is always supposed to be called with 'ipprotocol' set to 'inet' or 'inet6'. The cases of rules for both ('inet46') are handled by calling filter_generate_user_rule() twice, passing 'inet' then 'inet6'....

Fixes #7296
HTML tags not allowed in selector option values

(cherry picked from commit 57f4327a60c0cabf43161a6cfde98479b42a7092)

Check that DHCP registration isn't enabled for DNS forwarder/resolver when disabling DHCP server
(cherry picked from commit e83c9b733c86f39a14a874b115f2b8e0adc952e7)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit c6d03f09e035806dca8ac3314b41a3eaf523ab3f)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit 13fca9bcb3fdecfb6f9707e621b49f89569abfd7)

Only start dhcpleases if DHCP server is enabled (Bug #6750)
(cherry picked from commit 3d8b01e8c6392b4177572d540c8160c7e6e071ca)

Captive portal: fix "Disconnect All" button

(cherry picked from commit 4fb2b17772928f39add5fc0529e94ed07a09de31)

User Manager - Status Icon

Use icon for status rather than textual asterisk to indicate disabled account.

(2.4, 2.3)

(cherry picked from commit edd88334dbe95af4600ae493fa86d45244cbaecb)

Merge pull request #3528 from phil-davis/system-information-widget-filter-2_3

Merge pull request #3527 from phil-davis/breadcrumbs-2_3

Check for correct directory

Add missing space

Lead users with Stable repo set to 2.3.3-RELEASE

Make sure OVA_TMP is umounted before start using it

Unset EASYRSA on openvpn23

Do not try to set old options that were already removed from upstream

fix colspan background on dark theme

Add "required field" highlighting

Only save valid widget locations in config

Some widgets create extra panels, e.g. the widgets that now have the filter functionality. Those panels are processed in the ".each" at line 424. They do not have an id in the form "widget-*" and when the old code tries to find the "*" part it gets "undefined". This results in the layout being saved like:...

Allow 5 dashboard columns to work

Selecting 1,2,3,4 or 6 dashboards columns results in an exact integer result here and all is good. But 5 columns results in "2.4" and "col-sm-2.4" is not a thing in bootstrap.
We need just the best int we can choose here, which is one that is just the int part of the division. That ensures that the 5 columns extend over less than the standard bootstrap total of 12 "units" wide....

Remove $MNT after use

Make sure $MNT is umounted

Fix typo in variable name

Remove schg flag from directories before try to rm them

Fix #7257: Use pfSense-upgrade to look for new versions

Fix saving Hybrid RSA + Xauth. Fixes #7258

Revert "Add privs to control display of notices"

Fix #7051

This reverts commit 04665e78537906f7375668ca665cba17f95a4864.

Revert "Use cached groups in get_user_privileges"

This reverts commit 855826896509a1a0bec77a51535a8f004b4ca570.

Use cached groups in get_user_privileges

(cherry picked from commit 7abc3f992e5dd5bff53495844ce944163d6d1d9b)

Fix ldap_get_groups return value when down

In some places ldap_get_groups has:
```
return memberof;
```
It should have the "$" in front, so it will return the $memberof array (that is empty when this happens).

This causes issues for callers that expect to have a return value that is either false, an empty array, or an array of the groups....

IPv4 Tunnel Network is required for OpenVPN server

(cherry picked from commit e4488e51cf424907e06ef7cc73370aa0657e5e25)

Merge pull request #3530 from phil-davis/patch-2

Update version string at end of boot RELENG_2_3

When there is an upgrade, the echo here was outputting a stale value of the version. For example, on first upgrade from 2.3.3-DEVELOPMENT to 2.3.3-RC the console had:

pfSense (pfSense) 2.3.3-DEVELOPMENT amd6 Sat Feb 11 14:24:27 CST 2017...

Point to 2.3.3 branch on devel server while in RC

Set some specific rules for RC during build

System Information widget filter gettext()

(cherry picked from commit f5d762f90924510c097a9065dff135dab01f46f0)

System Information Widget Filter

(cherry picked from commit 718b3b0b1b75de09a87866cb37b5a0752643283a)

Fix cut-paste error in Breadcrumb Links
(cherry picked from commit 0e5ee5ae260c42a05b79edf74fb491fca52bacb4)

Breadcrumb links

(cherry picked from commit edcd75357f0e93b124159314d3306197d5312e6c)

Breadcrumb links support

(cherry picked from commit c50f228a1583fe694993778e8576322877a15bba)

Add foot.inc back to status.php

Use RELEASE branch and server for now

Bump version to 2.3.4-DEVELOPMENT

5th try
- change $do_ping default value to 'true' (which emulates the previous default behavior) to avoid any unexpected results

(cherry picked from commit 20cf8d8e20fa28c16e86ce0d91e57e4d78427d26)

4th attempt!
- Reworked based on recent comments from @rbgarga

(cherry picked from commit c516cb287a78f7b05459e7fcba410f443d8eb8af)

3rd try!
- incorporate suggestions from @rbgarga with slight modification

(cherry picked from commit 6c2f093000b05285546e81dd1a578fc9b573b72b)

2nd try. . .

/etc/inc/util.inc:
- arp_get_mac_by_ip() updated to support IPv6
- attempt at code streamline

/usr/local/www/services_dhcp_edit.php:
- streamline code, now just a simple call to arp_get_mac_by_ip()

(cherry picked from commit dd83f869b79a858bd74c7a8bb4adcd49217445b0)

enhancements to services_dhcp_edit.php
- added ndp call to get MAC addr if remote client is connected via IPv6
- automatically hide `Copy MAC` button if arp/ndp returns null
- switch to exec() instead of backticks for calls to arp
- uses builtin is_ipaddr() function from util.inc...

Sync up status.php with master, but keep the 2.3/10.3-specific parts. Fixes #7246

Do not output PHP shell starup message unless it is run interactively. Fixes #7045

Add a pfSense php shell playback script to show the gateway status. Ticket #7046

Add a function to format and return plain text output showing the gateway status, for use by a shell script and status.php. Ticket #7046

Add playback scripts to drill into pf tables and anchors to list their contents.

Fix for bug 6966 https://redmine.pfsense.org/issues/6966

Change-Id: I9471c2bbd8941e70965a86d369c8de87be9a4417
(cherry picked from commit 109a304e154a179bd340b06880ce95baec4dab03)

Revert "Fixed #6753"
User feedback suggests the sorted menu was better, despite the lack of consistency elsewhere.
This reverts commit 96ff627ff95e0fcadf8c15dbd6fe681309cb0fd8.

Mark missing parameter as required. It got lost during backport from master as spotted by @phil-davis

Required fields - Alias Type

should be a required field. And this 1-char change can also be backported to RELENG_2_3. I noticed this while looking at GUI pages in 2.3.3
(cherry picked from commit 8ea10c11441b5aed0b10eb14038aa8f8adbfb3de)

Fix #7157

trafficgraph: Don't update the on screen visual graph while invisible,
which avoids creating a large queue of pending timer objects waiting
for the next requestAnimationFrame to happen.

Submitted by: PiBa-NL at https://github.com/pfsense/pfsense/pull/3450

Ticket #7157: Backport upstream fix from https://github.com/novus/nvd3/commit/305cbad96e94f61a3c0bae02d16c28e09249fbc0

Example of setting required items

(cherry picked from commit 32a85c63c9411463c98a0605772b3e2c01702971)

Require Name field in Shaper

(cherry picked from commit 40dcb4b61a2c1213a0b3e213c78fddac845a0117)

Revise setHelpText to accommodate required fields

Provide Javascript set_Required function

Provide CSS for required fields

Add "Required field" capability to Groups.class.php

status_upnp remove nested getext()

I don't think this does anything useful.
(cherry picked from commit 3224663a3759935b47406c789b9f5cea3eb88136)

Part fix #7233 keep correct staticmap_array_index

The index needs to be incremented even for entries that were skipped for display because they (for whatever reason) have no MAC or CID set. So use the key directly from the array.
(cherry picked from commit 9aa3c5e84984958caa19ac76ecba849b94a8b360)

Part Fix #7233 Allow deletion of empty static map entries
(cherry picked from commit 2ea70e1a474fd871a007c76841f2a33f34082c58)

diag_backup do not use button text for comparisons

(cherry picked from commit 9a7e1c9580c5779c86bc97d6d82c43401c7a4b12)

Rather than setting the value directly, minimize exposure to eval() in update_config_field() from wizard.php by constructing a variable reference, then set the value using the reference rather than passing user input through eval(). Fixes #7230

Convert easyrule.php to use a confirmation landing page so that the parameters can be submitted via POST. Also, remove the JavaScript confirmation box since it is now redundant. Fixes #7228
The confirmation page displays the submitted parameters for an extra user sanity check. Also fixed a bunch of page formatting issues that were not apparent because users rarely if ever saw output from the page.

interfaces_ppps_edit fixes that will work on 2.3.3 also

1) Make "The MTU is too big" message actually come out. The code around line 300 was rubbish (maybe from before bootstrap?).
2) Show friendly description rather than 'wan' 'lan' opt1' in interface link list....

Fix #7226 Package installation message is incomplete

This makes it remember pkgname after the install finishes and the form is re-submitted.
(cherry picked from commit d12bc864ceb5d656fc094bde7cf5ec96e24bdde9)

pkg_mgr_install remove embedded HTML from result strings
(cherry picked from commit 682008ff758b942d85ed007b485e0b2fa8e3a11c)

Encode the contents of pkg_filter before output. Fixes #7227

Encode 'from' and 'to' before output on pkg_mgr_install.php. Fixes #7225

Revert "setHelp formatting for interfaces.php"

This reverts commit e6068596baf4307fe3eb9866072800e4c23b6840.

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

fbegin.inc and fend.inc obsolete

(cherry picked from commit 5af0922d75724e1eac89017173457f57842387f8)

fbegin.inc and fend.inc are no longer used

(cherry picked from commit c09188a21938f7b1d19fd845fa7e5b0712dd4a83)