pfSense

Update the Copyright year of the files owned by Rubicon/Netgate.

Remove WireGuard support

Out of an abundance of caution while we investigate the claims about
WireGuard in public, we need to remove it from pfSense Plus and CE in
order to shield customers from potential risk.

#5186 - Add ability to mark row-helper help text as required (underlined) by pre-pendinf text with '*'. No longer clear help text when adding new peer.

Update the Copyright year.

A subsequent commit will deal with .po's.

OpenVPN copy auth_pass. Fixes #10703

DNS64 support. Issue #10274

This is 2020. Issue #9245

Update copyright notice years. Issue #9245

Set autocomplete=new-password for auth forms around the GUI. Implements #9864

Provide optional "enable" argument to enable/disable form submit button

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Update copyright notices to 2019. Happy New Year

Add missing break in IpAddress form class. Fixes #8834

PHP7 Resolved Services->uPNP integer value warning

PHP7 - Resolve MultiCheckboxGroupAdd compatibility warning

PHP7 - Resolve setParent wanring

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Merge pull request #3711 from PiBa-NL/20170427-ipsec-multiple-P1-algo

Update the Copyright notice for pfSense.

ipsec, allow configuration of multiple ike phase1 encryption ciphers (algo/bits/hash/dh)
this is useful for mobile users that need to connect with different operating systems. This way there is no need to find a single commonly supported weaker cipher.

Fix anchor tag location

Improve comment

Use the section ID as an anchor so that hyperlinks can jump directly to that sectiom
e.g.: $section = new Form_Section("My section", "a_here");
then: https://firewall/system_somepage.php#a_here

Only use sprintf in setHelp() if more than one argument is received
This should eliminate all the issues caused by packages with embedded '%' in their text

Merge pull request #3484 from phil-davis/sethelp-empty

Use unique var names in Input.class.php

Do not pass empty string to gettext

COnvert the setHelp method(s) to accept conventioanl printf style argument lists. e.g.: setHelp("%d interfaces have been detected", $numIfs);

Refinement to #7083
Provides setRequired() Javascript function to facilitate making an input required or not dynamically

Fixed #7083

When composing an element with a form.class or via XML, prepend a '*' to the title to indicate a required field. This will cause the "element-required" class to be added to the label. pfSense.css contains the style associated with that class. (Currently a custom underline)....

Form_IpAddress add types remove patterns

1) Add alias and host types to Form_IpAddress with the appropriate hover
text.
2) Remove the patterns - the UI of those is not so effective anyway, so
leave the validation of input to the back end.
3) Update uses of Form_IpAddress to use the appropriate Alias or Host...

IPv6 address can contain a dot

When requiring the entry of an IPv6 address, the regex pattern should still allow a dot, so that an IPv6 address can be entered in the format that has an IPv4-address-like part at the end:
aa:bb:cc:dd:ee:ff:1.2.3.4
which is a valid way to choose to specify an IPv6 address.

Revert "Fix #6864 automatically convert IPv6 input to lowercase"

This reverts commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f.

Revert "Fix #6918 Allow aliases with capital letters in rules"

This reverts commit 9444a281f051e11d5456cc37b2a3f56fc8a7bc33.

Fix #6918 Allow aliases with capital letters in rules

Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text....

Remove "use lowercase" hint

As it is no longer relevant, because the code now automatically converts
to lowercase.

Fix #6864 automatically convert IPv6 input to lowercase

1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid...

Move copyright from ESF to Netgate

Code style and comments

No functional change - just making style consistent

Improved solution to #6716

Merge pull request #3056 from NewEraCracker/design-tweaks

Allow section header to be omitted by specifying "NOTITLE" as the section title.

Move to Apache License 2.0

Review license / copyright on all files (final round)

Review license / copyright on all files (1st round)

Some tweaks to improve alignment in table with checkbox

1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly

2) UPnP checkbox looks better with description instead of help

This commit fixes the two issues

Merge pull request #3018 from phil-davis/usersettings

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.

Feature #6388 custom GUI preference settings per user

Merge pull request #3011 from NewEraCracker/redmine-6394

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

Reduce maximum length of string to gettext()

This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139

Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0

Experimentally fixed #6327

Translate button text

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

Make fa-save the default button icon for 'Save' on all forms. Ticket #5965

Adding {} to if statement.

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext....

classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox and Chromium

Put this htmlspecialchars back, I found a better workaround for the inconsistent handling of checkboxes in packages.

Fix inconsistencies in Form_Input

renamed get_type to getType
fix capitalisation in getTagName

Don't run the checkbox label through htmlspecialchars, it breaks several packages.

Don't automatically run strings that are too long through gettext here.

Change method name to setIsRequired() to match other similar methods

Added new method setRequired() (shortcut for setAttribute("required", true) )

HTML Compliance - Form Button - HRef

The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.

Correct "noWrap" in text areas. (Function is not actually used by anyone, but it might as well work just in case.

Final updates in support of hidden passwords

Don't display dummy password if configured pwd is empty

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Move width:auto style to textarea handler in pkg_edit.php

Merge pull request #2316 from phil-davis/patch-3

Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_Placeholder

HTML Compliance - Form Select 3rd try

This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315

Default textarea width to 60 cols.
Use setCols() to override

Adds style="width: auto;" attribute to textareas to allow the "cols" attribute to take effect. Required bu pkg_edit.php and by wizards

Reverts change to Form_Selector which was breaking selectors with blank options

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_Hyper

HTML Compliance - Form Group - Label For

The for attribute of the label element must refer to a non-hidden form control.

WebGUI Left Column Labels Hyper

Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0

Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.

No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes....

HTML Compliance - Form Input - Placeholder

Attribute placeholder not allowed on element select at this point.
Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.

HTML Compliance - Form Select

Element option without attribute label must not be empty.

Applying htmlspecialchars on form action attribute causes ampersands to multiply, and also breaks multi-parameter query strings that are delimited with ampersands.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....

HTML Compliance - Checkbox Display As Radio Unique ID

Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument⁰.
If no argument is passed, construct id as name_value:uniqid.

Previous behavior was id = name. So all the radio buttons of the set had same id.

HTML Compliance - Form Action Attribute

Fix Empty Form Action Attribute Violation

An empty form action attribute is an HTML4 and HTML5 specification violation.

http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."...

Revise collapsible section behavior to use defines (COLLAPSIBLE, SEC_OPEN, SEC_CLOSED)

Spelling

Further changes to Section.class.php and to diag_logs_filter.php
Experimental section collapse

Form_Section() now accepts up to 4 arguments: Form_section(title, id, collapsable, initiall_collapsed)

collapsable = true specifies that the panel should be collapsable and should have a plus/minus icon in the title bar to allow that. Defaults to false...

Add full classpath to autoloader so that packages can run from their own directories.

Experimental changes to Form_Section() to allow the panel to be made collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY

Update Form_Input flass

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

add attribute 'id' for the Form_Section

Allow fa icons to be embedded in Form_Button class buttons