pfSense

Breadcrumb links

(cherry picked from commit edcd75357f0e93b124159314d3306197d5312e6c)

improve CSS handling for icmp types (overflow/table)

Minor CSS and formatting improvement to layout for icmp types in rules table. With this change, if several icmp types are specified in the rule, if they won't fit into 2 lines the GUI automatically switches to a scrollable overflow instead, to preserve the table layout. Also underlining is per icmptype so commas etc aren't underlined which is much easier to read...

coding layout fix
(cherry picked from commit 97eebb23531bc95af2cde686641080851107c42c)

remove gettext() not needed
(cherry picked from commit c7e31e37c1aa0a8e4154528a99a121c46ebf018d)

move implode() to same line as previous change
(cherry picked from commit 91822dc6d0b829a34254638c5d15db72fe70932d)

simplify avoiding loop. Also localise with gettext()
(cherry picked from commit 16b91b19e08e0778522c16e811754c22f03b5150)

Enhance ICMP types in rules

See main PR for details
(cherry picked from commit cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4)

Fix display of the number of states in the firewall rules page

For numbers greater than 1000 format_number() returns strings formatted like N.NNN K/M/G/T, that get cut to only the integer part if '%d' is used.

(cherry picked from commit ef0e956e48ec1b97a307a546cbc24d00872cde1f)

Fixed #6939 by moving CSS only to the two pages that require it

Fixed #6895
by setting overflow-x: visible; in CSS

Simplify logic
(cherry picked from commit 9a2d3fe1bf9bdad73fbffca44d5c1f02aa9825ae)

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

Move copyright from ESF to Netgate

Review license / copyright on all files (final round)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Link to correct schedule from firewall_rules.php. Ticket #6428

Miscellaneous Textual Correction - Firewall / Rules

(cherry picked from commit 1fd8a5520602803108ef8bbb56b8ffd6493f2a00)

Show insertion point icons only if one or more rules have been selected

(cherry picked from commit c6a8ddf8135881d6e11bd4f17fe4e5d827eea73d)

ALternative fix for #6092 uses icon to indicate insertion point rather than cell border.

(cherry picked from commit 995454f305ac46606af0e3a289d98c7519a41498)

Updated #6092 as requested

(cherry picked from commit a7893b72fe9405293ad23d29d03e8985ede796d4)

Firewall / Rules - Underscore Line Wrap

Replace underscore with space in display text of certain fields to allow them to line wrap. ex: long alias names

(cherry picked from commit ece727a7b64a8766ad3087f8f59c0f1784e7a514)

Fixed #6092

Merge pull request #2809 from NOYB/Firewall_/_Rules_-_Remove_Personalizations

(cherry picked from commit 1cde3afb4c048f66ffd670c373a14d3d3cfa2a71)

HTML Compliance - Firewall / Rules

Error: Duplicate ID frrfc1918.
<tr id=frrfc1918>

Comment typos - firewall_rules

Highlight moved rows to confirm move

Re-commit change

Revert "Fixed #5983"

This reverts commit 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Fixed #5983

Added the ability to move multiple firewall rules via a "movre to here" icon (anchor)

Firewall / Rules - Simplify Order-Store Loops

Replace indexing for loops with more easily readable key/value foreach loops.
Make the order-store rules selection logic consistent with the display rules selection logic.

Firewall / Rules - for/foreach Vars

Replace for $i var with foreach $filteri var.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Firewall Rules - for/foreach

Replace indexing for loops with more readable, and faster on arrays, key/value foreach loops.

Firewall / Rules - Consolidate Move Separators Function

Consolidate the moving of separators for add/copy/dup/delete into a generic function.

Merge pull request #2619 from NOYB/Firewall_/_Rules_-_Display_Separators_Efficiency

Firewall / Rules - Display Separators Efficiency

Use a list of separator rows to call the display separator function only for rows which there are separator(s). More efficient than looping through the list of separators on every row.

Convert section titles to title case

Merge pull request #2600 from NOYB/Firewall_/_Rules_-_Page_Efficiency_Upgrade

Added "Quick" icon to legend

Typo in icon color

Fixed #5860

Make display separators function generic and move to filter.inc.

Firewall / Rules - Page Efficiency Upgrade

1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables....

Implemented #5846 as requested

Fixed #5841

Remove bonus space

Possible fix for #5752

Minor cleanup

1) Undo typos in sasl.inc. 2) Remove unused code from CSS. 3) Correct typos in some comments. 4) Convert short_open_tag to full tags. 5) Make 'else' block look like the others.

Separator bar stuff moved to pfSenseHelpers.js so that it can be more easily applied to other pages
Separators added to firewall_nat.php

Remove no longer needed code

Adjest separators on rule move or delete

Fixup text for delete rule confirmation popup

It is was asking "Are you sure you wish to delete?"
On any buttons that have a confirmation popup the title text needs to be something that works on the end of "Are you sure you wish to".

Update typo spotted by @phil-davis

Remove href to prevent page scrolling on click

Cosmetic changes - part deux
Calculate colspans in casenumber of columns change again
"bytes" => "B" to reduce column width

Cosetic update - Part 1

Show rule state details in firewall rules.

Inspired by pull request #1901 from marcelloc/hitcount_23_02.

State visualization and kill will be committed in a subsequent commit.

Fixed variable names for power save modes

HTML Compliance - Firewall Rules - Separator

The font element is obsolete. Use CSS instead.
<font class="bg-danger">The Bad</font>

Typo

Fixed #5810

Fix PR syntax error

Tidy up "firewall_rules.php"

- add missing closing anachor tags
- close input tag correctly
- add missing closing TD tag
- remove invalid ALT

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Remove close button from firewall_rules

Issue: https://redmine.pfsense.org/issues/5788

Comment fix

Remove debug

Escape HTML on re-saving separator text

Provide warning message onleavinghte page
Allow Esc key to cancel a new separator
Allow Enter key to save a new separator

Changed color scheme to use existing bg-* classes
Simplfied color change mechanism
Implemented "Cancel" button

Add colors to the separator bars

Eliminate foreach for speed.

New separator text box has focus when created

Fixed issue with separator bar at very top of floating rule list

Completed basic #5373
May add a color option after some testing

Merge pull request #2477 from phil-davis/gt6

Internationalize firewall_rules pages

I might have gone too far wrapping '(other)', 'any', 'default', 'none'
in gettext() but actually if translating to a language with non-Latin
script then it can be useful to translate even these sort of single
words, because there might be some people who cannot even read Latin...

Restore separator bar delete functionality

Add Javascript htmlchars() equivalent to dynamically created inputs
Temporarily remove function that broke action icons

Fixup firewall rules schedule status images

1) $iconfn is not the var that contains the 'type' of block or reject.
2) In the bottom if-else of the diff "times-circle" was repeated twice.
3) It seemed odd to me that wen the schedule was out of its time that the icons would always be in "text-danger" color. My suggestion, make them "text-warning" which distinguishes them from the green or red that is shown when the schedule is active.

Added separator delete icon

Prototype #5373

Consistent panel-heading h2

Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0

Replace abbreviations with complete word

Change the automatic information block to look for <div class="infoblock" instrad of <div id="infoblock"
Just makes more sense to use a class for this

HTML Compliance - Firewall / Rules / WAN

Attribute name not allowed on element table at this point.
<table name="ruletable" class="table table-hover table-striped table-condensed">

Unclosed element div.
End tag for body seen, but there were unclosed elements.

back out design changes for now

Fixed #5648

improve firewall rules table (WIP)

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Coe style firewall *

Fixed #5620 change css classes from icon- to text-

Ticket #5518 update firewall rule icon colors

Merge pull request #2134 from ExolonDX/branch_04

Type up SCRIPT tags

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

ALternative to PR 2118/#5527

change reject icon to hand

clean up firewall rules tables

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.