pfSense

Only cache CP RADIUS Auth credentials when reauthentication is enabled. Fixes #7528

(cherry picked from commit d4e42c54a2b7d9c955b11ad3034a186a73159f1a)
(cherry picked from commit ed44d5fb36f1f69196417e3feab2a9d6df4a47c8)

Welcome pfSense 2.3.4-RELEASE

Typos in pkg management code comments

(cherry picked from commit 146dbf0139d1f3049131bdf7a7d96675e4ff00a4)

Let he user know if all selected interfaces are down

in the interface statistics widget.
At the moment, if all the selected interfaces are down, the widget will just display no columns. That will make users wonder what happened.
(cherry picked from commit b22fceb2d7973b8c80a55b4ec492819ddd5ae9f9)

Fix interface down in interface statistics widget

If an interface is down, the widget would write the interface description in a column heading but then omit the stats items. So later columns (to the right) would have the headings and stats items out of line....

Redmine #7318 None button for widget filters

(cherry picked from commit fba53b438540eb544c43adf4598e07320a910347)

Handle widgets having no items selected for display

(cherry picked from commit 405dfaad144de90a6e401354b80b82baf5ae3d59)

Remove bonus end td tag in interface statistics widget
(cherry picked from commit 9795332b0e101b4c500c3c75a8ea02325364fc17)

Make sure that array exists before using foreach() (Bug #7399)
(cherry picked from commit ce348731b63ea6980dc4f652e76d7c8c7432544c)

Spelling

space/tab

Add Netgate ID display to system info widget

Read default language from globals.inc instead of hardcoding (it was already defined there)

Set default anguage in General Setup to en_US

Since https://github.com/pfsense/pfsense/commit/fdcde31b4a910c4e058513c1e3f68a62e722da6b added German to the top of the get_locale_list() array, if you start with a default system and go to System->General Setup (make some changes to other fields if you like) and press Save, you end up in German because that is what gets selected in the dropdown when the config does not yet have a language in it....

Checks for DHCP Relay being enabled/disabled should be skipped when editting an additional pool

Encode hostname and other output for DHCP lease status. Fixes #7497

(cherry picked from commit a260eda55905607e9adfd5d7c3fd779b115459d5)

Always add the CN as the first SAN when creating a certificate in the GUI or an automatic GUI self-signed certificate. Per RFC 2818, relying on the CN to determine the hostname is deprecated, SANs are required. Chrome 58 started enforcing this requirement. Fixes #7496

Add expiration field to NDP listing

(cherry picked from commit fec2c3b73f05683b674d3b5351529268eadc8dd9)

Fix #7493 only check interface IP if static

(cherry picked from commit 8c6190e82f83a7907ec2757e72d9a8eac496dd61)

Avoid invalid arg error when saving WoL widget

when there are no WoL entries
(cherry picked from commit 66a5b767b1b533f6ce508a125404a2d8e3353c41)

Update services_dyndns_edit.php
(cherry picked from commit df4c21fc24cc6ff38988ca866928f2f73b97b744)

trafficgraphs, divide bandwidth by time when statistics where gathered to smooth out bumps in the graphs

(cherry picked from commit eddb01316c7ad06c1798e629b6158db505a86118)

ipsec overview, check label exists for interface including disabled ones, tell what was configured if not found.

(cherry picked from commit ac24ac6bbb5b94e1eb8420404a9b7bd9daf998b7)

ipsec webgui, move building the $iflabels array outside if the loop

(cherry picked from commit 11b9896609c2998106d5503fe2581bb3304b4a5f)

notify test buttons for smtp/growl should use new unsaved settings just made

(cherry picked from commit 64f8ec62ddd57241e4a8a755cade7ca8cd9196a6)

Do input validation on the actual array passed in

I was tearing my hair out for a while. If do_input_validation() is passed some array of keys/values that has been assembled elsewhere (not $_POST, $_GET or $_REQUEST superglobals) then it does not work. The code here, for at least the last 7 years, has actually been checking the array keys in the "hard-coded" superglobals. That is a bit surprising, since the array to be checked is passed in as $postdata parameter....

Escape IPv6 when passed to ndp delete command

(cherry picked from commit 1d92faa34f7c9aaa97b1983f273d2d73285befb5)

Add ability to delete NDP entry

(cherry picked from commit 13105d9c79fe3ac8be2b01c152fb9fb6a95147b4)

Remember original alias name on edit input errors

(cherry picked from commit 1271754326fe648093204296652398b1edd24912)

Refactor update_alias_names_upon_change

(cherry picked from commit 24807bfeaec218948937a1fdc2b4e863319e41a0)

Revise dev_mode change handler

(cherry picked from commit 8a0af41adc9c29ccf7b8dabb3b7658abf46054a6)

Fixed #7451
Revised onchage handlers to obviate need for second click in Chrome on MacOS

(cherry picked from commit dd3c646fa5744a550f91524035a92f509d6162cf)

Revert "Restore CSRF customizations"

This reverts commit 1d7a414705794f2527dc1b7b3bb5419db1024bb6.

Revert "CSRF: Close session before exit"

This reverts commit d2495e5893baa63b2973b66f7c1b9787fada2e30.

CSRF: Close session before exit

On CSRF, call phpsession_end() before exit to avoid syslog warning
about open session

Submitted by: PiBa-NL

Restore CSRF customizations

Update CSRF to latest version from github

Fix UTF8 in base64 decode

(cherry picked from commit 557e082696823ea5fa09a36d98f01775bf1e0c77)

Adds ability to ignore DHCP offers from multiple servers
- Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
- related dhclient source:
https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945

changed files:...

Typo fix

Disallow IPv6 for RADIUS server.

See https://redmine.pfsense.org/issues/4154. No need for users to waste their time with debugging packets black hole.

Merge pull request #3613 from doktornotor/patch-15

Fixed #7445
Now properly handles service names that contain hyphens

(cherry picked from commit 21a8edd7836baf1e4ee2f347fdc1bafb4d96c9d9)

Merge pull request #3687 from doktornotor/patch-1

(cherry picked from commit 7c820a5d1ddb0ecf66ccaf1c4c82cc6361e15a6b)

Merge pull request #3580 from doktornotor/patch-9

load package add-on tabs into config to avoid parsing all installed package xml's, fix tabgroup filter

(cherry picked from commit bc0661b7b32a99016b9e71b0ece969f6584034c2)

Redmine #7435 Fix edit problems due to POST id code

Add underscores to is_port* function names

(cherry picked from commit 593e9fe32d2959cd823fe5da55714ccfb9a0e958)

Provide functions for checking port range alias combinations

Show the button to reset CARP demotion status even when the value is negative, and change the reset code to accommodate. Also fixup text in that dialog. Fixes #7424

Fix display of BIOS only on Sytem Info widget

Show BIOS information in the system info widget, if it exists in kenv.

System Info Widget enable All button when disable firmware check is set

If system firmware disablecheck is set, then the click event for the filter "All" button is also not included in the JS, so the "All" button is not effective.

The setTimeout for systemStatusGetUpdateStatus() can be moved up just below where it is declared and inside the existing "if" that conditionally includes that function - no need for it to be inside events.push...

Fix #7317 Widget Filter All button gateways widget RELENG_2_3

Reduce numeric precision in gateways widget to single decimal place (Feature #6841)

Further internationalization

Add missing internationalization

Revise gateway widget config form

Allow hiding of gateways in Gateways Widget

Sometimes there are gateways that I do not care about, so it is handy to
be able to save some space on the dashboard by hiding them.
This uses similar code structure taken from service_status widget. I
made the Save and Clear buttons and all that stuff use the same styles...

Visually separate the package manager legend area (Bug #7203)

Fix #7317 Widget Filter All button

(cherry picked from commit 7067e174c27a1fe9b23d13806f1e52ce9bc2aaee)

Fix #7364 Console assigned VLAN disappears after reboot

(cherry picked from commit 75a1149e0104561446e6f90f98d98c6c13c52996)

Fix #7306 Correctly filter log widget entries by interface description
(cherry picked from commit 27bc5848cfea95f97f70a4fe0c30da6319794a9a)

Remove whirlpool from the list of CA/Cert digest algorithms as it does not work properly. OpenSSL claims it's not valid ("unknown signature algorithm"). Fixes #7370
While I'm here, stop needlessly repeating the algo list, it's a global in certs.inc, so use that single copy of the list.

Fix display of openssl errors when working with CA or certificate entries. Found this while looking into ticket #7370

Set new blog URL (https://www.netgate.com/blog/) as default for RSS widget

(cherry picked from commit 294f14f7897f973f1fa2a1506cfdd9117b5daf65)

Redmine #7301 Put dot after the word break

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 81b1b44ad7e4d7abc635b08533359b9df45b54b2)

Redmine #7301 Provide word-break opportunity for dynamic DNS host names

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 138e79d42cb1771e3b8fcc727270187f5c7ee7db)

Add reasons to write_config() calls
(cherry picked from commit 919a43a7caa551cb14e72a5cd82ec1629b3a9aa5)

Remove useless add_base_packages_menu_items() function

Not really sure what was the idea 7+ years ago, but the code just doesn't make sense now.
(cherry picked from commit 94503103d8ce4e34de79f221f4fdd24f07dccb93)

Deduplicate code

Allow CloudFlare DDNS entries to use "" or "." for the hostname portion of the domain in the GUI to update the domain's @ record. Then in the backend code, remove that from the FQDN since CloudFlare doesn't like that to be sent explicitly. Fixes #7357

Fix is confirmed to work by two forum users: https://forum.pfsense.org/index.php?topic=122099.msg699763#msg699763

Do not enforce a max limit on state timeout when editing a firewall rule. Fixes #7356

Remove useless config_lock()/config_unlock() calls

Adjust fix for ticket #7294 for 2.3.x, it used a setHelp change that was only valid on 2.4.

Fix 7294 keep full rule description

Signed-off-by: Phil Davis <phil.davis@inf.org>
(cherry picked from commit 680e15baef76a9c598d52d3f2b9ab498077336a8)

Show PPPoE/PPTP/L2TP uptime on the Interfaces widget (Feature #6032)
(cherry picked from commit dc0f5e46a03e0ea797fb74df03e09c58f44a5c1a)

User Manager - Status Icon - Sort Order

Make status column sort order work correctly with the icons.

(2.4, 2.3)

(cherry picked from commit 0fdbaca8f16d0424cb2565ff4341e7620a7bdd2d)

Use the same cache filename pattern for RFC2136 IPv6 items as used by dyndns

Use | to separate dyndns IPv4 fields on cache file as done by rfc2136 items and for all IPv6 items

Fix #7300 provide default value for ipprotocol for old rules

Remove another leftover

Fix NTP widget to show server time (Issue #7245)

Fixes #7296
HTML tags not allowed in selector option values

(cherry picked from commit 57f4327a60c0cabf43161a6cfde98479b42a7092)

Check that DHCP registration isn't enabled for DNS forwarder/resolver when disabling DHCP server
(cherry picked from commit e83c9b733c86f39a14a874b115f2b8e0adc952e7)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit c6d03f09e035806dca8ac3314b41a3eaf523ab3f)

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well
(cherry picked from commit 13fca9bcb3fdecfb6f9707e621b49f89569abfd7)

User Manager - Status Icon

Use icon for status rather than textual asterisk to indicate disabled account.

(2.4, 2.3)

(cherry picked from commit edd88334dbe95af4600ae493fa86d45244cbaecb)

Merge pull request #3528 from phil-davis/system-information-widget-filter-2_3

Merge pull request #3527 from phil-davis/breadcrumbs-2_3

fix colspan background on dark theme

Add "required field" highlighting

Only save valid widget locations in config

Some widgets create extra panels, e.g. the widgets that now have the filter functionality. Those panels are processed in the ".each" at line 424. They do not have an id in the form "widget-*" and when the old code tries to find the "*" part it gets "undefined". This results in the layout being saved like:...

Allow 5 dashboard columns to work

Selecting 1,2,3,4 or 6 dashboards columns results in an exact integer result here and all is good. But 5 columns results in "2.4" and "col-sm-2.4" is not a thing in bootstrap.
We need just the best int we can choose here, which is one that is just the int part of the division. That ensures that the 5 columns extend over less than the standard bootstrap total of 12 "units" wide....

Fix saving Hybrid RSA + Xauth. Fixes #7258

Revert "Add privs to control display of notices"

Fix #7051

This reverts commit 04665e78537906f7375668ca665cba17f95a4864.

IPv4 Tunnel Network is required for OpenVPN server

(cherry picked from commit e4488e51cf424907e06ef7cc73370aa0657e5e25)

System Information widget filter gettext()

(cherry picked from commit f5d762f90924510c097a9065dff135dab01f46f0)

System Information Widget Filter

(cherry picked from commit 718b3b0b1b75de09a87866cb37b5a0752643283a)

Fix cut-paste error in Breadcrumb Links
(cherry picked from commit 0e5ee5ae260c42a05b79edf74fb491fca52bacb4)