pfSense

Rector some direct config gets with complex paths.

Rector some config unsets with complex paths.

Rector some direct config sets with pure scalar paths.

DHCP6 Adv field validation errors. Fixes #13493

A few fields were being validated but not informing the user when the
values were bad. This commit lets the user know when they have entered
invalid data in the affected fields.

Rector some direct config gets with pure scalar paths.

Rector some more direct config unsets with pure scalar paths

Rector some direct config unsets with pure scalar string paths.

IPsec cert SAN improvements. Fixes #13373

• Improve descriptions of IPsec P1 cert fields.
• Allow using a cert with a wildcard SAN so long as there is at least
  one non-wildcard SAN.

Add CA/Cert invalid descr char list to help. Fixes #13387

Correct special net NPt dst prefix handling. Fixes #13240

Disables prefix length drop-down when using a special net (e.g. track6
delegated prefix) because that already has its own prefix length.

Being able to specify a custom prefix was of dubious use and served to...

Use 'ip' when copying+converting addr rules. Fixes #13364

Ensure copied rules get unique IDs. Fixes #13507

Fix more Rector foreach fallout

Fix PPP reset hr/min blank vs 0. Fixes #13307

Replace direct config accesses in services_dhcpv6_relay.php. Fixes #13676

Fix PPP interface regression

Fix descr for unbound network ifs. Fixes #13453

Detect/set default primary console. Fixes #12960

If the user has not chosen a primary console, use the current active
console type as the default.

This prevents a user from unintentionally switching from video to serial
without making an explicit choice to do so.

Correct QAT active reporting. Fixes #13674

Account for cases where the module(s) are loaded but the driver failed
to attach.

fix pciconf output parsing

In FreeBSD 14 the output format of pciconf changed. It now splits up the
device and vendor fields.

Simplify this code by using the column output. Concatenate device and
vendor fields to match the previous output (with awk).

See https://cgit.freebsd.org/src/commit/?id=635cfe5b819f60f28b7e21b94322b0237c13244b...

Replace direct config accesses to system/webgui paths in system_advanced_admin.inc. Fixes #13659

Also move default assignment of $pconfig['webguiproto'] to 'http' from
system_advanced_admin.php to system_advanced_admin.inc and remove unneccessary
init_config_arr() calls from system_advanced_admin.php.

RemoveUnusedForeachKeyRector runresults

Remove dead statement as per rector

Spelling fixes. Fix #13357

• Incorrect input validation for `dhcp6c` `keyinfo expire` `forever` keyword in `interfaces.inc`.
• Incorrect input validation for associated rule's `Source Port` in `firewall_rules_edit.php`.
• Incorrect `voucher*.` file lock reference in `status_captiveportal_voucher_rolls.php`....

Cleanup some unreachable statements as per Rector.

Merge pull request #4606 from KoenZomers/DNSExitFix

Update/cleanup DHCP 4/6 server text. Fixes #13250

Misc EasyRule updates/fixes.

• Addresses several known issues in EasyRule. Fixes #13445
• Updates syntax to new style for PHP 8.1. Fixes #13627

Rewrite functions for toggle & delete NAT. Fixes #13545

Refine IPsec deprecation behavior. Issue #13648

P1 and P2 entries are only disabled if they have no remaining valid combinations of options. This way tunnels that just had one bad entry selected can continue working.

Replace direct config accesses regarding ssh configuration. Fixes #13645

In system_advanced_admin.inc, use config interface funcs instead of direct
$config access regarding ssh configuration nodes. Also initialize the ssh
section as an array if it doesn't exist in system_advanced_admin.php to prevent...

ipsec: remove warnings about now removed algorithms

Redmine: #9247

ipsec: allow CHACHA20-POLY1305 to be configured

Redmine: #9246

Replace direct config accesses in firewall_rules_edit.php. Fixes #13614

Perform proper input validation on static DHCP mapping additional BOOTP/DHCP Options. Fixes #13584

Fix saving dhcp6c-dns setting in services_dhcpv6.php. Fixes #13594

services_dhcpv6.php: Fix a PHP81 config access error

Remove extraneous and malformed meta refresh tag during proto/port change for web UI. Fixes #13591

Change text in info block on Status > IPsec. Fixes #13398

Fix session timeout expiry. Fixes #13561

Fixed usage of image_type_to_extension. Fixes #13396

Fix PHP error in LAGG pages

Convert RSS Widget to use simplepie via Composer

Fix carp_status.widget.php for PHP81. Fixes #13535

Fix syntax error in system_authservers.php. For #13533

Fix a PHP81 bug in system_authservers.php

Encode path+fn in browser.php. Fixes #13262

DHCP/v6 PHP8 error fixes for some cases.

If a config starts with only WAN, no LAN assigned, there are a number of
tags that were not handled properly on DHCP, DHCPv6, and RA.

Fixed up some other unrelated low-hanging fruit while I'm here, but all
of these files need a lot more work for PHP8.

Fix service status widget listing of non-disabled services

PHP8 updates for resolver host editing

PHP8 fixes for service status widget. Fixes #13506

qinq: use if_vlan rather than netgraph

if_vlan now supports QinQ, so use that rather than netgraph. This is
expected to perform better, removes a subsystem dependency and
simplifies the php code as well.

Note that this is not possible on stable/12.

Fix missing ikeid in created ipsec p1. Issue #13446.

When a new or duped p1 is submitted, $p1ent['ikeid'] is an empty string. Prior
to php 8.0, comparing ($p1ent['ikeid'] == 0) for the empty string would yield
true, allowing the code to properly create and assign a new ikeid by calling...

Allow user to select PKCS#12 encryption. Fixes #13257

Convert P12 export to OpenSSL. Fixes #13257

PHP native method of creating PKCS#12 archives does not support using specific algorithms for encryption, so use the openssl binary instead.

Use AES-256 and SHA256 when encrypting the PKCS#12 data and private key.

Fixes some PHP bugs. For #13446

Fix primary console handling for EFI. Fixes #13080

Tested and working for both BIOS and EFI systems.

Update external http links

Fix some config access bugs in pkg.php for PHP81. Fixes #13446

Replace direct $config accesses in interfaces_vlan_edit.php. Issue #13446

Cert-related PHP 8.x changes.

Update status_carp.php PHP81 for #13446

Update interfaces_qinq_edit.php PHP81 for #13466

Update interfaces_vlan_edit.php PHP81 for #13466

Fix interfaces_groups_edit.php PHP81 for #13466

Fixes some PHP81 related config access issues related to interfaces and interface assignments for #13446

Merge pull request #4612 from zeroflow/master

Rename DHCP status from online/offline to active / idle/offline

Fix checking openvpn client or server config exists. Issue #13446

Captive portal PHP 8.1 fixes Issue #13446

Update pfSense-dark.css

Darken disabled input fields in dark theme. Fix #13390

Add option to list ACB restores in reverse order. Feature #11266

Restart gateway monitor on interface re-assign. Issue #12920

Skip empty gateways on interfaces.php Issue #13446

Fix PHP error on services_dnsmasq.php. Issue #13446

Fix PHP error on services_unbound.php. Issue #13446

Correct typo on include of config.lib. #13446

Remove IPv6 validation for RADIUS auth. Fixes #4154

Rework formatting

Add icons
remove red text for offline
remove bold/italic for both

Add formatting to online status in status_dhcp[v6]_leases.php for better readability. Implements #10345

Adds color & formatting to host online status
online = bold + green
offline = italic + red

Fix missing format specifier in input field help

Replace direct config accesses in status_graph.php, status_ntpd.php

Correct format specifier in input help

Replace direct config array access in diag_packet_capture.php

Add config and config lib requires to guionfig.inc

Fix some missing '/'es in config paths

Replace some direct config array accesses in wizard.php

Correct deprecated implode() syntax

Fix warnings in guiconfig.inc, unexpanded string in get_config_path call

Replace config array accesses in guiconfig.inc

Change some config array accesses in interfaces.php

Fix several unsafe multilevel config array accesses in setup wizard

Silence unused/undef'd variable warnings in filter.inc

Correct required param after optional param syntax errors

Consider EC digest prefix when renewing CA/Cert. Fixes #13437

CRL lifetime fixes to avoid rollover. Fixes #13424

Clean up+encode pkg rule filenames. Fixes #13426

Update UPnP status regex. Fixes #4500

Submitted-By: rtadams89 @ GitHub PR #4610

CA/Cert descr validation fixes. Fixes #13387

Validate description on save when editing and in other situations that
were not yet covered.

While here, ensure that errors when editing a cert leave the user on the
cert edit screen properly, but successful cases return to the cert list....