pfSense

Further fix for tun/tap and topology

Fixed #6236

Merge pull request #2883 from NOYB/Periodic_RRD_&_DHCP_Leases_RAM_Disk_Backup

Add 200000 to max cache while we're at it. Ticket #6230

Feature #6230 Increase Unbound Host Cache

This is very easy to do, if people are happy to have 100,000 as an option.

WArn user on selecting non pfSense theme/css

Fix #6173 Refactor NAT Edit src type matching

1) Remove a couple of unused calls to is_specialnet()
2) Change srctype_selected() to use a similar scheme to dsttype_selected() to decide if the existing value matches one of the dropdown list items.
3) Items like "WAN net" and "LAN net" in the src type dropdown were showing as just "WAN" and "LAN" in the dst type dropdown. Fixup the build_dsttype_list() code so it does the same as build_srctype_list() when making the text for those interface networks.

clean up jquery-ui themes and add images

Show insertion point icons only if one or more rules have been selected

ALternative fix for #6092 uses icon to indicate insertion point rather than cell border.

Do not try to show files that don't exist anymore on 2.3

Updated #6092 as requested

Merge pull request #2894 from NOYB/Services_-_Punctuation

Services - Punctuation

Clean up some services menu punctuation.

Fix #6173 Use correct list of special nets

is_specialnet() was only using a smaller list of "special nets", so when you have a VIP as the selected special destination it was not matching it up on edit, and thus "forgetting" the special VIP selection.
build_dsttype_list() already makes a good list of special destination types. That list includes all the "special" VIPs.

Password isn't required for growl. Ticket #6221

Add validation of address family and protocol combinations. Ticket #6219

Add validation of address family on IP aliases with CARP parent. Ticket #6218

Move the install cron job calls into an if/else so they are not added then immediately removed.

Periodic RRD & DHCP Leases RAM Disk Backup

Remove these cron jobs on full install if not using ramdisk.

Fix text style

Fixed #6214 by splitting the "Client settings" section into "Client settings" and "Advanced client settings"

Allow upload of favicon.ico without prefix adding

Merge pull request #2890 from phil-davis/patch-4

Merge pull request #2889 from NOYB/Firewall_-_Punctuation_-_Clean_-_Up

Fix #6212 Really disable checks

Belts and braces here - I the setTimeout is not done then the other bits of code do not get called anyway, but I took them all out to make sure there is no way to accidentally do the update check when it is disabled.

Fix validation of v4 in v6 rules and vice versa. Ticket #6211

Fix selection of dsttype in configs with VIPs defined. Ticket #6173

Firewall - Punctuation Clean Up

Some punctuation clean up.

(diag > edit file) page styling

(diag > command prompt) page styling

pad button groups

Setup HTTP_PROXY environment variable for pkg when it's called from the GUI and also for pfSense-upgrade

Fixed #6095 remove logo from wizards

add jquery ui themes for status monitoring

Make sure FreeBSD repo is disabled on a static file tracked by base package

Merge pull request #2882 from phil-davis/patch-4

Merge pull request #2880 from LucaTNT/patch-1

Merge pull request #2879 from NOYB/Firewall_NAT_-_Remove_Pencil_Icon_From_Aliases

Merge pull request #2875 from NOYB/Interfaces_-_Punctuation

Use English spelling for var name

For future maintenance it might be easier if this var name is spelled with the usual English spelling.

Merge pull request #28881 from phil-davis/patch-4

Fixed #6175

pfSenseHelpers white space formatting

Just a bit of white space and formatting to standardize this code, and a couple of typos in comments.

Added back GET parameters support (as in pre-2.3)

In version 2.3 the Traffic Graph page switched from GET to POST parameters to control the graph.
This patch restores the old functionality, which was useful to bookmark a given graph configuration.

Fixed GPS display sprintf => printf

Removing focus from the anchor gets rid of the annoying dotted box

Update widget to POST link

COmment fix

Make services POST only by providing JS code in pfSenseHelpers.js

Merge pull request #2866 from NOYB/Firewall_/_Rules_-_Underscore_Line_Wrap

Trim the OpenVPN tunnel network before use, and on save. Fixes #6198

Fix an oops.

Firewall NAT - Remove Pencil Icon From Aliases

Don't see the icon adding any value. Consumes space and clutters page. Make consistent with the firewall rules page.

Remove redundant if check.

Interfaces - Punctuation

Merge pull request #2871 from NOYB/System_/_Advanced_-_Punctuation

Unset dhcpdv6 for deleted interfaces on interfaces_assign.php. Ticket #6152

Allow 0 mask on Unbound ACLs. Ticket #6073

Avoid implode error if no interfaces are selected.

Fixed #6171

Fixed #6169
and added alias pop-ups to load_balancer_virtual_server.php

Fixed #6168
Needed to override form action since it was inheriting the current GET arguments

Fixed #6170

Fixed #6158
Really a temporary work-around. This issue requires a better solution in which the data is normalized and added to the <td> via a data-sortable attribute.

Fixed #6161

Merge pull request #2870 from phil-davis/patch-4

Fixed #6163

Fixed #6166

System / Advanced - Punctuation

Fix #6162 saving of bogons update frequency

Another easy fix of a "dumb bug".

Use RFC-defined capitalization IPsec.

Merge pull request #2867 from phil-davis/patch-4

Nuke srctrack default = 1400 per JimP

Fixed #6146

Allow to restore any ares of config

If the existing config does not have a particular area in it, then the user should still be able to restore it from another config.
Redmine #6144

Firewall / Rules - Underscore Line Wrap

Replace underscore with space in display text of certain fields to allow them to line wrap. ex: long alias names

Fix Namecheap DynDNS host parsing for @, fixes #6122

Merge pull request #2863 from phil-davis/widget-arrows

Fixed #6128

Use consistent arrow colors on dashboard

Interfaces widget and IPsec widget use text-success and text-danger to
make the up and down arrows be green and red.
This change does the same thing to OpenVPN and WoL widgets for
consistency.

Cosmetics

Fixed #6117

Merge pull request #2862 from NOYB/Services_/_DHCP_Server_-_DNS_Servers_Clarification

Fixed #6114

Fixed #6112
by adding isset() to checkbox value

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Fixed #6096

Fixed #6092

Fixed #6104 by changing trash icon to trash-o icon so that the JA configmation is not triggered.

Merged #2854 and updated to increment only the deleterow button

Fix add delete of rows with buttons

Redmine #6101
Forum https://forum.pfsense.org/index.php?topic=109554.0

Merge pull request #2860 from phil-davis/ipsec-keys-infobox

Merge pull request #2859 from phil-davis/patch-7

Merge pull request #2858 from jlduran/fix-ipsec-spd-arrow

Merge pull request #2856 from phil-davis/patch-5

Merge pull request #2855 from NOYB/System_/_General_Setup_-_Remove_Beta_Badges

Merge pull request #2853 from NOYB/Miscellaneous_II_-_Remove_Personalizations

Make VPN IPsec Keys messages proper infoblock

Redmine #6107
Note: I made this text be open by default on the edit page (blockopen)
because maybe users should see it by default.

Make forwarder info boxes consistent with resolver

DNS Resolver just has a single info box at the bottom of its settings page.
DNS Forwarder has different print_callout stuff that looks inconsistent with the rest of the GUI pages.
I have made it consistent with DNS Resolver, which does not have those bits of text describing host and domain overrides....