pfSense

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

(cherry picked from commit 6d028dc26c129ce1b0b25551142819772664f1e5)
(cherry picked from commit c7fd6ec9b196b0d7c37d14dad13f745dab82420d)...

fixed #7795
By changing var name to no longer conflict with ipsec widget

(cherry picked from commit 3ed475b11dfcb2999a71195987495ccf05808127)
(cherry picked from commit bc2772c18ef2aa9a32b941fcf79c0c160fad7666)

Eliminate unused functions from functions.inc.php

(cherry picked from commit 0f2d956be7d14f87776727ab476a4e47a51f6646)

Backport 2.4 getstats format for ease of maintenance

(cherry picked from commit 96d3d096a3c4c4d4cbc81befde9dbb3977c30a55)

Fix system information widget display order

(cherry picked from commit 135da15564e9efb33044195719e4296e86951d87)

Avoid JS error by always rendering mobile ipsec DIV, even if empty

(cherry picked from commit 60138edbd4d7740c2d140e0d8fb4c5ee945db9e5)

Merge branch 'RELENG_2_3_4' of gitlab.netgate.com:pfsense/pfsense into RELENG_2_3_4

Fixed JSON format in IPSec widet per Kill Bill (Thanks!)

(cherry picked from commit 2438b40dceaff2a23638be66018f8c9dc46d2e01)

Revise CPU load display to eliminate sleep in AJAX call

(cherry picked from commit c4ec696bf9eae3f8dbbad30b2e0804b9bf7de4b6)

No longer experimental so comment removed

(cherry picked from commit 2ef62d38adee7126141c1b54489cd191f59adc54)

Speedup package related calls to get_pkg_info() since now we have a script that update metadata periodically

Don't automatically update CIDR masks if the selector is disabled

(cherry picked from commit a379a5ff12b170df3a27e643794e576caf316a44)

Hide dashboard update period control. No longer needed with central refresh system

(cherry picked from commit 5e024279579ec76486f7cff713eecdb83611ed37)

Convert firewall logs widget to centralized refresh system

(cherry picked from commit a8c2e827cfeaf74bc99227e087584eefb2c466f2)

COnvert thermal sensor widget to central refresh system

(cherry picked from commit 032f6a8963a51195946b6a823967d31af5fffbe0)

COnvert dyndns widget to central refresh system

(cherry picked from commit 5efa7cae2f2df4974c7de19f00fe5b669fb73485)

Added refresh icon to version display

(cherry picked from commit b7a42d09d7ef010b34d6570fb5398b4f98f397b2)

Add refresh icon to system info widget version display

(cherry picked from commit 1557953af1d3a47bc508986688f0b285fa2b43e1)

Show user when pkg metadata was updated

Remove dead code using in the past to migrate from pfSense-repo-devel to a single pkg called pfSense-repo

System info widget prepared for background version checks

Re-wrote ipsec widgt to return JSON formatted AJAX data

(cherry picked from commit 067109d9fd64d8958408c7f9aaf30523319be91a)

First part of dashboard update system

(cherry picked from commit 8f3a49d7e9c22af2c97f92007aa23d2a45c8e697)

COmpleted conversion of dashboard widget to ventralized refresh system

(cherry picked from commit fe0eb5b1112791cf28e98e00757c4645d6b9234a)

Adding widget and login css files

New login design back-ported from 2.4

(cherry picked from commit 1605d94079fed5822ef1069eee05541d0ebc20ca)

Restructure how unbound zone data is written to fix processing of "redirect" zone entries. Fixes #7690
Also corrects some other misc issues for formatting of zone data.
While here, add an option, not exposed in the GUI, for users to get the previous behavior of defining short names for hosts....

Improve the way the auth server list is generated and account for a key being removed from the array when deleting. Fixes #7682

(cherry picked from commit fa628b1a15a1c03343caa2735e09de291ae4e382)

Remove extra spaces from User Agent

Send uniqueid instead of UUID on user-agent

Move uniqueid read to a function system_get_uniqueid()

Update diag_gmirror.php

Fix typo

(cherry picked from commit 55588e0ce32865568522e0afd0b577fdfabd3b74)

Issue #7659 foreach warning on adding gateway RELENG_2_3

Signed-off-by: Phil Davis <phil@jankaritech.com>

Fix interface groups link

(cherry picked from commit c0dd390b666d86b6b9ea61438c95b1370adda052)

Removed htmlspecialchars when loading leases from config
(cherry picked from commit 2322e9f3cb6dea9203d63a17c6a27de3a2c6b8bc)

(cherry picked from commit b4ff414aef9f43dce0931974dd18e28a19cdadda)

Add missing break for cloudflare case
(cherry picked from commit d900381c9384676462c91c0b2e7e59ec42723237)

(cherry picked from commit 2c4865e3fa05cf589891304933fa414a58381261)

Integrate various cloudflare changes
(cherry picked from commit 5ce6ce4b1ad850e70d5a2fe218317b1a1b545907)

(cherry picked from commit 543ea703f2dd41e53a746772332eb83bfb8ead3e)

Add more checks to eliminate empty config tags in package settings. Fixes #7624

(cherry picked from commit de147d3d614c877df2022d85d37256a93047764c)

pkg_edit, fix empty config tag check

(cherry picked from commit 6bf2a65086f7664c870a9565b70c39655c2a3dcf)
(cherry picked from commit eb65e543b4d04b29ee494fe8d3710213e0fddf23)

Change paid support help link to new support URL

(cherry picked from commit 16bf962333c3897170defb6bf95a2d69c7fdf506)

virtualips, ability to sort the table

(cherry picked from commit 77c53e65fb7d4f40baec5c01a796a637c9cc5034)
(cherry picked from commit 3af287f33a0ccf9de34e6dab8d1284c584ed0b37)

Diag DNS disable Add Alias button when host field is changed

(cherry picked from commit 45eafdbd7b958bd4f9459d90a6a63ff8202eec3b)
(cherry picked from commit 2e294992e4151a80a7d57aa4afabc12b9375539f)

Diag DNS fix update alias button text after add alias

1) Lookup a name with Diag DNS
2) Press "Add Alias"
The alias is added, but the button still says "Add Alias".

Actually the alias exists by now. The button should say "Update Alias".

Fix: once we have emitted the alias create/update success message, we can set $alias_exists true so that the rest of the code is based on the (possibly new) state.(cherry picked from commit 474b275684950ab8215b449987d4cbece005f9ed)...

Diag DNS do not show Add Alias if no priv to add alais

(cherry picked from commit 7fcccc8f09afd7f4a524ff598b43e15d678905eb)
(cherry picked from commit f54a3ede59ee819500f272ea87b244b7ab949e41)

Diag DNS do not create an empty alias if name does not resolve

(cherry picked from commit f445385114c43cb46b8188a7cea425648f7647f2)
(cherry picked from commit 14e90f2e5d34ca34cf226ece4f8fcb4fb6c943fa)

Remove stray debug-code (/tmp/script)

(cherry picked from commit a29361a2d94eed754255e75d63d511e7889d6c9f)
(cherry picked from commit 12ca33f4dc915c37eeee4b6b86c7daa399fdad91)

Make consistent rule information section

(cherry picked from commit f0dc8b688c2b7d973bc18769579ee8cc6d3d2dad)
(cherry picked from commit 4c4504b1e785396d92be853072a9c557c55b3c4a)

Add input validation for interface names on firewall_nat_edit.php and fix encoding of the interface name in dst_change. Fixes #7651

Fix handling of the 'type' parameter so it is validated and encoded on diag_table.php. Fixes #7652

Prevent the filename from being used to run XSS in the diag_edit.php file browser. Fixes #7650

Restore the captive portal feature to view the captive portal page directly from the portal web server. Add this as an additional button so both methods are possible. Fixes #7646

Redact BGP MD5 password/key in status output. Fixes #7642

(cherry picked from commit aa18c5b9b62e110ebf88fbb24c39c2a13813bd89)
(cherry picked from commit 4122033534b5dd927cd5678cbe8b00267438dd44)

Add download button/function directly on status.php to ease confusion.

(cherry picked from commit f7a72733f8c482e230e0042a6c65f4935a2b723a)
(cherry picked from commit b44ee60da886ae7eb7862d298d8018e94515d945)

Add NGID to status.php

(cherry picked from commit fcc24426ab16b02ffc77bc7c9ee040d76dd987a2)
(cherry picked from commit 2e7f67b274960210ef2d606f72b7bfee22c1b1c7)

Backport syslogd service definition/control to RELENG_2_3. Ticket #4382

(cherry picked from commit 5917696ded82c3343d52c03b850d4ce564a159b4)

Add "netstat -nWx" to status.php output

(cherry picked from commit 6252b47062a3bf2be19a43be480fd0acd56b75d0)
(cherry picked from commit 5479efd16933d28d697b499b1229a49554b8a645)

Only cache CP RADIUS Auth credentials when reauthentication is enabled. Fixes #7528

(cherry picked from commit d4e42c54a2b7d9c955b11ad3034a186a73159f1a)
(cherry picked from commit ed44d5fb36f1f69196417e3feab2a9d6df4a47c8)

Welcome pfSense 2.3.4-RELEASE

Typos in pkg management code comments

(cherry picked from commit 146dbf0139d1f3049131bdf7a7d96675e4ff00a4)

Let he user know if all selected interfaces are down

in the interface statistics widget.
At the moment, if all the selected interfaces are down, the widget will just display no columns. That will make users wonder what happened.
(cherry picked from commit b22fceb2d7973b8c80a55b4ec492819ddd5ae9f9)

Fix interface down in interface statistics widget

If an interface is down, the widget would write the interface description in a column heading but then omit the stats items. So later columns (to the right) would have the headings and stats items out of line....

Redmine #7318 None button for widget filters

(cherry picked from commit fba53b438540eb544c43adf4598e07320a910347)

Handle widgets having no items selected for display

(cherry picked from commit 405dfaad144de90a6e401354b80b82baf5ae3d59)

Remove bonus end td tag in interface statistics widget
(cherry picked from commit 9795332b0e101b4c500c3c75a8ea02325364fc17)

Make sure that array exists before using foreach() (Bug #7399)
(cherry picked from commit ce348731b63ea6980dc4f652e76d7c8c7432544c)

Spelling

space/tab

Add Netgate ID display to system info widget

Read default language from globals.inc instead of hardcoding (it was already defined there)

Set default anguage in General Setup to en_US

Since https://github.com/pfsense/pfsense/commit/fdcde31b4a910c4e058513c1e3f68a62e722da6b added German to the top of the get_locale_list() array, if you start with a default system and go to System->General Setup (make some changes to other fields if you like) and press Save, you end up in German because that is what gets selected in the dropdown when the config does not yet have a language in it....

Checks for DHCP Relay being enabled/disabled should be skipped when editting an additional pool

Encode hostname and other output for DHCP lease status. Fixes #7497

(cherry picked from commit a260eda55905607e9adfd5d7c3fd779b115459d5)

Always add the CN as the first SAN when creating a certificate in the GUI or an automatic GUI self-signed certificate. Per RFC 2818, relying on the CN to determine the hostname is deprecated, SANs are required. Chrome 58 started enforcing this requirement. Fixes #7496

Add expiration field to NDP listing

(cherry picked from commit fec2c3b73f05683b674d3b5351529268eadc8dd9)

Fix #7493 only check interface IP if static

(cherry picked from commit 8c6190e82f83a7907ec2757e72d9a8eac496dd61)

Avoid invalid arg error when saving WoL widget

when there are no WoL entries
(cherry picked from commit 66a5b767b1b533f6ce508a125404a2d8e3353c41)

Update services_dyndns_edit.php
(cherry picked from commit df4c21fc24cc6ff38988ca866928f2f73b97b744)

trafficgraphs, divide bandwidth by time when statistics where gathered to smooth out bumps in the graphs

(cherry picked from commit eddb01316c7ad06c1798e629b6158db505a86118)

ipsec overview, check label exists for interface including disabled ones, tell what was configured if not found.

(cherry picked from commit ac24ac6bbb5b94e1eb8420404a9b7bd9daf998b7)

ipsec webgui, move building the $iflabels array outside if the loop

(cherry picked from commit 11b9896609c2998106d5503fe2581bb3304b4a5f)

notify test buttons for smtp/growl should use new unsaved settings just made

(cherry picked from commit 64f8ec62ddd57241e4a8a755cade7ca8cd9196a6)

Do input validation on the actual array passed in

I was tearing my hair out for a while. If do_input_validation() is passed some array of keys/values that has been assembled elsewhere (not $_POST, $_GET or $_REQUEST superglobals) then it does not work. The code here, for at least the last 7 years, has actually been checking the array keys in the "hard-coded" superglobals. That is a bit surprising, since the array to be checked is passed in as $postdata parameter....

Escape IPv6 when passed to ndp delete command

(cherry picked from commit 1d92faa34f7c9aaa97b1983f273d2d73285befb5)

Add ability to delete NDP entry

(cherry picked from commit 13105d9c79fe3ac8be2b01c152fb9fb6a95147b4)

Remember original alias name on edit input errors

(cherry picked from commit 1271754326fe648093204296652398b1edd24912)

Refactor update_alias_names_upon_change

(cherry picked from commit 24807bfeaec218948937a1fdc2b4e863319e41a0)

Revise dev_mode change handler

(cherry picked from commit 8a0af41adc9c29ccf7b8dabb3b7658abf46054a6)

Fixed #7451
Revised onchage handlers to obviate need for second click in Chrome on MacOS

(cherry picked from commit dd3c646fa5744a550f91524035a92f509d6162cf)

Revert "Restore CSRF customizations"

This reverts commit 1d7a414705794f2527dc1b7b3bb5419db1024bb6.

Revert "CSRF: Close session before exit"

This reverts commit d2495e5893baa63b2973b66f7c1b9787fada2e30.

CSRF: Close session before exit

On CSRF, call phpsession_end() before exit to avoid syslog warning
about open session

Submitted by: PiBa-NL

Restore CSRF customizations

Update CSRF to latest version from github

Fix UTF8 in base64 decode

(cherry picked from commit 557e082696823ea5fa09a36d98f01775bf1e0c77)

Adds ability to ignore DHCP offers from multiple servers
- Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
- related dhclient source:
https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945

changed files:...

Typo fix

Disallow IPv6 for RADIUS server.

See https://redmine.pfsense.org/issues/4154. No need for users to waste their time with debugging packets black hole.

Merge pull request #3613 from doktornotor/patch-15

Fixed #7445
Now properly handles service names that contain hyphens

(cherry picked from commit 21a8edd7836baf1e4ee2f347fdc1bafb4d96c9d9)

Merge pull request #3687 from doktornotor/patch-1

(cherry picked from commit 7c820a5d1ddb0ecf66ccaf1c4c82cc6361e15a6b)