pfSense

Merge pull request #2809 from NOYB/Firewall_/_Rules_-_Remove_Personalizations

(cherry picked from commit 1cde3afb4c048f66ffd670c373a14d3d3cfa2a71)

Merge pull request #2808 from NOYB/Firewall_/_Aliases_-_Remove_Personalizations

(cherry picked from commit e8ea99014a38450ae28d58a6daf0cc60a33ff1e0)

Allow configuring RAs when DHCPv6 Relay is enabled. Ticket #6063

Remove one call to SetAvailableBandwidth() that I missed earlier.

Fixes the shaper setup on fresh installs.

Ticket #6042

Bring back rainterface, add config upgrade to convert to new _vip format. Ticket #6043

Add translations for group type selector

Clarify error message by including group type

Preserve group name on input error

Revised scope handling to allow user to set to remote or local, but only if it is not currently "system"

(status > DHCPv6 Leases) make tables responsive

clean up header on small screens

(status > ipsec) clean up css

Fix logic for RRD and DHCP leases backup, and fix wording in the placeholder text. Fixes #6040

Use correct subnet mask for IPv6. Fixes #6039

Merge pull request #2806 from NOYB/Interfaces_(assign)_-_Remove_Personalizations

Merge pull request #2805 from NOYB/System_/_User_Manager_-_Remove_Personalizations

Merge pull request #2804 from NOYB/System_/_Routing_/_Gateways_-_Remove_Personalizations

Merge pull request #2803 from NOYB/System_/_High_Availability_-_Remove_Personalizations

Merge pull request #2802 from NOYB/System_/_General_Setup_-_Remove_Personalizations

Interfaces (assign) - Remove Personalizations

Remove "you" personalizations.

System / User Manager - Remove Personalizations

Remove "you" personalizations.

System / Routing / Gateways - Remove Personalizations

Remove "you" personalizations.

System / High Availability - Remove Personalizations

Remove "you" personalizations.

System / General Setup - Remove Personalizations

Remove "you" personalizations.

System / Certificate Manager / CAs / Edit - Remove Personalizations

Remove "you" personalizations.

Add brackets for clarity

Add some extra brackets for clarity, rather than relying on the operator
precedence rules. IMHO this makes it more readable, and no need for the
reader to wonder if anything might go wrong with the operator
precedence.

(status > ipsec) clean up css

Fixes the shaper wizards to split the bandwidth correctly.

With P2P catchall disabled, the qLink queue (using 20% of root bandwidth) was not taken into account.

Decrease 20% of qInternet bandwidth queue in this case.

Ticket #5721

Further text refinements for PR 2790

Merge pull request #2790 from NOYB/Interfaces_-_Word_Smithing

Merge pull request #2798 from NOYB/System_/_Advanced_/_Notifications_-_Remove_Personalizations

Merge pull request #2797 from NOYB/System_/_Advanced_/_Miscellaneous_-_Remove_Personalizations

Merge pull request #2796 from NOYB/System_/_Advanced_/_Networking_-_Remove_Personalizations

Merge pull request #2795 from NOYB/System_/_Advanced_/_Firewall_&_NAT_-_Remove_Personalizations

Merge pull request #2794 from NOYB/System_/_Advanced_/_Admin_Access_-_Remove_Personalizations

Swap the colors on Diag > Command back. Executing is dangerous, hence the warning.

Fix display of PPP "uptime" (the word "uptime" was missing from output).

Apply "Editor" Phil's corrections.

Thanks Phil.

System / Advanced / Notifications - Remove Personalizations

Remove "you" personalizations.

System / Advanced / Miscellaneous - Remove Personalizations

Remove a bunch of "you" personalizations.
Typo and sentence spacing.

System / Advanced / Networking - Remove Personalizations

Remove a bunch of "you" personalizations.

System / Advanced / Firewall & NAT - Remove Personalizations

Remove a bunch of "you" personalizations.

System / Advanced / Admin Access - Remove Personalizations

Remove a bunch of "you" personalizations.

Merge pull request #2791 from NOYB/Interfaces_-_Section_Title_-_Reserved_Networks

Background all the ipsec commands run from status_ipsec.php to make sure they don't hang up the entire GUI. Ticket #5520

Remove "we" personalizations.

Interfaces - Section Title - Reserved Networks

More accurate section title.

Remove errant line.

Interfaces - Word Smithing

Word smithing to remove a bunch of personalization ("You").

Show the full OpenVPN verb debug range same as 2.2.x.

Clarify OpenVPN verb level descriptions

change logos to reflect community edition

HTML Compliance - Firewall / Rules

Error: Duplicate ID frrfc1918.
<tr id=frrfc1918>

Fix display of gateway IP address and gateway/group descriptions in firewall_rules_edit.php.

Merge pull request #2781 from jlduran/fix-openvpn-client-typo

Fix OpenVPN client additional options typo

Should read client instead of server. Also remove the `push` example.

HTML Compliance - Vertical Align

pkg.php and functions.inc

One too many "!" in the "Advanced options" button javascript caused the Link parameters to be always hidden

Fix syntax error in diag_traceroute

The semi-colon is not needed here.
Reported by forum: https://forum.pfsense.org/index.php?topic=108643.0

possible typo

Fixed #6017

The zone parameter needs to be in this html example for CP.

Merge pull request #2773 from NewEraCracker/small-php-js-tweaks

Merge pull request #2772 from NOYB/HTML_Compliance_-_Diagnostics_/_Test_Port

Merge pull request #2771 from stilez/patch-20

Merge pull request #2769 from phil-davis/btnattr

Merge pull request #2768 from phil-davis/patch-3

Echo boolean value instead of string

Prior to this change, code would echo an empty string if false and 1 if true. In all other files, with similar code, boolean representation is printed.

HTML Compliance - Diagnostics / Test Port

Error: Start tag seen without seeing a doctype first.
Expected e.g. <!DOCTYPE html>.
Error: Stray doctype.
Error: Stray start tag html.
Fatal Error: Cannot recover after last error. Any further errors will be ignored.

Remove apparent pointless function (2nd occurance)

replace apparently pointless function in 2 files

Code loops through all return values of get_possible_traffic_source_addresses(true) to create a list of key=>descript list, but the original function returned exactly such a list anyhow with no other data associated with the keys. So the code seems pointless as it replicates exactly the original return value from possible_traffic_source_addresses()....

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Allow moving last pool entry

If you are moving load balancer pool entries back and forth between the enabled and disabled pools, you can't move the last entry in the disabled pool back to the enabled pool, which you should be able to do.
This change also gives the user flexibility to move the last enabled entry to the disabled, that is helpful if the user is just moving entries around - e.g. putting everything into disabled then adding 1 or 2 back to the enabled. On save, the validation checks that the enabled list has something in it, so the user can;t actually save an empty load balancer pool anyway.

HTML Compliance - Firewall / Schedules / Edit

Error: Duplicate ID tempFriendlyTime.

Reconfigure any VLANs with a lagg parent after recreating the lagg. Ticket #6014

Changed the button colors and icons. The fa-terminal wasn't doing it for me :)

Partially fixed #6012 by removing space from chars allowed in group names

Services / DNS Resolver / General Settings

Static should be static.
Elements that don't need to be dynamic should be static.
More robust than depending on client-side processing to set them.

Suppress dashboard save icon until needed.

GIF had the same problem as GRE with flags, apply the same fix. Ticket #6010

Correct the code saving values for GRE. The GRE configure backend code tests for isset, the way the values were copied before it would be set to 'false' which was still set, so the code always triggered when it shouldn't. When reading back from XML at boot time it's OK, so only the web interface is affected. Fixes #6010

Merge pull request #2718 from NOYB/JavaScript_Polyfill_-_String_Includes_Method

Merge pull request #2757 from NewEraCracker/allow-ip-as-althostname

Much cleaner like this.

Services / DNS Resolver / General Settings

Echoing $pconfig['custom_options'] directly into JavaScript is prone to breaking the script by creating invalid syntax due to characters such as line feeds etc.
Best to transfer a flag from PHP.

Use correct variable for the remote ID in IPsec status. Fixes #6009

Add PCI and USB device lists to status output

Temporarily disable PR 2750 pending revision by NOYB

Merge pull request #2762 from phil-davis/patch-4

Redmine #5994 Enhance test for PPP advanced defaults

If pppoe_monthly, pppoe_weekly, pppeo_daily or pppoe_hourly was already set, then when editing the PPP interface the advanced fields were not automagically displayed. They should be, because the user needs to see these settings if they are there....

Redmine #5994 Fix test for default source port fields

Fixes the problem reported by Jim Pingle where the Advanced button for the source port fields would show "Hide Advanced" when creating a new rule from scratch. Now when creating a new rule, it starts off as "Display Advanced" (with the source port fields hidden.

Fixed #6003
Corrected showadv logic
Corrected long standing iussue displaying reset times (goes back to 2.0)
Corrected config save by adding hidden ptpid

FIlebrowser package moved to vendor direcroty

Relocated tree directory to vendors/tree

Revised fix #6007

Fixed #6007
Initilize element before refreshing

Remove unneeded control

Merge pull request #2755 from NOYB/HTML_Compliance_-_Services_/_DHCP_Server

Merge pull request #2758 from phil-davis/patch-4

Merge pull request #2754 from phil-davis/patch-3