pfSense

Fixed #5807

Further refinement to timeout message

Revise reload countdown for internaionalization

Merge pull request #2540 from NOYB/HTML_Compliance_-_Firewall_Rules_-_Separator

Merge pull request #2539 from NOYB/HTML_Compliance_-_Widget_-_Firewall_Logs

Status / System Logs / Firewall / Dynamic View - Efficiency Tweaks

Not very efficient to go through the entire table setting the class on existing entries that already have their class set. Just set the class on new entries when they are added to the table....

HTML Compliance - Firewall Rules - Separator

The font element is obsolete. Use CSS instead.
<font class="bg-danger">The Bad</font>

HTML Compliance - Widget - Firewall Logs

Attribute (that|triggered|this|action) not allowed on element a at this point.

Tidy print_info_box comments

Fix up config setting for killing states on gateway failure. Enable this option where gw_down_kill_states is set. Flip setting accordingly during config upgrade to not use confusing 'kill_states' tag to not kill states. Ticket #5815

Added some some comments to hte print_info_box area so package developers will know what happeded

Completed #5787

Apply gettext to javascript countdown message

Internationalization of pkg*.php

Various sentences were being built up from gettext() of individual words
or phrases concatenated together. That will not work for translation to
languages with different word order, so I have restructured that.
Note: TODO: The countdown timer text with seconds countdown is all in JS...

When the protocol is set for CARP, tell tcpdump to interpret it as CARP for more accurate output.

Merge pull request #2533 from phil-davis/rowmoved

Add leaving page message to NAT pages

These pages use the draggable/sortable rows stuff, so could use the same
warning message if the user tries to change page before saving

Remove no longer needed function

rules -> widgets

Typo

Merge pull request #2524 from NOYB/Status_/_System_Logs_/_Firewall_/_Dynamic_View_-_Tweaks

Merge pull request #2529 from phil-davis/patch-7

Typo

Widget - Firewall Log - Tweaks

Add a table row when there are no entries to prevent scroll bars after ajax update.
Add no logs to display message.
Add update interval configuration setting.
Add configuration form placeholders.
Don't include ':' when no port such as for ICMP....

pkg.php consolidate else-if statement

Merge pull request #2527 from phil-davis/patch-5

Add gettext to icon title

evised #5796

Completed #5796

Fixes the GUI URL in the last step of the setup wizard.

The SERVER_NAME variable is not available anymore, use HTTP_HOST instead.

Merge pull request #2025 from apilloud/dhcp-ignoreunknown

Merge pull request #2532 from brunostein/add_call_gettext_function_menu_services

add call gettext function in the services menu

Merge pull request #2531 from phil-davis/patch-8

Merge pull request #2526 from phil-davis/gtinterfaces

Internationalize pkgmgr_installed

Note: I enhanced the title text of the remove/update/reinstall buttons to include the package name.
Before that, when you clicked to remove a package there would be a popup that just said "Are you sure you wish to remove?" - which looked a bit odd.

Enhance error output when package file not found

I had a system that had upgraded but the Notes package had not managed to (re)install. In that situation the Notes item is on the Status menu but there is no notes.xml or other notes code on the the system....

Save selected wireless interface

This looks like a bug. I don't have a system with the necessary hardware running 2.3 right now to really test, but the code that processes the submit/apply looks for $_POST['if']
Please double-check on suitable hardware!

Internationalize interfaces UI code

interfaces_vlan_edit finish QinQ error message

The error message here just ended mid-sentence. I think what I have done here makes sense?

Fixed #5810

Fix PR syntax error

Status / System Logs / Firewall / Dynamic View - Tweaks

Don't run through the update table rows routine unless there are new rows to be added.
Handle special case when beginning with zero rows.
Remove classes listMRodd and listMReven. They don't exist and are handled by the table-striped class....

Merge pull request #2520 from NOYB/Status_/_System_Logs_-_Filter_Refinements

Merge pull request #2519 from dennypage/master

Merge pull request #2518 from ExolonDX/branch_01

Merge pull request #2516 from phil-davis/l2tpinfoblock

Rename function to better represent what it really is.

Fix a couple consolidation issues.

Force firewall dynamic view to use the raw mode table header so it gets updated.
Add a couple missing variables.

Make text-warning more yellow, less red

Fixed #5805

Lower contrast paneal headings

Merge pull request #2522 from phil-davis/printinfoboxcleanup

Merge pull request #2521 from phil-davis/patch-2

Remove print_info_box_np

Put the real code into print_info_box, adding just a $btntext parameter
to the existing 3 params of print_info_box.
Change the remaining print_info_box_np() calls to use print_info_box()

Note: The previous code also had a "bug" - the "apply" button said...

Consolidate log filter code and log table header code in to common functions.

Fixed #5802
Added collapsible action to config backup

vpn_openvpn_server change print_info_box_np to print_info_box

I missed this one yesterday - the aim is to get rid of all print_info_box_np soon, if I can.

Status / System Logs - Filter Refinements

Use advanced filter in firewall dynamic view even if raw mode is set. Raw mode is not applicable to the firewall dynamic view.
Update the count in firewall dynamic view.
JQuery the actual count in raw mode instead of just displaying the max setting value....

Switch to disabling strongswan unity plugin by default. Ticket #4178

Fix alignment problems resulting from tabification being performed inside strings

Tidy up "firewall_rules.php"

- add missing closing anachor tags
- close input tag correctly
- add missing closing TD tag
- remove invalid ALT

Relax shaper wizard interface validation when there are no interfaces with gateways selected. Fixes #5424

Fix indent

Fixed #5797

Make L2TP VPN reminder text an infoblock

Restore code from bad merge

Correct this function call. Fixes #5799

firewall_aliases add print_apply_box code

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Only the serial enable/disable and primary console selectors should be hidden for this test, the serial speed selector must still be available.

Merge pull request #2513 from ch1c4um/replace_jQuery_to_$

Replaced jQuery to $ in same files

Relocate subnet mask drop-down to a more sensible place on the PPPoE server, add a user login count option.

Use default log file from pfSense-upgrade when it's called by GUI, this will make sure we preserve first part of upgrade after reboot

Make diag_arp info an infoblock

I might find a few of these while looking at various print_info_block calls, but this one for a start that works well as infoblock blockopen.

Merge pull request #2510 from brunostein/add_call_gettext_function_menu_vpn

Make sure LANG = C for pkg calls

Move set_language() call back to guiconfig.inc since it's causing trouble on console

replaced jQuery to $

add call 'gettext' function in the vpn menu files

Merge pull request #2502 from phil-davis/patch-6

Replace "jQuery" with "$" for consistency

add call 'gettext' function in the status menu files

Fixed #5793

Remove redundant alias check and move group check to proper place, fixes #5795

Do not let interface description to have same name of an interface group. Fixes #5795

Merge pull request #2503 from NOYB/Form_Group_-_Empty_Title_GetText

Merge pull request #2494 from phil-davis/patch-2

Merge pull request #2500 from NOYB/Firewall_Log_Widget_-_Revert_Abbreviation

Adding {} to if statement.

Merge pull request #2505 from phil-davis/patch-5

Cleanup crash_reporter Submit checks

When looking at this earlier I never paid attention to the left side of each of these conditions. It is pretty dumb to gettext($_POST['Submit']) and then compare it to gettext("Yes") !!!
This cleans it up so it does just an ordinary comparison - works fine.

Merge pull request #2504 from phil-davis/gettext-widgets

Internationalize dashboard widgets

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext....

Be more flexible on detecting the need for the Apply button

This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794

Merge pull request #2501 from phil-davis/patch-5

Don't show RTT, RTTsd, Loss for unmonitored gateways

Crash Reporter compare choice with language-specific string #5792

I don't really understand why this has to be - the HTML has value="Yes" and value="No" - I thought those would be the strings sent along with "submit".
The translation of Yes and No should have been just for display purposes....