pfSense

Remove executable bit of .inc found in www

Clean up another closing tag followed by opening

Clean up dead code at pkg.php

See c24bb3fc80baef04d7b500e18d69c2ada2abdb76 for where this 'if' block was emptied

Cleanup

Remove closing tag followed by opening tag. Change short_open_tag to full tag and put small instructions on same line.

Show user the URL causing the error. Ticket #5848

Remove process_alias_unzip, which never worked because of variable typo (at a minimum) and wasn't documented as an available feature so people don't expect to be able to use it.

Return false if download fails in process_alias_urltable so input validation based upon it works. Ticket #5848

Set same as max_input_vars

Match this to max_input_vars for large aliases

Correct variable in error log

Don't try to process aliases whose downloads have failed in update_alias_url_data(). Ticket #5848

Sync up download_file_with_progress_bar with download_file. The former is no longer used in the base system, but still in some packages.

Don't try to process URL alias if the download fails. Ticket #5848

Further revision to service hiding system

Fix style issues.

Revised hiding

Revised service hiding

Fixed #5867

Add the configuration upgrade code to make sure the existent settings will work after the last changes.

The CARP part of this code should be added together with the initial uniqid changes.

Fix get_interface_ip[v6]() to try first the IP from our configuration before ask the kernel. The OS will return the first IP it find for the interface and not necessarily the main IP address.

This can cause conflicts where get_interface_ip[v6]() returns a CARP or IP alias for the interface (missing the real IP and generating a duplicated IP address).

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Return false in download_file rather than the failed status code when a download fails. Return would always evaluate to true previously though other parts of the code expect a false value when a download fails. related to Ticket #5848

Merge pull request #2600 from NOYB/Firewall_/_Rules_-_Page_Efficiency_Upgrade

Merge pull request #2576 from NOYB/HTML_Compliance_-_VPN_/_IPsec_/_Tunnel_-_Edit_Phase_II

Merge pull request #2602 from phil-davis/patch-2

Merge pull request #2609 from NewEraCracker/bgcolor-removal

Added "Quick" icon to legend

Typo in icon color

Fixed #5860

Fixed #5858
Adds an incrementing suffix to service names when there are duplicates

Remove bgcolor attribute and use style instead.

See 24fac9b4b803938d403aab6645a3be028f2531d7 for similar change.

Cleanup some text in wireless options and fix a description.

Merge pull request #2608 from NOYB/HTML_Compliance_-_Diagnostics_/_Backup/Restore

Merge pull request #2605 from phil-davis/patch-1

Merge pull request #2604 from NewEraCracker/illegal-offset-fix

Fix comparator name and add missing quotes

Comparator name was wrong on system_groupmanager_addprivs.php and quotes were missing around the comparator name at system_usermanager_addprivs.php

A hack for floating rules copy/dup so that separators get moved.

The interface var $if is set to the interface set in the float rule.

HTML Compliance - Diagnostics / Backup/Restore

Duplicate ID Submit.
Suppressing unused ID Submit attributes.

Make display separators function generic and move to filter.inc.

A little tweak for code consistency. No functional change.

Bring NAT separators into the fold.

Also add config empty test to upgrade script.

Firewall / Rules - Page Efficiency Upgrade

1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables....

Fix #3209 properly

The small change I made previously was not all of it - but it did avoid the previous problem by (accidentally) referring to the (undefined) $a_vlan array! I should actually pay more attention to the detail.
This should be even better :)

Implemented #5846 as requested

get_failover_interface returns the parent physical NIC for _lloc interfaces, so make sure it's returning null before it gets to that point.

Fix help text index when the privs are filtered.

Use IEC MiB units on dashboard

1) physmem calculation is already in MiB
2) swapinfo -m actually reports in MiB - good
3) The code that gathers the disk space data already uses "df -h" which reports in IEC units, but the output just has the single char "M", "G" etc. We can always add "iB" here....

Use IEC KiB MiB GiB TiB units

See forum https://forum.pfsense.org/index.php?topic=106547.0 for discussion if this is wanted.

Merge pull request #2592 from phil-davis/patch-1

This should prevent the possibility of illegal offsets

If you poke pfSense WebGUI you'll find some funny stuff. Username and Password should never be arrays at all.

Redmine #4647 default DHCP server tab to a interface with DHCP enabled

This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:...

Fix #3209 editing unassigned VLAN tag can change an assigned interface

To reproduce:
a) Create VLAN 10 on some real device (e.g. em0)
b) Create VLAN 11 similarly.
c) Assign VLAN 11 (the last one in the vlan array in the config) to OPT1.
d) Edit VLAN 10 tag to be 12....

Merge pull request #2599 from phil-davis/gtvpn

Merge pull request #2597 from phil-davis/patch-3

Merge pull request #2596 from phil-davis/gtsug

Merge pull request #2595 from phil-davis/grppriv

Merge pull request #2594 from NOYB/HTML_Compliance_-_Status_/_Gateways

Suppress unused id attributes.

Internationalize vpn*.php

Enhance input error message for RADIUS secret

Make this input error message different to the one just above for the "ordinary" secret so that users can read the message and know which are the fields with the problem.

Make group addpriv descriptions work like user addpriv

HTML Compliance - Status / Gateways

The bgcolor attribute on the td element is obsolete. Use CSS instead.

Internationalize system user and group code

Fix subnet_size var name typo

Add support for TB when reporting bytes

Forum: https://forum.pfsense.org/index.php?topic=106470.0
I believe that this should work OK on both 32 and 64 bit systems. A 32-bit system will convert big values of $bytes and big numbers like 1099511627776 to float first, then do the comparison. 64-bit systems will do (int) comparisons. Either way, in the end, the value is sprintf() into a float anyway....

Add missing comma

Fix NAS IP listing in captive portal. semi-related to Ticket #5656

Don't include 127.0.0.0/8 in unbound.conf in forward mode. Ticket #5750

Use a better check for whether there are DNS servers available with dynamic WAN types. Ticket #4747

Merge pull request #2587 from davidjwood/preserve-sshd-parent

Merge pull request #2588 from davidjwood/rrd-ntp-offset

Verify a DNS server exists before allowing enabling of forwarding mode. Ticket #4747

Handle start/stop of OpenVPN client instances bound to gateway groups using CARP IPs. Ticket #4858

clean up text

Fix get_interface_ip to return correct IP for CARP VIPs. Ticket #4858

Tell rrd that ntpd offset can be negative as well as positive

Fix find_interface_ip for gateway groups with VIPs. Ticket #4858

Don't kill an sshd parent process on exit from /etc/rc.initial

This stops exiting a shell running in an SSH session from terminating the parent sshd process, which has the unwanted side effect of killing all other sessions running under that sshd process (including cloned shell sessions).

$interface isn't used here. Wasn't before either, otherwise it would have broken the get_configured_carp_interface_list. Ticket #5844

Just show the IP to the user, the VIP's uniqid is meaningless noise to the user. Ticket #5844

Only show VIPs associated with the correct interface. Ticket #5844

Select appropriate VIP where one is configured. Ticket #5844

Add pfsync to the list of pre-defined packet capture filters. Also add negation for ESP that seems to have been accidentally omitted.

Fix #5837

Since the introduction of pkg_with_pb(), direct calls to this function
were added using the following format:

if ! pkg_with_pb ... | tee -a $logfile; then

What happened in this case is if was always getting a successfull
return code from tee call, and pkg_with_pb return was always being...

HTML Compliance - Status / OpenVPN

Start tag body seen but an element of the same type was already open.
Stray start tag script.

Merge pull request #2585 from k-paulius/patch-pkg-syslog-v2

Set gif interface MTU in interface_gif_configure if it's not already correct. Ticket #5842

Adding ability to run dhcp6c in debug mode.

Fixed #5841

Now that the fields on interfaces.php aren't hidden upon disabling the interface, we don't want to handle disable separately from everything else, as that discards all the changes other than disabling the interface. Everything else with handling bringing down of interfaces is still handled correctly. semi-related to Ticket #2453

Return blank rather than 0ms/0% for unmonitored gateways latency and loss. Show on dashboard widget when a gateway is unmonitored. Ticket #2226

Remove rc.restore_full_backup, remainder of full backup components were removed already.

Enable gzip compression in nginx.

Allow gateway weights up to 30, and add a check in filter.inc to prevent creating too long of a route-to line. Related to pull request 1614

Fix multi-session time counting for the FreeRADIUS start/stop case. Ticket #2164

Fix typo in button class for CP status

Merge pull request #2584 from schinken/radvd-lifetime-defaults

Add defaults to radvd valid and preferred lifetime

Make sure subnet_size() didn't return 0

Merge pull request #2435 from stilez/patch-7