pfSense

Interfaces (assign) - Remove Personalizations

Remove "you" personalizations.

Merge pull request #2800 from phil-davis/r1

Specify the zone in the PORTAL_ACTION URL. Ticket #6037

Add brackets for clarity

Add some extra brackets for clarity, rather than relying on the operator
precedence rules. IMHO this makes it more readable, and no need for the
reader to wonder if anything might go wrong with the operator
precedence.

(status > ipsec) clean up css

Set the ALTQ root queue bandwidth.

Whenever possible set it to 1Gb, if the sum of child queues if higher than 1Gb, set it the correct value so we do not break any existing setup.

Ticket #5721

Fixes the shaper wizards to split the bandwidth correctly.

With P2P catchall disabled, the qLink queue (using 20% of root bandwidth) was not taken into account.

Decrease 20% of qInternet bandwidth queue in this case.

Ticket #5721

Fix the sum of child bandwidth.

Now percentages are correctly handled.

Remove commented and unused old code supposed to do the same.

Ticket #5721

Implement system_get_serial()

Remove dead code

Further text refinements for PR 2790

Merge pull request #2790 from NOYB/Interfaces_-_Word_Smithing

Identify specific hardware models of some Netgate products

Rename variable to a name that make sense

Merge pull request #2798 from NOYB/System_/_Advanced_/_Notifications_-_Remove_Personalizations

Merge pull request #2797 from NOYB/System_/_Advanced_/_Miscellaneous_-_Remove_Personalizations

Merge pull request #2796 from NOYB/System_/_Advanced_/_Networking_-_Remove_Personalizations

Merge pull request #2795 from NOYB/System_/_Advanced_/_Firewall_&_NAT_-_Remove_Personalizations

Merge pull request #2794 from NOYB/System_/_Advanced_/_Admin_Access_-_Remove_Personalizations

Swap the colors on Diag > Command back. Executing is dangerous, hence the warning.

Fix display of PPP "uptime" (the word "uptime" was missing from output).

Unset this as well, or else it spams the log needlessly (no actual problem). Fixes #6034

Apply "Editor" Phil's corrections.

Thanks Phil.

System / Advanced / Notifications - Remove Personalizations

Remove "you" personalizations.

System / Advanced / Miscellaneous - Remove Personalizations

Remove a bunch of "you" personalizations.
Typo and sentence spacing.

System / Advanced / Networking - Remove Personalizations

Remove a bunch of "you" personalizations.

System / Advanced / Firewall & NAT - Remove Personalizations

Remove a bunch of "you" personalizations.

System / Advanced / Admin Access - Remove Personalizations

Remove a bunch of "you" personalizations.

Don't log 404s for captive portal. Ticket #6027

Merge pull request #2788 from phil-davis/patch-3

Merge pull request #2791 from NOYB/Interfaces_-_Section_Title_-_Reserved_Networks

Background all the ipsec commands run from status_ipsec.php to make sure they don't hang up the entire GUI. Ticket #5520

Remove "we" personalizations.

Interfaces - Section Title - Reserved Networks

More accurate section title.

Revert "Branch master is now 2.4-DEVELOPMENT"

Fat finger here, rolling back for now

This reverts commit 30d9ba51d194600ccb7d474d998c7491d0ba61b6.

Branch master is now 2.4-DEVELOPMENT

Remove errant line.

Interfaces - Word Smithing

Word smithing to remove a bunch of personalization ("You").

Do not allow empty elements in IPv6 addresses

Redmine #6024
Upstream pull request https://github.com/pear/Net_IPv6/pull/14
At this point in the checkIPv6 processing the string should be an uncompressed IPv6 addressed - all the elements should have something in them, a "0" if that element is zero. So any zero-length element is a problem.

Disable the check of subqueues bandwidth until it is fixed.

Ticket #5721

Show the full OpenVPN verb debug range same as 2.2.x.

Clarify OpenVPN verb level descriptions

change logos to reflect community edition

HTML Compliance - Firewall / Rules

Error: Duplicate ID frrfc1918.
<tr id=frrfc1918>

Pass the correct variable to get_interface_bandwidth(). Fixes the boot crash reported by JimP.

Spotted by: Jorge Oliveira
Ticket #5721

Fix display of gateway IP address and gateway/group descriptions in firewall_rules_edit.php.

Band-aid to stop this from breaking the firewall. Ticket #5721

Merge pull request #2781 from jlduran/fix-openvpn-client-typo

Fix OpenVPN client additional options typo

Should read client instead of server. Also remove the `push` example.

HTML Compliance - Vertical Align

pkg.php and functions.inc

Add paren here for clarity, suggested by Phil Davis.

Force the existence of bandwidth on root queue.

If the bandwidth is not set the speed of root queue is set by media status.

In this case a ruleset which contains queues with speeds higher than 100Mb/s will fail to be loaded when the root interface is connected to a fast ethernet port (100Mb/s) - but works fine on a gigabit ethernet port....

Remove ssl_stapling. Ticket #6020

One too many "!" in the "Advanced options" button javascript caused the Link parameters to be always hidden

Re-run priv script to pick up changes.

Detect default config flavor

Merge pull request #2776 from NOYB/HTML_Compliance_-_Captiveportal

HTML Compliance - Captiveportal

Text Align & Background Color

Fix syntax error in diag_traceroute

The semi-colon is not needed here.
Reported by forum: https://forum.pfsense.org/index.php?topic=108643.0

Don't log to filter.log when local logging is disabled. Ticket #6018

Have recovery mode go to a shell as intended.

possible typo

Fixed #6017

Read return code from right command

The zone parameter needs to be in this html example for CP.

Bump default config ver to 14.8

Merge pull request #2773 from NewEraCracker/small-php-js-tweaks

Merge pull request #2772 from NOYB/HTML_Compliance_-_Diagnostics_/_Test_Port

Merge pull request #2771 from stilez/patch-20

Merge pull request #2769 from phil-davis/btnattr

Merge pull request #2768 from phil-davis/patch-3

Echo boolean value instead of string

Prior to this change, code would echo an empty string if false and 1 if true. In all other files, with similar code, boolean representation is printed.

HTML Compliance - Diagnostics / Test Port

Error: Start tag seen without seeing a doctype first.
Expected e.g. <!DOCTYPE html>.
Error: Stray doctype.
Error: Stray start tag html.
Fatal Error: Cannot recover after last error. Any further errors will be ignored.

Remove apparent pointless function (2nd occurance)

replace apparently pointless function in 2 files

Code loops through all return values of get_possible_traffic_source_addresses(true) to create a list of key=>descript list, but the original function returned exactly such a list anyhow with no other data associated with the keys. So the code seems pointless as it replicates exactly the original return value from possible_traffic_source_addresses()....

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Allow moving last pool entry

If you are moving load balancer pool entries back and forth between the enabled and disabled pools, you can't move the last entry in the disabled pool back to the enabled pool, which you should be able to do.
This change also gives the user flexibility to move the last enabled entry to the disabled, that is helpful if the user is just moving entries around - e.g. putting everything into disabled then adding 1 or 2 back to the enabled. On save, the validation checks that the enabled list has something in it, so the user can;t actually save an empty load balancer pool anyway.

HTML Compliance - Firewall / Schedules / Edit

Error: Duplicate ID tempFriendlyTime.

If there was a group with a space, delete all the user-defined groups before hitting local_sync_accounts so pw doesn't get hung up. Ticket #6012

Merge pull request #2766 from jlduran/nginx-ssl-parameter-on-listen-directive

Reconfigure any VLANs with a lagg parent after recreating the lagg. Ticket #6014

Check whether group exists using GID rather than name. Users can change the name, but not the GID. Check return code of pw for whether group exists. Ticket #6013

Save changes to config in 148 config upgrade. Ticket #6012

Changed the button colors and icons. The fa-terminal wasn't doing it for me :)

Ensure replacement group name is unique

Cleanup nginx configuration file

- Fix indentations
- Use the `ssl` parameter of the `listen` directive [1]
- Change the rewrite rule to use the recommended syntax [2]

[1]: http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl
[2]: http://nginx.org/en/docs/http/converting_rewrite_rules.html

Fixed #6012
Config upgrade function replaces space with underscore in group names

Partially fixed #6012 by removing space from chars allowed in group names

Services / DNS Resolver / General Settings

Static should be static.
Elements that don't need to be dynamic should be static.
More robust than depending on client-side processing to set them.

Suppress dashboard save icon until needed.

GIF had the same problem as GRE with flags, apply the same fix. Ticket #6010

Correct the code saving values for GRE. The GRE configure backend code tests for isset, the way the values were copied before it would be set to 'false' which was still set, so the code always triggered when it shouldn't. When reading back from XML at boot time it's OK, so only the web interface is affected. Fixes #6010

Merge pull request #2761 from heper/patch-1

Merge pull request #2718 from NOYB/JavaScript_Polyfill_-_String_Includes_Method

Merge pull request #2757 from NewEraCracker/allow-ip-as-althostname

Much cleaner like this.

Services / DNS Resolver / General Settings

Echoing $pconfig['custom_options'] directly into JavaScript is prone to breaking the script by creating invalid syntax due to characters such as line feeds etc.
Best to transfer a flag from PHP.

Use correct variable for the remote ID in IPsec status. Fixes #6009

Add PCI and USB device lists to status output

Temporarily disable PR 2750 pending revision by NOYB