pfSense

Fix copy/paste error in variable test.

Create a dummy /etc/printcap when starting bsnmpd so it it will not log errors. Fixes #6838

Add missing L2TP from this gateway handling case. Fixes #6980

Fix reversed accounting style

(cherry picked from commit f3838572c59ea5ebe656851511c75d217afec815)

Send packages to files03 too

Disable PAM when using only key-based authentication, otherwise keyboard-interactive fails. Fixes #6963

Build hping

Fix #6918 Allow aliases with capital letters in rules

Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text....

Consider the IPv6 checksum options when dealing with "Disable hardware checksum offload".

Ticket #5321

(cherry picked from commit 411d4e6e55475cc66b997ca3e47478dbe10b4e1b)

Fix bug where CARP vip status is incorrent in the interface when more
than one CARP vip is configured for an interface.

(cherry picked from commit 5116a8aa60ad87c0a47aafeca422cc323147ea14)

Remove "use lowercase" hint

As it is no longer relevant, because the code now automatically converts
to lowercase.

(cherry picked from commit 6a54698517430760ddcbc84dd0476046d3926b31)

Fix #6864 automatically convert IPv6 input to lowercase

1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid...

Enable ALTQ for cxl. Fixes #6830

OpenBSD removed the pf FAQ page for shaping, so link to the proper page on archive.org since they offer no current equivalent and no other suitable replacement page is immediately available. Fixes #6781

Fix #6758

extensions.ini must be readable by any users otherwise any php script
called by a non-root user will not be able to use PHP extensions

This is a direct fix for RELENG_2_3_2 since extensions.ini is not being
used anymore on RELENG_2_3 or master

Import a patch to fix Net_IPv6::compress("::")

Obtained from: https://github.com/phil-davis/Net_IPv6/commit/638b96a253164b65c63825c38e79812b6c5f448d
Submitted by: @phil-davis

Make sure we consume staging packages on build process after pfSense-repo became a package

Fix display advanced after input error for system_gateways_edit

Use case:
1) Edit a gateway that has no advanced settings (i.e. the Advanced section does not need to open on page load) - that works fine.
2) Modify the Gateway IP Address to something invalid like 1:2::z...

Better handle no dhcpv6 leases file

(cherry picked from commit 2355c154b7598f937ba2121429659f5676ce4d96)

Fix #6872 CP bandwidth 0 is no valid

The front-end validation prevents zero from being entered. "Leave empty" is the way to specify no limit.
(cherry picked from commit b7f2ebb5448f7992cceec899504bdd0a29058fb9)

Make setup_serial_port() write config files safely

This function used to replace /boot.conf, /boot/loader.conf and
/etc/ttys on every call. Depending of the moment a power failure
happens, any of these files can be blank and it'll break console setup
on next boot....

Change safe_write_file $content parameter to accept an array

Make $force_binary parameter optional, default to false

Prevent /etc/ttys to miss essential lines

We do not create /etc/ttys from scratch but we change it on every boot.
If original file is corrupted for some reason we can end up with a file
missing essential lines. Added a check to verify if these lines are
missing and add them back in this case

Merge pull request #3153 from NewEraCracker/RELENG_2_3_2+

Fixup ntpd IPv6 restrict clauses.

This should eliminate the following errors from the ntpd log file when
using IPv6 or dual-stack networks:
"syntax error, unexpected T_Mask, expecting T_EOC"

(cherry picked from commit daed7646d7e8e5d555676299ce660408b490ef81)

Backport save_widget_settings with 3 arguments from RELENG_2_3

Commit 6f1410582412fe771f51bd8b67bcbb952da97db6 introduced code relying on this

Fix typo: The input field is named source_hash_key

(cherry picked from commit 870b9bc11b993ce8122b448083d29a04bcb30151)

Fix static blackhole routes. Bug was introduced in
8be135cd114fbc9294ec9dafed2125d0e553956c (February, 2013).

(cherry picked from commit 580bef1ee3052437487553fcc5dc8428ca665098)

Spelling mistake "system_gateways.php"

Fix spelling mistake in "system_gateways.php"

(cherry picked from commit 47180823dc0560801085a227abf512e265363b16)

Revise merge error

Applied PR #3173 to correct merge error

Fixed #6835 by revising Javascript show/hide

(cherry picked from commit 850c3d8b9352e7467beca8502c24ca8d4fbbbd29)

Bump PRODUCT_REVISION

Make serial/UUID bold

Show system platform and serial / UUID

Obscure RADIUS shared secret.

Obscured password field in system_authservers.php bind section
Fixed #6759

(cherry picked from commit 1c1f08f92e8841f7282280caeed7613edd810453)

Ensure a mobile P2 is marked as such when saving.

Use wider display for pftop to fill up dead area. Output still looks OK with narrower terminals as well.

Some views were omitting important info at the narrower width

Declare $config as a global in guiconfig.inc csrf_startup() function, to properly respect the timeouts. Ticket #6803

Apply #601 fix to firewall_nat.php

(cherry picked from commit 4b0815f38a8a0f98519ca0c2bff7c81b6464e579)

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

Do not show certificates in drop-down list that are already contained in this CRL.

Add missing \) and fix syntax

Sanitize 'zone' parameter on CP pages

Merged #2975

Revised service running/stopped icons

(cherry picked from commit a03162c874c4e52e6cae52c2eefce87118fd90d2)

Fixed #6788 by clearing only the first label in the cloned row

(cherry picked from commit d38d215d1d9429d3a1a15708f92b14cf3a15b247)

Fix up/catch up remote syslog areas. Fixes #6780

More pptp bits

Remove some more dangling PPTP bits.

Fix description of the VPN remote log setting

Fix handling of backup config count. Fixes #6771

Enable apcupsd build

Input boxes with setPattern validation should not contain escape characters as they are already properly considered 'lists of characters' even when not escaped.

(cherry picked from commit 8ea3fd0569ac2b1681de5ba3fbc2a2cc20981ad6)

Outbound nat overview, show alias popup and edit options on source and destination, for both the address and port.

(cherry picked from commit d98e54b215a7798aa0cd9d8432340d6e6df762f5)

Prevent accessing undefined offset in IPv6.inc

On perfectly good IPs (eg. 1:2::3:4) this code could cause the following notice:
Notice: Undefined offset: 2 in IPv6.inc on line 560

On bad IPs like 1::2::3 it would not result in any notice.

This commit fixes the above problem, while making sure that only valid sequences pass validation....

-resolved syntax error
(cherry picked from commit 0a6ab475d80b580b09fefaf3ca346b08ec6a23c9)

system_dhcpleases_configure() - Improve pidfile handling

1) Set the pidfile variable in the correct place.
pidfile variable is required in both 'if' and 'else' blocks.

2) Ensure pidfile is valid before sending term signal

(cherry picked from commit 4509abc380552554cbdf3f42c6783b47112f245a)

Apply the fix for ticket #6589 also into dhcpdv6 config

(cherry picked from commit 20350989db5d66ffb827beaed5ef5738cd62fc9d)

Indent dhcpd.conf option custom
(cherry picked from commit c507161d557817c1f6f0adbef9ffdbad82115ee8)

Fix #6720 DHCP options by pool

It is a little bit tricky having to generate the unique "option custom-if-n-m code ..." lines at first where n = pool index and m = item index in the items of the pool. Then make sure to reference that later, getting the same pool index into the array of pools. The $all_pools array as the "overall" or "base" pool first (at index 0), followed by the user-specified pools at index 1, 2, 3,... - which are actually at indexes 0, 1, 2,... in the ordinary array of pools in the config. So the -1 at line 910 has to happen....

Fix double domain-name-servers for pool

Add a pool and specify something in 1 or more of the DNS servers boxes for the pool.
The "option domain-name-servers 1.2.3.4" line appears twice in dhcpd.conf
The first bit of code to do it is at lines 787-799. I have deleted this 2nd time that it is done at lines 854-856....

Fix #6724 VLAN interface displayed wrong

in interface assignment script dialog.

The str_replace() calls were not smart enough to just get rid of bare "igb1" when "igb1_vlan123" and such like was also in the list.
(cherry picked from commit fd020a2d94077cc9c8ee6bac5b3da11e116c84a2)

Clean up the text on diag_sockets.php. Fixes #6708

Clarify language on diag_tables.php. Fixes #6713

Use -l with traceroute6 to show both IP Addresses and Hostnames when resolving hops. Add note about max ttl/hop limit in source comment. Fixes #6715

Add output encoding to diag_dns.php for results returned from DNS. Fixes #6737

Merge pull request #3116 from NewEraCracker/RELENG_2_3_2+

Fix syntax error on openvpn.widget.php

Fix problems caused by c93d289

This commit syncs openvpn.widget.php with version from RELENG_2_3 branch

Use "-C /dev/null" when starting dnsmasq to avoid it picking up an incorrect default config which would override our command line parameters. Fixes #6730

Text typos in openvpn.widget.php
(cherry picked from commit 8da4847472e03195aeb73a1acedbc27f8af520d1)

Revise widget refresh timing

(cherry picked from commit 134ee13df54280441c25b047b406628eeebbb8db)

Added control to set dashboard widget refresh period
Start each widget refresh system after a short random delay to prevent all widgets hitting the server at the exactsame time
Fix issues wherein two widgets were resetting the refresh timer from the AJAX call, not the call-back function, thereby risking stepping on themselves...

Fix messup caused by 9d3e872

(cherry picked from commit d5b993fc310147d68bc3c3654a512b0ac981ecd2)

Tidy up filenames

Make sure the filenames represent the actual file

(cherry picked from commit 6173d1f5a5ed50b8c8a8523b1eb6824f7c9c1ae6)

Fix DDNS domain for static map DHCP entries

If you specify DDNS Domain in a DHCP static map entry, it does not make its way through to dhcpd.conf
This is because the var name $pdnscfg is wrong from an old copy-paste that first made this code.
(cherry picked from commit a5a55231770e548898b6b1c18146cc0c6631c5c6)

Merge branch 'RELENG_2_3_2' of git.pfmechanics.com:pfsense/pfsense into RELENG_2_3_2

Code style and comments

No functional change - just making style consistent

(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)

Add 2nd server to the list of places to submit files

Improved solution to #6716

(cherry picked from commit 0ed3b15981b4451efb11839d6ee7b9acf1ed1d84)

Fixed #6716

(cherry picked from commit 4d4782fcd7213b5f279cb372853f5fedb07f6178)

Fixed #6700

(cherry picked from commit 40eca7e3a8abdff768e29e310ba945e74fdcfe17)

Fixed #6710

Fixed #6709

(cherry picked from commit 3726918df1dc4744bb7ea694ec5c8f40de59d856)

Fixed #6703

(cherry picked from commit e5343844c6de78feafae9e601b25bdf31f114a50)

Fixed #6706

(cherry picked from commit b86938e7e19a09a5b1f3f54825193b57f7c73131)

Fixed #6705

(cherry picked from commit d526fc2d2acc87af2ca829dfe01f0037e3368051)

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

Fixed #6704

(cherry picked from commit fd778d8bef8ea3b0e5dcc8007de242b6e2ac6d5a)

Change hostname to send pkg repos

Change build scripts to make it possible to rsync files to multiple locations

Remove bwlimit from rsync

Do not scp log files

Retire snapshots_rotate_logfile()

Merge pull request #3096 from ch1c4um/fixed_to_save_ppp_interface_configs

Fixed to properly save configs in PPPs interfaces

Pass along send_smtp_message() return, otherwise message will not be shown when testing SMTP settings