pfSense

Tweak upgrade - Remove unused code and document changes better

This will ensure a smooth upgrade for those running config 15.4 to any next version.

Revert "Add config upgrade code to update package names. Ticket #6118"

This reverts commit 291fad43870bdb39ef0ab32125b022e268a29cf7.

Update L7 config upgrade code removal. Only file notice if it was actually in use, otherwise it just confuses people.

Add config upgrade code to update package names. Ticket #6118

Don't foreach unless it's an array. Ticket #6142

Similar thing to https://github.com/pfsense/pfsense/commit/13dab3538fe8b6c1688142c89a017520ad0aaac6 should be done here in upgrade_130_to_131()

Add config upgrade code for CARP IPs on gateway groups, GRE and gif. Ticket #6222

Don't foreach unless it's an array. Ticket #6142

Update VIPs CARP parent on upgrade. Ticket #6164

Periodic RRD & DHCP Leases RAM Disk Backup

Remove these cron jobs on full install if not using ramdisk.

Add checks in case there are dpinger param problems

in 2.3 installations that were upgraded from 2.2.* when the apinger to
dpinger params conversion code in upgrade_130_to_131() was not so good.

(cherry picked from commit f8f2eae491ac44ac5cdbd1fd3d38d7c2c36f48f8)

Fix #6142 validate and adjust dpinger params on upgrade

1) The previous "down" value was being converted to msec and put into
"loss_interval". It should go into "time_period".
2) loss_interval must always be at least latencyhigh - make it so if
latencyhigh is big....

Correct OpenVPN upgrade code for topology subnet.

Merge pull request #2831 from NOYB/Includes_-_Remove_Personalizations

(cherry picked from commit 7a2c15f527459cc82aadaf23d06895174c008320)

Bring back rainterface, add config upgrade to convert to new _vip format. Ticket #6043

fix style

Rather than renaming groups with spaces, mark their scope as remote. Ticket #6012

Add brackets for clarity

Add some extra brackets for clarity, rather than relying on the operator
precedence rules. IMHO this makes it more readable, and no need for the
reader to wonder if anything might go wrong with the operator
precedence.

Set the ALTQ root queue bandwidth.

Whenever possible set it to 1Gb, if the sum of child queues if higher than 1Gb, set it the correct value so we do not break any existing setup.

Ticket #5721

If there was a group with a space, delete all the user-defined groups before hitting local_sync_accounts so pw doesn't get hung up. Ticket #6012

Save changes to config in 148 config upgrade. Ticket #6012

Ensure replacement group name is unique

Fixed #6012
Config upgrade function replaces space with underscore in group names

Add the upgrade code for OpenBGPd and Quagga OSPF packages.

Ticket #5884

Merge branch 'master' of github.com:dennypage/pfsense

• 'master' of github.com:dennypage/pfsense:
  Add stddev information to the quality graphs.
  Update config version to trigger upgrade of rrd files
  Add standard deviation to quality rrd files

Add config upgrade code to enable and configure DHCPv6 server and radvd where track6 is in use, as they were automatically configured previously. Add same config to default config.xml to retain existing behavior there. Ticket #3029

Merge branch 'master' of https://github.com/pfsense/pfsense

Internationalize etc inc uvx

Add standard deviation to quality rrd files

Fixed #5873

Fix style issues.

Add the configuration upgrade code to make sure the existent settings will work after the last changes.

The CARP part of this code should be added together with the initial uniqid changes.

Bring NAT separators into the fold.

Also add config empty test to upgrade script.

Firewall / Rules - Page Efficiency Upgrade

1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables....

Remove old pppoerestart cron job if it exists. Ticket #1905

Change Namecheap dyndns to use split hostname and domain name fields. Upgrade existing entries automatically. Implements #4366
Code should be generic enough that if other DynDNS providers would work better with a separate domain field, they can pick up the feature without too much trouble.

OpenVPN server config upgrade already handled in 129_to_130. Ticket #5764

Make sure filter rules have a tracker ID, associated rules were missing it previously.

retain OpenVPN's net30 default topology for upgraded configs so they still work. Ticket #5764

Add uniqid tag to CARP VIPs that don't have one upon upgrade. Ticket #4858

Fix up config setting for killing states on gateway failure. Enable this option where gw_down_kill_states is set. Flip setting accordingly during config upgrade to not use confusing 'kill_states' tag to not kill states. Ticket #5815

Switch to disabling strongswan unity plugin by default. Ticket #4178

Bring text to current reality

Encode DHCP/DHCPv6 server additional BOOTP text options before save to XML to preserve data. It fixes #5623

Add config upgrade code to remove L7 config pieces, and file a notice where found. Ticket #5508

Fix whitespace in upgrade_118_to_119

add config upgrade code for lighty->nginx logging

Fixed #5714

Do not start dpinger processes due to rrd

Disable IPsec phase1 or phase2 using DES and inform user why they were disabled since DES is no longer supported. It should fix #5543

Disable all IPsec P1 entries when old version has IPsec globally disabled. Fixes #5699

Nuke fifolog support. It was never used or fully implemented, no GUI option, and didn't end up working out.
It buffered writes too long, users could never see the most current log data.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Fix GW setting names in upgrade_config

Write upgrade config to replace apinger by dpinger, it should fix #5624

Code style and white space in etc

Include ipsec.inc here otherwise the global is undefined when called when restoring a config in the GUI.

net.inet.ipsec.debug in 10-STABLE and newer is extremely noisy and has a serious performance impact, where that wasn't the case on 10.1 base versions. Change it to 0 on upgrade to avoid problems for those who had it set previously.

Upgrade code to change topology_subnet checkbox to drop-down. Issue #5526

Move recently added config upgrade for IPsec enable to last config upgrade

Optimize upgrade_128_to_129()

Move recently added upgrade code to a new config version

When necessary, unset $config['ipsec']['enable'] in upgrade code.

Unset "net.inet.ip.fastforwarding" when upgrading from older versions.

Issue: #5370

Fix old SNMP bindlan setting - Redmine #3883

Remove run-time code in services.inc that referenced "bindlan".
Provide upgrade code to convert bindlan to bindip="lan" if needed.
Update current config version.

Fixes upgrade of config file on already upgraded 2.3 Alpha systems

Changes after testing on real hardware

Revert "Fix upgrade_126_to_127()" partialy

The first item was wrong, thoe items should be discarded

- Do not discard items with $display already set to open or close

This reverts commit 303d345dd5e7ead6975bd3140b213219d7e0f4f0.

Fix upgrade_126_to_127()

- Do not discard items with $display already set to open or close
- Call continue 2 to move to next widget

Fixed #5432

Remove fastforwarding from config upgrade. Ticket #5370

add require of ipsec.inc so convert_config doesn't fail when invoked by gitsync. #5350.

Fix #5350. Correct issues with strongswan logging (setting changes did not persist across reboots, setting silent did not work).

etc inc delete $Id comments

and bits of white space.
Note: There are plenty of files still with old-format copyright sections
in here.

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

Require notices.inc only if it's going to be used

IKE auto mode is back, remove this config upgrade code unsetting it.

Remove more references to theme, ticket #5333

Fix function name, spotted by mgsmith

Remove config stuff for WEP. on upgrade, disable WEP on interfaces that have it configured and disable those interfaces and generate a notice. Fixes #5123.

Completed #5333

Cleanup unused code:

- Remove xmlrpcbaseurl from globals
- Remove xmlrpcpath from globals
- Remove embeddedbootupslice from globals
- Remove call_pfsense_method()
- Remove check_firmware_version()
- Remove get_active_xml_rpc_base_url()
- Remove zeromq.inc...

Use product_name global variable in more places

White space and minor bits in etc

Cleaner version of https://github.com/pfsense/pfsense/pull/1846

Retire PPTP server, fixes #4226:

- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
firewall and NAT rules using PPTP interface or src/des

Retire PPTP server, fixes #4226:

- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
firewall and NAT rules using PPTP interface or src/des

Merge pull request #1848 from phil-davis/bootstrap-review

Merge branch 'master' into bootstrap

Integrate bootstrap etc/inc with master

This applies the little changes in etc/inc master to the bootstrap
branch so that etc/inc in bootstrap will now just have the real
differences that are due to real bootstrap changes.

Merge branch 'master' into bootstrap

Protect unset() with isset() in upgrade_config

Forum: https://forum.pfsense.org/index.php?topic=96827.0
Sometimes there can be unexpected stuff in a config. To avoid errors
like "PHP Fatal error: Cannot unset string offsets in
/etc/inc/upgrade_config.inc on line 291" it seems good to use...

update config to rid of nt-hash
credit to: das projekt der goatse

Move main pfSense content to src/