pfSense

Update copyright years to include 2023

Rector some direct config gets with pure scalar paths.

RemoveUnusedForeachKeyRector runresults

Update the Copyright year of the files owned by Rubicon/Netgate.

Merge pull request #4494 from bmhughes/fix_pkg_edit_button_descr

Update the Copyright year.

A subsequent commit will deal with .po's.

Fix incorrect description for pkg_edit buttons

Disable autocomplete for pkg_edit password fields. Issue #9864

This is 2020. Issue #9245

Setup shortcuts for packages. Fixes #9770

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Merge pull request #3964 from marcelloc/patch-7

PHP7 Fixed illegal string offset for alias

suppress php7.2 eval erros on pkg_edit.php

https://redmine.pfsense.org/issues/8637

As of PHP 7, if there is a parse error in the evaluated code, eval() throws a ParseError exception. Before PHP 7, in this case eval() returned FALSE and execution of the following code continued normally. It is not possible to catch a parse error in eval() using set_error_handler()....

PHP7 - Resolve invalid arguemtn and illegal string offset warnings

Update the Copyright notice for pfSense.

Remove no-op code

See https://redmine.pfsense.org/issues/7889 for related discussion

Comment typo/whitespace fix

Add more checks to eliminate empty config tags in package settings. Fixes #7624

pkg_edit, fix empty config tag check

Merge branch 'master' into patch-18

Remove duplicate pfSenseHeader() function

Sort includes while here.

Sanitize linebreaks for textarea fields in packages on save (Bug #5306)

GET/POST conversion

fields with <required/> set now pre-pend an asterisk to the field title, thereby causing it to be displayed as a required field (currently an underline)

Breadcrumb links

Fix #7100

Fix typo in grouping/$grouping

Fix "<onchange>" tag processing in package XML handling

Revert "Fixed #6811"

This reverts commit f92d44da5a4958372c7fb925043abc34588143e3.

Fixed #6811

Move copyright from ESF to Netgate

fix typo

Move to Apache License 2.0

Review license / copyright on all files (final round)

Correct spacing

Remove debug

(cherry picked from commit 5810f934472368f43942ea66820dc98e17143c19)

Fixed #6577 - Preserve user input on error

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

fix rowhelper select_source empty combo

while using $config['installedpackage']{['...'] as source

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Merge pull request #2728 from phil-davis/form_button

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Some safety belts to avoid presenting PHP errors to the user. Ticket #5973

More icon/button inconsistencies. Ticket #5965

Add the ability for packages to control their button icon and class. Ticket #5965

Add button on pkg needs fa-plus, too. Ticket #5965

Print help text when passed as "description" for a select_source.

Headers don't need HTML entities

This commits fixes form submission on Services/UPnP redirecting to an URL with & on it.

Show page title because that's where page help icon is displayed.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Remove redundant gettext call

Convert section titles to title case

Internationalization of pkg*.php

Various sentences were being built up from gettext() of individual words
or phrases concatenated together. That will not work for translation to
languages with different word order, so I have restructured that.
Note: TODO: The countdown timer text with seconds countdown is all in JS...

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Replaced jQuery to $ in same files

Do not call gettext() for empty string

Test for an array here to avoid an error if the var isn't an array

Merge branch 'print_info_box' of https://github.com/phil-davis/pfsense

• 'print_info_box' of https://github.com/phil-davis/pfsense:
  Redmine #5759 print_info_box style

Redmine #5759 print_info_box style

Define the 'success' 'info' etc style of calls to print_info_box()

Added support for <collapse> tags in listtopic fields. e.g.:
<collapse>closed</collapse> // Creates a panel that is collapsible and iniatially closed
<collapse>open</collapse> // Creates a panel that is collapsible and iniatially open

Update pkg_edit.php

• Incorrect variable name in pkg_edit

Added support for <width> on inouts and aliases.

Fixed #5668

Add trash can icon to rowhelper delete buttons

Remove name collision in $width attribute

Accommodate <width> XML tag in rowhelper input fields

Move width:auto style to textarea handler in pkg_edit.php

Adds support for <width> XML tag in rowhelper selects

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

Test for #5676

Remove $closehead variable

Remove unused variable $closehead

Support <savehelp> package tag to allow adding help text to the save button.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Merge pull request #2237 from phil-davis/r009

Code style pkg

pkg_edit curlies

This looks wrong - with the way the curlies were, the custom_php_after_form_command stuff was inside the ($pkg['note'] != "") block.
It looks like these should be 2 independent if statement blocks.

Add gettext() calls to title elements

Parse package title, splitting into an array delineated by '/'.
So if the package title is "Services/Magic" the $pgtitle will be array("Services", "Magic") and the breadcrumb display will be as expected.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2161 from heper/patch-1

Fix field description/name display of select_source package fields.

problem with $only_edit

proposed fix breadcrumb pkg xml

fix syntax errors

Support the fieldtype "<sethelp>" for checkboxes.

Support <comment> tag in package XML

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Change Form_TextArea to Form_Textarea
(autoload now makes the classes case sensitive)

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Always honor the required tag in package XML fields

Dunno whose idea it was to restrict this to input. WTH really.

pkg_edit.php - base64 encoding/decoding fixes (Bug #5134)

Currently, the base64 is only usable for textarea fields - see Bug #5134 for details.

This adds base64_decode() to input and password field types if <encoding>base64</encoding> tag is set for those fields (also for rowhelpers) to prevent the values from getting perpetually re-encoded which makes it unusable for those field types....

Fixed #5443

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Javascript refine to hide Delete row button if there is only one row