pfSense

Merge pull request #4156 from vktg/syncempty

XMLRPC: fix last shaper/limiter removing. Issue #9468-9469

This is 2020. Issue #9245

IPsec swanctl conversion. Implements #9603

• Converted IPsec configuration code from ipsec.conf ipsec/stroke style
  to swanctl.conf swanctl/vici style. Issue #9603
• Split up much of the single large IPsec configuration function into
  multiple functions as appropriate....

Fix random typos

Fixup format of XMLRPC auth error to match GUI auth error.

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Deprecate the built-in relayd Load Balancer. Closes #9386

It is not available on FreeBSD 12 with OpenSSL 1.1.x.

Users can migrate to the HAProxy package.

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Fix #8806: Configure captive portal on secondary identical as master HA node

Fix #8721: Call proper filter_configure function from this class

Only alter users/groups via XMLRPC when the primary is set to do so. Fixes #8450

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Fix #7972

Rework the way Captive Portal vouchers are synchronized on HA:

- When voucher use is enabled on primary, do the same on secondary
- When voucher rolls are created/modified/deleted, sync to secondary
- When voucher is used, disconnected or expired, sync it in both...

Fix #7469

• Rename local_sync_accounts() to local_reset_accounts() and keep it
  only being used /etc/rc.bootup
• Reimplement local_sync_accounts() receiving a list of users and
  groups to be added and/or deleted
• Remove call to filter_configure xmlrpc method from...

Update the Copyright notice for pfSense.

xmlrpc, webgui, prevent that a xmlrpc.lock is placed that is never unlocked, thus hanging php and the webgui after a few more sync request are trying to acquire the lock and all are waiting..

Use spaces in the write_config() message to prevent text wrapping issues in webGUI

See https://redmine.pfsense.org/issues/6363

Remove unused get_notices() from xmlrpc.php

Fix get_notices parameter in xmlrpc.php

This looks to me like the var name here should be $category
Note: I don't see where this get_notices() inside class pfsense_xmlrpc_server is ever unused anyway - so maybe get_notices() can just be deleted from here?

Check for lo0 when reconfiguring VIPs on sync. Fixes #7010

xmlrpc, fix loopback detection

xmlrpc, use authentication through the basic auth header instead of extra user/pass parameters

Move copyright from ESF to Netgate

Add specific permission to allow HA XMLRPC sync. It fixes #809

Fix remote_addr array key

Disable autoDocument

Ticket #3734: Convert xmlrpc.php to use XML/RPC2/Server.php

Move to Apache License 2.0

Review license / copyright on all files (final round)

chmod 0644 php web pages

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Refine the way the DNS Forwarder and DNS Resolver are handled via XMLRPC. Fixes #5882

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

xmlrpc signature and docstring

A few of the entries in this array had dodgy var references. I don't think anything would have caused an actual error.

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Remove the last usage cases of $config['ipsec']['enable'].

IPSEC is always on in 2.3, where necessary (IPSEC rules, IPSEC daemon), we check the existence of phase 1 entries.

Copyright updates Batch 2 of 3

Cleanup unused code:

- Remove xmlrpcbaseurl from globals
- Remove xmlrpcpath from globals
- Remove embeddedbootupslice from globals
- Remove call_pfsense_method()
- Remove check_firmware_version()
- Remove get_active_xml_rpc_base_url()
- Remove zeromq.inc...

Move main pfSense content to src/