pfSense

Remove redundant gettext call

Convert section titles to title case

Convert section titles to title case

Change NAT '1 to 1' spelling to '1:1', since latter is used everywhere else

Convert section titles to title case

Only show VIPs on the correct interface. Ticket #5844

Merge pull request #2614 from dennypage/master

Merge pull request #2612 from NewEraCracker/php-cleanup

Merge pull request #2611 from NOYB/Firewall_/_Rules_-_Page_Efficiency_Upgrade

Fix description disappering when editing admin user

Default "State filter" to open, it's too often used to annoy users by having to expand it over and over.

Remove unused CDEF from quality graph

Make RRD lists global, validate graph name using whitelist of known values rather than blacklist of characters, beef up validation and escaping of related values while here. Fixes #5874 for 2.3

Remove executable bit of .inc found in www

Clean up another closing tag followed by opening

Clean up dead code at pkg.php

See c24bb3fc80baef04d7b500e18d69c2ada2abdb76 for where this 'if' block was emptied

Cleanup

Remove closing tag followed by opening tag. Change short_open_tag to full tag and put small instructions on same line.

Show user the URL causing the error. Ticket #5848

Remove process_alias_unzip, which never worked because of variable typo (at a minimum) and wasn't documented as an available feature so people don't expect to be able to use it.

Set same as max_input_vars

Add a comment about the floating rules copy/dup "hack" so the purpose will remain evident in the future.

Don't try to process URL alias if the download fails. Ticket #5848

Further revision to service hiding system

Fix style issues.

Revised hiding

Revised service hiding

Fixed #5867

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Merge pull request #2600 from NOYB/Firewall_/_Rules_-_Page_Efficiency_Upgrade

Merge pull request #2576 from NOYB/HTML_Compliance_-_VPN_/_IPsec_/_Tunnel_-_Edit_Phase_II

Merge pull request #2602 from phil-davis/patch-2

Merge pull request #2609 from NewEraCracker/bgcolor-removal

Added "Quick" icon to legend

Typo in icon color

Fixed #5860

Fixed #5858
Adds an incrementing suffix to service names when there are duplicates

Remove bgcolor attribute and use style instead.

See 24fac9b4b803938d403aab6645a3be028f2531d7 for similar change.

Cleanup some text in wireless options and fix a description.

Merge pull request #2608 from NOYB/HTML_Compliance_-_Diagnostics_/_Backup/Restore

Merge pull request #2605 from phil-davis/patch-1

Fix comparator name and add missing quotes

Comparator name was wrong on system_groupmanager_addprivs.php and quotes were missing around the comparator name at system_usermanager_addprivs.php

A hack for floating rules copy/dup so that separators get moved.

The interface var $if is set to the interface set in the float rule.

HTML Compliance - Diagnostics / Backup/Restore

Duplicate ID Submit.
Suppressing unused ID Submit attributes.

Make display separators function generic and move to filter.inc.

A little tweak for code consistency. No functional change.

Bring NAT separators into the fold.

Also add config empty test to upgrade script.

Firewall / Rules - Page Efficiency Upgrade

1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables....

Fix #3209 properly

The small change I made previously was not all of it - but it did avoid the previous problem by (accidentally) referring to the (undefined) $a_vlan array! I should actually pay more attention to the detail.
This should be even better :)

Implemented #5846 as requested

Fix help text index when the privs are filtered.

Use IEC MiB units on dashboard

1) physmem calculation is already in MiB
2) swapinfo -m actually reports in MiB - good
3) The code that gathers the disk space data already uses "df -h" which reports in IEC units, but the output just has the single char "M", "G" etc. We can always add "iB" here....

Redmine #4647 default DHCP server tab to a interface with DHCP enabled

This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:...

Fix #3209 editing unassigned VLAN tag can change an assigned interface

To reproduce:
a) Create VLAN 10 on some real device (e.g. em0)
b) Create VLAN 11 similarly.
c) Assign VLAN 11 (the last one in the vlan array in the config) to OPT1.
d) Edit VLAN 10 tag to be 12....

Merge pull request #2599 from phil-davis/gtvpn

Merge pull request #2597 from phil-davis/patch-3

Merge pull request #2596 from phil-davis/gtsug

Merge pull request #2595 from phil-davis/grppriv

Merge pull request #2594 from NOYB/HTML_Compliance_-_Status_/_Gateways

Suppress unused id attributes.

Internationalize vpn*.php

Enhance input error message for RADIUS secret

Make this input error message different to the one just above for the "ordinary" secret so that users can read the message and know which are the fields with the problem.

Make group addpriv descriptions work like user addpriv

HTML Compliance - Status / Gateways

The bgcolor attribute on the td element is obsolete. Use CSS instead.

Internationalize system user and group code

Fix subnet_size var name typo

Add missing comma

Fix NAS IP listing in captive portal. semi-related to Ticket #5656

Use a better check for whether there are DNS servers available with dynamic WAN types. Ticket #4747

Verify a DNS server exists before allowing enabling of forwarding mode. Ticket #4747

$interface isn't used here. Wasn't before either, otherwise it would have broken the get_configured_carp_interface_list. Ticket #5844

Just show the IP to the user, the VIP's uniqid is meaningless noise to the user. Ticket #5844

Only show VIPs associated with the correct interface. Ticket #5844

Select appropriate VIP where one is configured. Ticket #5844

Add pfsync to the list of pre-defined packet capture filters. Also add negation for ESP that seems to have been accidentally omitted.

HTML Compliance - Status / OpenVPN

Start tag body seen but an element of the same type was already open.
Stray start tag script.

Adding ability to run dhcp6c in debug mode.

Fixed #5841

Now that the fields on interfaces.php aren't hidden upon disabling the interface, we don't want to handle disable separately from everything else, as that discards all the changes other than disabling the interface. Everything else with handling bringing down of interfaces is still handled correctly. semi-related to Ticket #2453

Return blank rather than 0ms/0% for unmonitored gateways latency and loss. Show on dashboard widget when a gateway is unmonitored. Ticket #2226

Allow gateway weights up to 30, and add a check in filter.inc to prevent creating too long of a route-to line. Related to pull request 1614

Fix typo in button class for CP status

Make sure subnet_size() didn't return 0

Isolate the check for @label in the end of hostname only for noip and noip-free

Merge pull request #2574 from tiagobar/master

Merge pull request #2579 from NOYB/HTML_Compliance_-_Status_/_DHCPv6_leases

Merger PR 2583 but retained non-sortable actions column

Status / DHCP leases - Root Cause Sort Issue

Sort routine apparently does not honor colspan attribute.

Here are three possible solutions:
1) Add a description column instead of spanning the start and end columns. This is the method presented in this commit....

Fix #5830

Add a new advanced option on gateways to allow user define data
payload. Default is 0

Don't sort online, lease type or action icon columns

Add RFC 2136 support to the DynDNS widget

Add back "Save & Force Update" for RFC 2136

Implement Multi-WAN for RFC2136.
A failover gateway group may be selected similar to the other DynDNS styles.

Fix hiding of shadow selector

Improvements to priv filtering

Improvements to the priviledge filter functionality

System / Advanced / Firewall and NAT - Remove PPTP from Verbiage

Remove PPTP from Verbiage. https://forum.pfsense.org/index.php?topic=106257.0
Also don't see any reason for the span tag here.

Duplicate monitors rather than overwrite. Ticket #4441

pfsync syncpeer requires IPv4. Ticket #4648

Added priv filter capability

Fixed #5049