pfSense

Fix indent and spaces

Remove stray '

Merge pull request #3046 from phil-davis/portimport

Improve patterns to read dhcpd6.leases to prevent leases containing '}' in ia-na line not showing up. It fixes #6543

Fix #6585 Do not use [] syntax for lookups

IPv6 address plus port is displayed with the format [1:2::3]:80 - the address is in square brackets followed by colon and the port number. This is necessary to disambiguate the port from the address, a good thing. But it messes up the use of the IPv6 address for reverse lookup....

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the...

Show "cannot delete alias" message as error

If I try to delete an alias that is in use, the "cannot delete alias" message was being displayed as the "success" color.

Fix PTR lookups on diag_dns.php. Ticket #6561

Merge pull request #3043 from NOYB/Label_Rename

Correct spacing

Remove debug

(cherry picked from commit 5810f934472368f43942ea66820dc98e17143c19)

Fixed #6577 - Preserve user input on error

Change group labels s/MAC controls/MAC Address/

webgui tables, doubleclick event to perform 'edit' action, part 2

webgui tables, doubleclick event to perform 'edit' action

ipsec widget, check for valid array

Clarify Negate option description on firewall_nat_out.php.

Change button order on diag_dns.php so hitting enter in the field does a lookup rather than update alias. semi-related to Ticket #6561

Update system_usermanager_settings.php

Use of undefined constant min - assumed 'min'

Update system_crlmanager.php

Use of undefined constant min - assumed 'min'
Use of undefined constant max - assumed 'max'

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

Merge pull request #3034 from NOYB/startsWith_Polyfill

startsWith Polyfill

Fixes hidding of custom individual settings when not in use on user manager page.

Diag Tables Last Update

Use correct Thursday abbreviation (s/Thr/Thu/).

Allow wildcard for hostname with Namecheap DDNS. Ticket #6260

Merge pull request #3018 from phil-davis/usersettings

Merge pull request #3030 from phil-davis/patch-1

Merge pull request #3028 from PiBa-NL/2.3_dnsV6

Rationalize System Update GUI messages

At present, when doing a System Update, there is a message box that says:
"Please wait while the installation of completes.
This may take several minutes."

Between "of" and "completes" is the package name, which is blank in the case of a System Update....

Omit <secret> tags from L2TP in status.php config.xml dump.

Restore 2.2.x and prior means of obtaining pfsync nodes to avoid exhausting memory on systems with large state tables. Ticket #6364

Diagnostics - DNS Lookup, also query for IPv6 addresses

Merge pull request #2944 from stilez/patch-23

Merge pull request #3024 from phil-davis/include_once

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Use the translated destination for kill_states if one exists. Ticket #6531

Correct/clarify column header. Ticket #6530

Fix style

pfSense_get_pf_states always returns source as src and dest as dst, this flipping based on direction is wrong. Ticket #6530

Fix style

Comment typo

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Merge pull request #3019 from NOYB/RFC2136_Client_Edit_Priv_Def

Merge pull request #3017 from phil-davis/patch-2

Restored countdown functionality and menu refresh on successful update/remove/install
Added comments to clarify operation of the page

Shouldn't the priv match here be set to "services_rfc2136_edit.php*"?

Feature #6388 custom GUI preference settings per user

Load actual value of webguihostnamemenu

This is a string from a list of valid values (empty, "hostonly", "fqdn"). So it is not correct to just gather a true/false value here.

Clarify ports alias hint. Ticket #6523

% and / are also allowed in values

Merge pull request #3011 from NewEraCracker/redmine-6394

Merge pull request #3005 from phil-davis/patch-4

Merge pull request #3004 from hailthemelody/master

Merge pull request #3002 from NewEraCracker/patch-invalid-foreach

Merge pull request #2989 from phil-davis/patch-2

Merge pull request #2988 from stilez/patch-28

Merge pull request #2987 from stilez/patch-27

Merge pull request #2986 from NewEraCracker/patch-ntp-gps

Merge pull request #2982 from stilez/patch-26

Merge pull request #2942 from stilez/patch-22

Merge pull request #2935 from cfazendin/hostname_menu

Merge pull request #2906 from Chrisc-c-c/Fix-QinQ-Interfaces

Allow IGMP Proxy logging verbosity to be selected via system log settings (PR 2901)

Merge pull request #2891 from gottaloveit/dns-overrides-privs

Fixed #6504 by making table sortable

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

fix rowhelper select_source empty combo

while using $config['installedpackage']{['...'] as source

update d3.js

update nvd3 files

Fixed #6514 by requiring string starts with letter ot underscore

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

Fix typo

Fix redundant phrasing.

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

Remove tab_array from interfaces_groups_edit.php to be consistent with other *_edit files

Correct value for 9600. Ticket #6416

Fix NTP PPS. It had 'None' option available on 2.2.x.

Fix "Unable to remove NTP GPS from configuration"

https://forum.pfsense.org/index.php?topic=112771.msg627573

Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue

This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked)....

added missing div.content wrapper when reloading filters

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

Merge pull request #2999 from phil-davis/patch-6

Validate submitted groups when editing a user. Ticket #6475

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Merge pull request #2998 from phil-davis/patch-5

Fix #6460 Interface mismatch apply changes button

Rework pkg_mgr_install.php:

- Stop using id parameter for additional packages, keep using it only
for firmware upgrades
- Created to control variables $completed and $confirmed to check all
the stages and make it easy to understand what is happening
- Stop using $pkgid and use $pkgname instead...

Fix variable name s/POST/_POST/ and also parameter name s/complete/completed/

Fix indent

Improve readability

Improve readability

Simplify mode parameter validation

Remove redundant check since pkgcancel is never set

Validate mode parameter and use sanitized variable on other places

Fix #6468 Do not allow edit of day and times

in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields....

Fix #6463 Dest net alias matching on page load

Do not set destination field to use customarray
Note: dstbeginport_cust does not exist on this page, so I got removed it here also to avoid future confusion.