pfSense

update conditional re:LAN dhcp
(cherry picked from commit 0eb2512f93c7e187511ea258948715c2e230e98f)

update LAN regex for case insensitivity
(cherry picked from commit 32980f321e854bf008efa04ee9187553231b6423)

IPv6 address can contain a dot

When requiring the entry of an IPv6 address, the regex pattern should still allow a dot, so that an IPv6 address can be entered in the format that has an IPv4-address-like part at the end:
aa:bb:cc:dd:ee:ff:1.2.3.4
which is a valid way to choose to specify an IPv6 address....

Captive portal: use "Admin Reset" as termination cause when disconnecting a user from admin UI

When a user is disconnected by the administrator using the pfSense captive portal status page or widget set the value of the Acct-Terminate-Cause in the RADIUS accounting stop packet to "Admin Reset" (6) as per RFC 2866....

clarified input format hint for expiration date
(cherry picked from commit 98b87cfafe8a890787ca5d22a1089678b9b250ac)

Fix System Update link

Improved error message to explicitly state allowable characters

Related to Bug #6432.

(cherry picked from commit 3b55b54e9c76998a2b0e28897a0be79d5cf0cb8f)

DHCPv6 ddnsdomainprimary must currently be IPv4

This field is currently validated to allow only an IPv4 address to be entered, so it may as well be consistent client-side so the user knows that only an IPv4 address is allowed.
(cherry picked from commit ff3d11c85450284d8949234f90af7a6c6681199e)

services_dhcp_edit add extra IPv4 validation

a) Validate that ipaddr must be IPv4 (note if you enter an IPv6 address, it will fail other later tests of being in the subnet etc, but it is nice to give the user an explicit message that they must enter an IPv4 address)...

Specify the IP address family in interfaces.php

Where it is known what sort of IP address is required, we can specify it in the call to Form_IpAddress. That will make the hover text reflect what is really required as input, and make the client-side regex pattern also match only the allowed chars....

Keep the rule type selection after input errors on firewall rule

If the user:
a) Edit a firewall rule
b) Select "single host or alias"
c) Enter an invalid IP address that is not an alias
d) Press "Save"
The error is displayed "1.2.3.999 is not a valid source IP address or alias"...

Added addrtolower() to interface pages

Added addrtolower calls to force IPv6 addresses to lower case
First of many

Revise filter_reload page to display entire reload_filter_status contents, not just last line

Revise shaper wizards to support multi-line filter_reload_status

Revise update_filter_relaod_status() function to append status messages rather than overwrite the file

Fixed #6922
Added code for IPv6 Dynamic DNS

Fixed #6939 by moving CSS only to the two pages that require it

Fixed #6931

Revise host and domain sorting so that the index is not lost

Revert "Fix #6864 automatically convert IPv6 input to lowercase"

This reverts commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f.

(cherry picked from commit 75bc87fe10f30f49a09218820f7bb59e859cb6bb)

Revert "Fix #6918 Allow aliases with capital letters in rules"

This reverts commit 9444a281f051e11d5456cc37b2a3f56fc8a7bc33.

(cherry picked from commit 9128641db5c9b6839163948f3f71ad139c7a4625)

Fix #6918 Allow aliases with capital letters in rules

Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text....

Revert change to row delete button

Revert "Suppress delete button if only one row"

This reverts commit 13be068fe5e1377d1d5649efe0f860ba5c34ba90.

Suppress delete button if only one row

Fixed #6916

Revert "Fixed #6811"

This reverts commit f92d44da5a4958372c7fb925043abc34588143e3.

Remove "use lowercase" hint

As it is no longer relevant, because the code now automatically converts
to lowercase.

(cherry picked from commit 6a54698517430760ddcbc84dd0476046d3926b31)

Fix #6864 automatically convert IPv6 input to lowercase

1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid...

Comment typos alphabet
(cherry picked from commit d622a62eb4f3ec8535ead494a863f10bbc409f41)

Fixed #6903
hosts and domains sorted on display, not on save to config

Fixed 6901

Fixed #6898

Fixed #6779 by rounding bandwidth down to nearest integer

Fixed #6895
by setting overflow-x: visible; in CSS

Fixed $6811

When deleting or disabling a non-dynamic gateway, if that gateway was set as default then remove the corresponding default route to respect the user's decision. Fixes #6659

(cherry picked from commit 1be1b87b5f9ab8d0a259b888aab08ec6babad568)

Fixed #6753
Interface menu entries no longer sorted for consistency with other GUI instances

(cherry picked from commit e5d339735836fd55b0fa944d5d7e472793785e30)

Improve IPv4 address validation for services_dhcp

The input pattern that goes with Form_IpAddress by default allows for IPv4 and IPv6 valid characters. The back-end validation here is checking for IPv4 addresses, so it seems reasonable that the front-end input pattern checks might as well be restricted to the IPv4 valid characters. Unneeded setPattern have also been removed....

Fix display advanced after input error for system_gateways_edit

Use case:
1) Edit a gateway that has no advanced settings (i.e. the Advanced section does not need to open on page load) - that works fine.
2) Modify the Gateway IP Address to something invalid like 1:2::z...

Better handle no dhcpv6 leases file

(cherry picked from commit 2355c154b7598f937ba2121429659f5676ce4d96)

Merge pull request #3204 from phil-davis/patch-6

Fix #6872 CP bandwidth 0 is no valid

The front-end validation prevents zero from being entered. "Leave empty" is the way to specify no limit.
(cherry picked from commit b7f2ebb5448f7992cceec899504bdd0a29058fb9)

Provide conrol on system.php to allow display of hostname on login banner

(cherry picked from commit a22947a4980a9f8beb294d6bad039495164ff1aa)

Fix #6869 diag_routes resolve names for RELENG_2_3

This code to parse the netstat output and use gethostbyaddr() to reverse resolve names is only needed in RELENG_2_3, so that long names are not truncated. In FreeBSD 10.3 some long resolved names are still being truncated by `netstat`, even though `-W` is specified....

Fix up help text on outbound NAT.

Clarify source port warning when editing a firewall rule.

In the setup wizard, do not change the DHCP range if it is already set inside the new subnet. Otherwise it will overwrite a range set manually from the DHCP settings or the console when the wizard is run later. Fixes #4820

DHCPV6 only check VIPs in range if range valid

If the user has input invalid values into range from and to, then there
is no point checking any IPv6 VIPs to see if they fall in the range.
None of them would be "in range" because the specified range is not even...

Allow Hyphens in DHCP NTP Server form validation

Also removes the ability to have underscores `_` in ntp server
FQDNs.

Closes #6806

(cherry picked from commit c68dbfc7580180cd9d47bdbecaeeb6cf835fe210)

Format file_notice alerts in webgui with newline characters as <br/> for easier reading.

(cherry picked from commit 348fae16e4c4735afef619184fba76b97effd875)

lowercasing and sprintf of setHelp
(cherry picked from commit 705679339705657832422f5fdc336b5e39d48b79)

label src/dst incorrect - fixed (minor)
(cherry picked from commit a309ffa5cc1e8682bb083f9288f73f43a2a9c282)

UI improvement - src port button label and src port help msgs

1. Rename "srcportadv" to "srcporttoggle" - not ideal to have 2 fields both labelled "advanced options". This presentation probably works nicer
2. Self-explanatory show/hide button itself doesn't need a label. (If srcports are shown, they will have a label as usual)...

add array index how value for authserver list

(cherry picked from commit db0c1e142c98a6253204d69218557b91a8754337)

Simplify logic
(cherry picked from commit 9a2d3fe1bf9bdad73fbffca44d5c1f02aa9825ae)

Spelling mistake "system_gateways.php"

Fix spelling mistake in "system_gateways.php"

(cherry picked from commit 47180823dc0560801085a227abf512e265363b16)

Fix typo: The input field is named source_hash_key

(cherry picked from commit 870b9bc11b993ce8122b448083d29a04bcb30151)

Fixed #6835 by revising Javascript show/hide

(cherry picked from commit 850c3d8b9352e7467beca8502c24ca8d4fbbbd29)

Make serial/UUID bold

Show system platform and serial / UUID

Obscure RADIUS shared secret.

Ensure a mobile P2 is marked as such when saving.

Use wider display for pftop to fill up dead area. Output still looks OK with narrower terminals as well.

Some views were omitting important info at the narrower width

Declare $config as a global in guiconfig.inc csrf_startup() function, to properly respect the timeouts. Ticket #6803

Apply #601 fix to firewall_nat.php

(cherry picked from commit 4b0815f38a8a0f98519ca0c2bff7c81b6464e579)

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

Do not show certificates in drop-down list that are already contained in this CRL.

Add missing \) and fix syntax

Extra "S" fixed - thanks @rbgarga
(cherry picked from commit d20b69c529654f2b5d4adf9ab2bba5116f980c64)

Add OpenVPN key lengths to Wizard - missed in original PRs

Original PRs and rationale:

• https://github.com/pfsense/pfsense/pull/2944 ("Add missing recommended key lengths/digest to Cert system")
• https://github.com/pfsense/pfsense/pull/2942 ("Add missing recommended key lengths to OpenVPN options")...

Sanitize 'zone' parameter on CP pages

Show a little more key info in main info table

• Key crypto info shown
• TAP/TUN appended to description (important descriptive distinction)
  (cherry picked from commit b1919bc7d635c875c9187df7ac4885cde7acf621)

Merge pull request #3137 from NOYB/Secure_SMTP_Connection_Modes_-_Mutually_Exclusive

Correct indentation.

Fixed #6786 by making table sortable

(cherry picked from commit e846d7f882d57331d7ead5fcf593e7e4daf7e247)

Simplify icmp conversion

pprior code "converts" every icmp type - of which only 3 actually get changed (rest keep same value anyhow!). If also uses a SWITCH {} construct rather than lookup + foreach, which is longer and less efficient.
(cherry picked from commit 0ce1667bc6fe80ef8e6b4d0d6d38d9859d5f4d94)

Improve handling of source-hash key

- Store the source-hash key in its own config field.
- Validate the provided source-hash key. Check that hex string input is
of the form "0x" followed by 32 hexadecimal digits. Any other string
not starting with "0x" is hashed using md5 and stored as "0x" followed...

Add field to specify source-hash key

The source-hash pool option uses a hash of the source address to
determine the translation address. This hashing algorithm is also fed a
key, which unless specified defaults to a random value. This random
value is then generated each time pf is reloaded....

Merged #2975

Fixed #6788 by clearing only the first label in the cloned row

(cherry picked from commit d38d215d1d9429d3a1a15708f92b14cf3a15b247)

Secure SMTP Connection Modes - Mutually Exclusive

Secure SMTP Connection modes are mutually exclusive. Select only one.

Code style changes

(cherry picked from commit b2836666a8e7fc021ea750fafc8fc6e8097d52ff)

Allow packages to request syslogd log socket to be created inside chroot by specifying it in /package/logging/logsocket element. Implements #4898.

Example:
<package>
<logging>
<logsocket>/var/appname/var/run/log</logsocket>
</logging>...

dnsresolver, make interface boxes resizable, to allow for easier picking/checking of multiple selected interfaces

(cherry picked from commit 57625777c88603f1d2ca55cc981c5ec538c3770f)

Fix diag_dns regressions

After testing diag_dns behaviour some regressions have been noticed.

1) Looking up ipv6.google.com (it only has AAAA records) doesn't work
- gethostbyname() only supports v4, ipv6.google.com only has v6
- this bug was recently and inadvertently introduced...

Remove empty concatenation.

(cherry picked from commit a25c797a44e5cd2480947eb5ae427dcb8e0c031c)

Check IP Services - Info Box

Change warning box with dismissal to collapsible info box.

(cherry picked from commit 6f3ac947b2a83f18ade12ad9876fb8d75a9ff3a2)

Fix up/catch up remote syslog areas. Fixes #6780

Remove some more dangling PPTP bits.

Fix description of the VPN remote log setting

Move copyright from ESF to Netgate

Revert "Remove unused file browser.php"

This reverts commit 48ffade7502839380cc6046187e0c1447723d67a.

Move copyright from ESF to Netgate

Remove unused file browser.php

css: Fix jQuery UI widgets' font

Use the main font with jQuery UI widgets (e.g. autocomplete forms)

(cherry picked from commit e540a9d774f5dfcdd18bf51529932f79f78374a0)

[theme] Compact-RED: improve hovered table rows visibility
(cherry picked from commit e5bc38d21b6ac6c419758ecab7b31f7c06a5c53d)

[theme] Compact-RED: compact panel titles

(cherry picked from commit 953a88a4482e72764ba6ab7ed9f0ce2b21748506)

[theme] Compact-RED: make drop-down menus not too "compact"

and improve hovered element visibility

(cherry picked from commit b8916dccad084ffaa4b402c535f4047fb7a51f3c)