pfSense

Allow URLs for TFTP Server (Bug #6634)

The setPattern() thing ain't usable for this and just causes regressions.

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.

Update pfSense.pot

Typo fix

Allow URLs for TFTP Server (Bug #6634)

is_URL() from util.inc is way too limited for this purpose.

experiment with tighter styling

Fixes #6601 clean up installed packages html

clean up Installed Packages widget by removing category

Fix redmine #6640 DHCPv6 server time format

The original code here ended up always applying the time zone offset once, and if you had set dhcpv6leaseinlocaltime then it got applied twice, so Sydney at UTC+10:00 would show UTC+20:00 and presumably somewhere at UTC-04:00 would show UTC-08:00...

Section title was wrong, discovered by mfine

Allow section header to be omitted by specifying "NOTITLE" as the section title.

Allow AES-GCM for P1 where using IKEv2. Ticket #5990

Clarify that HMAC-MD5 key is required. Ticket #6622

Merge pull request #3055 from marjohn56/master

Fix "http://pf.sense/UNKNOWN" links in Pkg Manager

I noticed recently that many packages do not have the 'www' field in the database filled, or have it set to UNKNOWN The way the table is built, this causes bad links to be generated pointing to e.g. http://pf.sense/UNKNOWN. This patch fixes it, causing only packages with actual links to get the <a> tag.

fix typo

Fix license.php to show correct text

Revert wrong conversion in license.php

Update pot

Merge pull request #3059 from NewEraCracker/xml-syntax-fix

Move to Apache License 2.0

Fix xml syntax after license update

Make a function to resync all OpenVPN CSCs and use it when saving an OpenVPN server. Fixes #6139

dse was under contract with BSDP for all the work he did, we own (c)

Review license / copyright on all files (final round)

Fix #6613 Do not show Aply Changes button when Save needed

I got a bit carried away in the fix for #6460 https://github.com/pfsense/pfsense/commit/21c18c3df11547aba172c10f95872dbd8682f7d9
The message here at line 507 should not actually show the Apply Changes button. At this point the user needs to adjust the assigned interfaces and save. Then after saving an Apply Changes button can be used to implement the saved changes.

Review license / copyright on all files (1st round)

Retire deactivated widgets

chmod 0644 php web pages

Retire copyright-master.txt

chmod 0644 php web pages

Retire /usr/local/bin/slowdownpipe.sh

Ignore cp result for cases when files are the same. Ticket #6557

Merge pull request #3057 from wokis/master

Merge pull request #3052 from phil-davis/patch-3

Added and modified functions to send correct Radius attributes to the Radius authenticator.

style sortable tables

clean up captive poral widget

change order of css files in head element

write_config before openvpn_resync here as well. Ticket #6139

Align GIF link options with those currently supported by the base OS. Ticket #6587

Remove GRE link flag options from GUI/backend. Keep link1 as it was also used to add an explicit static route, though the GUI previous GUI option name wasn't related to that at all. Updated GUI description to match reality. Ticket #6586

write_config before calling openvpn_resync. Ticket #6319

DHCP6 init before RA

Some ISP BNG's require that a dhcp6c init is sent before RA. The
additions to interfaces.php adds a new option flag 'dhcp6withoutra',
this flag is set or unset in the WAN DHCP6 section 'Do not wait for a
RA'.

The interfaces.inc file handles this flag and either launches dhcp6c on...

Remove input_errors2Ajax calls, was never implemented. Ticket #3027

fix typo. noticed-by: phil.davis

Add config option for AdvDefaultLifetime, clean up descriptions on other. Ticket #6533

Add configuration for Min and MaxRtrAdvInterval. Ticket #6533

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page.

Fix #6590 NTPd Leapfile Upload

Merge pull request #3037 from NOYB/Check_IP_Services

Fix indent and spaces

Remove stray '

Merge pull request #3046 from phil-davis/portimport

Improve patterns to read dhcpd6.leases to prevent leases containing '}' in ia-na line not showing up. It fixes #6543

Fix #6585 Do not use [] syntax for lookups

IPv6 address plus port is displayed with the format [1:2::3]:80 - the address is in square brackets followed by colon and the port number. This is necessary to disambiguate the port from the address, a good thing. But it messes up the use of the IPv6 address for reverse lookup....

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the...

Show "cannot delete alias" message as error

If I try to delete an alias that is in use, the "cannot delete alias" message was being displayed as the "success" color.

Fix PTR lookups on diag_dns.php. Ticket #6561

Merge pull request #3043 from NOYB/Label_Rename

Correct spacing

Remove debug

(cherry picked from commit 5810f934472368f43942ea66820dc98e17143c19)

Fixed #6577 - Preserve user input on error

Make sure resolv.conf is present during nanobsd upgrade. Fixes #6557

Change group labels s/MAC controls/MAC Address/

webgui tables, doubleclick event to perform 'edit' action, part 2

webgui tables, doubleclick event to perform 'edit' action

ipsec widget, check for valid array

Clarify Negate option description on firewall_nat_out.php.

Check IP Services

Configurable check IP services.
Used by Dynamic DNS services to check IP addresses.
Configure as many check IP services as desired. The first (highest in the list) that is enabled will be used as the default.
A future possibility could be to add an option to the Dynamic DNS entires to use a specific check IP service....

Change button order on diag_dns.php so hitting enter in the field does a lookup rather than update alias. semi-related to Ticket #6561

Update system_usermanager_settings.php

Use of undefined constant min - assumed 'min'

Update system_crlmanager.php

Use of undefined constant min - assumed 'min'
Use of undefined constant max - assumed 'max'

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

Merge pull request #3034 from NOYB/startsWith_Polyfill

startsWith Polyfill

Fixes hidding of custom individual settings when not in use on user manager page.

Diag Tables Last Update

Use correct Thursday abbreviation (s/Thr/Thu/).

Allow wildcard for hostname with Namecheap DDNS. Ticket #6260

Merge pull request #2729 from zevlag/BountyRequestTopic106193

Merge pull request #3018 from phil-davis/usersettings

Merge pull request #3030 from phil-davis/patch-1

Merge pull request #3028 from PiBa-NL/2.3_dnsV6

Rationalize System Update GUI messages

At present, when doing a System Update, there is a message box that says:
"Please wait while the installation of completes.
This may take several minutes."

Between "of" and "completes" is the package name, which is blank in the case of a System Update....

Omit <secret> tags from L2TP in status.php config.xml dump.

Restore 2.2.x and prior means of obtaining pfsync nodes to avoid exhausting memory on systems with large state tables. Ticket #6364

Diagnostics - DNS Lookup, also query for IPv6 addresses

Merge pull request #2944 from stilez/patch-23

Merge pull request #3024 from phil-davis/include_once

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Use the translated destination for kill_states if one exists. Ticket #6531

Correct/clarify column header. Ticket #6530

Fix style

pfSense_get_pf_states always returns source as src and dest as dst, this flipping based on direction is wrong. Ticket #6530

Fix style

Comment typo

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Merge pull request #3019 from NOYB/RFC2136_Client_Edit_Priv_Def