pfSense

Fixed #6703

(cherry picked from commit e5343844c6de78feafae9e601b25bdf31f114a50)

Fixed #6706

(cherry picked from commit b86938e7e19a09a5b1f3f54825193b57f7c73131)

Fixed #6705

(cherry picked from commit d526fc2d2acc87af2ca829dfe01f0037e3368051)

Fixed #6701

(cherry picked from commit 03fd538eefd641771b6302370b901fe4ace3ab4f)

Fixed #6704

(cherry picked from commit fd778d8bef8ea3b0e5dcc8007de242b6e2ac6d5a)

Fixed to properly save configs in PPPs interfaces

Fix wording of the "Reject leases from" option for a DHCP interface.

pfSense.css: Fix sortable tables' font

Experiment using the OS' native font stack

Following the steps of bfbfa4dd254c110db4122925d0a3716a34d4c664,
experiment using the OS' native font stack.

Obtained from the Bootstrap project (twbs/bootstrap#19098,
twbs/bootstrap@0a31dacf3e0c43a73b2e61e266155b9dcce35339)

Add a field to CA/Cert pages for OU, which is required by some external CAs and users. Fixes #6672

Remove defunct link to the devwiki site. Everything is on doc.pfsense.org now.

Fix typo, LT2P->L2TP

Fixed #6669
Read widget config before adding a new one. (Was starting a new array)

(cherry picked from commit 236e6a54e9a93284ca170b68aa1188dfaa195c3d)

experiment with tighter styling

Fixes #6601 clean up installed packages html

clean up Installed Packages widget by removing category

Fix redmine #6640 DHCPv6 server time format

The original code here ended up always applying the time zone offset once, and if you had set dhcpv6leaseinlocaltime then it got applied twice, so Sydney at UTC+10:00 would show UTC+20:00 and presumably somewhere at UTC-04:00 would show UTC-08:00...

Welcome 2.3.2-RELEASE

Allow section header to be omitted by specifying "NOTITLE" as the section title.

(cherry picked from commit 9ce54773be5e02235e3be7d2b970f61fbb27ba86)

Allow AES-GCM for P1 where using IKEv2. Ticket #5990

Clarify that HMAC-MD5 key is required. Ticket #6622

Fix "http://pf.sense/UNKNOWN" links in Pkg Manager

I noticed recently that many packages do not have the 'www' field in the database filled, or have it set to UNKNOWN The way the table is built, this causes bad links to be generated pointing to e.g. http://pf.sense/UNKNOWN. This patch fixes it, causing only packages with actual links to get the <a> tag.

fix typo

Fix xml syntax after license update

(cherry picked from commit f7057140af3a98af925f76b6b0bb544dc7bfc418)

Make a function to resync all OpenVPN CSCs and use it when saving an OpenVPN server. Fixes #6139

dse was under contract with BSDP for all the work he did, we own (c)

Review license / copyright on all files (final round)

Fix #6613 Do not show Aply Changes button when Save needed

I got a bit carried away in the fix for #6460 https://github.com/pfsense/pfsense/commit/21c18c3df11547aba172c10f95872dbd8682f7d9
The message here at line 507 should not actually show the Apply Changes button. At this point the user needs to adjust the assigned interfaces and save. Then after saving an Apply Changes button can be used to implement the saved changes.

Review license / copyright on all files (1st round)

Retire deactivated widgets

chmod 0644 php web pages

Retire copyright-master.txt

chmod 0644 php web pages

Retire /usr/local/bin/slowdownpipe.sh

Ignore cp result for cases when files are the same. Ticket #6557

Fix #6050 DHCP - provide Network Booting display/hide advanced button

This one moves the "Network Booting" above the "Additional BOOTP/DHCP Options". That allows "Network Booting" to be a Display/Hide Advanced group of buttons just like TFTP, LDAP etc. (without a special section header) and for "Additional BOOTP/DHCP Options" to come last on the page....

style sortable tables

clean up captive poral widget

change order of css files in head element

write_config before openvpn_resync here as well. Ticket #6139

Align GIF link options with those currently supported by the base OS. Ticket #6587

Remove GRE link flag options from GUI/backend. Keep link1 as it was also used to add an explicit static route, though the GUI previous GUI option name wasn't related to that at all. Updated GUI description to match reality. Ticket #6586

write_config before calling openvpn_resync. Ticket #6319

fix typo. noticed-by: phil.davis

Add config option for AdvDefaultLifetime, clean up descriptions on other. Ticket #6533

Add configuration for Min and MaxRtrAdvInterval. Ticket #6533

Fix #6590 NTPd Leapfile Upload

Fix indent and spaces

Remove stray '

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the...

Improve patterns to read dhcpd6.leases to prevent leases containing '}' in ia-na line not showing up. It fixes #6543

Fix #6585 Do not use [] syntax for lookups

IPv6 address plus port is displayed with the format [1:2::3]:80 - the address is in square brackets followed by colon and the port number. This is necessary to disambiguate the port from the address, a good thing. But it messes up the use of the IPv6 address for reverse lookup....

Show "cannot delete alias" message as error

If I try to delete an alias that is in use, the "cannot delete alias" message was being displayed as the "success" color.
(cherry picked from commit 04b571e836077c436d109d982be5a8e710ff8aab)

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

Fix PTR lookups on diag_dns.php. Ticket #6561

Change group labels s/MAC controls/MAC Address/

Correct spacing

(cherry picked from commit a0b0acd1540764d5221ea54ea596d569bbe2df2a)

Remove debug

Fixed #6577 - Preserve user input on error

(cherry picked from commit a654d899cd5d288501fea1ec52dba2e3f0e479ba)

Make sure resolv.conf is present during nanobsd upgrade. Fixes #6557

webgui tables, doubleclick event to perform 'edit' action, part 2

(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)

webgui tables, doubleclick event to perform 'edit' action

(cherry picked from commit 54691fc663eae7c6e92e4eaad596906758d7ebea)

ipsec widget, check for valid array

(cherry picked from commit 658180daffe0fe5f005b6fe6b528c758309dffef)

Clarify Negate option description on firewall_nat_out.php.

Change button order on diag_dns.php so hitting enter in the field does a lookup rather than update alias. semi-related to Ticket #6561

Update system_usermanager_settings.php

Use of undefined constant min - assumed 'min'

Update system_crlmanager.php

Use of undefined constant min - assumed 'min'
Use of undefined constant max - assumed 'max'

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

startsWith Polyfill

Fixes hidding of custom individual settings when not in use on user manager page.

Diag Tables Last Update

Use correct Thursday abbreviation (s/Thr/Thu/).

Allow wildcard for hostname with Namecheap DDNS. Ticket #6260

Whitespace cleanup

Make model_number customizable

Make presentation_url customizable

Feature #6388 custom GUI preference settings per user

Rationalize System Update GUI messages

At present, when doing a System Update, there is a message box that says:
"Please wait while the installation of completes.
This may take several minutes."

Between "of" and "completes" is the package name, which is blank in the case of a System Update....

Diagnostics - DNS Lookup, also query for IPv6 addresses

Omit <secret> tags from L2TP in status.php config.xml dump.

Restore 2.2.x and prior means of obtaining pfsync nodes to avoid exhausting memory on systems with large state tables. Ticket #6364

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.
(cherry picked from commit 1f49dd8a3a49b724ded5840c1db6c168ed466aae)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Use the translated destination for kill_states if one exists. Ticket #6531

Correct/clarify column header. Ticket #6530

Fix style

pfSense_get_pf_states always returns source as src and dest as dst, this flipping based on direction is wrong. Ticket #6530

Fix style

Revert "Incorporated ssl changes"

It's a specific 2.4 change, only in master branch

This reverts commit 00a7688401c15015c3f43735b2b1536ebfec7e92.

Comment typo

(cherry picked from commit b069f77e0a5e355e811dd7bd4a4d17a802a3f682)

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Shouldn't the priv match here be set to "services_rfc2136_edit.php*"?

(cherry picked from commit 5c403f843291bdc670dcdb45e1e097f2eb7f36ab)

Load actual value of webguihostnamemenu

This is a string from a list of valid values (empty, "hostonly", "fqdn"). So it is not correct to just gather a true/false value here.
(cherry picked from commit e93242eb2ad5a45fb6ab1526f0b6ddcc716e5b96)

Restored countdown functionality and menu refresh on successful update/remove/install
Added comments to clarify operation of the page

(cherry picked from commit 18295ff2f907f638afa9f7c665cc16e4262e6899)

Clarify ports alias hint. Ticket #6523

% and / are also allowed in values

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

(cherry picked from commit 6ae99aba5cab12440d88dd9ddaa6535c3b9b5d82)

Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue

This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked)....

added missing div.content wrapper when reloading filters

(cherry picked from commit e8406abe627675db2c2f77a81c1bb883f5158bb6)

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....