System / Advanced / Networking - Remove Personalizations
Remove a bunch of "you" personalizations.
Don't log 404s for captive portal. Ticket #6027
Merge pull request #2788 from phil-davis/patch-3
Merge pull request #2791 from NOYB/Interfaces_-_Section_Title_-_Reserved_Networks
Background all the ipsec commands run from status_ipsec.php to make sure they don't hang up the entire GUI. Ticket #5520
Interfaces - Section Title - Reserved Networks
More accurate section title.
Revert "Branch master is now 2.4-DEVELOPMENT"
Fat finger here, rolling back for now
This reverts commit 30d9ba51d194600ccb7d474d998c7491d0ba61b6.
Branch master is now 2.4-DEVELOPMENT
Do not allow empty elements in IPv6 addresses
Redmine #6024Upstream pull request https://github.com/pear/Net_IPv6/pull/14At this point in the checkIPv6 processing the string should be an uncompressed IPv6 addressed - all the elements should have something in them, a "0" if that element is zero. So any zero-length element is a problem.
Disable the check of subqueues bandwidth until it is fixed.
Ticket #5721
Show the full OpenVPN verb debug range same as 2.2.x.
Clarify OpenVPN verb level descriptions
change logos to reflect community edition
HTML Compliance - Firewall / Rules
Error: Duplicate ID frrfc1918.<tr id=frrfc1918>
Pass the correct variable to get_interface_bandwidth(). Fixes the boot crash reported by JimP.
Spotted by: Jorge OliveiraTicket #5721
Fix display of gateway IP address and gateway/group descriptions in firewall_rules_edit.php.
Band-aid to stop this from breaking the firewall. Ticket #5721
Merge pull request #2781 from jlduran/fix-openvpn-client-typo
Fix OpenVPN client additional options typo
Should read client instead of server. Also remove the `push` example.
HTML Compliance - Vertical Align
pkg.php and functions.inc
Add paren here for clarity, suggested by Phil Davis.
Force the existence of bandwidth on root queue.
If the bandwidth is not set the speed of root queue is set by media status.
In this case a ruleset which contains queues with speeds higher than 100Mb/s will fail to be loaded when the root interface is connected to a fast ethernet port (100Mb/s) - but works fine on a gigabit ethernet port....
Remove ssl_stapling. Ticket #6020
One too many "!" in the "Advanced options" button javascript caused the Link parameters to be always hidden
Re-run priv script to pick up changes.
Detect default config flavor
Merge pull request #2776 from NOYB/HTML_Compliance_-_Captiveportal
HTML Compliance - Captiveportal
Text Align & Background Color
Fix syntax error in diag_traceroute
The semi-colon is not needed here.Reported by forum: https://forum.pfsense.org/index.php?topic=108643.0
Don't log to filter.log when local logging is disabled. Ticket #6018
Have recovery mode go to a shell as intended.
possible typo
Fixed #6017
Read return code from right command
The zone parameter needs to be in this html example for CP.
Bump default config ver to 14.8
Merge pull request #2773 from NewEraCracker/small-php-js-tweaks
Merge pull request #2772 from NOYB/HTML_Compliance_-_Diagnostics_/_Test_Port
Merge pull request #2771 from stilez/patch-20
Merge pull request #2769 from phil-davis/btnattr
Merge pull request #2768 from phil-davis/patch-3
Echo boolean value instead of string
Prior to this change, code would echo an empty string if false and 1 if true. In all other files, with similar code, boolean representation is printed.
HTML Compliance - Diagnostics / Test Port
Error: Start tag seen without seeing a doctype first.Expected e.g. <!DOCTYPE html>.Error: Stray doctype.Error: Stray start tag html.Fatal Error: Cannot recover after last error. Any further errors will be ignored.
Remove apparent pointless function (2nd occurance)
replace apparently pointless function in 2 files
Code loops through all return values of get_possible_traffic_source_addresses(true) to create a list of key=>descript list, but the original function returned exactly such a list anyhow with no other data associated with the keys. So the code seems pointless as it replicates exactly the original return value from possible_traffic_source_addresses()....
Reengineer Form_Button setAttribute
As per what was done for https://github.com/pfsense/pfsense/pull/2765 -do it to the rest of them.Seems to work OK.
Allow moving last pool entry
If you are moving load balancer pool entries back and forth between the enabled and disabled pools, you can't move the last entry in the disabled pool back to the enabled pool, which you should be able to do.This change also gives the user flexibility to move the last enabled entry to the disabled, that is helpful if the user is just moving entries around - e.g. putting everything into disabled then adding 1 or 2 back to the enabled. On save, the validation checks that the enabled list has something in it, so the user can;t actually save an empty load balancer pool anyway.
HTML Compliance - Firewall / Schedules / Edit
Error: Duplicate ID tempFriendlyTime.
If there was a group with a space, delete all the user-defined groups before hitting local_sync_accounts so pw doesn't get hung up. Ticket #6012
Merge pull request #2766 from jlduran/nginx-ssl-parameter-on-listen-directive
Reconfigure any VLANs with a lagg parent after recreating the lagg. Ticket #6014
Check whether group exists using GID rather than name. Users can change the name, but not the GID. Check return code of pw for whether group exists. Ticket #6013
Save changes to config in 148 config upgrade. Ticket #6012
Changed the button colors and icons. The fa-terminal wasn't doing it for me :)
Ensure replacement group name is unique
Cleanup nginx configuration file
- Fix indentations- Use the `ssl` parameter of the `listen` directive [1]- Change the rewrite rule to use the recommended syntax [2]
[1]: http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl[2]: http://nginx.org/en/docs/http/converting_rewrite_rules.html
Fixed #6012Config upgrade function replaces space with underscore in group names
Partially fixed #6012 by removing space from chars allowed in group names
Services / DNS Resolver / General Settings
Static should be static.Elements that don't need to be dynamic should be static.More robust than depending on client-side processing to set them.
Suppress dashboard save icon until needed.
GIF had the same problem as GRE with flags, apply the same fix. Ticket #6010
Correct the code saving values for GRE. The GRE configure backend code tests for isset, the way the values were copied before it would be set to 'false' which was still set, so the code always triggered when it shouldn't. When reading back from XML at boot time it's OK, so only the web interface is affected. Fixes #6010
Merge pull request #2761 from heper/patch-1
Merge pull request #2718 from NOYB/JavaScript_Polyfill_-_String_Includes_Method
Merge pull request #2757 from NewEraCracker/allow-ip-as-althostname
Much cleaner like this.
Echoing $pconfig['custom_options'] directly into JavaScript is prone to breaking the script by creating invalid syntax due to characters such as line feeds etc.Best to transfer a flag from PHP.
Use correct variable for the remote ID in IPsec status. Fixes #6009
Add PCI and USB device lists to status output
Temporarily disable PR 2750 pending revision by NOYB
Merge pull request #2762 from phil-davis/patch-4
Redmine #5994 Enhance test for PPP advanced defaults
If pppoe_monthly, pppoe_weekly, pppeo_daily or pppoe_hourly was already set, then when editing the PPP interface the advanced fields were not automagically displayed. They should be, because the user needs to see these settings if they are there....
fix rrd error on boot
Seems to be a copy/paste error remain from when i initially created the dhcpd rrd thingy. Just noticed this now ;)
Mar 17 22:33:34 php-cgi rc.bootup: The command '/usr/bin/nice -n20 /usr/local/bin/rrdtool update /var/db/rrd/opt3-dhcpd.rrd N:U:U:U:U:U:U:U:U' returned exit code '1', the output was 'ERROR: /var/db/rrd/opt3-dhcpd.rrd: found extra data on update argument: U:U:U:U:U'
Redmine #5994 Fix test for default source port fields
Fixes the problem reported by Jim Pingle where the Advanced button for the source port fields would show "Hide Advanced" when creating a new rule from scratch. Now when creating a new rule, it starts off as "Display Advanced" (with the source port fields hidden.
Fixed #6003Corrected showadv logicCorrected long standing iussue displaying reset times (goes back to 2.0)Corrected config save by adding hidden ptpid
FIlebrowser package moved to vendor direcroty
Relocated tree directory to vendors/tree
Revised fix #6007
Fixed #6007Initilize element before refreshing
Remove unneeded control
Merge pull request #2755 from NOYB/HTML_Compliance_-_Services_/_DHCP_Server
Merge pull request #2758 from phil-davis/patch-4
Merge pull request #2754 from phil-davis/patch-3
Redmine #5994 Standardize Unbound custom options button
This is the last piece of code I have for standardizing "advanced" buttons in the UI.
Allow IPs in althostnames
This change will allow implementation of workarounds for bugs involving 'An HTTP_REFERER was detected other than what is defined in System' by adding the IP address to the alternate hostnames list, without having to disable protection completely....
Redmine #5994 Standardize NAT Edit Source Advanced
1) Standardize the way the Advanced button works to display and hide the source address/port fields.2) Remove dstenable boolean - it was always set to 1 (true) and so all the tests that used it were meaningless....
Redmine #5994 standardize firewall rule advanced button
Update file_exists check to full path as done in other files
jquery folder rename to js
JavaScript Polyfill - String Includes Method
A place for JavaScript polyfills.
JavaScript string includes method polyfill. A new method that has not yet found it's way into many browser implementations.Documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes...
Fix CSS paths missed by 9d1be24ef72c0c27fe7a297bf79ec5e4f552a390
HTML Compliance - Services / DHCP Server
Error: The align attribute on the td element is obsolete. Use CSS instead.
shorten ipsec widget refresh time
Fixed #5918 ipsec widget row color on dark theme
Redmine #5994 Standardize source port button
in firewall_rules_edit1) Put some common code fragments into show_source_port_range() and use code that actually successfully changes the button text Display/Hide. Around line 1808.2) Make the button itself be hidden when a protocol is selected that does not use source port range (as well as the source port fields being hidden) - line 1908-1909...
remove extra slash
point css files to the new location
add color to icons
remove old depricated location
Make pkg_mgr_installed.php use an ajax call to avoid GUI timeout when rpeo is unreachable