pfSense

Suppress errors when opening router file. Fixes #11314

Automatic WireGuard interface gateways. Part of NG 5437

Update the Copyright year.

A subsequent commit will deal with .po's.

Ticket #9270: Make sure parameters are UTF-8

As described on ticket, for some reason we still don't know, when
pfSense_kill_states() is called with subnet as parameter (n.n.n.n/n) it
makes changes on $_POST content that can lead system to unpredictable
results....

Fix #204: Add messages to all write_config() calls

Auto add static routes for PPP interfaces. Fixes #10407

Revert "Remove non captive-portal logs from Local4 syslog facility."

This reverts commit 6960993dc53c559619fe3f8d8ea903e7730b4fa6.

Revert "Adjust some missing ident on syslog"

This reverts commit 12719a87e3ba77f5459938a4cfec7f007bbe0c4a.

Check correct value and fix regression introduced by 9eae3005e1200319a14d6ebafe92c52885bf1cfd

Revert "Fix monitor address on correct variable"

This reverts commit 9eae3005e1200319a14d6ebafe92c52885bf1cfd.

Adjust some missing ident on syslog

Fix monitor address on correct variable

Revert "Prevent possible race condition, fixes #9450"

This reverts commit 5affb137561c74bb5559f0706c86c28a85b14557.

Revert "Fix #9450"

This reverts commit 0de6758e2893e4390acfa0b55e31b1dece231618.

Fix #9450

Change default value for clear_alarm to true so cache file is used only
once. We can't be sure the value on cache will remain the same even if
the status of gateway doesn't change.

Replace unlink() by unlink_if_exists()

Style fixes

Add missing parameter to get_dpinger_status() call

Prevent possible race condition, fixes #9450

Instead of calling get_dpinger_status() again in the code handling dpinger
alarms, save the original alarm status in rc.gateway_alarm to a file, then
read the status from the file.

Minor text fix. Issue #10546

No need to log the PID, it's added to the logs anyways.

Add gateway substatus. Fixes #10546

Update return_gateways_status to return a substatus as well as the existing status.

status changed to be one of online or down.
substatus can be one of none, down, highloss, highlatency, loss, latency, or force_down
...

Merge pull request #4190 from vktg/remove00vti

Rework route functions

- Created route_table() that returns an array containing all items from
route table. It uses --libxo to get a json object
- Created route_get() that return an array with route items to desired
target
- Created route_get_default() to get current default route for inet or...

Remove extra 00 padding of VTI interface names. Issue #9592

Fix some illegal string offset errors. Issue #10659

Revise default gateway handling for speed

Move gateway interface friendly name functionality to gwlb.inc

Fix indenting

Fix typo in comment

Revise return_gateways_array() to include the tier name in hte returned array. This avoids the need to call the function for every gateway in the array and makes life easier for system_gateways.php, which no longer needs to call multiple functions to get the display information.

Merge pull request #4240 from Kapmeister/master

Merge pull request #4150 from Augustin-FL/captiveportal-db-sync

Set the default ICMP data payload size to 1 in dpinger probes.

This fixes the dropping of the ICMP probes in some broken routers/ISPs.

There is no increase of the packet size on wire as probes are smaller than 60
 bytes (all probe packets are padded)....

Remove non captive-portal logs from Local4 syslog facility.
Various logs are recorded in local4 in HA situation. They should not be recorded here.
Redmine #97

Telegram Notification Support. Feature #10354

Readmine feature https://redmine.pfsense.org/issues/10354 ready for review.

This is 2020. Issue #9245

Fix syntax error

fixes

fix route delete code

fix route delete code

Suppress errors from touch when marking GW down. Fixes #9851

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Merge pull request #4044 from PiBa-NL/20190127-actually-show-current-default-route

Fix #8821: Deprecate Growl Notifications

Growl appears to be abandoned upstream. No updates in ~5 years, and few if
any users on pfSense

Remove code commented out in 2013

Fix deeper continues. Issue #9365

Target the proper loop in switch statements. Issue #9365

Routing, actually show the "(default)" mark on the default route as it is present on the OS

Most obvious problem was when manually switching from WANGW1 to WANGW2 it showed both as (default) after saving the setting and before applying it. Also after applying it would require another page refresh to show the updated situation. Also add a little information box that shows what (Default) means for the user.

Update gwlb.inc

(cherry picked from commit 58d009bc41137e77d799e53a8ce8c02215274eac)

Update gwlb.inc

Correct BUG 9004 -> set the default gateway when system start and a gateway_group is default IPV4 gateway

(cherry picked from commit 67dd34a0996c14fdfeb1823e07fb3c82748d3794)

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Merge pull request #3987 from PiBa-NL/20180920-apinger-wait-for-terminate

Merge pull request #3984 from luckman212/gwlb-log-spew

garga changes
move conditional before platform_booting
and join w && instead of indenting

gateway monitoring, wait for apinger to terminate or remove its pid file when restarting it.

Fix #8910: Restore older versions behaviour and consider 'wan' interface as primary default gateway

reduce the tons of log spew that currently spit out during boot
and gateway failure events. Try to make the logs readable again,
while still allowing verbose logging if needed via a new hidden
config option:

['system']['gw-debug']

Fixed #8880

Merge pull request #3967 from PiBa-NL/20180729-alias-with-carp-parent

Merge pull request #3962 from PiBa-NL/20180708-routing-default-gateway

interfaces, ipalias fix initializing ipaliases that have a carp parent after interface down / up

Fix PHP error when adding a gateway from interfaces.php. Fixes #8680

routing, when a new pppoe connection is made the gatewaymonitor should be started before decisions about default route can be properly made. also for 'automatic' provide a fallback to the first enabled gateway thats configured, just in case..

Removed debug statement

Changed it to just use the variable name

Fixed #8633 PHP7 issue use of undefined constant, Should work as it did before.

routing, add option 'automatic' for gateway selection, and allow manual ordering of gateways

routeing, gateways show proper IPv4 IPv6 default, also for dynamic gateways

routing, fix setting the default-route when the configured default gateway is a dynamic pppoe gateway. it doesnt have a gateway-status when it hasn't connected yet.

Fix IPsec VTI gateway generation to match interface changes. Fixes #8544

Please welcome routed IPsec using if_ipsec VTI interfaces. Implements #8544

To use, create a P1/P2 and set P2 to VTI using local/remote network as tunnel endpoint addresses, then assign the interface (enable, but IP type = none), and use like any other interface for routing.

Suppress route command errors and related debug output. Fixes #8497

PHP7 - Resolve foreach() warning

Use array tests and operations that are more friedly to PHP 7.2 in gwlb.

Check for valid array before call foreach()

Gateways, allow for configuring a gatewaygroup as the default gateway.
-Avoid changing routes by just visiting a webgui page.
-Avoid change some unneeded events when nothing changed.

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Fix dyndns update with gateway group

Update the Copyright notice for pfSense.

Don't create vestigial gateways, alt. approach

Move this file_exists test inside the dpinger status check loop and also suppress PHP errors from stream_socket_client()
Both are done to avoid a race where the status file can be missing and the status check fails, resulting in an alert/crash report.

Merge pull request #3763 from PiBa-NL/20170624-apinger-initialize

Do not run the dpinger when the IPv6 address has the tentative flag even after the timeout.

Issue #7659 foreach warning on adding gateway

Signed-off-by: Phil Davis <phil@jankaritech.com>

gateway monitoring, give apinger some time to properly 'initialize' before using its results

Merge pull request #3700 from phil-davis/ifgwadd

Simplify indexing of gateways array

Remove obsolete isAjax array key handling

Validate gateway and interface together

Refactor gateway save

Refactor gateway parameter validation

Refactor get_configured_interface_with_descr remove unused parameter

Fix incorrect sorting for various dropdown lists.

Wait while interface is in 'tentative' state before try to bind dpinger to its address

Correctly report unmonitored gateway status

If an alternate monitor IP has been entered and saved, then the user
checks "Disable Gateway Monitoring" and saves, the alternate monitor IP
is retained in the config - that is handy for when unchecking "Disable...

Add a function to format and return plain text output showing the gateway status, for use by a shell script and status.php. Ticket #7046

Add a gateway state plugin hook.

Pull Request #3093

Feature #3151 Disable gateway monitoring actions

without disabling gateway monitoring.

This allows the user to continue to monitor the gateway with dpinger, so
they can see how it is performing, but for the system not to take any
real action if the latency/loss exceeds the given limits....

Add missing L2TP from this gateway handling case. Fixes #6980