pfSense

upgrade_config.inc: Remove all restore_rrd() calls

Commit 0869605131ba3e5d7e502af7a799e54f27d2e7f6 removed the
restore_rrd() function. To avoid errors when restoring older configs
remove all callers to it.

Bug: https://redmine.pfsense.org/issues/8231
Signed-off-by: Alistair Francis <alistair@alistair23.me>

Fix foreach error on hosts that have no dyndns entries.

Update the Copyright notice for pfSense.

Delete keytype field from config, remove unnecessary file cleanup.

Remove old dnssec-keygen style files during upgrade

Fix #7981: Convert PPP ports interface names to new VLAN notation using dots

Fix the QinQ support.

Bring the QinQ support to the VLAN dotted format.

To avoid breaks third party software (such as dhcpd), we silently ignore the interfaces with names bigger than the maximum size in FreeBSD.

Ticket #7942

Change the VLAN inteface names to use the 'dotted' format of FreeBSD, which is shorter and helps to keep the interface name smaller than the limit (16).

This fixes the 4 digit VLAN issues when the NIC name is 6 bytes long.

Ticket #294

Bump config revision, fix comment. Ticket #7809

Setup upgrade code for wireless interfaces to the new format needed for 2.4, and switch rc.bootup so the config upgrade happens before a mismatch test, otherwise we can't fix this type of situation. Fixes #7809

Fix indent/space

Add a function to be called every time convert_config() runs

Unset workaround used to set cronjob on 2.3.x

Add a protection to prevent ending up with duplicate crontab entry

Make sure pkg metadata is updated at least once daily. It will be used to speedup GUI parts related to pkg update

Revise upgrade script to insert support widget at the top of column 2
Add old support widget to obsolete files list

Update config version

Fix upgrade 166 to 167 script

Force the support widget to show when a user upgrades to this version

Fix OpenVPN Auth Digest Algorithm selection so it does not use duplicate/alias names in the list, and fix existing entries on upgrade so they use the actual digest name and not an alias.

Merge pull request #3556 from doktornotor/patch-3

Add upgrade code to work around broken shaper rules from old wizard code. Ticket #7434

Refactor get_configured_interface_list remove unused parameter

Upgrade widget settings for multiple copies of widgets

Upgrade code to convert old Traffic Graphs Widget settings

Add GUI components for loading cryptodev as a module, and upgrade code so users have it on upgrade since it was in-kernel before. Fixes #5976
Having both aesni and cryptodev loaded at the same time appears to only negatively impact performance, no gains, so at the moment there is no need to load them at the same time.

Fix net.inet.ip.random_id tunable description (Bug #6087)

Add a parameter to install_cron_job to stop it from performing its own write_config. Adjust base system calls to match. Ticket #7146

Packages may still need the old behavior but need tested individually. Once all function calls are confirmed to work without the write, the write_config parameter and call can be removed from this function for good.

RAM Disk Management - Config Upgrade

Update OpenVPN protocol preferences to match the new behavior of OpenVPN 2.4. Fixes #7062

Fix unset glxsb

This bit of upgrade_config code needs a global reference to $config

Store Dynamic DNS passwords in Base64 to protect special characters. Fixes #6688

Convert CloudFlare and GratisDNS dynamic DNS over to split hostname and domain name fields, like Namecheap. Otherwise they could both break with subdomains or international TLDs with many parts. Fixes #6778

Deprecate nanobsd platform and remove all conditionals that uses it

Remove all calls to conf_mount_r* functions

Move copyright from ESF to Netgate

Remove references to glxsb as it is not relevant to current supported platforms. Fixes #6755

Code style and comments

No functional change - just making style consistent

Move to Apache License 2.0

Review license / copyright on all files (1st round)

Add upgrade code to clean up the old GRE/GIF flags that are no longer used. Ticket #6586 and Ticket #6587

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Tweak upgrade - Remove unused code and document changes better

This will ensure a smooth upgrade for those running config 15.4 to any next version.

Revert "Add config upgrade code to update package names. Ticket #6118"

This reverts commit 297ace668e4a4ffbf1fb1581e7c765e2ed158e29.

Update L7 config upgrade code removal. Only file notice if it was actually in use, otherwise it just confuses people.

Add config upgrade code to update package names. Ticket #6118

Don't foreach unless it's an array. Ticket #6142

Similar thing to https://github.com/pfsense/pfsense/commit/13dab3538fe8b6c1688142c89a017520ad0aaac6 should be done here in upgrade_130_to_131()

Add config upgrade code for CARP IPs on gateway groups, GRE and gif. Ticket #6222

Don't foreach unless it's an array. Ticket #6142

Update VIPs CARP parent on upgrade. Ticket #6164

Periodic RRD & DHCP Leases RAM Disk Backup

Remove these cron jobs on full install if not using ramdisk.

Add checks in case there are dpinger param problems

in 2.3 installations that were upgraded from 2.2.* when the apinger to
dpinger params conversion code in upgrade_130_to_131() was not so good.

Fix #6142 validate and adjust dpinger params on upgrade

1) The previous "down" value was being converted to msec and put into
"loss_interval". It should go into "time_period".
2) loss_interval must always be at least latencyhigh - make it so if
latencyhigh is big....

Correct OpenVPN upgrade code for topology subnet.

Includes - Remove Personalizations

Remove "you" personalizations.

Bring back rainterface, add config upgrade to convert to new _vip format. Ticket #6043

fix style

Rather than renaming groups with spaces, mark their scope as remote. Ticket #6012

Add brackets for clarity

Add some extra brackets for clarity, rather than relying on the operator
precedence rules. IMHO this makes it more readable, and no need for the
reader to wonder if anything might go wrong with the operator
precedence.

Set the ALTQ root queue bandwidth.

Whenever possible set it to 1Gb, if the sum of child queues if higher than 1Gb, set it the correct value so we do not break any existing setup.

Ticket #5721

If there was a group with a space, delete all the user-defined groups before hitting local_sync_accounts so pw doesn't get hung up. Ticket #6012

Save changes to config in 148 config upgrade. Ticket #6012

Ensure replacement group name is unique

Fixed #6012
Config upgrade function replaces space with underscore in group names

Add the upgrade code for OpenBGPd and Quagga OSPF packages.

Ticket #5884

Merge branch 'master' of github.com:dennypage/pfsense

• 'master' of github.com:dennypage/pfsense:
  Add stddev information to the quality graphs.
  Update config version to trigger upgrade of rrd files
  Add standard deviation to quality rrd files

Add config upgrade code to enable and configure DHCPv6 server and radvd where track6 is in use, as they were automatically configured previously. Add same config to default config.xml to retain existing behavior there. Ticket #3029

Merge branch 'master' of https://github.com/pfsense/pfsense

Internationalize etc inc uvx

Add standard deviation to quality rrd files

Fixed #5873

Fix style issues.

Add the configuration upgrade code to make sure the existent settings will work after the last changes.

The CARP part of this code should be added together with the initial uniqid changes.

Bring NAT separators into the fold.

Also add config empty test to upgrade script.

Firewall / Rules - Page Efficiency Upgrade

1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables....

Remove old pppoerestart cron job if it exists. Ticket #1905

Change Namecheap dyndns to use split hostname and domain name fields. Upgrade existing entries automatically. Implements #4366
Code should be generic enough that if other DynDNS providers would work better with a separate domain field, they can pick up the feature without too much trouble.

OpenVPN server config upgrade already handled in 129_to_130. Ticket #5764

Make sure filter rules have a tracker ID, associated rules were missing it previously.

retain OpenVPN's net30 default topology for upgraded configs so they still work. Ticket #5764

Add uniqid tag to CARP VIPs that don't have one upon upgrade. Ticket #4858

Fix up config setting for killing states on gateway failure. Enable this option where gw_down_kill_states is set. Flip setting accordingly during config upgrade to not use confusing 'kill_states' tag to not kill states. Ticket #5815

Switch to disabling strongswan unity plugin by default. Ticket #4178

Bring text to current reality

Encode DHCP/DHCPv6 server additional BOOTP text options before save to XML to preserve data. It fixes #5623

Add config upgrade code to remove L7 config pieces, and file a notice where found. Ticket #5508

Fix whitespace in upgrade_118_to_119

add config upgrade code for lighty->nginx logging

Fixed #5714

Do not start dpinger processes due to rrd

Disable IPsec phase1 or phase2 using DES and inform user why they were disabled since DES is no longer supported. It should fix #5543

Disable all IPsec P1 entries when old version has IPsec globally disabled. Fixes #5699

Nuke fifolog support. It was never used or fully implemented, no GUI option, and didn't end up working out.
It buffered writes too long, users could never see the most current log data.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Fix GW setting names in upgrade_config

Write upgrade config to replace apinger by dpinger, it should fix #5624

Code style and white space in etc

Include ipsec.inc here otherwise the global is undefined when called when restoring a config in the GUI.

net.inet.ipsec.debug in 10-STABLE and newer is extremely noisy and has a serious performance impact, where that wasn't the case on 10.1 base versions. Change it to 0 on upgrade to avoid problems for those who had it set previously.

Upgrade code to change topology_subnet checkbox to drop-down. Issue #5526