pfSense

Fix selection of dsttype in configs with VIPs defined. Ticket #6173

(diag > edit file) page styling

(diag > command prompt) page styling

pad button groups

Fixed #6095 remove logo from wizards

add jquery ui themes for status monitoring

Merge pull request #2882 from phil-davis/patch-4

Merge pull request #2880 from LucaTNT/patch-1

Merge pull request #2879 from NOYB/Firewall_NAT_-_Remove_Pencil_Icon_From_Aliases

Merge pull request #2875 from NOYB/Interfaces_-_Punctuation

Use English spelling for var name

For future maintenance it might be easier if this var name is spelled with the usual English spelling.

Merge pull request #28881 from phil-davis/patch-4

Fixed #6175

pfSenseHelpers white space formatting

Just a bit of white space and formatting to standardize this code, and a couple of typos in comments.

Added back GET parameters support (as in pre-2.3)

In version 2.3 the Traffic Graph page switched from GET to POST parameters to control the graph.
This patch restores the old functionality, which was useful to bookmark a given graph configuration.

Fixed GPS display sprintf => printf

Removing focus from the anchor gets rid of the annoying dotted box

Update widget to POST link

COmment fix

Make services POST only by providing JS code in pfSenseHelpers.js

Merge pull request #2866 from NOYB/Firewall_/_Rules_-_Underscore_Line_Wrap

Trim the OpenVPN tunnel network before use, and on save. Fixes #6198

Fix an oops.

Firewall NAT - Remove Pencil Icon From Aliases

Don't see the icon adding any value. Consumes space and clutters page. Make consistent with the firewall rules page.

Remove redundant if check.

Interfaces - Punctuation

Merge pull request #2871 from NOYB/System_/_Advanced_-_Punctuation

Unset dhcpdv6 for deleted interfaces on interfaces_assign.php. Ticket #6152

Allow 0 mask on Unbound ACLs. Ticket #6073

Avoid implode error if no interfaces are selected.

Fixed #6171

Fixed #6169
and added alias pop-ups to load_balancer_virtual_server.php

Fixed #6168
Needed to override form action since it was inheriting the current GET arguments

Fixed #6170

Fixed #6158
Really a temporary work-around. This issue requires a better solution in which the data is normalized and added to the <td> via a data-sortable attribute.

Fixed #6161

Merge pull request #2870 from phil-davis/patch-4

Fixed #6163

Fixed #6166

System / Advanced - Punctuation

Fix #6162 saving of bogons update frequency

Another easy fix of a "dumb bug".

Use RFC-defined capitalization IPsec.

Merge pull request #2867 from phil-davis/patch-4

Nuke srctrack default = 1400 per JimP

Fixed #6146

Allow to restore any ares of config

If the existing config does not have a particular area in it, then the user should still be able to restore it from another config.
Redmine #6144

Firewall / Rules - Underscore Line Wrap

Replace underscore with space in display text of certain fields to allow them to line wrap. ex: long alias names

Fix Namecheap DynDNS host parsing for @, fixes #6122

Merge pull request #2863 from phil-davis/widget-arrows

Fixed #6128

Use consistent arrow colors on dashboard

Interfaces widget and IPsec widget use text-success and text-danger to
make the up and down arrows be green and red.
This change does the same thing to OpenVPN and WoL widgets for
consistency.

Cosmetics

Fixed #6117

Merge pull request #2862 from NOYB/Services_/_DHCP_Server_-_DNS_Servers_Clarification

Fixed #6114

Fixed #6112
by adding isset() to checkbox value

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Fixed #6096

Fixed #6092

Fixed #6104 by changing trash icon to trash-o icon so that the JA configmation is not triggered.

Merged #2854 and updated to increment only the deleterow button

Fix add delete of rows with buttons

Redmine #6101
Forum https://forum.pfsense.org/index.php?topic=109554.0

Merge pull request #2860 from phil-davis/ipsec-keys-infobox

Merge pull request #2859 from phil-davis/patch-7

Merge pull request #2858 from jlduran/fix-ipsec-spd-arrow

Merge pull request #2856 from phil-davis/patch-5

Merge pull request #2855 from NOYB/System_/_General_Setup_-_Remove_Beta_Badges

Merge pull request #2853 from NOYB/Miscellaneous_II_-_Remove_Personalizations

Make VPN IPsec Keys messages proper infoblock

Redmine #6107
Note: I made this text be open by default on the edit page (blockopen)
because maybe users should see it by default.

Make forwarder info boxes consistent with resolver

DNS Resolver just has a single info box at the bottom of its settings page.
DNS Forwarder has different print_callout stuff that looks inconsistent with the rest of the GUI pages.
I have made it consistent with DNS Resolver, which does not have those bits of text describing host and domain overrides....

Fix the IPsec SPD arrows

Currently, a `BLACK RIGHT-POINTING POINTER` and a `BLACK LEFT-POINTING
TRIANGLE` are used to display the direction.

This commit changes both arrows to be `POINTER`s.

Fix extraneous chars in help texts - OpenVPN Server

Redmine bug #6102

System / General Setup - Remove Beta Badges

Remove beta badge from Associated Panels Show/Hide options.
Remove beta badge from Left Column Labels option.

Miscellaneous II - Remove Personalizations

Remove "you" personalizations.

Miscellaneous - Remove Personalizations

Remove "you" personalizations.

Merge pull request #2850 from NOYB/Traffic_Shaper_Wizard_-_Remove_Personalizations

OpenVPN Wizard - Remove Personalizations

Remove "you" personalizations.

Avoid PHP warning if no server selected

when saving a client specific override.
Forum report https://forum.pfsense.org/index.php?topic=109431.msg0
Redmine issue 6089

Traffic Shaper Wizard - Remove Personalizations

Remove "you" personalizations.

Deprecate references to modulate state. Remove rule allowing TCP 1723 inbound when PPTP client is in use, as that's unnecessary.

Redmine #6081 do not reuse index var

The value of $i needs to be kept constant from the outer loop - do not reuse it here.

Fix typo

services_ntpd_pps remove bonus f

Only apply htmlentities() once on each data element

Redmine #6079

Add Unbound to license.php. Ticket #5903

Rework the way repo packages work

- Distribute only a single pfSense-repo package containing all templates
- Create a symlink pointing to selected repo
- Do not limit it only to pfSense-repo and pfSense-repo-devel

(cherry picked from commit a90f1c9b12c4d31ea845fa04188e599ba28dbaf1)

Fix missing space in status_ipsec.php

Add a missing space before NAT-T

Eliminate "onclick" from child SA buttons
Revise recording of open children

Fix wording on advanced IPsec settings titles.
strongSwan doesn't get restarted in debug mode, it just changes the verbose level of log sections. Old terminology was leftover from racoon days.

Correct logic for display of MAC address & vendor (if present). Fixes #6078

Merge pull request #2839 from phil-davis/patch-6

Merge pull request #2841 from NOYB/System_-_Miscellaneous_-_Remove_Personalizations

Merge pull request #2840 from phil-davis/patch-7

Merge pull request #2837 from phil-davis/we

Merge pull request #2836 from phil-davis/patch-4

System - Miscellaneous - Remove Personalizations

Remove "you" personalizations.

Allow to update existing alias from diag DNS

See Redmine #6077
This seems the easy and reasonable thing to do. Make the button text reflect what is going to happen "Add alias" or "Update alias". Then the backend code can just either create a new alias or overwrite an existing one.

Handle alias from CNAME in diag_dns

If I resolve a CNAME with diag_dns, it gives back the translated FQDNs - e.g. www.inf.org translates to inf.org. Then press "Add Alias".
Problem: The existing code puts a "/32" CIDR after that in the alias "www_inf_org" in the config - "inf.org./32" - and if you then edit the "www_inf_org" alias it shows as "inf.org./32" in the Network or FQDN Address field. Normally when putting an FQDN into an alias, no CIDR is inserted....

Truncate alias name at 31 characters to prevent creating an invalid ruleset. Ticket #6075

Remove "we" personalizations