pfSense

Remove redundant if check.

System / Advanced - Punctuation

Unset dhcpdv6 for deleted interfaces on interfaces_assign.php. Ticket #6152

Allow 0 mask on Unbound ACLs. Ticket #6073

Avoid implode error if no interfaces are selected.

Fixed #6171

(cherry picked from commit ed49fe7ae13c01ee083c3f205b86c6713e0d90a3)

Fixed #6169
and added alias pop-ups to load_balancer_virtual_server.php

(cherry picked from commit 0200db178ef225f796aea837e33ae438f5899ae3)

Fixed #6168
Needed to override form action since it was inheriting the current GET arguments

(cherry picked from commit 91cd1923b133c57eaa9897ce4574ce19b7122dc4)

Fixed #6170

(cherry picked from commit a2050d386f99bf027b70de5aa4b4aa713a49e5b9)

Fixed #6158
Really a temporary work-around. This issue requires a better solution in which the data is normalized and added to the <td> via a data-sortable attribute.

(cherry picked from commit 106eb8d38db478616499f0c5ee220596dca9f57a)

Fixed #6161

(cherry picked from commit 24828c63965b9be493db486fa5a46ab64c8091db)

Fix #6162 saving of bogons update frequency

Another easy fix of a "dumb bug".
(cherry picked from commit d1acd5bb5723e66bc5871bdf4335208253f5a4bd)

Fixed #6163

(cherry picked from commit bcb3c9283e45eb4e741cbfa5d79e56d5f5bf678a)

Fixed #6166

(cherry picked from commit ebaf36ebe5b6f409887d2352db44aba45bf7e086)

Use RFC-defined capitalization IPsec.

Allow to restore any ares of config

If the existing config does not have a particular area in it, then the user should still be able to restore it from another config.
Redmine #6144

Nuke srctrack default = 1400 per JimP

(cherry picked from commit 509c089479525d69b714fef3f9d7770610719408)

Fixed #6146

(cherry picked from commit b3fc5089d679d7d43fc1e00400af8038b65c8998)

Fix Namecheap DynDNS host parsing for @, fixes #6122

Use consistent arrow colors on dashboard

Interfaces widget and IPsec widget use text-success and text-danger to
make the up and down arrows be green and red.
This change does the same thing to OpenVPN and WoL widgets for
consistency.

(cherry picked from commit fa5f513658f7f1aba530e76e01dfbc021605c3ad)

Fixed #6128

(cherry picked from commit e8d6c134fe44f0ad1756caa246a7c6efbbd27bbc)

Cosmetics

Fixed #6117

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Fixed #6114

Fixed #6112
by adding isset() to checkbox value

Merged #2854 and updated to increment only the deleterow button

Fixed #6096

Fixed #6092

Fixed #6104 by changing trash icon to trash-o icon so that the JA configmation is not triggered.

Fix add delete of rows with buttons

Redmine #6101
Forum https://forum.pfsense.org/index.php?topic=109554.0

Make VPN IPsec Keys messages proper infoblock

Redmine #6107
Note: I made this text be open by default on the edit page (blockopen)
because maybe users should see it by default.

Make forwarder info boxes consistent with resolver

DNS Resolver just has a single info box at the bottom of its settings page.
DNS Forwarder has different print_callout stuff that looks inconsistent with the rest of the GUI pages.
I have made it consistent with DNS Resolver, which does not have those bits of text describing host and domain overrides....

Fix the IPsec SPD arrows

Currently, a `BLACK RIGHT-POINTING POINTER` and a `BLACK LEFT-POINTING
TRIANGLE` are used to display the direction.

This commit changes both arrows to be `POINTER`s.

Fix extraneous chars in help texts - OpenVPN Server

Redmine bug #6102

System / General Setup - Remove Beta Badges

Remove beta badge from Associated Panels Show/Hide options.
Remove beta badge from Left Column Labels option.

Miscellaneous II - Remove Personalizations

Remove "you" personalizations.

Miscellaneous - Remove Personalizations

Remove "you" personalizations.

Traffic Shaper Wizard - Remove Personalizations

Remove "you" personalizations.

(cherry picked from commit a0e3dab3a64aff6045eb3acf40706aead39c306a)

OpenVPN Wizard - Remove Personalizations

Remove "you" personalizations.

(cherry picked from commit 1c43074ace32fc986cda93c4533d366080887381)

Avoid PHP warning if no server selected

when saving a client specific override.
Forum report https://forum.pfsense.org/index.php?topic=109431.msg0
Redmine issue 6089

Deprecate references to modulate state. Remove rule allowing TCP 1723 inbound when PPTP client is in use, as that's unnecessary.

Redmine #6081 do not reuse index var

The value of $i needs to be kept constant from the outer loop - do not reuse it here.

Add fingerprint for RELEASE pkg sign key

Fix typo

services_ntpd_pps remove bonus f
(cherry picked from commit 0f191478bab18158a70439f279d7232855928afe)

Silence /etc/rc.notify_message garbage output

Fix code used to read config repo path

Do all steps to replace repo package and make sure symlink is in place

Force update after reinstall repo pkg

Only apply htmlentities() once on each data element

Redmine #6079
(cherry picked from commit 82cde7f1067f527df5e902cf1bc7070612d039f4)

Simplify logic

(cherry picked from commit 05bdceee8c8fd598cdf83dc57c4006e20612e26d)

Make sure directory exists

Add Unbound to license.php. Ticket #5903

Make sure source file exists

(cherry picked from commit 75cdfae39bff2b5ccc523cc32df7dde99f04eeed)

Add a workaround on pfSense-upgrade to make sure repo package is replaced by correct one

Rework the way repo packages work

- Distribute only a single pfSense-repo package containing all templates
- Create a symlink pointing to selected repo
- Do not limit it only to pfSense-repo and pfSense-repo-devel

Do not return -1, sh doesn't like it

Merge pull request #2843 from jlduran/fix-missing-space-status-ipsec

(cherry picked from commit f332da5fbb0ca2018f1ff733208702bc5ad77b2d)

Eliminate "onclick" from child SA buttons
Revise recording of open children

(cherry picked from commit 067551a44058656cd980bd95f55c59399c5c36af)

Fix wording on advanced IPsec settings titles.
strongSwan doesn't get restarted in debug mode, it just changes the verbose level of log sections. Old terminology was leftover from racoon days.

Correct logic for display of MAC address & vendor (if present). Fixes #6078

Handle alias from CNAME in diag_dns

If I resolve a CNAME with diag_dns, it gives back the translated FQDNs - e.g. www.inf.org translates to inf.org. Then press "Add Alias".
Problem: The existing code puts a "/32" CIDR after that in the alias "www_inf_org" in the config - "inf.org./32" - and if you then edit the "www_inf_org" alias it shows as "inf.org./32" in the Network or FQDN Address field. Normally when putting an FQDN into an alias, no CIDR is inserted....

Merge pull request #2841 from NOYB/System_-_Miscellaneous_-_Remove_Personalizations

(cherry picked from commit 3061702cce23fcc5259f7d6d119a6fe05de84149)

Merge pull request #2840 from phil-davis/patch-7

(cherry picked from commit 64c3e9a58d426637fa91996d3a30695f10e01e70)

Merge pull request #2837 from phil-davis/we

(cherry picked from commit f4d13d55d7b15449780b5eb521f54d76d8279df5)

Merge pull request #2836 from phil-davis/patch-4

(cherry picked from commit b102779f21ab50d3de3dc41a63ab5cffae378f78)

Truncate alias name at 31 characters to prevent creating an invalid ruleset. Ticket #6075

Merge pull request #2835 from phil-davis/patch-5

(cherry picked from commit 146684ee657f0f146afad5aa9d74b89884ee4c53)

Merge pull request #2832 from NewEraCracker/lang-fixes

(cherry picked from commit c67308d9b8e36fc73cb3c4381861698aa73bee00)

Merge pull request #2834 from phil-davis/patch-4

(cherry picked from commit 2fdd07e9bbb5eda3c42c9d1cb4980d668f8dfcdf)

Fixed #6068

(cherry picked from commit 669343a2d37534fec4a41c3b2c6c8cd1bf4e1170)

COrrected missing "<"

(cherry picked from commit 9723b525a4ec62946248014747bfa1f4ed2ef8ae)

Ticket #6053

- Do not call ntpdate before start ntpd, ntpd g parameter is enough
Deprecate /usr/local/sbin/ntpdate_sync_once.sh
- Remove system_ntp_configure parameter and always start ntpd

Set exec bit on gmirror_status_check.php

Fixed #6049

(cherry picked from commit 4260c32a42c6d0201737730a373e795703ca1141)

VPN / IPsec - Remove Personalizations

Remove "you" personalizations.

(cherry picked from commit dbe87243ffef17cc41f7fe3bc5fa02ed1372059d)

Make sure repo metadata is updated before any other package when repo conf changes. Fixes #6052

Correct input type to 'text' for RADIUS shared secret used by wireless hostap interfaces. Fixes #6067

Fixes corrupted display when special chars appear in the alias

(cherry picked from commit f14ec73c66c341464b9bd893175732b188049d24)

Merge pull request #2808 from NOYB/Firewall_/_NAT_-_Remove_Personalizations

(cherry picked from commit 4012d55c028ca1c4d449e7b80ba738d4dd5b2976)

Merge pull request #2830 from NOYB/Diagnostics_-_Remove_Personalizations

(cherry picked from commit 235d9db9da3f871d6daefa4130abb8fb960a0222)

Merge pull request #2829 from phil-davis/openvpn-widget

(cherry picked from commit 1dae6c0f4184ac72c252fb934d2bfa4fd3a967fe)

Merge pull request #2828 from phil-davis/widget-personalizations

(cherry picked from commit e18fb7e8bbf8c26639d0598fa04320c5608ce660)

Merge pull request #2827 from NOYB/Status_-_Remove_Personalizations

(cherry picked from commit 94463e858131f23d44bfdb72cd3c8b053cf6ed28)

Merge pull request #2826 from NOYB/VPN_/_OpenVPN_-_Remove_Personalizations

(cherry picked from commit 28ca20bb51fb3002f89c026f160e7d6ea0c4d310)

Merge pull request #2825 from NOYB/VPN_/_L2TP_-_Remove_Personalizations

(cherry picked from commit 1505c1350e19c70a2ee4a2bf524497cede51eccf)

Merge pull request #2823 from derelict-pf/patch-1

(cherry picked from commit b3d255deb16192ad33cbcd4cb157cf9acf1919fb)

Merge pull request #2822 from NOYB/Services_/_Wake-on-LAN_-_Remove_Personalizations

(cherry picked from commit 5ec4c7fda092991c3574f5857a0917d54613682b)

Merge pull request #2821 from NOYB/Services_/_PPPoE_Server_-_Remove_Personalizations

(cherry picked from commit 378f989cdc07a61bc1a8c2964c249922a416f51c)

Merge pull request #2820 from NOYB/Services_/_NTP_-_Remove_Personalizations

(cherry picked from commit 72c57c3f09f483e747480e704e1b0090e32a728e)

Merge pull request #2819 from NOYB/Services_/_Load_Balancer_-_Remove_Personalizations

(cherry picked from commit 6d105e8d5ded647dfc65cbc9625c41a3afc74a0e)

Merge pull request #2818 from NOYB/Services_/_IGMP_Proxy_-_Remove_Personalizations

(cherry picked from commit 81513d46cb78834b2dbd4e9f585b0a8b38d75e07)

Merge pull request #2817 from NOYB/Services_/_Dynamic_DNS_-_Remove_Personalizations

(cherry picked from commit a6108e4983a8d9a75d5c607fff6538604df369a7)

Merge pull request #2816 from NOYB/Services_/_DNS_Resolver_-_Remove_Personalizations

(cherry picked from commit 09aad9f8a6f190f4ca5cf2f08a824af695da6304)

Merge pull request #2815 from NOYB/Services_/_DNS_Forwarder_-_Remove_Personalizations

(cherry picked from commit 1301cc6700b4d8831aaa819dffb7f2f056ee3ac2)

Merge pull request #2814 from NOYB/Services_/_DHCP_-_Remove_Personalizations

(cherry picked from commit b68e48f20c6ae99786e67372f802d16aacf22de3)

Merge pull request #2813 from NOYB/Services_/_Captive_Portal_-_Remove_Personalizations

(cherry picked from commit cbe2d30f3b69f35ee2a174e931209a49cee594c6)

Merge pull request #2812 from NOYB/Firewall_/_Virtual_IPs_-_Remove_Personalizations

(cherry picked from commit 70ecf3db0aa1c0ec04784a69942788f6fef29ec4)

Merge pull request #2811 from NOYB/Firewall_/_Traffic_Shaper_-_Remove_Personalizations

(cherry picked from commit 7f824121528288fdcc493f36da25c61982f4e320)