pfSense

format correction

Added real DUID placeholder, new text and call to new get_duid_from_file() function.

Typo correct

Text change

User Defined DUID

User may define a DUID to use in System->Advanced->Networking. The
entered DUID is validated for composition and length, if valid it is
stored in the config.xml. On call of wan_dhcp6_configure() the DUID is
written to file to be read by dhcp6c on launch.

Merge pull request #3301 from doktornotor/patch-1

Use empty()

Fix display of the number of states in the firewall rules page

For numbers greater than 1000 format_number() returns strings formatted like N.NNN K/M/G/T, that get cut to only the integer part if '%d' is used.

Fix CPU update period in System Information widget

This only updates after the refresh period set in System - General Setup - Dashboard update period; should not be hardcoded.

Allow "DHCP" in upper or lower case when adding LAN IP to setup wizard

Do not enter or leave the persistent maintenance mode if the CARP is temporary disabled.

While here update the CARP status check.

Test fix for #6762

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

Merge pull request #3299 from phil-davis/patch-8

NAT 1:1 use constant name when checking validateipaddr return value

Merge pull request #3299 from phil-davis/patch-8

Fix #7021: Deprecate device polling

Fix #6927 1:1 NAT validate address family

Ensure that all the manually-entered addresses come from the same
address family - i.e. they are all either IPv4 or IPv6 addresses.

Captive Portal: convert active sessions table to a sortable table

Convert the active sessions table in the captive portal status page to a sortable table and remove the old sorting code. The conversion fixes both sorting by ip address and by last activity time.

"Internationalize" help text in router advertisements

Merge pull request #3291 from doktornotor/patch-4

Merge pull request #3295 from marjohn56/No-Release

dhcp6c no release

Script changes to allow no-release option of dhcp6c. These changes to be
used in conjunction with pfSense/FreeBSD-ports/net/dhcp6c recent change
from PR #231

Revised #6889 to use formatted list syntax

COmpleted #6889 by re-formatting help text

Merge pull request #3286 from plumbeo/danger-lower-case

Reset the $icon variable (otherwise it can keep the last value - in a few broken cases)

Update pot

Merge pull request #3289 from doktornotor/patch-2

Update pot

Validate IP addresses using validateipaddr() function

status_queues.php - remove redundant escaping

Update pfSense.pot

Unbound - add support for "deny_non_local" and "refuse_non_local" ACLs (Feature #6914)

Update pfSense.pot

Improve RADVD router mode help text (Todo #6889)

Fix up validation and encoding on Captive Portal status pages. Fixes #7019

Fix capitalization of confirmation messages for btn-danger buttons and fa-trash icons

Value and title were converted to lower case but not textContent. Consequently some pop-up messages included capitalized words, for example in the Log Settings page ("Are you sure you wish to Reset Log Files?").

Merge pull request #3283 from doktornotor/patch-1

Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702

Update pfSense.pot

Added a function validateipaddr() use as:
// Validate a network address
// $addr: the address to validate
// $type: IPV4|IPV6|IPV4V6
// $label: the label used by the GUI to display this value. Required to compose an error message
// $err_msg: pointer to the callers error message array so that error messages can be added to it here...

Update pfSense.pot

Correct the descriptions and behavior of the Adaptive Start and Adaptive End settings.

Merge pull request #3274 from phil-davis/dhcpv6serverrelay

Merge pull request #3271 from phil-davis/dhcpserverrelay

Merge pull request #3277 from phil-davis/patch-2

Check for lo0 when reconfiguring VIPs on sync. Fixes #7010

status_dcp_leases change if statement style

Status DHCP Leases show CID and other enhancements

1) If there is a Client Id specified then show it (otherwise it is possible to define a Static Mapping that has only Client Id and all other fields empty, which would look like an empty row in the displayed table)....

Merge pull request #3275 from phil-davis/patch-9

Merge pull request #3272 from phil-davis/patch-7

Merge pull request #3270 from phil-davis/patch-5

Services DHCPv6 Static Edit fix var name

The example format at the end of the error message was not coming out.

DHCPv6 server edit when DHCPv6 Relay enabled

Part of Redmine #6997
This implements the similar behaviour as for the DHCPv4 server in Pull
Request https://github.com/pfsense/pfsense/pull/3271

Status DHCP Leases table row end

Each row of the table needs a tr end, only the last row was getting the tr end.

DHCP server edit when DHCP Relay enabled

Part of Redmine #6997
1) Display the DHCP Server settings even when DHCP Relay is enabled, but
disable the "enable" checkbox in this case - so the user cannot enable
DHCP Server when DHCP Relay is enabled, but can view and modify the DHCP...

DHCPv6 Relay Form_IpAddress is V6

DHCP4 Relay must relay to an IPv4 address

This code would accept an IPv6 address, but that causes an error to be reported by the DHCP (v4) Relay service on startup.
Validate the destination server IP address(es) to ensure they are IPv4.

Improve input validation for services_dhcpv6_relay

Make the same imrovements as was done for services_dhcp_relay in commit https://github.com/pfsense/pfsense/commit/ac999f3b7894bd8d5fc35419a22cc2df39416e42

Do not allow a group name to start with 'pkg-', reserve it for packages use (e.g. tinc)

Update interface group name validation rules to match ifconfig

Fix #6976: Make sure interface description, interface name and alias don't have the same name

Ticket #6976: Check disabled interfaces

Fix CA input validation to (again) allow an import without a key. Fixes #7001

Update services_captiveportal.php

fixes https://redmine.pfsense.org/issues/6391

Improve input validation for services_dhcp_relay

While looking at interactions between DHCP Relay and DHCP Server, I noticed a few annoying/inconsistent things in driving the UI:
1) If there were validation errors on the Destination Server IP Addresses that the user input, messages would be given about invalid addresses but the data in the Destination Server row(s) would be reset to what it was before the user started editing, losing whatever they changes they had been trying to make so far....

move export button to heading for status monitoring page

Fix #6472: Enable/Disable associated firewall rule when NAT rule changes

Ticket #6472: Respect disabled field

Respect disabled field when creating firewall associated rule

Do not set disabled or nordr fields when they are not selected. Checks are using isset() and not its boolean value

Rule type icon should not change to 'X' when disabled

Fix copy/paste error in variable test.

Change (assign) to Assignments in Interfaces menu
Add HTML divider in Interfaces menu to separate actions form the interface list

Fix log file deletion

Remove destination self from NAT 1:1

It is not needed and caused problems if used and was not remembered on
edit anyway.

Merge pull request #3257 from phil-davis/patch-7

Feature #3151 Disable gateway monitoring actions

without disabling gateway monitoring.

This allows the user to continue to monitor the gateway with dpinger, so
they can see how it is performing, but for the system not to take any
real action if the latency/loss exceeds the given limits....

Merge pull request #3256 from phil-davis/patch-5

Merge pull request #3249 from plumbeo/idletime-in-sessiontime

Merge pull request #3240 from derelict-pf/ldap_starttls

Fix #6224 NAT edit - preserve user selections when input errors

1) Edit a NAT Port Forward rule, change the destination type to "Network", but do not input any network address/mask.
2) Press Save, an input error is reported telling that the network destination address/mask is required - good....

NAT 1:1 edit - preserve user selections on edit-save with input errors

1) Edit a NAT 1:1 rule, change the source and/or destination type to "Network", but do not input any network address/mask.
2) Press Save, input errors are reported telling that the network source and/or destination address/mask is required - good....

Tidy input errors in services_ntpd_acls

1) If there are multiple rows with invalid IP addresses then the same message was displayed multiple times. We might as well let the use know which row(s) have the problem.
2) The section that checks is_subnet stuff was first using is_ipaddr() (redundantly given it is already in the else of !is_ipaddr() ), and then is_subnet() - these would have handled both the IPv4 and IPv6 cases, so the other IPv6 tests would never have happened....

Merge pull request #4815 from doktornotor/patch-2

Merge pull request #3159 from stilez/patch-46

Merge pull request #3181 from moisseev/master

remove bogus debug

Fixed #6454
Fixed #6984

Do not truncate IPv6 addresss in NTP widget (Bug #4815)

Captive portal: add option to include idle time in total session time

Add an option to choose whether the time spent idle by a user disconnected for exceeding the idle timeout must be included in the total session time sent to the RADIUS server or not.

Remove the PHP limit from diag_dump_states(), it is now managed on pfSense_get_pf_state().

OpenVPN populates IPv6 env vars now, so we can fetch them for the IPv6 gateway. Fixes #6016

Merge pull request #3145 from skrude61/master

Standardize and fix 'other' type VIP display on NAT pages. Fixes #6094

Fix 'Other' type VIP options. Ticket #6094
While here, remove some defunct 'range' code that was never used.

Merge pull request #3213 from PiBa-NL/interfaces-gateway-message

Merge pull request #3246 from overhacked/dhcpd-dyndns-force-hostname

Add decoration to "On latest version" message

Revise status messages. Adjust PID file timeout to accommodate slower systems