pfSense

Allow upload of favicon.ico without prefix adding

Comment out no longer used function. Remove after next release.

Merge pull request #2872 from phil-davis/dpinger-params-check

Merge pull request #2890 from phil-davis/patch-4

Merge pull request #2889 from NOYB/Firewall_-_Punctuation_-_Clean_-_Up

Fix #6212 Really disable checks

Belts and braces here - I the setTimeout is not done then the other bits of code do not get called anyway, but I took them all out to make sure there is no way to accidentally do the update check when it is disabled.

Fix validation of v4 in v6 rules and vice versa. Ticket #6211

Fix selection of dsttype in configs with VIPs defined. Ticket #6173

Firewall - Punctuation Clean Up

Some punctuation clean up.

(diag > edit file) page styling

(diag > command prompt) page styling

pad button groups

Setup HTTP_PROXY environment variable for pkg when it's called from the GUI and also for pfSense-upgrade

Fixed #6095 remove logo from wizards

add jquery ui themes for status monitoring

Make sure FreeBSD repo is disabled on a static file tracked by base package

Merge branch 'patch-7' of https://github.com/phil-davis/pfsense

• 'patch-7' of https://github.com/phil-davis/pfsense:
  Escape username before use in CP SQL

Merge pull request #2886 from phil-davis/patch-6

Merge pull request #2885 from devnullity/patch-1

Merge pull request #2882 from phil-davis/patch-4

Merge pull request #2880 from LucaTNT/patch-1

Escape username before use in CP SQL

A maybe "better" version to try.

Merge pull request #2879 from NOYB/Firewall_NAT_-_Remove_Pencil_Icon_From_Aliases

Merge pull request #2875 from NOYB/Interfaces_-_Punctuation

Handle single quotes in user names for CP

Forum: https://forum.pfsense.org/index.php?topic=110243.0
This is a trial - make sure it really works before committing.

Fix trivial GUI typo.

TRB should be TBR for "Token Bucket Regulator".

Use English spelling for var name

For future maintenance it might be easier if this var name is spelled with the usual English spelling.

Merge pull request #28881 from phil-davis/patch-4

Fixed #6175

pfSenseHelpers white space formatting

Just a bit of white space and formatting to standardize this code, and a couple of typos in comments.

chmod +x on rc.backup_aliastables.sh. Ticket #6189

Added back GET parameters support (as in pre-2.3)

In version 2.3 the Traffic Graph page switched from GET to POST parameters to control the graph.
This patch restores the old functionality, which was useful to bookmark a given graph configuration.

Fixed GPS display sprintf => printf

Removing focus from the anchor gets rid of the annoying dotted box

Update widget to POST link

COmment fix

Make services POST only by providing JS code in pfSenseHelpers.js

Merge pull request #2878 from NOYB/Alias_Tables_RAM_Disk_Store

Merge pull request #2877 from phil-davis/dns_get_record

Merge pull request #2866 from NOYB/Firewall_/_Rules_-_Underscore_Line_Wrap

Trim the OpenVPN tunnel network before use, and on save. Fixes #6198

Fix an oops.

Firewall NAT - Remove Pencil Icon From Aliases

Don't see the icon adding any value. Consumes space and clutters page. Make consistent with the firewall rules page.

Fix #6187 Handle Growl IP Address problems

Alias Tables RAM Disk Store

If ramdisk is enabled keep a copy of the alias tables to restore at boot time. Otherwise unpredictable behavior may occur due to some aliases not being available when the firewall rules load.

Because alias tables are typically somewhat static, the following strategies are employed to keep write cycles to a minimum for SSD and flash drive type devices friendliness....

Remove redundant if check.

Interfaces - Punctuation

Merge pull request #2871 from NOYB/System_/_Advanced_-_Punctuation

Merge pull request #2874 from jlduran/6143-fix-sshd-log-spam

Unset dhcpdv6 for deleted interfaces on interfaces_assign.php. Ticket #6152

Allow 0 mask on Unbound ACLs. Ticket #6073

Avoid implode error if no interfaces are selected.

Fix sshd can't load key log spam

Closes [6143](https://redmine.pfsense.org/issues/6143)

Fixed #6174

Fixed #6171

Fixed #6169
and added alias pop-ups to load_balancer_virtual_server.php

Fixed #6168
Needed to override form action since it was inheriting the current GET arguments

Fixed #6170

Fixed #6158
Really a temporary work-around. This issue requires a better solution in which the data is normalized and added to the <td> via a data-sortable attribute.

Fixed #6161

Merge pull request #2870 from phil-davis/patch-4

Fixed #6163

Add checks in case there are dpinger param problems

in 2.3 installations that were upgraded from 2.2.* when the apinger to
dpinger params conversion code in upgrade_130_to_131() was not so good.

Fixed #6166

System / Advanced - Punctuation

Merge pull request #2869 from phil-davis/dpinger-upgrade

Fix #6162 saving of bogons update frequency

Another easy fix of a "dumb bug".

Use RFC-defined capitalization IPsec.

Unset dhcpdv6 on LAN here as well. Ticket #6152

Merge pull request #2867 from phil-davis/patch-4

Add lock in vpn_ipsec_configure. Ticket #6160

Add table.css to Obsoleted files list

Fix #6142 validate and adjust dpinger params on upgrade

1) The previous "down" value was being converted to msec and put into
"loss_interval". It should go into "time_period".
2) loss_interval must always be at least latencyhigh - make it so if
latencyhigh is big....

Nuke srctrack default = 1400 per JimP

Fixed #6146

Allow to restore any ares of config

If the existing config does not have a particular area in it, then the user should still be able to restore it from another config.
Redmine #6144

Firewall / Rules - Underscore Line Wrap

Replace underscore with space in display text of certain fields to allow them to line wrap. ex: long alias names

Correct OpenVPN upgrade code for topology subnet.

Fix Namecheap DynDNS host parsing for @, fixes #6122

Put gateway name and group around the correct way

Redmine #6134
Forum: https://forum.pfsense.org/index.php?topic=109781.0
Originally broken by commit: https://github.com/pfsense/pfsense/commit/d18f3f6e09b86359395cd78db2e19f721818b992

Merge pull request #2864 from NOYB/Update_RRD_Script_-_Comments

Merge pull request #2863 from phil-davis/widget-arrows

Fixed #6128

Update RRD Script - Comments

Correct units in conversion comments.

Use consistent arrow colors on dashboard

Interfaces widget and IPsec widget use text-success and text-danger to
make the up and down arrows be green and red.
This change does the same thing to OpenVPN and WoL widgets for
consistency.

Cosmetics

Fixed #6117

Merge pull request #2862 from NOYB/Services_/_DHCP_Server_-_DNS_Servers_Clarification

Fixed #6114

Fixed #6112
by adding isset() to checkbox value

Services / DHCP Server - DNS Servers Clarification

It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.

Fixed #6096

Fixed #6092

Fixed #6104 by changing trash icon to trash-o icon so that the JA configmation is not triggered.

Merged #2854 and updated to increment only the deleterow button

Fix add delete of rows with buttons

Redmine #6101
Forum https://forum.pfsense.org/index.php?topic=109554.0

Merge pull request #2861 from NOYB/Easyrule_Block_Firewall_Separators_Update

Merge pull request #2860 from phil-davis/ipsec-keys-infobox

Merge pull request #2859 from phil-davis/patch-7

Merge pull request #2858 from jlduran/fix-ipsec-spd-arrow