pfSense

GET/POST conversions

Merge pull request #3545 from phil-davis/patch-6

Only save valid widget locations in config

Some widgets create extra panels, e.g. the widgets that now have the filter functionality. Those panels are processed in the ".each" at line 424. They do not have an id in the form "widget-*" and when the old code tries to find the "*" part it gets "undefined". This results in the layout being saved like:...

Allow 5 dashboard columns to work

Selecting 1,2,3,4 or 6 dashboards columns results in an exact integer result here and all is good. But 5 columns results in "2.4" and "col-sm-2.4" is not a thing in bootstrap.
We need just the best int we can choose here, which is one that is just the int part of the division. That ensures that the 5 columns extend over less than the standard bootstrap total of 12 "units" wide.

setHelp and getttext for i*.php files

Remove \n from gettext strings

Change system admin to firewall admin

Fix #7043 Do not display crash reporter link when no crash_reporter access

Deprecate nanobsd platform and remove all conditionals that uses it

Remove all calls to conf_mount_r* functions

Move copyright from ESF to Netgate

Remove references to glxsb as it is not relevant to current supported platforms. Fixes #6755

Be sure that user_settings for widgets is an array

Save widget settings per user

For users that have "custom settings" enabled, save the "tool" settings
of their widgets on a per-user basis.
User that do not have "custom settings" enabled will continue to use and
save widget settings to/from the system-wide settings.

Fixed #6669
Read widget config before adding a new one. (Was starting a new array)

Move to Apache License 2.0

Review license / copyright on all files (final round)

Merge pull request #3018 from phil-davis/usersettings

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Feature #6388 custom GUI preference settings per user

Fix Redmine #6097

Replace '/usr/bin/grep -vi warning' with '/bin/cat'

Remove "we" personalizations

Status - Remove Personalizations

Remove "you" personalizations.

Suppress dashboard save icon until needed.

point css files to the new location

Status / Dashboard - Conceal save icon when not dirty.

remove troubleshooting code

Fixed #5953 Dashboard widget alignment issues

Limit widget column to dashboardcolumns

Stops widgets from "going missing" when the user reduces the dashboard columns in System, General Setup.
If the user just lowers dashboard columns to see what happens, then increases it again, the actual column settings are preserved in the config, so the widgets go back where they were. That seems a good thing....

Fix for but #5901

Move the widgets save out of index.php jquery and into head.inc php along with it's counterpart the available widgets icon.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Improvements to the priviledge filter functionality

Remove Non-Existent Class - help-icon

Remove non-existent help-icon class statements from index and head.

Remove no longer needed function

rules -> widgets

Typo

Add gettext to icon title

evised #5796

Completed #5796

Internationalization graph guiconfig head index

Special Panels - Show/Hide

Add configuration option to show or hide special panels.
When a panel is hidden a button is displayed on the page title bar to toggle the panel display.

Small tunning to all aspects involving widgets

1) Perform exclusion of non .inc files while reading directory. 2) Be more strict when checking for widget title. 3) We are in the PHP 5.5 age. We can convert certain pieces to anonymous functions and overall better coding.

Improved widget sorting (case insensitive)

Final Fixd #5774

Temporarily fixed #5774

Revise sorting to accommodate firewall logs name (logs)

Consistent panel-heading h2

Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0

Sort the Available Widgets before display
Remove unused modal

print_info_box success

In most situations we want the print_info_box() of $savemsg to be
'success'. If there was some problem saving, then it can be 'warning'.
These are a few places I have found so far that need this sort of fixing
up - more to come but sleep calls just now!...

Fixed #5659

Fixed #5653
Removed bogus code that forced system information to be first in the list
Added JS to always add system_information to col 1

Merge pull request #2265 from phil-davis/r017

Merge pull request #2266 from NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel

HTML Compliance - Dashboard - Widget Config Panel

Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
Fix the widget config/wrench icon href.
Add matching widgetname id tag to widgets configuration panel div element....

Use different var name looping through columns

There is some problem with the var $i getting reset somehow somewhere
related to the include of each widget PHP code. I found that this was
doing $i = 1, $i = 2 and then $i = 2 again and I got fatal errors
because each widget code was being included twice....

HTML Compliance - Dashboard

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

The .panel-footer requires mod to the widgets with config options. So will submit separate commit so it can be handled independently....

Code style index.php

Couple of little bits here.

Further refinement to widget config

Fixed the broken widget config action (again)

no longer used

fixed issue where if all widgets were in col2, no col1 was created

Reverted commit 677d8bdfebace3321da677a57a0756a27332d505, PR 2218
because it broke all of the widget configuration actions.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Code style g-i

HTML Compliance - Dashboard

HTML compliance (aside from the active widgets).

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

Use the _title var to make the widget title

Each widget has an include file that already has the required widget
title in a var like $dyn_dns_status_title $carp_status_title etc.
Use that var to set the displayed title of the widget, rather than the
stuff that was capitalizing the file name and then having a list of...

Added status page links to widget titles

remove comment

add option to choose number of dashboard columns

Experimental changes to Form_Section() to allow the panel to be made collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY

Type up SCRIPT tags

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Completed #5499

Redmine #5492 case of acronyms in widget names

I am not sure how else to do this. If someone in future writes a widget about "Smart Carp" (an intelligent species of fish) then it will get turned into "SMART CARP". The other strings are not English words, or parts of English words, so not likely to be matched wrongly in future....

Fix widgetname variables

These were wrong. But actually I don't think any widgets use this mechanism of $config['widgets']['mywidget-config'] - they seem to do their own thing making names for the keys they use in $config['widgets'] to store their settings. So I didn't find anything actually broken because of this.

Ticket #5470 fix dashboard breadcumbs

Completed #5470

Fix icon in dashboard

DEBUG code for Redmine: 5463

Ticket #5471 another convert batch to font-awesome icons

Move the widget icons back to the right

Fixed #5463

Make the display of hardware crypto information more reliable at least for AESNI.

Issue: #4911

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Correction per Phil Davis

First batch of copyright updates

Remove unnecessary functions verify_all_package_servers() and check_package_server_ssl()

Further refinement to #5223
Prevent "Store widget configutation" button from apeparing when opening/closing the available widgets panel.

Comment fix

Fixed #5280

update widget header color and fix collapse toggle

Fixed #5236

Fixed #5234
Javascript Base64 class was MIA

improve spacing for non form panels

Use product_name global variable in more places

Corrected page title (which was using incorect PHP format)

Corrected logo hyperlink
Changed Jumbotron font to white so you can actually read the text

To not try to include files that don't exist

Fix comment style