pfSense

Validation for GUI custom settings. Fixes #8726

Add validation for customizable GUI setting fields and test submitted
values before allowing them to be stored.
Also ensure that dashboardcolumns is an integer before using it in the
GUI.

(cherry picked from commit 9ceace2562e718b9b460633847c12050fff96640)

Fix up user/group management save message descriptions, add logging for same. Fixes #8548

(cherry picked from commit 3fa6d46229757e2316120a7160a806bb7d28a8ed)

Fix #7469

Sort users / groups alphabetically on config.xml

Update the Copyright notice for pfSense.

Change how SANs are generated from the CN, considering that not all CNs will produce a valid SAN. Fixes #8252

Changed maximum length of usernames from 16 to 32 characters. This seems to be some old FreeBSD requirement which is not needed anymore.

Reindex the user and group arrays after deleting items, to avoid operating on incorrect array entries. Fixes #7733

Add the username as the first SAN when making a user certificate from the user manager creation screen. Fixes #7666

Provide a useful error message to the user when there is no private CA with which to create a new user certificate. Fixes #7585

Merge pull request #3629 from doktornotor/patch-18

Add user option to sort interface names

Merge branch 'master' into patch-18

Redmine #7381 Disable detail in alias popup

Add missing include

User Manager - Status Icon - Sort Order

Make status column sort order work correctly with the icons.

(2.4, 2.3)

User Manager - Status Icon

Use icon for status rather than textual asterisk to indicate disabled account.

(2.4, 2.3)

Revisions to GET/POST conversion limiting POSTs to save, apply, and delete functions

GET/POST conversion

Fix keylength.com href in system_usermanager

The literal <a href=... text was displaying here, not an actual link to keylength.com
While here, reformat to take the HTML out of the main setHelp string.
Note: the literal text keylength.com has also been taken out of the main setHelp string, because it is literally the referenced site URL text, so it would not be appropriate for it to be translated.

Automatic GET to POST functions moved to pfSenseHelpers.js so they can be used by any page

Improve comments

Experimental method to convert GET calls to POST

Required fields for System pages

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Breadcrumb links

Change "privilege" to "access"

in various text to make it read better

Use admin rather than root in UI text

Add security notes for privilege assignment pages

Suggested solution for Redmine 2247

clarified input format hint for expiration date

Remove all calls to conf_mount_r* functions

Move copyright from ESF to Netgate

Code style and comments

No functional change - just making style consistent

Move to Apache License 2.0

Review license / copyright on all files (final round)

Remove input_errors2Ajax calls, was never implemented. Ticket #3027

webgui tables, doubleclick event to perform 'edit' action, part 2

Merge pull request #3018 from phil-davis/usersettings

Merge pull request #2944 from stilez/patch-23

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Feature #6388 custom GUI preference settings per user

Merge pull request #3002 from NewEraCracker/patch-invalid-foreach

Merge pull request #2989 from phil-davis/patch-2

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

Validate submitted groups when editing a user. Ticket #6475

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

Changed element type from date to text. Date inputs are not yet handled consistently accross different browsers :(

Miscellanous Textual Corrections - Add missing dots to phrases

Add missing recommended key lengths to user manager

Add key lengths to user manager options

Fix typo

System / User Manager - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

System / User Manager / Users / Edit

Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).

Error: Stray end tag td.

Fixed #5911

Restore infoblock functionality for now

Replace alert with callout. Removed mention about greyed out icon - that is no longer applicable.

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Merge pull request #2637 from k-paulius/patch-6

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Indicate in the breadcrumb if we are editing list item.

Synchronize page title with tab title

Convert section titles to title case

Fix description disappering when editing admin user

Internationalize system user and group code

UI Consistency

1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g....

Fixed #5566

Allow thee use of multiple infoblock on a page

Change the automatic information block to look for <div class="infoblock" instrad of <div id="infoblock"
Just makes more sense to use a class for this

Adjust more calls to print_info_box with unquoted strings

HTML Compliance - System / User Manager / Users

A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.

Remove $closehead variable

Remove unused variable $closehead

system_usermanager remove unused code

1) Line 448 "Remove this certificate association? (Certificate will not be deleted)" there was the text "Delete" being displayed and not looking good, in addition to the trash bin icon. Just the trash bin icon seems to be all that is needed....

Code style system_*

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Standardize breadcrumbs for User Manager tabs

I think this is the way it should be to make it like everywhere else.
Even when in the "Groups" pages, it is still reached by "System" "User
Manager".

Fixed #5389

Merge pull request #2134 from ExolonDX/branch_04

Type up SCRIPT tags

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

fix moveOption function

Ticket #5471 another convert batch to font-awesome icons

Fixed #5416

undo earlier commit

Merge pull request #2047 from heper/patch-2

Fixed #5405

fix submit & move back to seperate ACT==delprivid

the code for delprivid was inside ACT==save / when hitting 'save' the post-data for delprivid was already gone

Completes #5400, #3999, #5405
Mote: New ticket will be opened to provide IP address sorting

partial fix Bug #5389

Fixed #5388

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Copyright updates Batch 2 of 3

Delete confirmation vi fa-trash automated via pfSense.js

Moved action-buttons in-line styling to pfSense.css

replace and find for icon-embed-btn