pfSense

util.inc: fix incorrect resource test in unlock()

Refactor some direct config access in sysctl

Correctly identify newer AWS instances

Remove unnecessary count param. Fixes #13890

Fix PHP error on diag_backup.php. Fixes #13876

Check IP service list corrections. Fixes #13862

Fix conf history confirmation prompt. Fixes #13861

• Change confirmation method to be compatible with usepost
• Update action icon titles to be more descriptive, which improves the
  confirmation dialog text as well as accessibility.
• While here, add a note to restore message about how to activate the...

Add bandwidth selections for pipes regardless of whether passthrumac is set. Fixes #13853

Locate cron jobs more accurately. Fixes #13833

Fix cron job removal. Fixes #13833

Fix copy/paste error. Issue #13831

Fix catch syntax and variable usage. Fixes #13831

• Add variable back to catch statement
• Use the exception message
• Correct error message when this exception is thrown
• Fix inaccurate/inconsistent error message when catching

Restore resolver host override sorting.

Fix #13799: Unbound python module persistently shows enabled in resolver settings.

Change captive portal counter keys to string keys. Fixes #13418.

String keys for rule counters are introduced in php-pfSense-module v0.89

Fix loading the i915 driver for MBT in 2.7.

Include all interface IPs and VIPs in cpip table. #13391

The cpzoneid_<zone>_cpips tables only include the IP and VIPS of the final
interface searched, causing captive portal zone associated with multiple
interfaces to work improperly.

The revision prior to this erroneously reassigned $cpiplist at each iteration...

Remove rules before unlinking the db files

xmlparse.inc: tweak the handling of XML listtags that are parsed as leaf strings

Correct check IP service config path.

Revert "Pass reloadall flag to dhcp6c config. Fixes #13253"

This reverts commit 8e88bd48a22b55d213ac7613be74c651706cfa0d.

Always declare $config global in case a script is included in a non-global scope

$config is expected to always be a global containing the parsed configuration,
however in the sources that it is assigned a value in toplevel scope it is not
explicitly declared as such. As a result, if one of these sources is included in...

Fix more config access regressions in filter.inc. Fix #13754

Fix regression allowing blocked MAC addresses to login. Fix #13747

PHP 8.1 fixes for DNS Forwarder Hosts/Overrides. Fixes #13781

Correct DHCP lease reg enabled test. Fixes #13782

Revert "Fix more config access regressions in filter.inc. Fix #13754"

This reverts commit c0d7519df5dc1632ba9f2791ab377bdc19f45105.

Fix more config access regressions in filter.inc. Fix #13754

Redo Unbound ACL action handling. Fixes #13767

Don't load CSRF timeout from config. Fixes #13757

This allows us to reorder includes so that authgui.inc can load auth.inc first, which fixes several auth mechanisms that rely on this order for GUI pages.

Protect mem_usage() from doing arithmetic with empty sysctl values.

get_single_sysctl() may return an empty string in some conditions, there is no
guarantee that it returns an expected int value. Protect mem_usage() from
attempting to do arithmetic with sysctl values unless they are definitely...

Remove trailing whitespace

Remove cxl from altq capable interfaces list

Some cleanups in system_routes.php

Clean up some global access in system_routes_edit.php

Fix gateway list for static routes. Fixes #13761

Revert "Correct includes/load order in guiconfig.inc. Fixes #13757"

This reverts commit 2a24c162e0a8e69d176c54b5a7be09b23cb233f8.

Correct includes/load order in guiconfig.inc. Fixes #13757

The recent change here ended up loading some things out of order.

Another DDNS empty entry fix. Fixes #13581

Improve handling of empty DDNS entries. Fixes #13581

UPnP rule/service cleanup. Fixes #13755

• Fix several incorrect config paths/tests
• Fix UPnP local interface automatic rule to pass traffic into UPnP
  itself.
• Wrap all rules/anchors in UPnP enabled test, no reason for them to be
  in the ruleset if UPnP is off....

Fix config access regressions in filter.inc. Fix #13754

Fix direct config accesses in unbound for php81

Fix DHCP server ping check option. Fixes #13748

Restore default interface media selection. Fix #13635

Restore default description behavior. Fix #13739

Prevent get_pf_rules() from indexing a string error. Fixes #13660

pfSense_get_pf_rules(), which populates the $rulescnt variable sent to
get_pf_rules(), will terminate its loop fetching rules if a call to
pfctl_get_rule() returns nonzero, adding to the associative array return value...

Remove leftover debug prints.

Work around for empty config tags. Fixes #13564.

Related to issue #13642, the serialization of route maps was broken for a time
in such a way that the frrglobalroutemaps tag would contain only a single empty
config tag. The xml parser element handler considers 'config' to be a 'list...

globals.inc needs to be sourced in auth_func.inc

Improve visibility of select fields in dark theme. Fix #11730

Rector direct global g accesses

Use correct UPnP enabled test. Fixes #13735

Add ifmcstat to status.php. Implements #13731

Use rtrim for trimming whitespace and EOLs from version files

Cleanup globals.inc. Use single quotes on scalar strings.

Eliminate some direct config access in util.inc, add some documentation

Add append hook to globals.inc.

Fix a regression caused by Rector: Fixes #13712

Replace direct config access in services_dhcp.php. Fix #13719

Eliminate backticks shell execution operator in diag_system_activity.php.

Fix unnecessarily duplicated work. Issue #13250

Introduce public accessors for $g: g_has, g_get, and g_set.

Improve LDAP debug logs. Implements #13718

Revert "Remove unused global $config_extra"

This reverts commit e36bc382ae1e0533c328b9dcd99959b17171de2e

Remove unused global $config_extra

Remove unused xmlreader implementation and conditional sourcing

Disable MTU input for a bridged interface

Bridge member interfaces cannot have their MTU configured independently from a
bridge, this change disables the MTU input for an interface that is configured
as a bridge member and replaces any configured value with the bridge's actual...

Add ovpn qinqs to bridges instead of rebuilding them. Fixes #13666

qinq interfaces defined with parent openvpn interfaces are configured late in
rc.bootup, after qinqs for other physical and logical interfaces and bridges are
configured. The resolution to #13225 ensured that these late interfaces were...

rc.ipsec: Strip bonus quotes. Fixes #13076

The string was coming from check_reload_status wrapped in quotes that
were not necessary, and were causing the string to not match when it
should have.

$usedmacs should never be a string, default should be an array. For #13705

Rector some direct config gets with complex paths.

Pass reloadall flag to dhcp6c config. Fixes #13253

This ensures that if the interface is being configured in a way that requires a reload, that the DHCP6 client is also restarted. This allows the DHCP6 client to restart when applying settings and during other necessary events.

Rector some config unsets with complex paths.

DDNS Save+Force timeout improvements. Fixes #12870

• In PHP8, curl_close is a no-op, so remove it.
• Now that curl_close does nothing, we have to set CURLOPT_FORBID_REUSE
  to prevent connections from getting stuck in a pool waiting for reuse.
• Add a couple more debug log entries for when certain functions end,...

Rector some direct config sets with pure scalar paths.

DHCP6 Adv field validation errors. Fixes #13493

A few fields were being validated but not informing the user when the
values were bad. This commit lets the user know when they have entered
invalid data in the affected fields.

Rector some direct config gets with pure scalar paths.

Rector some more direct config unsets with pure scalar paths

Rector some direct config unsets with pure scalar string paths.

IPsec cert SAN improvements. Fixes #13373

• Improve descriptions of IPsec P1 cert fields.
• Allow using a cert with a wildcard SAN so long as there is at least
  one non-wildcard SAN.

Add CA/Cert invalid descr char list to help. Fixes #13387

Fix regression in URL alias parsing. Fixes #13685

Correct special net NPt dst prefix handling. Fixes #13240

Disables prefix length drop-down when using a special net (e.g. track6
delegated prefix) because that already has its own prefix length.

Being able to specify a custom prefix was of dubious use and served to...

Use 'ip' when copying+converting addr rules. Fixes #13364

Ensure copied rules get unique IDs. Fixes #13507

Omit RAM disk size check when disabled. Fixes #13479

Remove unused deprecated code from dhclient script. Fixes #13501

Add CDATA protection to "hint". Fixes #13388

rc.linkup code refresh and fixes. Fixes #13254

• Update code to be more compatible with PHP 8.1
• Consistency changes to code and logging so every path has similar
  output instead of some being unusually different.
• Do not restart unbound on linkup as other mechanisms already do that...

Fix more Rector foreach fallout

Restore unintentionally removed line. Issue NG 9247

captiveportal: actually allocate a pipe number for new clients

When a client authenticates to the captive portal we generate a pipe
number (actually two) for it. However, we did this with
'check_only = true', so the next client got assigned the same pipe...

Fix gif interface _routerv6 files not being created. Fixes #11545

interface_gif_configure() uses the global variable $g to look up the temp
directory in which to write the router/gateway files used for gateway
monitoring. The declaration of $g in this scope was inadvertently removed in...

Add iface to some resolver restarts. Fixes #12612

A few interface-specific calls to restart the resolver were not passing
the interface name to ensure it was only restarted when necessary.

Fix PPP reset hr/min blank vs 0. Fixes #13307

Replace direct config accesses in services_dhcpv6_relay.php. Fixes #13676

Fix PPP interface regression

Correct console set IP addr script. Fixes #12632

• Prompt to replace default gateway instead of only setting if it was
  empty before.
• Correct faulty assumptions about WAN or LAN interfaces and either
  remove unnecessary checks or change so they look for presence of a...

Fix descr for unbound network ifs. Fixes #13453