pfSense

Fix #9121: Initialize arrays to prevent PHP 7 errors

Remove unneeded commas

Redmine #8592: Clarify DHCP hostname registration

Add GUI controls to the DNS Resolver for providing DNS over TLS service to local clients. Implements #8030

Add GUI option for DNS over TLS. Implements #8388

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Update the Copyright notice for pfSense.

Merge pull request #3183 from znerol/feature/master/register-openvpn-cn

Restructure how unbound zone data is written to fix processing of "redirect" zone entries. Fixes #7690
Also corrects some other misc issues for formatting of zone data.
While here, add an option, not exposed in the GUI, for users to get the previous behavior of defining short names for hosts.

Clarify checkbox help text

Register CN of OpenVPN clients in DNS Resolver

Merge pull request #3610 from stilez/patch-57

Textual changes requested

Add reason to write_config() calls

change "returned" -> "to return"

better title

Clearer narrative for domain override on main resolver config page

Clearer narrative for domain override on main resolver config page

Only allow the DHCP registration options to be enabled when DHCP server is enabled as well

GET/POST conversions

Remove unneeded sprintf from setHelp calls

Code with multiple %s in usr/local/www

Required fields in Services pages

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Merge pull request #3343 from phil-davis/retval1

Breadcrumb links

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Update format

Improve Unbound forwarding mode description

Make this consistent with System - General Setup - DNS Server Settings.

Merge pull request #3104 from PiBa-NL/resizable-selectionbox

dnsresolver, make interface boxes resizable, to allow for easier picking/checking of multiple selected interfaces

Move copyright from ESF to Netgate

Move to Apache License 2.0

Review license / copyright on all files (final round)

webgui tables, doubleclick event to perform 'edit' action, part 2

Miscellaneous Textual Corrections - Services DNS Resolver

Services - Punctuation

Clean up some services menu punctuation.

Services / DNS Resolver - Remove Personalizations

Remove "you" personalizations.

Echo boolean value instead of string

Prior to this change, code would echo an empty string if false and 1 if true. In all other files, with similar code, boolean representation is printed.

Services / DNS Resolver / General Settings

Static should be static.
Elements that don't need to be dynamic should be static.
More robust than depending on client-side processing to set them.

Much cleaner like this.

Services / DNS Resolver / General Settings

Echoing $pconfig['custom_options'] directly into JavaScript is prone to breaking the script by creating invalid syntax due to characters such as line feeds etc.
Best to transfer a flag from PHP.

Redmine #5994 Standardize Unbound custom options button

This is the last piece of code I have for standardizing "advanced" buttons in the UI.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Advanced button consistency. Ticket #5965

Add Actions column heading

to other places where it was missing, for UI consistency.

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Review alert wording.

Synchronize page title with tab title. Convert page title to title case.

Use a better check for whether there are DNS servers available with dynamic WAN types. Ticket #4747

Verify a DNS server exists before allowing enabling of forwarding mode. Ticket #4747

Merge pull request #2120 from NOYB/Services-DNS_Resolver-System_Domain_Local_Zone_Type

Standardize print_apply_box usage

1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually....

Remove unnecessary checks. Code prevents var from being empty.

Wrap var in string with braces.

Move unbound local zone types array to function in unbound.inc.

Protect against breaking the system; check for valid unbound local zone type rather than just the setting existence.

Remove errant var set to self.

Break long line of local zone types list.

add call gettext function in the services menu

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Allow thee use of multiple infoblock on a page

Change the automatic information block to look for <div class="infoblock" instrad of <div id="infoblock"
Just makes more sense to use a class for this

Adjust more calls to print_info_box with unquoted strings

Fixed bug to disable dns resolver service

Remove $closehead variable

Remove unused variable $closehead

Code style services

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Revise child icon

Add fa icon to show override is a child

Standardize DNS Resolver breadcrumbs

Remove txtsupport from Unbound. Of limited use, and the back end code was never ported over from the package (and is messy to do so). Ticket #5545

Services - DNS Resolver - System Domain Local Zone Type Option

Expose system domain unbound local-zone type to be configurable.

Type up SCRIPT tags

Listen port type should probably be 'number' instead of 'text'

Listen Port Config Not Being Saved - Correct it.

Services DNS Resolver Listen Port Placeholder

Add default value (53) placeholder.

Merge pull request #2115 from NOYB/Services-DNS_Resolver-Host_Overrides-Case_Sensitivity

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Various updates to privileges and related metadata

Services - DNS Resolver - Host Overrides - Case Sensitivity

Host and domain names are not case sensitive. Maintain display case as entered.

Typo fix

Change Form_TextArea to Form_Textarea
(autoload now makes the classes case sensitive)

Completed #5407

Correct Form_TextArea -> Form_Textarea

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Add tr/td to empty tbodys for Microsoft IE

Unbound UI Review

Few things found when looking at the Unbound UI code

Completes #5400, #3999, #5405
Mote: New ticket will be opened to provide IP address sorting

Rearrange calls in unbound.inc so config text can be generated without writing the actual file and a syntax check can be run. Rearrange services_unbound.php to wait until input checking is complete before saving things to global config and run syntax check as part of input checking. Implements #4411.

EOL whitespace and header consistency for www

Fix services_unbound.php. The interfaces menus did not display the selected
interfaces, they always showed "all" selected. Made it so an "apply changes"
message shows when something changes.

Copyright updates Batch 2 of 3

Delete confirmation vi fa-trash automated via pfSense.js

Moved action-buttons in-line styling to pfSense.css

replace and find for icon-embed-btn

Buttons changed to new design

convert services_unbound to fa

Fixed #5045

Addresses #5159 by removing hide/show/disable/enable functions to included file

bootstrap, small fixes to unbound/dnsmasq edit pages, service icons.
+ FIXME item that prevented lots of pages from loading..