pfSense

Use central download function

Reduce duplicated/inconsistent code by using the new download function.

(cherry picked from commit ecb594d094ce0e11cacd9062ebd0aa0ba190444a)

change http to https for redirect link

(cherry picked from commit a3d92f1b47ca82707b5ba760bb31a8f21f9e4e28)

cosmetic

(cherry picked from commit 81157e5c9872594afd8238445299fb5a1ffc2030)

export aliases to txt file

(cherry picked from commit 0cdb5e9569f4be2aa5a42cb7f986b3c218ab3bf2)

update redirect to issue tracker

(cherry picked from commit 01e88604e991901dbd56fa4ed33ae9687d153d6c)

Fixed 10156
Fixed 10157

New redirects.netgate.com/whatever links set up and incorporated in menu system

(cherry picked from commit f07e6d64f0f94fe7f58fc7ada12d42bcf705dc88)

Revise survey wording

(cherry picked from commit ed6f2195b282008e7d84a087759dbc6b4fc23eed)

Fixed #10154 by revising wizard text

(cherry picked from commit 3ac4b218bc493e004aaf60abdc4a39bdafada07a)

Remove redundant DNSimple instructions

(cherry picked from commit 01a6ef7b28907021533df2b3a17ed05451bbbd31)

check ntp acl only for localhost block

(cherry picked from commit 7faeec0727528d27afbcd1462d5f726985e951e7)

Merge pull request #4155 from BBcan177/RELENG_2_4_5

Do not allow 'invert match' and 'any' on firewall rules. Fixes #10168

The backend code ignores the invert in this case, and it makes the GUI
render confusingly (!* which could never match anything)

(cherry picked from commit 40baab141eb30b11b57efa0cf14521021aa7b4c7)

Add a few more common ports to list. Fixes #10166

(cherry picked from commit d2c6e89c40b1bff2deb1f0a8847a5199b317ba0f)

Unbound python integration

Remove deprecated & unused option that wasn't displayed in the GUI.

(cherry picked from commit 839bf5a209274f9f2e8152815612fa9cd6f50e1a)

Remove vestiges of legacy ACB system

(cherry picked from commit 8a6d9d7f82e7a992d2c48910fb4bb847b28f3f45)

Remove some outdated references. Issue #10156

(cherry picked from commit e48255d5b36fdb953af8afeb775686c619c52500)

This is 2020. Issue #9245

Add help for missing pages. Issue #10135

Relocate IGMP proxy verbose setting. Fixes #10139

Update some old doc URLs

(cherry picked from commit b9c73e94fecf41e6d3a8854ba51d8e3bbc7dd5d4)

help.php book URL updates. Issue #10135

fix vti localid hiding in WebGUI

(cherry picked from commit 16ed13478daeceb1ad6a2b180dba7506574d4480)

Another layer of help.php URL redirects. Issue #10135

Like an onion.

Also remove some non-existent pages.

Update help.php current post-redirect URLs. Issue #10135

URLs were still pointing at the retired docs server URLs, update to
current targets after redirecting.

Fix manual backup flag

(cherry picked from commit 0bdd1774a1666852e35452ea3f17bb9dc075ecec)

cosmetic

(cherry picked from commit f1c43228ab62ffae24dd6059049d2d03dbee10a8)

fix

(cherry picked from commit 2edf9abaacbecbc173262bccc8d797b9553096ca)

allow to disable APIPA blocking

(cherry picked from commit 09b6735d1c936ad7962d66af17a32f8a0bb9f9ed)

use disablepingcheck as option name

(cherry picked from commit a0541b292d4cde76b9e95c1d8cbd99f5f26afee5)

add an option to the DHCP server to disable the ping check feature

(cherry picked from commit 7847e55fa2cd5813adb1ee4aa888b694957109b9)

Update copyright notice years. Issue #9245

Update copyright notice years. Issue #9245

Add Gandi LiveDNS DynDNS client.

(cherry picked from commit edfe22f8bae894eb678f3e7060cc91cea6f664da)

Add back inadvertently removed line

(cherry picked from commit 946238ef46e766e46392b7b9aed444cbc3a43909)

Fix syntax error in services_dyndns_edit.php, reformat statement.

(cherry picked from commit 1c11171b19ee8cabcbdaa5ffa433238033c510a2)

Keep "Show all configured leases" enabled after deleting DHCP leases.

(cherry picked from commit 59385e0413d77079c8acaf796868429475865603)

Fix tlsauth_keydir read on vpn_openvpn_server.php. Fixes #9030

(cherry picked from commit 20cb21ee5b71be43b16280b337bb24bcf5a1d17d)

Fix tlsauth_keydir save on vpn_openvpn_server.php. Fixes #9030

(cherry picked from commit 7dca65a19d08393cdb36f22fe98b847b46d9caf9)

Prevent OpenVPN tunnel network reuse. Fixes #3244

Ensures that a submitted tunnel network is not already in use on other
OpenVPN client or server instances, to avoid conflicts.

(cherry picked from commit 19a0636d7c0e0178209406480cc383853f0d3f72)

Add IPFW table contents to status.php

(cherry picked from commit 47f555e2e0718a188bc86d4dac801d32645d8a05)

Fix GUI display of CARP capture contents. Issue #9867

(cherry picked from commit dd79aac6bfe13ee93177fcd0664115e7cfa25562)

Add exit notify to OpenVPN servers/clients. Implements #9078

(cherry picked from commit 7591a72a5108a2ac28d28745cec43ea282869aae)

DigitalOcean DynDNS description update. Close #9602

The description for DigitalOcean dynamic DNS is incorrect. The documentation currently states to "Enter @ as the hostname to indicate an empty field" but that produces errors since the DigitalOcean record ID is missing. Instead the user should look up their record ID and insert that record ID into the hostname field....

escapeshellarg()

(cherry picked from commit 6ad0603b9fc9a65a9bd10390976676ae48b3fbd0)

escapeshellarg()

(cherry picked from commit e43f0619b0f0937689ad78c023dfe077b1f84a10)

more readable

(cherry picked from commit c1c375e6fab9b334af8c290912324bf6aa42591b)

full cmd: route delete $fml $tgt $gw

(cherry picked from commit 3e20d17562406d1735720fe6b083e702cfc43de3)

Revise jquery/jquery-ui in csrf_error page, which needs its own copy

(cherry picked from commit fb249aefa378172d6c246e62d15a8da40d80c5b6)

Renamed jQuery-ui files for consistency with jQuery naming

(cherry picked from commit b1a3d89a0278ff16c270b86fca8621e5457c05fd)

Fixed #9407

(cherry picked from commit df4262d0e1d8d460ba93b9fcde16476306ee21f6)

traffic-graphs, don't stop drawing graphs when a interface is disabled

traffic-graphs, don't stop drawing graphs when a interface is disabled

(cherry picked from commit 176c7256bd1b13f401c554faae4a6ed55950682a)

"don't" -> "doesn't" (typo fix for help text)

(cherry picked from commit 9d6adc62d78f7c0e6dcb6865edf5fb3ca60db1b0)

Search filter log by tracker ID. Implements #8703

(cherry picked from commit 6270bfe22ce283cca18855c5e79a1f4714505177)

Fix UPnP status when using an alternate interface address. Fixes #9961

(cherry picked from commit a8183b25c6bab388206f18acf679d96cd8b60f0e)

OpenVPN server cert default lifetime 825 days

(cherry picked from commit c576842887ac696dd5faf9d86d5447538d316069)

status_ipsec.php improvements

• Fixes Child SA button JS hide. Fixes #8847
• Adds Child SA count to JS button
• Fixes alignment of 'Connect' button for pending P1s
• Adds "Connect Children" button when P1 is up but P2s are not
• Adds space after comma in P1 source so that IPv4+IPv6 P1s do not break...

Fix is_set/isset

(cherry picked from commit cb442cfa7406e561761a52c826c9c58e7a4ee2bc)

Bump version to 2.4.5

Make hostname optional for for DNS-O-Matic.
This resolves ticket #7601.

(cherry picked from commit 1ccc327f0014d74de501a066df556add28c38e78)

Add OpenVPN Keepalive/Ping/Inactive input validation. Fixes #3473

(cherry picked from commit 4a5875a1771d286aee1c1e90d7f45991f9892a68)

Hide OpenVPN 'interface' when multihome is selected. Fixes #7840

(cherry picked from commit 5a9dc1dc278c6c537bfd5289125607117ceb99df)

OpenVPN page sorting tweaks

(cherry picked from commit 41025f6094ed34406cdf23097656ea7cae4483ae)

OpenVPN status page sent/recv bytes sorting changes. Fixes #7359

(cherry picked from commit f467ea24cb3c3a98b370c2427ff1aa53d25f14a1)

Add copy action to OpenVPN pages. Implements #5851

Added to Server, Client, and Client-Specific Override pages

(cherry picked from commit d86c28bc833cdeb8eb90525d930ff81fa3738cc9)

Change interface disconnect/release button to 'danger'. Fixes #9911

While here, add the interface name to the button text.

Net effect is a confirmation box to ensure the user wants to take that
action, which could be disruptive.

(cherry picked from commit cca21e50e2f97afe09709249975b3adf331fcf9f)

Test DNS Hostnames separtely from GWs when storing new values. Fixes #9898

(cherry picked from commit 0d192133299b02efcb1db8f72bdce85a32a96631)

Fix #3743: Allow OpenVPN keepalive configuration

- Remove hardcoded 'keepalive 10 60' configuration
- Added 'inactive seconds' option
- Let user configure 'keepalive interval timeout'. It defaults to 10 60
as it was hardcoded until now
- Let user define ping and chose between ping-exit or ping-restart...

Show DNS server help when server list is empty

(cherry picked from commit 05025e63edf9f85b679de8f99d38d6600e8ad5e3)

Allow packet capture to match IPv4+IPv6 CARP. Fixes #9867

(cherry picked from commit b86891b1d5d62d30bc8f1bf3a7fdfee7030ed82b)

Add search/filter to DHCP/DHCPv6 leases, ARP, and NDP. Implements #9791

(cherry picked from commit 9297ad6504618c5ffcee9f8fe02535cb33f570c9)

Removed escaping of CSS classes

(cherry picked from commit c8954c9f0957264a0287d3591b44fab5d52d0998)

Initialize JSON data to avoid warning.

Avoid warning/error for not initialized JSON variable.

(cherry picked from commit 6f2192d44689066e55cb7af6d19323edfc188b91)

Fix malformed JSON

Fix malformed JSON using json_encode().

(cherry picked from commit a9941bf65f82bd0a5491c693a55bc2163a43676d)

Update privilege definitions

Set autocomplete=new-password for auth forms around the GUI. Implements #9864

(cherry picked from commit 659a8a26d12b75399063dae060fa32fa23751dbf)

Image upload validation improvements. Fixes #9804

• Make functions for validating images against a pre-defined list of
  approved types
• Change the picture widget to use these functions
• Add validation for uploaded Captive Portal logo/background images

(cherry picked from commit 09d597434c9ccb456c8f207649dbe43fd5ff85db)

Create custom CSRF Error page. Implements #9799

• Use formatting consistent with other GUI pages
• Warns the user about potential dangers of submitting form data

(cherry picked from commit da7384c4a42adbcb7c20beba05ff460d0f6da7b3)

Fix oinkmastercode tag in status.php. Fixes #9736

(cherry picked from commit 9adb7806cffdd1393fd9223c17d7a938a37944c4)

Ticket #9674: Do not check password when using shared key

Clarify that error message is about proxy password

Fix #9719: Fix descriptive name field behavior

Redact BandwidthD postgres db password. Fixes #9784

(cherry picked from commit ca3129138b9866f5c82ff80d59eeed3f746367a1)

Initialize array properly

(cherry picked from commit d4393366bc0c30437c234652a2f124e08281acd5)

Redirect to status_captiveportal.php

(cherry picked from commit 15e8ee8621a552eb7d1b1a7749816846a24ae724)

Fix #9722: Change voucher shortcut to point to voucher status page

(cherry picked from commit 4baf532b5b834e659f484fc2b79e73fcfd169e46)

Fix #9756: Fix NCP multiple selection

(cherry picked from commit b0595985418416de4fe87063a1e21ffa1d2d5532)

Setup shortcuts for packages. Fixes #9770

(cherry picked from commit 37213abe96e83884b4a8ffbbbb7cc759cd2799ec)

Allow Dynamic DNS wildcards for Route53 #9053

(cherry picked from commit 0b230bb2957d32059ea4610965a9507346a1d3e9)

Add wizard select_source & use for OpenVPN DH. Fixes #9748

(cherry picked from commit 52f686a97f77cfd00ddb69088bef7164676d4117)

Add additional DHCPv6 prefix delegation size options to dropdown list on interface settings.
- implements #9590

(cherry picked from commit 51dc008bfebef50bc4be9ff2a894e176ba013866)

Added tlsauth keydir options to openvpn client and server

(cherry picked from commit 8698f918d170d3836037d3a39b4e1f8aa6389f6d)

Fix interface/config alignment on interfaces_ppps_edit.php. Fixes #9741

(cherry picked from commit d81f270454ec66680cb645c0d3c13f9431d9c026)

Was failing the check if clicking test notifications twice in a row. So it was saving the asterisks and overwriting the current password.

(cherry picked from commit 6176862f98749e15524e02ccaa705b65c498ceed)

Fix PHP warning

(cherry picked from commit b94eb4b90540dfb294376d6578aa9e9cbec63be9)

Add more color choices for login screen

(cherry picked from commit 1fe82d1dc90969fad058819ce6e7b6001382191e)

Fix CA/Cert search description. Issue #9412

(cherry picked from commit f30da999bc135fe80eda2eeddcc0cc1350a989d3)

Fix bonus closing tag. Issue #9412

(cherry picked from commit dd4fb72cfa8c0904d3cc7eae6ec01c2493f113f7)

Add sorting and search to CA/Certs. Implements #9412

(cherry picked from commit 14973058752f8b19f63af5c45b3f7b42560ae432)

Routing, actually show the "(default)" mark on the default route as it is present on the OS

Most obvious problem was when manually switching from WANGW1 to WANGW2 it showed both as (default) after saving the setting and before applying it. Also after applying it would require another page refresh to show the updated situation. Also add a little information box that shows what (Default) means for the user....