pfSense

Fix missed reference to the pfSense-dhclient-script move.

Merge pull request #3301 from doktornotor/patch-1

Use empty()

Fix display of the number of states in the firewall rules page

For numbers greater than 1000 format_number() returns strings formatted like N.NNN K/M/G/T, that get cut to only the integer part if '%d' is used.

Fix CPU update period in System Information widget

This only updates after the refresh period set in System - General Setup - Dashboard update period; should not be hardcoded.

Allow "DHCP" in upper or lower case when adding LAN IP to setup wizard

Do not enter or leave the persistent maintenance mode if the CARP is temporary disabled.

While here update the CARP status check.

Test fix for #6762

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

Merge pull request #3299 from phil-davis/patch-8

NAT 1:1 use constant name when checking validateipaddr return value

Merge pull request #3299 from phil-davis/patch-8

Merge pull request #3298 from phil-davis/patch-7

validateipaddr update return value comments

Fix #7021: Deprecate device polling

validateipaddr use constants from globals.inc

Revise define values for address types to allow an easier transition in validateipaddr()

Revert "ctrl-c is handy in the shell. Do not lock out."

This doesn't seem to be a problem these days. Fixes #6741

This reverts commit e8b82b8191356d50a2f210067d7a9f32976d4075.

Fix #6927 1:1 NAT validate address family

Ensure that all the manually-entered addresses come from the same
address family - i.e. they are all either IPv4 or IPv6 addresses.

validateipaddr return address family

Enhanced the return values from validateipaddr() so the caller can know if the validated address is IPv4 or IPv6 (or an alias if that check was requested). That makes it a better replacement for is_ipaddr().

Captive Portal: convert active sessions table to a sortable table

Convert the active sessions table in the captive portal status page to a sortable table and remove the old sorting code. The conversion fixes both sorting by ip address and by last activity time.

"Internationalize" help text in router advertisements

Merge pull request #3291 from doktornotor/patch-4

Merge pull request #3295 from marjohn56/No-Release

dhcp6c no release

Script changes to allow no-release option of dhcp6c. These changes to be
used in conjunction with pfSense/FreeBSD-ports/net/dhcp6c recent change
from PR #231

Revised #6889 to use formatted list syntax

COmpleted #6889 by re-formatting help text

Merge pull request #3286 from plumbeo/danger-lower-case

Reset the $icon variable (otherwise it can keep the last value - in a few broken cases)

Update pot

Merge pull request #3289 from doktornotor/patch-2

Update pot

Validate IP addresses using validateipaddr() function

Merge pull request #3284 from doktornotor/patch-1

status_queues.php - remove redundant escaping

Update pfSense.pot

Unbound - add support for "deny_non_local" and "refuse_non_local" ACLs (Feature #6914)

Unbound - add support for "deny_non_local" and "refuse_non_local" ACLs (Feature #6914)

Update pfSense.pot

Improve RADVD router mode help text (Todo #6889)

Fix up validation and encoding on Captive Portal status pages. Fixes #7019

Fix capitalization of confirmation messages for btn-danger buttons and fa-trash icons

Value and title were converted to lower case but not textContent. Consequently some pop-up messages included capitalized words, for example in the Log Settings page ("Are you sure you wish to Reset Log Files?").

Add missing include

Restart unbound after clearing logs (Bug #6915)

Merge pull request #3283 from doktornotor/patch-1

Merge pull request #3281 from phil-davis/patch-7

Merge pull request #3280 from phil-davis/patch-2

Ensure that the more secure option is used if both user-copy-files and user-copy-files-chroot is granted

Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702

Update pfSense.pot

Add support for chrooted SCP

Add support for chrooted SCP

validateipaddr enhance flexibility for translation

By using sprintf() we can allow for some language where the label text does not fit at the start of the sentence.

validateipaddr code format

Fix comment

Added a function validateipaddr() use as:
// Validate a network address
// $addr: the address to validate
// $type: IPV4|IPV6|IPV4V6
// $label: the label used by the GUI to display this value. Required to compose an error message
// $err_msg: pointer to the callers error message array so that error messages can be added to it here...

If nothing is enabled that requires xinetd, do not run xinetd. Fixes #6308

Fix to match the pot template.

Update pfSense.pot

Nuke outdated hint about scponly install

Correct the descriptions and behavior of the Adaptive Start and Adaptive End settings.

Merge pull request #3236 from PiBa-NL/openvpn_startup_lock

Merge pull request #3274 from phil-davis/dhcpv6serverrelay

Merge pull request #3271 from phil-davis/dhcpserverrelay

Merge pull request #3277 from phil-davis/patch-2

Check for lo0 when reconfiguring VIPs on sync. Fixes #7010

status_dcp_leases change if statement style

Status DHCP Leases show CID and other enhancements

1) If there is a Client Id specified then show it (otherwise it is possible to define a Static Mapping that has only Client Id and all other fields empty, which would look like an empty row in the displayed table)....

Merge pull request #3276 from phil-davis/patch-10

Merge pull request #3275 from phil-davis/patch-9

Merge pull request #3272 from phil-davis/patch-7

Merge pull request #3270 from phil-davis/patch-5

Merge pull request #3269 from phil-davis/patch-2

Merge pull request #3268 from blkeller/apu2-serial-fix

dhcpv6_pd_str_help add default case

When the interface concerned does not yet have its details known (e.g. Track Interface values from upstream have not come yet) then we might as well at least give the caller some reasonable text.
e.g. I was adding V6 Static Mappings on an interface that has "Track Interface" and no IPv6 delegation yet. The error message that tries to tell me the type of input I need to put or the static IP offset had no example at all.

Services DHCPv6 Static Edit fix var name

The example format at the end of the error message was not coming out.

DHCPv6 server edit when DHCPv6 Relay enabled

Part of Redmine #6997
This implements the similar behaviour as for the DHCPv4 server in Pull
Request https://github.com/pfsense/pfsense/pull/3271

Status DHCP Leases table row end

Each row of the table needs a tr end, only the last row was getting the tr end.

DHCP server edit when DHCP Relay enabled

Part of Redmine #6997
1) Display the DHCP Server settings even when DHCP Relay is enabled, but
disable the "enable" checkbox in this case - so the user cannot enable
DHCP Server when DHCP Relay is enabled, but can view and modify the DHCP...

DHCPv6 Relay Form_IpAddress is V6

DHCP4 Relay must relay to an IPv4 address

This code would accept an IPv6 address, but that causes an error to be reported by the DHCP (v4) Relay service on startup.
Validate the destination server IP address(es) to ensure they are IPv4.

Improve input validation for services_dhcpv6_relay

Make the same imrovements as was done for services_dhcp_relay in commit https://github.com/pfsense/pfsense/commit/ac999f3b7894bd8d5fc35419a22cc2df39416e42

Add PC Engines APU2 to the list of serial-only platforms

The vidconsole needs to be explicitly disabled for PC Engines APU2,
otherwise the comconsole is garbled and mostly unusable during the
boot block and boot loader.

Add specific platform detection for PC Engines APU2

Based detection on $product rather than $hw_model, because $hw_model
returns the name of the AMD SoC, which might be used on other boards.

Encode the auth server list before passing it on the CLI, to avoid issues with special characters that break when interpreted as URL parameters during OpenVPN auth. Fixes #7002

This script is not called directly in a way that requires a shabang, and it interferes with the script output, preventing successful authentication. Fixes #7008

Do not allow a group name to start with 'pkg-', reserve it for packages use (e.g. tinc)

Update interface group name validation rules to match ifconfig

Fix #6976: Make sure interface description, interface name and alias don't have the same name

Ticket #6976: Check disabled interfaces

Fix CA input validation to (again) allow an import without a key. Fixes #7001

Ensure that mobile IPsec client addresses are added to vpn_networks. Fixes #7005

Merge pull request #3267 from noledge/patch-1

Merge pull request #3264 from phil-davis/patch-2

Update services_captiveportal.php

fixes https://redmine.pfsense.org/issues/6391

Improve input validation for services_dhcp_relay

While looking at interactions between DHCP Relay and DHCP Server, I noticed a few annoying/inconsistent things in driving the UI:
1) If there were validation errors on the Destination Server IP Addresses that the user input, messages would be given about invalid addresses but the data in the Destination Server row(s) would be reset to what it was before the user started editing, losing whatever they changes they had been trying to make so far....

Comment typos in itemid.inc

Add a gateway state plugin hook.

Pull Request #3093

Revert the workaround now that the pf parsing issue is fixed.

Ticket #6985

move export button to heading for status monitoring page