pfSense » Bootstrap

11/08/2015

08:50 PM Bug #5385: guiconfig.inc display_top_tabs() breaks on long tab names

Applied in changeset pfsense:commit:02e2825a852bc0cd10cf0bc38b933a03c7da0a45. Steve Beaver

08:40 PM Bug #5385 (Feedback): guiconfig.inc display_top_tabs() breaks on long tab names

Fixed
Cherry picked from suggested code change in forum message Steve Beaver

08:23 PM Bug #5385 (Resolved): guiconfig.inc display_top_tabs() breaks on long tab names

https://forum.pfsense.org/index.php?topic=102059.msg569234#msg569234
Steve Beaver

08:10 PM Bug #5384 (Resolved): status_nptd.php - syntax error

Bonus */ removed. File tested. Steve Beaver

08:09 PM Bug #5384 (Resolved): status_nptd.php - syntax error

https://forum.pfsense.org/index.php?topic=102064.msg0#new Steve Beaver

08:10 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

Applied in changeset pfsense:commit:57cadb042dc133f1a3a671f4ff823589760574bf. Steve Beaver

08:03 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

php corrected and wrapped in <![CDATA[ ]]> Steve Beaver

07:50 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

Sure, but it's interesting that this problem has been in there since RELENG_2.0 Steve Beaver

11/07/2015

04:18 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

And in general, all that entity crap in that file (like descriptions) would benefit from the same. Completely unreada... Kill Bill

04:13 PM Bug #5381: syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

Put that between CDATA. Kill Bill

01:10 PM Bug #5381 (Feedback): syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

I'm guessing this is the culprit: (line 3 of the PHP)... Steve Beaver

12:56 AM Bug #5381 (Resolved): syntax error, unexpected ';' in /usr/local/www/wizard.php(156) : eval()'d code on line 3

Go through the setup wizard, set the hostname and timezone, leave rest at defaults. Go back to the dashboard at the e... Chris Buechler

01:20 PM Bug #5382: diag_ping.php source address selection not retained

Applied in changeset pfsense:commit:3f91d34e5e20d9b110e50d9f9a82a14f6ebc5ec3. Steve Beaver

01:17 PM Bug #5382 (Feedback): diag_ping.php source address selection not retained

Initial value incorrectly obtained from $pconfig. Now corrected. Steve Beaver

01:17 AM Bug #5382 (Resolved): diag_ping.php source address selection not retained

On diag_ping.php, pick a source like "LAN", fill in an IP, and ping. The page that returns with the results used to r... Chris Buechler

12:47 AM Bug #5380 (Resolved): setup wizard timezone should default to GMT

The timezone in the setup wizard defaults to the first in the list. Should default to GMT as before. Chris Buechler

11/05/2015

02:23 PM Bug #5375 (Resolved): diag_logs_filter.php Search functionality broken

Steve Beaver

11:21 AM Bug #5375: diag_logs_filter.php Search functionality broken

https://github.com/pfsense/pfsense/pull/2033 jeroen van breedam

10:06 AM Bug #5375 (Resolved): diag_logs_filter.php Search functionality broken

Installed 2.3-Alpha on my fpsense SG-2440... Used to sort firewall logs with "Block" checkmark to see whats blocked o... Steve Beaver

11/03/2015

11:06 AM Bug #5369 (Resolved): Thermal sensor widget no longer functions

Widget re-written to use correct 2.3 widget structure.
Now uses Bootstrap stacked progress bars that change color to ... Steve Beaver

11:04 AM Bug #5369 (Resolved): Thermal sensor widget no longer functions

Widget was converted to Bootstrap at some point, but it is no longer functional since the graphing library it uses ha... Steve Beaver

09:04 PM Bug #5365: diag_logs_filter_dynamic.php not so dynamic

https://github.com/pfsense/pfsense/pull/2019
should help with the cross/tick button and getting the syntax correct f... Phillip Davis

11/02/2015

12:51 PM Bug #5365 (Feedback): diag_logs_filter_dynamic.php not so dynamic

Dynamism has been restored.
etc/inc/filter_log.inc has been updated to use fa icon, but still needs work similar t... Steve Beaver

11:50 AM Bug #5365 (Resolved): diag_logs_filter_dynamic.php not so dynamic

There is no "dynamic" to Firewall Log Dynamic view.
diag_logs_filter_dynamic.php refers to /javascript/filter_log.js... Steve Beaver

10/31/2015

09:35 AM Bug #5357 (Resolved): Simplify vpn_ipsec.php

Steve Beaver

10/30/2015

02:06 PM Bug #5359 (Resolved): Update UI pages to use copyright-master

Steve Beaver

09:06 AM Feature #5358 (Resolved): Setup wizard PPPoE password field should be type password, not text

Steve Beaver

09:03 AM Feature #5358 (Resolved): Setup wizard PPPoE password field should be type password, not text

Need to protect from prying eyes.
Also requires "Show password" button to allow checking for typos. Steve Beaver

10/29/2015

03:00 PM Bug #5228 (Feedback): Empty space before (drop-down) field display value

A combination of the suggested methods seems to produce the best display. Select padding has been reduced from 12 to ... Steve Beaver

01:48 PM Bug #5357 (Resolved): Simplify vpn_ipsec.php

This page is a mess of buttons, icons and sortable rows. It really needs to be completely re-written using a jQuery l... Steve Beaver

09:15 AM Todo #5356 (Feedback): Refactor row toggle code in pages that use drag/drop sorting

Refactor completed and tested. Steve Beaver

09:10 AM Todo #5356 (Resolved): Refactor row toggle code in pages that use drag/drop sorting

Move row toggle code to jquery/pfSenseHelpers.js to make hte pages consistent and reduce code size.
usr/local/www/... Steve Beaver

10/28/2015

03:28 PM Bug #5228: Empty space before (drop-down) field display value

to clarify myself: google found a way to fix.....
i'm just idiot with some spare time ;) jeroen van breedam

03:25 PM Bug #5228: Empty space before (drop-down) field display value

found a way to fix it without having to manually add classes to the option fields
https://github.com/pfsense/pfsen... jeroen van breedam

03:07 PM Bug #5228: Empty space before (drop-down) field display value

Thanks. If we really need to do this, I think your second scheme "create a new entry in pfsense.css ".form-select-opt... Steve Beaver

02:49 PM Bug #5228: Empty space before (drop-down) field display value

<select class=form-control> form-control has padding enabled
the class is not applied to it's <option>'s
so... jeroen van breedam

11:40 AM Bug #5352 (Resolved): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.

Steve Beaver

10:20 AM Bug #5352: interfaces_vlan_edit.php produces errors related to the "interfaces" selector.

Applied in changeset pfsense:commit:ed7f3bbcda1767494e90d779fa92a4d8fcac2524. Steve Beaver

10:17 AM Bug #5352 (Feedback): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.

Replaced complex and unsafe options generation code with a safer function. Steve Beaver

10:15 AM Bug #5352 (Resolved): interfaces_vlan_edit.php produces errors related to the "interfaces" selector.

https://forum.pfsense.org/index.php?topic=101537.0 Steve Beaver

10/27/2015

10:47 AM Bug #5349 (Resolved): wake_on_line.widget.php - Layout needs to be improved

Widget table Bootstrap formatted.
Icons changed to more suitable font-awesome icons.
Tool-tips added. Steve Beaver

10:09 AM Bug #5349 (Resolved): wake_on_line.widget.php - Layout needs to be improved

Current layout is unattractive and uninformative. Steve Beaver

10:01 AM Bug #5348 (Resolved): Viewing on mobile device

Steve Beaver

09:55 AM Bug #5348: Viewing on mobile device

I have just tried it and works fine now thanks Jake Rote

09:35 AM Bug #5348: Viewing on mobile device

You can git-sync now to get it. It will also be in the next image, but I'm not sure what time today that will be gene... Steve Beaver

08:48 AM Bug #5348: Viewing on mobile device

Ok cool what build will this be in? Jake Rote

07:32 AM Bug #5348: Viewing on mobile device

Great. Thank you. I will start testing in that way too.
I have added the metadata tag Steve Beaver

07:22 AM Bug #5348: Viewing on mobile device

This happens on my note 4 it's due to the PPI but the viewport header fixes this. I managed to replicate in chrome de... Jake Rote

07:08 AM Bug #5348 (Feedback): Viewing on mobile device

Thanks Jake.
I have been testing device compatibility using Safari in "Responsive design mode" like this, and have n... Steve Beaver

06:36 AM Bug #5348 (Resolved): Viewing on mobile device

Bootstrap is not displaying correctly on mobile as the following metadata is missing from the top of the <head> secti... Jake Rote

07:00 AM Bug #5347: firewall_nat_out_edit.php issues

Applied in changeset pfsense:commit:9fc6233a19532421c5ff8f88745d6345cb978fc5. Steve Beaver

06:52 AM Bug #5347 (Feedback): firewall_nat_out_edit.php issues

The two missing elements had been provided, but were hidden unless the protocol was set to TCP, UDP or TCP/UDP.
I ... Steve Beaver

12:37 AM Bug #5347: firewall_nat_out_edit.php issues

thanks Phil, merged that. Chris Buechler

11:15 PM Bug #5347: firewall_nat_out_edit.php issues

Part (1) should be fixed by https://github.com/pfsense/pfsense/pull/1989
I will leave parts (2) and (3) for Mr Bea... Phillip Davis

10:14 PM Bug #5347 (Resolved): firewall_nat_out_edit.php issues

1) The source field loses its value upon editing an existing rule.
2) the static port checkbox has gone missing
3... Chris Buechler

01:14 AM Bug #5288: After Execute PHP Commands with bad code, menus do not work

I can understand that! I am happy to see the results of the crud code that I typed, and press "No" to not submit the ... Phillip Davis

12:46 AM Bug #5288: After Execute PHP Commands with bad code, menus do not work

Phillip Davis wrote:
>
> It still gives the "crash report" stuff, which is good
This part, I'm not sure that's ... Chris Buechler

12:35 AM Bug #5288 (Resolved): After Execute PHP Commands with bad code, menus do not work

thanks Phil.
The general issue Steve discussed earlier today as part of this, where PHP getting stuck making the ... Chris Buechler

11:23 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work

2.3-ALPHA (amd64)
built on Mon Oct 26 19:32:58 CDT 2015
FreeBSD 10.2-STABLE
That works nicely now. It still gi... Phillip Davis

10/26/2015

03:10 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work

Applied in changeset pfsense:commit:3e115dbf716a9bdb6b972a367c0f0a44f183f6ab. Steve Beaver

03:09 PM Bug #5288 (Feedback): After Execute PHP Commands with bad code, menus do not work

Changed the code to write the user's PHP to a file and execute it with a new instance of PHP.
Seems to fix the pro... Steve Beaver

02:34 PM Bug #5288: After Execute PHP Commands with bad code, menus do not work

My testing has not uncovered an answer to this yet. Basically fatal PHP errors (as opposed to syntax errors) cause th... Steve Beaver

10/23/2015

09:16 AM Bug #5336 (Resolved): Page must be refreshed after pkg install to show new menu items

Works Jim Pingle

10/22/2015

03:50 PM Bug #5311 (Feedback): vpn_openvpn_*.php: export tabs not installed after installing openvpn client export package

Applied in changeset pfsense:commit:a2b0d90982e6d0e2b6e36cf3cf2b258628244ca3. Renato Botelho

11:30 AM Bug #5336: Page must be refreshed after pkg install to show new menu items

Applied in changeset pfsense:commit:db1cc32f5ad36be20896e5688a810065efd7e6bc. Steve Beaver

11:21 AM Bug #5336 (Feedback): Page must be refreshed after pkg install to show new menu items

Page performs a sneaky refresh after a successful install/remove. Menu changes now take effect immediately. Steve Beaver

11:18 AM Bug #5336 (Resolved): Page must be refreshed after pkg install to show new menu items

After a new package is installed new menu items may be installed. You can't see them, however, until you refresh the ... Steve Beaver

10:17 PM Bug #5315 (Resolved): System->advanced->Settings cannot save alternate URL

this is fine now. The functionality in general needs work as the alternate URL is no longer applicable, but that's se... Chris Buechler

10/21/2015

10:53 AM Bug #5332 (Resolved): Firewall Log Widget - IPv6 log entries spill out and break formatting

Very nice! Jim Pingle

10:51 AM Bug #5332: Firewall Log Widget - IPv6 log entries spill out and break formatting

!pfSense_localdomain_-_Status__Dashboard.jpg! Steve Beaver

10:48 AM Bug #5332 (Feedback): Firewall Log Widget - IPv6 log entries spill out and break formatting

<wbr> (word break opportunity) tags have been inserted into the displayed address string at every ':' to allow the wo... Steve Beaver

09:44 AM Bug #5332 (Resolved): Firewall Log Widget - IPv6 log entries spill out and break formatting

When firewall log entries are present with IPv6 addresses, the log entries spill out and break formatting.
Example... Jim Pingle

10/20/2015

12:34 PM Feature #5326 (Resolved): Add "Top of page" links at bottom of every page

Steve Beaver

12:34 PM Feature #5326 (Resolved): Add "Top of page" links at bottom of every page

Steve Beaver

10/19/2015

12:38 PM Bug #5316 (Resolved): OpenVPN wizard fails on manually created CA

A line of HTML from the old version was accidentally left in place. Now removed. Steve Beaver

10/18/2015

07:35 PM Bug #5316 (Resolved): OpenVPN wizard fails on manually created CA

*OpenVPN Wizard: Authentication Type Selection
-Select an Authentication Backend Type
Local User Access
Next
*O... Steve Beaver

07:30 PM Todo #5204 (Resolved): Clean up jquery sections at the bottom of pages

Steve Beaver

07:21 PM Bug #5302 (Resolved): Traffic shaper wizaerd has minor issues

OP reports the issues have been corrected. Steve Beaver

10/17/2015

08:40 AM Bug #5315: System->advanced->Settings cannot save alternate URL

Functionality changed per description.
Chris, would you please verify this functionality is acceptable? Steve Beaver

08:40 AM Bug #5315 (Feedback): System->advanced->Settings cannot save alternate URL

Applied in changeset pfsense:commit:02570c3f093140e038452c7c58c202913b6b3858. Steve Beaver

08:35 AM Bug #5315 (Resolved): System->advanced->Settings cannot save alternate URL

The functionality of system->firmware->Updater Settings->Base URL has been changed. It now displays the URL associate... Steve Beaver

07:55 AM Bug #5310: Wizard error page not correctly formatted

Thanks. The Javascript alert was caused by an error I made in escaping the validation strings. Now corrected. Steve Beaver

05:18 AM Bug #5310: Wizard error page not correctly formatted

Error page seems now ok, but doing the same (that is entering a dot in the hostname field) results in a nonsense java... Lorenzo Milesi

12:53 AM Bug #5293 (Resolved): Edit button on block private/bogon rules goes to wrong page

fixed Chris Buechler

10/16/2015

02:56 PM Bug #5310: Wizard error page not correctly formatted

traffic_shaper_wizard_multi_all* updated and tested for correct operation/appearance Steve Beaver

02:45 PM Bug #5310: Wizard error page not correctly formatted

wizard.php updated to generate correct jquery action handlers
dedicated wizard and include file updated to correct d... Steve Beaver

09:10 AM Bug #5310: Wizard error page not correctly formatted

Applied in changeset pfsense:commit:0342d2548a0a9cc7c3267b39e20b2c2d49050e5c. Steve Beaver

09:08 AM Bug #5310 (Feedback): Wizard error page not correctly formatted

Required page header and footer added to the error messages in setup_wizard.xml
"Back" button behavior is under re... Steve Beaver

06:23 AM Bug #5310 (Assigned): Wizard error page not correctly formatted

Steve Beaver

01:10 AM Bug #5310 (Resolved): Wizard error page not correctly formatted

I entered a wrong hostname in the configuration wizard and the attached error message appears.
The error is not bo... Lorenzo Milesi

09:11 AM Bug #5312 (Resolved): system_advanced_admin.php - Serial speed drop-down is saving incorrect values

Tested, works fine now, thanks! Jim Pingle

09:06 AM Bug #5312 (Feedback): system_advanced_admin.php - Serial speed drop-down is saving incorrect values

Corrected select array type Steve Beaver

08:42 AM Bug #5312 (Resolved): system_advanced_admin.php - Serial speed drop-down is saving incorrect values

The serial speed drop down should be using the numerical serial speed for both the value and the label, and it's curr... Jim Pingle

08:26 AM Bug #5311 (Resolved): vpn_openvpn_*.php: export tabs not installed after installing openvpn client export package

vpn_openvpn_client.php calls add_package_tabs() in guiconfig.php where the call to get_pkg_data() has been commented ... Steve Beaver

10/15/2015

01:41 AM Bug #5248: OpenVPN dashboard widget layout

That looks good now - thanks.
2.3-ALPHA (amd64)
built on Wed Oct 14 16:15:05 CDT 2015 Phillip Davis

10/14/2015

10:47 AM Todo #5279 (Resolved): Package installation GUI updates

Scripts combined and reloads handled. Steve Beaver

10/13/2015

01:55 PM Todo #5299 (Resolved): Remove Reinstall GUI funtionality from installed packages

I removed the text from wiki page. Jared Dillard

12:54 PM Todo #5299: Remove Reinstall GUI funtionality from installed packages

Code has been removed. Would you please update the wikior assign to whomever does that? Steve Beaver

01:18 PM Bug #5302 (Resolved): Traffic shaper wizaerd has minor issues

See: https://forum.pfsense.org/index.php?topic=100762.0
This is an issue for both Multiple Lan/Wan;traffic_shaper_... Steve Beaver

01:17 PM Bug #5248 (Resolved): OpenVPN dashboard widget layout

Steve Beaver

01:03 PM Todo #5279: Package installation GUI updates

The package installation system has been updated such that:
* The installer is run in the background so that the GUI... Steve Beaver

12:55 PM Bug #5296 (Resolved): Notification E-Mail Auth Mechanism missing

Steve Beaver

10/12/2015

05:36 PM Todo #5299: Remove Reinstall GUI funtionality from installed packages

Ok great. The wiki page would also need to be updated: https://doc.pfsense.org/index.php/Package_Manager Jared Dillard

05:24 PM Todo #5299 (Assigned): Remove Reinstall GUI funtionality from installed packages

I believe this needs to be removed. I will do so today. Steve Beaver

03:38 PM Todo #5299 (Resolved): Remove Reinstall GUI funtionality from installed packages

Remove the Reinstall GUI button from pkg_mgr_installed.php and the supporting code in pkg_mgr_install.php?mode=reinst... Jared Dillard

03:44 PM Bug #5085 (Resolved): dashboard "progress bars" hard to read

Steve Beaver cleaned it up by moving the text below the progress bar. Jared Dillard

12:24 PM Bug #5248 (Feedback): OpenVPN dashboard widget layout

Steve Beaver wrote:
> Jarred: Would you play with the panel-heading class colors in this widget please? We should pr... Jared Dillard

07:10 AM Bug #5296: Notification E-Mail Auth Mechanism missing

Applied in changeset pfsense:commit:f00e23d991f0397ea918c55ad1c6c54c003aa645. Steve Beaver

07:03 AM Bug #5296 (Feedback): Notification E-Mail Auth Mechanism missing

Steve Beaver

07:02 AM Bug #5296: Notification E-Mail Auth Mechanism missing

Missing selector provided and tested
Thanks for finding.
Steve Beaver

07:00 AM Bug #5296 (Confirmed): Notification E-Mail Auth Mechanism missing

Steve Beaver

08:48 PM Bug #5296: Notification E-Mail Auth Mechanism missing

This code was committed to master in https://github.com/pfsense/pfsense/pull/1421/files
and was backported to RELENG... Phillip Davis

08:38 PM Bug #5296 (Resolved): Notification E-Mail Auth Mechanism missing

This dropdown to choose PLAIN or LOGIN is a recent addition to 2.2.*
It is missing in 2.3-ALPHA
Forum https://forum... Phillip Davis

10/10/2015

07:10 AM Bug #5293: Edit button on block private/bogon rules goes to wrong page

Applied in changeset pfsense:commit:6f5a3fead80408f084156aa76f471b3bb611dc48. Steve Beaver

07:08 AM Bug #5293 (Feedback): Edit button on block private/bogon rules goes to wrong page

Button link corrected. Steve Beaver

12:24 AM Bug #5109 (Resolved): services_captiveportal.php missing description for RADIUS servers fields

I fixed the help text so it shows the field description, which was the primary issue here. That'll suffice. Chris Buechler

12:02 AM Bug #5194 (Resolved): diag_dump_states.php "Remove" button should be an X

looks good, thanks! Chris Buechler